- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] HTTPS Patch
by Indan Zupancic Nov. 7, 2003

Nov. 7, 2003

Updated the diff, gcc 2.x should work now, link is still http://www.xs4all.nl/~dorinek/dillo/dillo-ssl.diff.gz Did anyone found the bug yet, without reading the diff? If not, then it's as harmless as I thought ;-). Still not nice of course, but it's unclear where it goes wrong exactly, doesn't seem to be easily fixed without changing Dillo a lot. It would be nice to get some feedback from the Dillo developers, I'd like to know what they think should change before the code is good enough to go into the official Dillo, and if they even consider that of course. I have plenty of ideas, but most of them aren't feasible without merging the two IOData structures (now there is one for the read part, and one for the write part, why, I don't know, doesn't make things simpler), doing that makes it much easier to do certain, more complex things that need to have all the fd related info in one place, like ssl, connection caching (currently Dillo opens and closes a connection for each action, although it seems to work well, it's still more efficient to keep connections open longer, especially with slow/bad network connections), "keep alive" (to avoid timeout problems in ssl, quite annoying when you're taking too much time typing an email), simple ftp support, etc. I know that the Dillo developers want to implement most "extra" features like https/ftp/bookmarks/etc as plugins, but I think it's beter to implement the features that are used a lot, or just very important, like https and ftp, natively in Dillo with a small implementation. The overall code is most times smaller too, can say that Dillo is just 300 K, but it would be a bit weird if the plugins together are bigger than Dillo after a while. https took around 2 Kb, I think I can implement basic FTP (and possibly ftps) in about 15 K, using no external ftp library or program (hopefully 10, worst case 20K). If you let me loose on Dillo's code then this is what I would do: # Cleanup the IO engine, one IOData per fd. # Moving the dns stuff to IO. # Add ftp support. # Add file upload support in html forms. # Add connection caching to IO. # Move all the socket stuff into IO.c, the module that wants to handle opening the connection should also close it (all non-internet sockets, like files. Unix sockets may be added to IO.c.). # Auto keep alive like behaviour for ssl connections. # Maybe always ACCEPT_SESSION for cookies when they come via a https connection. # Get rid of the ccc construction, or change it so that it behaves more logical. My opinion is that you should have either a clear unique API for each module, or one general API that is the same for each module. Something in between like the current ccc functions is only confusing (if you want a chain like behaviour, then use function pointer stuctures or something). # When changing the internal API anyway, making shared library plugins possible too, at least for the IO part (maybe ftp library plugin as proof of concept). # Get rid of the splash stuff, move it to an external html file that is opened by default when nothing else is opened. Currently the splash screen is even opened when you do "dillo http://site.org". Loading a file is almost as fast as the build in splash screen. Removing it makes Dillo smaller (about 10 K), simpler and lets people make their own startup pages (for instance a to hd saved google.com) As you could notice, I'm mainly interested in the internet/IO part, graphical stuff doesn't attract me much. If it did, I would help/start porting Dillo to FLTK. If Dillo decides to go with GTK 2 then I will probably stop using it :(. I don't have enough faith in GTK2, it's already too big (and I saw the test results). If you have GTK 2 running anyway it doesn't matter much if you run Dillo too of course, but that's the case too with all those KDE/Gnome programs. IMHO, you should look at all the code that a program uses, including the one in dependencies. I prefer a program that has it's own small and efficient implementation of something to one that is smaller but uses huge libraries. I'm also thinking about making a Dillo installer (sh script) that downloads and installs the cvs version of Dillo and applies the patches the user wants. This needs some coordination, I saw links to other Dillo patches, but I don't know if they are up to date, nor if the maker is willing to keep that so. Currently the only patches I know that are up to date are Frank's patches and my own https patch. Greetings, Indan ------------------------------------------------- This mail is written in SquirrelMail with Dillo -------------------------------------------------

2 1

Simulating a slow connection
by Sebastian Geerken Nov. 4, 2003

Nov. 4, 2003

Hi! Sorry for being silent the last week. At <http://www.dillo.org/download/dillo-slow-0.0.1.tar.gz>, you'll find a dpi, which simulates a slow connection, and is useful for testing incremental rendering. Read the README file within the tarball for more informations. (I'm not yet very familiar with dpip, I just modified the "hello world" example for my needs, and especially, currently only one instance of this dpi can run at a time.) Sebastian

2 2

[PATCH] memory leak in dw_ext_iterator
by Frank de Lange Nov. 4, 2003

Nov. 4, 2003

Hi'all, There's a memory leak in dw_ext_iterator, which causes every call to dw_ext_iterator_new() to leak one DwIterator. The solution is simple, as can be seen in the attached patch. Jorge, can you apply this? It saves quite a bit of memory, and will do so even more once my next kbnav patch is out (now testing). The patch currently contains this fix for dw_ext_iterator (plus a whole lot of other changes to it). As this would make the patch fail to apply cleanly, I'd like to see this fixed in CVS. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] diff -pruN dillo/src/dw_ext_iterator.c dillo_patched/src/dw_ext_iterator.c --- dillo/src/dw_ext_iterator.c 2003-07-12 19:35:50.000000000 +0200 +++ dillo_patched/src/dw_ext_iterator.c 2003-11-03 13:58:35.020401864 +0100 @@ -366,7 +366,7 @@ gint a_Dw_ext_iterator_compare (DwExtIte void a_Dw_ext_iterator_free (DwExtIterator *eit) { int i; - for (i = 0; i < eit->stack_top; i++) + for (i = 0; i <= eit->stack_top; i++) a_Dw_iterator_free (eit->stack[i]); g_free (eit->stack); g_free (eit);

2 2

IPv6
by Jorge Arellano Cid Nov. 3, 2003

Nov. 3, 2003

Hi there! Please someone give a test to the CVS's IPv6 code. It has some new memory handling calls and it'd be good to be sure it works as expected. Just navigating will do, but the key point of the test is when dillo has to retry with different IPs for a single connection (that is: when the GioChannel is reused). Cheers Jorge.-

1 0

(no subject)
by Jan.Stary＠ff.cuni.cz Nov. 3, 2003

Nov. 3, 2003

Hello, using the usual "http://validator.w3.org/check/referer" doesn't seem to work in dillo. On the validator page, you get a "302 Moved", which dillo _does_ follow, but the resulting "http://validator.w3.org/check/referer?uri=" is of no use. I tried viewing http://www.stare.cz/referer.html and clicking 'validate' in lynx, mozilla and dillo. In dillo it does not work. Is dillo really _sending_ the referer? Thanks Jan

2 2

version tests on automake and autoconf
by robert w hall Nov. 2, 2003

Nov. 2, 2003

I believe Dillo 7.2 tests for v1.7 of autoconf and, if configure.in is patched, for 1.7 of automake. A couple of us are interested in porting uptodate ssl-enabled versions of dillo to the playstation2, where the base distro is rather ancient (Redhat 5 -era :-)) Dillo 7.1.2 with Andreas' ssl-patch compiled fine, but didn't require these recent versions of automake & autoconf. Are these recent versions _in fact_ required or can the tests for them be safely disabled? Bob -- robert w hall

2 2

hairy bug in IO fixed!
by Jorge Arellano Cid Oct. 31, 2003

Oct. 31, 2003

Hi there! The last five or six days were spent on trying to find (& fix) a bug that caused the CPU to hog under very hard to reproduce conditions. I know that heavy duty dillo users had noticed that in rare ocassions dillo starts taking all the CPU, and that's almost impossible to reproduce it again with another dillo... Well, the first interesting thing is that the CPU hog is "soft" (i.e. doesn't block dillo) because it is caused by a polling loop. The other surprising fact is that the CPU-hog occurs outside of dillo (!). That is, not in any part of its code. So if you were to attach GDB to find the bug (once on hog), you'd be always pointed outside dillo's source, but with a clue: polling. I was working with the ftp dpi when I finally came accross a way to reproduce the bug, so I took the chance and started digging. A whole revision/tweaking of the IO engine close/abort handling, a revision of glib's sources (gio channels) to finally find a way to stop the polling loop. Short story, there were several involved parts: threads, the IO, external processes, several open connections in parallel, glib (and the kernel). It turned out to be a race condition in the window between the actual close of the file descriptor, the glib source event removal for the watch, and the kernel reuse of FD number. The source code for gio channels (inside glib) hinted a way to remove the event source cleanly, but outside the gio channel's explicit API. The details are in IO.[ch] in CVS! Cheers Jorge.- PS: Indan wrote: > 3) There is no efficient way of (un)registering file descriptor events in > GTK. (FLTK has a perfect interface). Yes there is! (subtle but effective) > Did anyone found the bug yet, without reading the diff? If not, then it's > as harmless as I thought ;-). Still not nice of course, but it's unclear > where it goes wrong exactly, doesn't seem to be easily fixed without > changing Dillo a lot. I hope this patch and explanations helps you with point number 3. More comments later... Cheers 2 Jorge.-

1 0

Re: [Dillo-dev] HTTPS Patch
by David McKee Oct. 28, 2003

Oct. 28, 2003

Folks, When I apply and attempt to compile (on a Redhat 6.2 machine, gcc 2.95), I have two problems. First, the build doesn't know where to find my openssl headers and libraries, and there does not seem to be a ./configure option for this. (BTW: My goodies are in /usr/local/ssl/...) I can fix this locally, but a config option might be in order. Secondly, I get two compilation errors in IO.c. Both are related to the code: errno = 0; ssize_t St = SSL_read(io->ssl, io->Buf, io->BufSize); which I believe should (strictly) be ssize_t St; errno = 0; St = SSL_read(io->ssl, io->Buf, io->BufSize); because declaration should come before statements. In anycase, making this change in both places (around lines 822 and 852) fixes the problem for me. Now to try it out... Thanks, -- -- David McKee -- dmckee(a)jlab.org -- (757) 269-7492 (Office)

5 6

HTTPS patch
by Indan Zupancic Oct. 27, 2003

Oct. 27, 2003

Get it here: http://www.xs4all.nl/~dorinek/dillo/dillo-ssl.diff.gz It's not as nice and simple as I wanted it to be, thanks to three things: 1) SSL can always read and write, meaning that SSL_write may want to read. 2) Dillo uses two IOData structures per file descriptor. 3) There is no efficient way of (un)registering file descriptor events in GTK. (FLTK has a perfect interface). This three facts contribute a lot to the complexity of the code. There is one known bug, you may try to find it. ;) Dillo will not crash, I made it exit with a message. This patch adds also generic ssl/tls support to Dillo, most work was done in IO.c, http.c has hardly changed. The current way to tell the IO engine that it should use ssl is by giving a negative fd to a_IO_new. This avoids extra interface, is simple, and doesn't clash with anything else. Dillo is about 2K bigger after the patch. It was made against the current cvs, apply it with 'patch -p1 < dillo-ssl.diff' while you're in the dillo dir. Run configure with --disable-ssl if you don't want https... Have fun. p.s. I hate glib ;), it's totally worthless, the most complex piece Dillo uses is a hash table, and glib implements it as a linked list, look in the code yourself if you don't believe me. Since when is ansi c not good enough? Please switch to FLTK. :) p.s.s This mail was sent from webmail with a patched Dillo. :)

2 3

fltk c binding
by cesar Oct. 27, 2003

Oct. 27, 2003

Fltk was modeled following XForms and has a XForms compatibility layer: http://fltk.org/documentation.php/doc-1.1/forms.html#forms http://fltk.org/documentation.php/doc-2.0/forms.html#forms You can learn more about XForms here: http://world.std.com/~xforms/ pd: I don't know how to program using Fltk or XForms. I only was aware of this compatibility layer. Both also have a GUI designer. I only know of very few apps using XForms, the most important of those being LyX. cesar;

2 1