February 2013 - Dillo-dev - lists.mailman3.com

https related crash
by Johannes.Hofmann＠gmx.de 05 Mar '13

05 Mar '13

Hi, from time to time I get the crash below. Would a simple NULL check in a_Chain_check() be the correct fix? Cheers, Johannes nated with signal 11, Segmentation fault. #0 0x0805d359 in a_Chain_check (FuncStr=0x81135b3 "a_Capi_ccc", Op=2, Branch=1, Dir=2, Info=0x0) at chain.c:192 192 if (Info->Flags & (CCC_Ended + CCC_Aborted)) { (gdb) p Info $1 = (ChainLink *) 0x0 (gdb) bt #0 0x0805d359 in a_Chain_check (FuncStr=0x81135b3 "a_Capi_ccc", Op=2, Branch=1, Dir=2, Info=0x0) at chain.c:192 #1 0x08062f03 in a_Capi_ccc (Op=2, Branch=1, Dir=2, Info=0x0, Data1=0x28c83670, Data2=0x0) at capi.c:622 #2 0x0806372f in a_Capi_dpi_send_data (url=0x0, bw=0x2871da20, data=0x29563748 "<cmd='answer' to_cmd='dialog' msg='1' '>", data_sz=40, server=0x2940ee70 "proto.https", flags=<optimized out>) at capi.c:576 #3 0x0806381a in a_Capi_dpi_send_cmd (url=0x0, bw=0x2871da20, cmd=0x29563748 "<cmd='answer' to_cmd='dialog' msg='1' '>", server=0x2940ee70 "proto.https", flags=0) at capi.c:593 #4 0x08085bed in Dpiapi_dialog_answer_cb (answer=<optimized out>, bw=<optimized out>) at dpiapi.c:43 #5 a_Dpiapi_dialog (bw=0x2871da20, server=0x2940ee70 "proto.https", dpip_tag=0x286612d0 "<cmd='dialog' title='Dillo HTTPS: Missing issuer certificate!' msg='Unable to get local issuer certificate. The issuer certificate of an untrusted certificate cannot be found.' alt1='Continue' alt2='C"...) at dpiapi.c:74 #6 0x0805d21f in a_Chain_fcb (Op=684209776, Info=0x2878cec0, Data1=0x286612d0, Data2=0x29ecb9d0) at chain.c:114 #7 0x0808b533 in Dpi_parse_token (conn=<optimized out>) at dpi.c:228 #8 Dpi_process_dbuf (conn=<optimized out>, Data1=<optimized out>, Op=<optimized out>) at dpi.c:326 #9 a_Dpi_ccc (Op=2, Branch=2, Dir=1, Info=0x2878cec0, Data1=0x29e55470, Data2=0x0) at dpi.c:713 #10 0x0805d21f in a_Chain_fcb (Op=684209776, Info=0x28788fc0, Data1=0x29e55470, Data2=0x0) at chain.c:114 #11 0x0808ba6e in a_IO_ccc (Op=2, Branch=2, Dir=1, Info=0x28788fc0, Data1=0x292f6d40, Data2=0x0) at IO.c:425 #12 0x0808bc80 in IO_read (io=0x292f6d40) at IO.c:194 #13 0x0808bd88 in IO_callback (io=0x0) at IO.c:259 #14 0x0808be47 in IO_fd_read_cb (fd=6, data=0x6d7) at IO.c:280 #15 0x080e7d15 in fl_wait(double) () #16 0x080c36fc in Fl::wait(double) () #17 0x080c377b in Fl::run() () #18 0x0804e1f1 in main (argc=1, argv=0xbfbff8c4) at dillo.cc:502 (gdb)

2 3

text-transform and hyphenation
by corvid＠lavabit.com 16 Feb '13

16 Feb '13

'text-transform: capitalize' and hyphenation do not play well together (example attached). The fragments are capitalized, and the word is sometimes split as "Cap-" "Talization", losing the 'i'.

2 1

form input button and margin
by corvid＠lavabit.com 08 Feb '13

08 Feb '13

In the second one, the words and the button overlap. I'm not immediately sure what's special enough about that case to cause that. <button type="submit" style="font-size: 200%; margin-bottom: 1em; width: 100%;">button submit margin bottom</button> words words <p> <input type="submit" value="input submit margin bottom BAD" style="font-size: 200%; margin-bottom: 1em; width: 100%;"> words words <p> <input type="submit" value="input submit" style="font-size: 200%; width: 100%;"> words words <p> <div style="font-size: 200%; margin-bottom: 1em; width: 100%; border-width: 1px; border-style: solid">div margin bottom</div> words words <p> <img src=file:/tmp/whatever border=1 style="margin-bottom: 1em; width: 100%"> words words

2 2

IO/proto.c
by p37sitdu＠lavabit.com 07 Feb '13

07 Feb '13

File is empty except for comment. Shouldn't it be removed?

1 0

[patch] remove old comment from src/IO/IO.c
by p37sitdu＠lavabit.com 02 Feb '13

02 Feb '13

There is an outdated comment in src/IO/IO.c. hg blame src/IO/IO.c also shows that it is older than the code. This patch removes comment. #defines are similar to SHUT_RD, SHUT_WR and SHUT_RDWR, but shutdown is not used: code just dCloses descriptor when both sides are asked to be closed.

1 0

chain.c cleanup
by p37sitdu＠lavabit.com 02 Feb '13

02 Feb '13

http://www.inventati.org/noname/dillo/chain-cleanup.patch 1. Replaced dNew with dMalloc and dNew0 with dMalloc0. This way it is possible to use (sizeof *var) instead of repeating variable type. By the way, when 'count' is constant, dMalloc is easier to use, and when count is not constant, integer overflow can happen in dNew during multiplication. It looks like there are no such errors, but I think check should be added or, better, dCalloc can be introduced so libc checks for such cases. 2. Replaced #defines with enums and made them uppercase so it is easier to distinguish them from variables. This style is already used in most modules. IO should be fixed too, probably. 3. Moved duplicate code from a_Chain_fcb and a_Chain_bcb to Chain_cb. Anonymous structures for connections (forward or backward) are introduced in ChainLink structure for this purpose. 4. Removed unused a_Chain_unlink function. Chain links are just dFreed instead. Anyway, there is no function to connect existing links back, so disconnected link can only be dFreed. 5. Replaced AtoB_branch and BtoA_branch parameters of a_Chain_link_new with single Branch parameter. They were always equal anyway, and using different branch identifiers for one connection makes no sense, as branch ID is used to distinguish between Answer and Query chains. Branch parameter can be eliminated completely by separating existing CCC callbacks into answer and query callbacks. Currently instead of two functions we have one with if (Branch == 1) { ... } else { ... }

1 1