October 2009 - Dillo-dev - lists.mailman3.com

Latest whitespace handling patches
by jcid＠dillo.org 29 Oct '09

29 Oct '09

Hi, The latest cleanups and whitespace handling patches have come like a fresh breeze removing unnecessary code. They're good for better code clarity. One of the few regressions I've noticed is extra underlining of links (the space before the first word's letter). As in: http://www.dwheeler.com/blog/2009/10/27/#dod-oss-2009 BTW, I'm close to commiting the DPIP changes. Hopefully near this month's end. -- Cheers Jorge.-

2 5

Re: NULL for default tag close?
by jcid＠dillo.org 27 Oct '09

27 Oct '09

On Tue, Oct 27, 2009 at 05:09:37PM +0000, corvid wrote: > Would it be all right if I changed the default_close()s to NULL? > I think it makes Tags[] easier to read, I'd prefer it as is for the same reason! :-) > and testing for NULL would > mean less time calling an empty function anyway... I'd be surprised if the gain is more than 0.1%. BTW, today in one part of the DPIP code I found that avoiding thousands of read() calls made no noticeable difference. With write() it was a different story though. Most probably gcc optimizes out empty functions too. -- Cheers Jorge.-

1 0

Re: link signal emission from layout?
by corvid＠lavabit.com 25 Oct '09

25 Oct '09

Jorge wrote: > On Sat, Oct 24, 2009 at 03:48:55PM +0000, corvid wrote: > > I never liked all of the connectSignals() for all of the > > textblocks and images and whatever else in html.cc. > > Why not? So much signal connection for the listitems and the tablecells and everything, and all redundant, since it's all going back to the same receiver in html. > > Would you have any opinion about moving the > > (perhaps increasingly-inaccurately-named) > > link signal emission to layout? > > Could be. > > > I was just playing with the idea, and, at least after > > a moment's test :) , it seemed to be working. > > And, as a bonus, it lets me pop up menus when > > pressing button 3 below the bottom of page content. > > I miss this feature. Also being able to popup a menu over > a bare image would be a plus. Random thought: it would nice if there were a mechanism to change the size of images. > > (I left the event emitter alone for the moment, but I > > think the only thing using it right now is plain.cc. > > If so, it would be nice to rip that out in any case, > > even if plain doesn't have "links" exactly...) > > I don't know why it's currently done in html.cc, maybe it's > just grouping by required functionality, maybe not. If the new > approach is simpler and provides the same and more as you > pointed, id say: +1. It's simpler for src/, but the ickiness is preserved for dw/, since what was excised from Widget gets implanted into Layout. > BTW, please move this thread to dillo-dev.

1 0

[patch]: fix w3c_plus_heuristics=NO
by onepoint＠starurchin.org 21 Oct '09

21 Oct '09

As I understand it, the purpose of the w3c_plus_heuristics preference is to control whether Dillo will force close some tags when it sees an unmatched close tag. But it seems to have no effect! If you try this HTML: <html> <head><title></title></head> <body> <p> <table><tr><td><s></table> </body> </html> then the <s> tag is closed no matter what w3c_plus_heuristics is! The bug is in Html_tag_cleanup_at_close() in html.cc, in this code: /* Look for the candidate tag to close */ stack_idx = html->stack->size() - 1; while (stack_idx && (cmp = (new_idx != html->stack->getRef(stack_idx)->tag_idx)) && ((w3c_mode && Tags[html->stack->getRef(stack_idx)->tag_idx].EndTag == 'O') || ((!w3c_mode && (Tags[html->stack->getRef(stack_idx)->tag_idx].EndTag == 'O')) || Tags[html->stack->getRef(stack_idx)->tag_idx].TagLevel < Tags[new_idx].TagLevel))) { --stack_idx; } The indentation makes it appear that the comparison between the TagLevel fields is bracketed with !w3c_mode but both the indentation and the bracketing are wrong. In fact this code is equivalent to: /* Look for the candidate tag to close */ stack_idx = html->stack->size() - 1; while (stack_idx && (cmp = (new_idx != html->stack->getRef(stack_idx)->tag_idx)) && ((w3c_mode && Tags[html->stack->getRef(stack_idx)->tag_idx].EndTag == 'O') || (!w3c_mode && (Tags[html->stack->getRef(stack_idx)->tag_idx].EndTag == 'O')) || Tags[html->stack->getRef(stack_idx)->tag_idx].TagLevel < Tags[new_idx].TagLevel)) { --stack_idx; } which is in turn equivalent to /* Look for the candidate tag to close */ stack_idx = html->stack->size() - 1; while (stack_idx && (cmp = (new_idx != html->stack->getRef(stack_idx)->tag_idx)) && (Tags[html->stack->getRef(stack_idx)->tag_idx].EndTag == 'O' || Tags[html->stack->getRef(stack_idx)->tag_idx].TagLevel < Tags[new_idx].TagLevel)) { --stack_idx; } so that w3c_mode has no effect. In other words w3c_plus_heuristics is effectively always YES, even if dillorc says otherwise. I have attached a patch that implements (what I *think* is) the correct behaviour. Regards, Jeremy Henty

2 2

How to limit cache in Dillo v2.1.1?
by eriol2004＠163.com 20 Oct '09

20 Oct '09

Hello, I am using Dillo v2.1.1 on my embedded device with limitation of memory usage. How to limit the cache size or set no cache to the image? Many thanks. Best Regards Cyril 09ÄêÐÂœú3DÖ÷Á÷ÍøÓÎ¡¶ÌìÏÂ·¡¡·£¬ÍøÒ×ÁùÄêÒÚ×ÊŽòÔì

2 1

FWD
by jcid＠dillo.org 18 Oct '09

18 Oct '09

Hi, [Alexandre Berges (alexandre dot berges @ GMAIL) wrote:] > Hello > > I use Dillo and i like it. > I have a littel problem with it it's how to use letter-spacing attribut. I > know this attribut is'nt implemented > Do you know when this attribute will be implemented ? -- Cheers Jorge.-

3 6

auto/abs sizes in image.cc, auto/abs/per in textblock.cc
by corvid＠lavabit.com 17 Oct '09

17 Oct '09

At http://naturalhistory.museumwales.ac.uk/sharpshooters/ two of the image tags specify a size for one dimension, giving it as 100%. When one dimension is auto and the other is percentage, it doesn't scale properly. I see that calculation using percentage has to be in textblock because it uses availWidth or availHeight, so... is there a deep need to keep the auto/abs case in Image's sizeRequestImpl instead of Textblock's calcWidgetSize? I was just playing with adding all of the cases to calcWidgetSize and it looked like it was working except that an unloaded image with, e.g., height=100% alt=whatever would end up ridiculously wide because height_of_page / height_of_alt_text * width_of_alt_text is a large number.

4 8

flicker at reload
by nst＠gersys.de 15 Oct '09

15 Oct '09

Hello I'm new to both dillo and fltk. I'm trying to do two things and I'm hoping you can point me in the right directions on how to do it. 1) flicker at reload When doing a reload my screen flickers and I'd like to get rid of that. I first tried the dillorc option buffered_drawing=0/1/2 but that didn't make any difference. I then tried to find the source where the screen is cleared before redrawing the page. I followed the source of redraw() until layout.cc where topLevel->draw() is executed but I cannot find its implementation. Is the flickering an fltk issue or where is the screen cleared? 2) externally trigger reload I'd like to trigger a page reload externally by another application. I searched a bit about IPC mechanisms of fltk but didn't find any. So I'm thinking about using a UNIX fifo or the system signal SIGUSR2. Do you think this is a good approach? Many thanks Stefan.

4 6

textarea multiline input bug
by dennisn＠dennisn.dyndns.org 14 Oct '09

14 Oct '09

In textareas (multiline form input), say for example: http://translate.google.ca/translate_t ... if I first enter the following line into the textarea: yo soy anarco-capitalista ... and after submitting it, I edit it (the previous contents are retained -- although I suspect internally there might be something broken -- not sure where it breaks exactly.), by inserting a newline at the very beginning (pressing enter), then backspacing (removing the newline) to make it appear exactly the same, then resubmitting the form, strange stuff happens. (I remember earlier posting experiences some of my lines getting duplicated, and other strange stuff. I think it only happens when I edit stuff at the beginning.)

2 3

tooltips not clearing properly
by corvid＠lavabit.com 08 Oct '09

08 Oct '09

Johannes wrote: > corvid wrote: > > Jorge wrote: > > http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.31.y.git;a=summa… > > > > > > Go to NOMMU, wait for tooltip, scroll with mouse wheel... > > > > I don't have one, although I'll try to look into it anyway. > > Do links show up and disappear from the status bar > > properly with the mouse wheel? > > > > It may also have to do with our scrolling code. Sometimes it looks as if the tooltip > is cleared partially, but some part "sticks". I will have a look when I find some time. Ah, I see it now if I set buffered_drawing to the default value. Luckily I don't know anything at all about the buffering code :)

1 0