September 2008 - Dillo-dev - lists.mailman3.com

a list of what dillo2 runs on
by corvid＠lavabit.com 20 Nov '08

20 Nov '08

I want to get the status of everything in order to update http://www.dillo.org/Compatibility.html for dillo2. Linux x86 - works DragonFlyBSD - works Linux x86-64 - Justus was and is making snapshots, but I don't know whether he uses them much. Solaris 10 - Justus reported that it was running, but I believe it was just a quick test. OSX - Jorge reports that it works but is currently flaky. *BSD - Some of the mailing list traffic in October was devoted to getting them working. Presumably it would have been mentioned here if they had stopped working since, but... other - no idea. Looking back at what I just wrote, let me clarify that I meant that dillo2-on-osx is flaky, not that Jorge is flaky :)

9 16

what crashes remain?
by corvid＠lavabit.com 03 Oct '08

03 Oct '08

It's still possible to crash dillo if you click on a remote link and quickly click on some images to load them. Doesn't crash every time, but typically within four tries or so. I had assumed it was the same thing as whatever was wrong with the menu crash, so I'd ignored it. If I stick a_Bw_stop_clients(bw, BW_Img); in the DilloHtml destructor, I can no longer get it to crash, but I randomly got a "Cache_process_queue Caught busy!!!" while browsing earlier today, so there's something wrong with just doing that. (Assuming it's related; I'm not in the habit of getting that MSG.) I can't think of any other crashes, but I don't remember whether Johannes still gets bus errors.

3 33

an experiment regarding cross site request forgery
by corvid＠lavabit.com 03 Oct '08

03 Oct '08

Cross site request forgery is the one where the bad person sticks an image tag or some javascript or whatever on a page, and your privileges are used to do something. So my latest little experiment: out of the image urls your browser sees that have queries (the '?a=b&c=d&e=f'), how many are - just advertisement trash anyway - things you want where the request would work just as well with the query removed (e.g. forum software that likes to stick session ids on everything) - things that wouldn't still work but don't really matter (e.g. user icons) - things you need Here's a little bit of code that tries rejecting them. (If dillo had an option for such a thing someday, I imagine it would have a form more like "don't automatically load, and make it easier to know what the URL is before you load it manually")

4 11

segfault -- callback + closed window?
by corvid＠lavabit.com 01 Oct '08

01 Oct '08

I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image. Got: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127 Maybe that's just a part of life with callbacks...

3 9

source window's reluctance to show end of file
by corvid＠lavabit.com 30 Sep '08

30 Sep '08

I've been assuming all along that everyone sees this problem, but then I don't think anyone has ever mentioned it, so I wonder whether it only shows up on my slow machine. Thus far it's always been easier for me to resize the window -- thereby causing whatever refiguring is necessary -- than to dig through TextDisplay to find out what goes wrong when line numbers are turned on.

2 3

Window close dialog
by jcid＠dillo.org 30 Sep '08

30 Sep '08

Hi, Can somebody please make the dialog for closing a window with tabs open? -- Cheers Jorge.-

2 4

patch: changeLinkColor
by Johannes.Hofmann＠gmx.de 30 Sep '08

30 Sep '08

On Sun, Sep 28, 2008 at 02:54:56PM -0400, Jorge Arellano Cid wrote: > On Sun, Sep 28, 2008 at 05:55:10PM +0000, corvid wrote: > > Encouraged by the idea that I am going in the right direction, I have > > made a new one with spaceStyle: > > Funny how we were working on the same patch a the same time! > > I had an ancient version, and gave it a review. > The link search is linear inside textblock. A linux gazette page > showed more than 33000 words to color a link. On bigger pages it may be worst. > It depends on the structure. For instance our bookmarks uses tables > and the link is usually found in less than 10 words. > > The patch in CVS reduce the 35000 steps to 1500 or so (the > sorted link list is sparse, so there's a penalty for looking > for an actual link to compare to). > Not sure I understand this optimization. It is assuming that link numbers are always increasing, right? Can we assume this in dw/*? src/html.cc seems to be implemented currently in way that this is true. But perhaps we could/should reuse link numbers for equal destination urls in the future? Or someone might just choose hashes of the url string as link number. BTW. with both implementations I now see issues with this example: <html> <body> <a href="http://www.dillo.org">dillo</a> <a href="http://slashdot.org">slashdot</a> <a href="http://www.dillo.org">dillo</a> </body> </html> When opening the first link in a new window, it doesn't change color in the original one. When opening it in a tab, the first one changes color. After a reload also the second one changes color. Am I missing something? Cheers, Johannes

3 6

Window close dialog
by jcid＠dillo.org 30 Sep '08

30 Sep '08

On Mon, Sep 29, 2008 at 07:46:52PM +0200, Johannes Hofmann wrote: > Hi Jorge, > > On Mon, Sep 29, 2008 at 11:12:39AM -0400, Jorge Arellano Cid wrote: > > On Mon, Sep 29, 2008 at 04:03:55PM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > On Mon, Sep 29, 2008 at 09:48:58AM -0400, Jorge Arellano Cid wrote: > > > > Hi, > > > > > > > > Can somebody please make the dialog for closing a window > > > > with tabs open? > > > > > > "Close Window" only closes the current tab anyway. > > > > Yes. > > > > > "Exit Dillo" closes all windows including tabs. > > > So, do you think about a dialog in the "Exit Dillo" case when > > > there is more than one tab or more than one window or both? > > > > Both, plus the window manager's "close window" if there're open Tabs. > > > > > Do we have the number of open windows somewhere? > > > > In bw.cc's num_bws. > > > > just tried to implement that by creating a callback for the > fltk::Window. But then I noticed that user_data() of the windows is > already beeing used in ui.cc. > I don't understand why this is necessary. UI also contains a pointer > to the BrowserWindow (Bw). It helps the child widgets find their bw. e.g. search button, panel buttons, etc. They are nested in different ways depending on the panel shape choice so AFAIS there's no easy way to navigate up to the UI. One way solve it is to store the bw in the window's user_data(), thus a simple wid->window()->user_data() does the trick. Giving it some more thought, the danger of some function not belonging to the current UI geting the wrong bw is real, and it may end sending commands to the wrong bw. IOW: there's only one window for several tabs. When Tabs switch focus, the window()->user_data() is updated accordingly. If a background Tab requests its bw using window()->user_data() it will get the wrong one! (this may cause problems as the one reported by corvid.) If we can find an alternative method to get to a widget's bw (storing it in the CustTabGroup for instance), it'd be much better. -- Cheers Jorge.-

1 0

patch: show_msg=NO disable debug messages
by corvid＠lavabit.com 29 Sep '08

29 Sep '08

tried turning off show_msg and saw how dillo is still somewhat chatty thanks to DEBUG_MSG. (Or would you prefer a show_debug_messages pref as suggested in dillo2rc? Hmm... thinking about the sentence "Generic messages (mainly for debugging specific parts)", I'd have to say that we use MSG for plenty of debugging messages and DEBUG_MSG for plenty of of-more-general-interest messages.)

3 2

patch: changeLinkColor
by Johannes.Hofmann＠gmx.de 28 Sep '08

28 Sep '08

On Sun, Sep 28, 2008 at 07:42:14PM +0000, corvid wrote: > Jorge wrote: > > On Sun, Sep 28, 2008 at 05:55:10PM +0000, corvid wrote: > > > Encouraged by the idea that I am going in the right direction, I have > > > made a new one with spaceStyle: > > > > Funny how we were working on the same patch a the same time! > > > > I had an ancient version, and gave it a review. > > The link search is linear inside textblock. A linux gazette page > > showed more than 33000 words to color a link. On bigger pages it may be worst. > > It depends on the structure. For instance our bookmarks uses tables > > and the link is usually found in less than 10 words. > > > > The patch in CVS reduce the 35000 steps to 1500 or so (the > > sorted link list is sparse, so there's a penalty for looking > > for an actual link to compare to). > > > > Please apply the spaceStyle part, and send it to me. > > Do we know that all of the (TEXT -- putting WIDGET aside for the moment) > contents of a link will have the same style? First likely example I could > come up with is how about in a utopian future dillo where tooltips are > implemented and there's an ABBR inside? Oh right. Just think about: <html> <body> <a href="http://slashdot.org">slash<b>dot</b></a> </body> </html> After clicking, the dot is no longer bold. Cheers, Johannes

1 0