June 2012 - Dillo-dev - lists.mailman3.com

Doxyfile
by p37sitdu＠lavabit.com 26 Sep '12

26 Sep '12

I have removed all boilerplate from Doxyfile, now it is much shorter and there are less empty/default vairables. I was looking for some way to change layout to something simplier (no CSS-based tabs for example), but looks it is easier to just disable CSS. Cleaned up Doxyfile attached. I have enabled DOT_MULTI_TARGETS to make building faster and left TODO for Dillo logo.

3 3

Horizontal scrolling with mouse buttons
by jcid＠dillo.org 07 Aug '12

07 Aug '12

On Mon, Aug 15, 2011 at 02:18:33PM -0400, saulgoode(a)flashingtwelve.brickfilms.com wrote: > Quoting Jorge Arellano Cid <jcid(a)dillo.org>: > > > Please try dillo-3.0-pre, following these directions [1]. > >Then report back how it goes. > > > > [1] http://www.dillo.org/source.html > > With that build, the horizontal scroll buttons are inactive. To my > mind this is satisfactory behavior as it does not interfere with the > vertical scrolling of the mouse wheel (previously the only way to > restore vertical wheel scrolling was to restart the program). Good! This looks like an issue with fltk-1.3. FWIW, inside fltk-1.3 src/Fl_x.cxx:1443, there's no code to handle those buttons. Having something like the following may be worth a try (if you're a coder): if (xevent.xbutton.button == Button4) { Fl::e_dy = -1; // Up event = FL_MOUSEWHEEL; } else if (xevent.xbutton.button == Button5) { Fl::e_dy = +1; // Down event = FL_MOUSEWHEEL; + } else if (xevent.xbutton.button == Button6) { + Fl::e_dx = -1; // Left + event = FL_MOUSEWHEEL; + } else if (xevent.xbutton.button == Button7) { + Fl::e_dx = +1; // Right + event = FL_MOUSEWHEEL; } else { Fl::e_state |= (FL_BUTTON1 << (xevent.xbutton.button-1)); event = FL_PUSH; checkdouble(); } > Thank you for your response. :) -- Cheers Jorge.-

3 2

signed integer overflow in cache.c
by p37sitdu＠lavabit.com 18 Jun '12

18 Jun '12

In function Cache_client_enqueue variable ClientKey is incremented and checked for negative values after that (in case of overflow). Even though overflow is unlikely, signed integer overflow results in wraparound on most systems and gcc don't seem to optimize away overflow check even with -O3 (it only inlines Cache_client_enqueue in my case) it is better to avoid overflow completely as there are other compilers and compiler versions.

2 2

dillo.cc cleanup and bugfix
by p37sitdu＠lavabit.com 18 Jun '12

18 Jun '12

Reordered #includes. Fixed --geometry flag. It is --geometry in man page but -geometry in usage and only -geometry is recognized by program. Simplified getCmdOption. Removed State enum, it was overkill. It is also possible to remove support for mandatory arguments (opt_argc < 0) as it is not used, but it does not add LOC so I left it there. Removed check for about:blank as start_page, it is not a special case.

4 9

Dillo working directory
by p37sitdu＠lavabit.com 15 Jun '12

15 Jun '12

In Paths::init Dillo changes working directory to /tmp. This way every time I try to open some page stored on the hard disk (Ctrl-O) I have to start in /tmp. What is the reason for changing WD to /tmp? BTW oldWorkingDir is not used anywhere.

1 2

[patch] VOIDP2INT, INT2VOIDP and pointer size
by p37sitdu＠lavabit.com 14 Jun '12

14 Jun '12

Now (long) is used for converting (void *) to integer. This patch replaces (long) with intptr_t. I don't think this fixes the real problem. When VOIDP2INT and INT2VOIDP macros are used, it is possible that converted type won't fit into intptr_t. It is better to rewrite code that uses these macros in portable way and remove these macros. Anyway, using intptr_t is better than using (long), (long long) or introducing more autoconf dependency.

4 3

[patch] HTML parser bugfix
by p37sitdu＠lavabit.com 12 Jun '12

12 Jun '12

The following HTML fragment is shown as BUG<">abc by Dillo. It is valid (checked with validator.w3.org) HTML. In Firefox it is shown as abc with '>BUG<' tooltip. <div title=">BUG<">abc</div> What happens is that Dillo see < character inside quotes, shows bug "attribute lacks closing quote" and breaks out of tag parsing loop. In fact it is not possible to say if there is a bug in HTML at that point. In WWW you can see this bug on http://reddit.com. Each entry on this page contains votehash', null, event)" > and bug meter shows bugs for them. Attached patch removes logic that tries to detect unterminated quoted attributes and fixes this bug.

4 8

[customercare@dotster.com: Case Number: 01278137 - New Comment Added - ref:_00D30S5t._50060JcXjd:ref]
by jcid＠dillo.org 07 Jun '12

07 Jun '12

FYI -- Cheers Jorge.-

1 0

dillo.org web site
by jcid＠dillo.org 07 Jun '12

07 Jun '12

Hi there, The domain was renewed, but I still can't see the website from Chile, although when I log to the wearlab it works [1]. Is everybody seeing having the same problem? [1] lynx www.dillo.org -- Cheers Jorge.-

6 15

[patch] dlib cleanup
by p37sitdu＠lavabit.com 05 Jun '12

05 Jun '12

malloc.diff: added perror calls for malloc and realloc errors dstr.diff: dStr* functions cleanup dlist.diff: replaced recursive QuickSort with qsort from stdlib.h. Tested with file.dpi where it is used for sorting directory listing.

3 4