October 2007 - Dillo-dev - lists.mailman3.com

Scrolling patch!
by bogus＠does.not.exist.com 21 Nov '07

21 Nov '07

Hi there, Here's a patch I wanted to add since a long time. Remembering the scroll position in a page. At least for me, it improves web browsing a lot! The dw2 part of the patch is attached to this email, so Sebastian can look at a minor change that looks like a fix for a hidden bug in the code... The patch is complete in CVS. -- Cheers Jorge.-

4 7

some more bugs
by matthias.franz＠ujf-grenoble.fr 08 Nov '07

08 Nov '07

Hi everybody, here are some more bugs I've discovered. (I'm sorry that testing usually leads to postings about problems ... Thanks to all who have volunteered to fix them so far!) - The tag <hr> does not produce a horizontal line, but only a small dot. - Pressing "@" anytime quits Dillo immediately. (I guess that was made on purpose during development.) - The bookmark page looks very funny. The columns for the sections and the bookmarks are much to narrow and together use only about one third of the window width. - A problem which is already present in the fltk2 program test/input: Pressing a dead key and then a letter (e.g., "^" and "o") works fine. Pressing a dead key followed by space only sometimes gives the accent (as it should) and sometimes just a space. What you get seems to be random; it changes even while the program is running. I understand that fltk2 processes dead keys on its own. For us, it would probably be easier if the keyboard was used in a "cooked" mode based on the X keyboard settings. Cheers, -- Matthias Franz

3 5

new browser windows slower than first one
by Johannes.Hofmann＠gmx.de 07 Nov '07

07 Nov '07

Hello, just noticed a scroll performance-related problem: When I create many browser windows (e.g. using the middle mouse button), srolling in these created windows causes more Xorg CPU usage than in the first one. Maybe, scrolling in the new windows causes redraws from the old ones? Johannes

5 13

New CVS repository and patches
by bogus＠does.not.exist.com 06 Nov '07

06 Nov '07

Hi There! Once again, thanks for the patches and keep them flowing. The new CVS repository is up and updated with the patches: e.g. (with "-cur" terminated directories being the working directories) alias dcvs='cvs -z3 -djcid@auriga.wearlab.de:/sfhome/cvs/dillo' dcvs co dillo2 dcvs co dw2 cp -r dillo2 dillo2-cur cp -r dw2 dw2-cur ln -s dw2-cur dw-testbed find dw2-cur -name CVS -exec rm \{\} \; find dillo2-cur -name CVS -exec rm \{\} \; cd dw2-cur ./autogen.sh make cd ../dillo2-cur ./autogen.sh make Here follow my comments on the patches. Please test this CVS code and send feedback: > [Johannes wrote] > * the namespace "signal" in dw-testbed/lout/signal.hh conflicts with > the declaration in /usr/include/sys/signal.h: > __sighandler_t *signal (int, __sighandler_t *); > I renamed the namespace to loutsignal. Johannes: please send me the patch for this. > [Vincent wrote (va_list issue)] > Sure, though i'm not at all sure this is the correct way to fix this > issue. Vincent: AFAIS, the problem is looping without the va_copy, so the patch is OK. Anyway, please test the CVS code and tell us how it works. > [Andreas wrote] > Ok, then I got it to compile finally for my ipaq with familar 0.8.4 on it. > I runs with X-forwarding so that I get the window on my notebook display. > But it segfaults without x forwarding: Andreas: please let us know the procedure when you have cleaned it up. > [Alexander wrote (strndup)] > Hm, right. I had used malloc() in my replacement function, but with > calloc() it is indeed unnecessary. > > I have wrapped this in autoconf, see attached patch. I also made > autoconf in dillo and dw-testbed check for the path to the perl binary > and substitute it in dpidc and Doxyfile, respectively, see other patch. > Actually, these patches can't simply be applied: first, > dillo-f15/dpid/dpidc and dw-testbed-0.0.43j/Doxyfile have to be moved > to *.in. Alexander: as strndup is a GNU extension, and we have kept the code as portable as possible, I just added the wrapper for it based on the patch. With regard to Perl, I'd like to get rid of that dependence either with bash (if possible) or C. BTW, if Sebastian agrees it may also be a good idea to use Dlib in dw2. That way those problems could be layered down... > [Johannes wrote] > here is a new version of dillo-fltk scroll performance > improvements. This patch is against vanilla dillo-fltk. > > New in this patch: > > * Hotkey bindings for arrow keys, Home- and EndKey. > This only works when the focus is on the > display area. > > * Only unclipped area is exposed which improves performance on > large pages (e.g. http://www.w3.org/TR/xslt). > > * Limit scrolling to reasonable values. It improves not only performance on large pages but also avoids overlapped rendering. Applied. > [Matthias wrote] > Fine! Only using the arrow keys is quite slow and consumes all CPU time > on my machine. In contrast, srolling with the old Dillo was quick and > produced almost no CPU load. > > A question: Would it be difficult to add mouse wheel support as well? > On my machine that does not work. (Or is thia a configuration issue > regarding FLTK?) Dillo1 didn't render antialiased text, and was heavily optimized. The optimization phase of rendering in dillo2 has just started (thanks Johannes :). I hope we can tune it to a dillo1 similar CPU-consumtion. > [Matthias wrote] > Compilation on Debian Etch worked well. I had to use the "--x-includes" > and "--x-libraries" options when configuring FLTK, and the test glpuzzle > did not compile. I'm also using Etch here and didn't need those options. I also have a running glpuzzle. The CPU, hogs when scrolling on vanilla but not with the scrolling patch, and entities work. I also don't experience CPU-hogs from the over-link-quick-switch-from arrow-to-hand test. Maybe this is related to something not installed or not configured in your machine... (This system has: x11proto-gl-dev, freeglut3, freeglut3-dev, libxft2, libxft2-dev, libgl1-mesa-{dev,dri,glx} among others that I don't know whether relevant or not! ;). BTW, I'm testing on a fast machine. It will be interesting to see what the old one produces. > [Johannes wrote] > Mouse wheel is a matter of binding. Place your mouse pointer over the > scroll bar and use the mouse wheel (it needs to be bound to the viewport). > > It is slow, because the default linesize (the amount a scrollbar > scrolls when pushing on the arrow is 1. I could change that, but > what would be a reasonable value? The height of a word in normal text (i.e. line height). We know the font and font factor from dillorc2 (or defaults). This number is a good candidate. ---------------- Side Note to all: Have you right-clicked over the search button? :-) -- Cheers Jorge.-

5 10

Crashes on OpenBSD
by Christian.Kellermann＠nefkom.net 05 Nov '07

05 Nov '07

Skipped content of type multipart/mixed

3 8

Re: yet another patch: forms. activateReceiver
by jcid＠dillo.org 29 Oct '07

29 Oct '07

Hi, After a rescue operation (and re-trainning of my bogofilter), there were this emails/patches in the SPAM bin: place (5.6K) patch: just the not-hooked-up image menu place (6.8K) patch: image loading toggle button + preference place (4.2K) patch: plain page menu place (2.6K) yet another patch: forms. activateReceiver All of them were commited with only minor changes. > I assumed I was going to have to _understand_ forms or resources, and here > I find out that all I have to do is hook A to B. At least to make the forms > I use regularly work... I wonder whether you guys left the easy stuff for > whoever comes along just so that it would be easy for them to feel rewarded > for their efforts... :-) We were trying with Sebastian to check that FLTK2, was providing everything we needed to complete the port. Thus, if something worked, but needed lots of hooks thorough the code, only the first one was made (and the rest left for the future), so we could advance to the next case. In the case of forms, while I was porting the html parser the resources for forms were not yet developed, so I had to comment and skip some hooks to make it compile. Later I started joining some dots... > I didn't patch the rc to mention the preference, though. I did. > A slavish copy of linkblock, which, since there certainly weren't any links > involved, ended up named 'eventdata'... In general, do you plan to make the rest of the patches (e.g. hook the image menu, the image loading toggle), or want some help here? BTW, with regard to the linkblock (and my past comments on it), I can try to check how it looks without linkblock, and decide what to make of it afterwards while you work on the part II of the above patches. Just let me know. -- Cheers Jorge.-

1 0

Test (for posting problems), please ignore
by onepoint＠starurchin.org 27 Oct '07

27 Oct '07

Lets see if Jorge has has fixed whatever it was that stopped my posts getting through... Jeremy Henty

1 0

directory listings?
by hans＠stare.cz 22 Oct '07

22 Oct '07

On Oct 19 19:33:56, dillo-dev-bounces(a)dillo.org wrote: > On Thu, Oct 18, 2007 at 02:27:57PM +0200, Jan Stary wrote: > > Hi all, > > > > dillo-fltk http://stare.cz/~hans/foto/ gives me a directory > > listing as it should. It's full of subdirectories, and they > > are all the same (just contain JPEGs). > > > > Now when I click on _some_ of the links, I get a correct directory > > listing again (of the subdirectory). When I click on _some_ others > > I get nothing, just a blank page (gray). > > > > [...] > > Please try the CVS code on this. With current code, I cannot even test it, because dillo keeps "Connecting to server" forever, giving the following message: $ dillo-fltk http://stare.cz/~hans/foto/ prefs: Can't open dillorc2 file: /home/hans/.dillo/dillorc2 prefs: Can't open dillorc2 file: /usr/local/etc/dillorc prefs: Using internal defaults. dillo_dns_init: Here we go! (threaded) Enabling cookies as from cookiesrc... Nav_open_url: Url=>http://stare.cz/~hans/foto/< Dns_server [0]: stare.cz is 0x7f7b8640 Connecting to 88.208.90.43 ** ERROR **: IO_fd_write_cb: call on already closed io! a_UIcmd_close_bw ... until I kill it. (The server is acessible, the same URL can be browsed with lynx.) Jan

2 1

drag scrolling as in good old dillo1
by Johannes.Hofmann＠gmx.de 21 Oct '07

21 Oct '07

Hi, here is a patch to enable drag scrolling with the middle mouse button as in dillo1. For me from now only the "Backspace" hotkey is missing for daily browsing - apart from the occasional crashes of course :-) Johannes diff --git a/dw/fltkviewport.cc b/dw/fltkviewport.cc --- a/dw/fltkviewport.cc +++ b/dw/fltkviewport.cc @@ -47,6 +47,7 @@ FltkViewport::FltkViewport (int x, int y vscrollbar->callback (vscrollbarCallback, this); scrollX = scrollY = 0; + dragScrolling = 0; gadgetOrientation[0] = GADGET_HORIZONTAL; gadgetOrientation[1] = GADGET_HORIZONTAL; @@ -202,6 +203,34 @@ int FltkViewport::handle (int event) /** \bug Undraw focus box. */ return 1; + case ::fltk::PUSH: + if (::fltk::event_button() == ::fltk::MiddleButton) { + dragScrolling = 1; + dragX = ::fltk::event_x(); + dragY = ::fltk::event_y(); + /* pass event so that middle click can open link in new window */ + FltkWidgetView::handle (event); + return 1; + } + break; + + case ::fltk::DRAG: + if (::fltk::event_button() == ::fltk::MiddleButton) { + if (dragScrolling) { + scroll(dragX - ::fltk::event_x(), dragY - ::fltk::event_y()); + dragX = ::fltk::event_x(); + dragY = ::fltk::event_y(); + return 1; + } + } + break; + + case ::fltk::RELEASE: + if (::fltk::event_button() == ::fltk::MiddleButton) { + dragScrolling = 0; + } + break; + case ::fltk::SHORTCUT: switch (::fltk::event_key()) { case PageUpKey: @@ -236,12 +265,9 @@ int FltkViewport::handle (int event) scrollTo (canvasWidth, canvasHeight); /* gets adjusted in scroll() */ return 1; } + } - return FltkWidgetView::handle (event); - - default: - return FltkWidgetView::handle (event); - } + return FltkWidgetView::handle (event); } // ---------------------------------------------------------------------- diff --git a/dw/fltkviewport.hh b/dw/fltkviewport.hh --- a/dw/fltkviewport.hh +++ b/dw/fltkviewport.hh @@ -21,6 +21,7 @@ private: int scrollX, scrollY; int scrollDX, scrollDY; + int dragScrolling, dragX, dragY; ::fltk::Scrollbar *vscrollbar, *hscrollbar;

2 1

bug: non-ascii characters not displayed correctly in the title bar
by matthias.franz＠ujf-grenoble.fr 20 Oct '07

20 Oct '07

Hi, by default, I use Latin1 encoding on my machine, not UTF-8. Dillo2 does not do UTF-8 -> Latin1 conversion for the title bar. Here is an example: <title>dillô</title> <body> dillô </body> You don't get "dill?" in the title bar, but "dill??". Cheers, -- Matthias Franz

2 2