- Dillo-dev - lists.mailman3.com

[PATCH] cleanup of URL_ILLEGAL_CHARS
by Frank de Lange Nov. 12, 2003

Nov. 12, 2003

Jorge, Skip that last patch I sent you, here is a new one which also touches html.c... Please apply ASAP... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] diff -pruN dillo/src/html.c dillo_patched/src/html.c --- dillo/src/html.c 2003-11-11 21:45:01.947370344 +0100 +++ dillo_patched/src/html.c 2003-11-12 09:01:46.119597904 +0100 @@ -152,7 +152,7 @@ static DilloUrl *Html_url_new(DilloHtml url_str, (use_base_url) ? base_url : URL_STR_(html->linkblock->base_url), flags, pos); - if ((n_ic = URL_ILLEGAL_CHARS(url)) != 0) + if ((n_ic = URL_ILLEGAL_CHARS_(url)) != 0) MSG_HTML("URL has %d illegal character%s (00-1F, 7F or space)\n", n_ic, (n_ic) > 1 ? "s" : ""); return url; diff -pruN dillo/src/url.h dillo_patched/src/url.h --- dillo/src/url.h 2003-11-11 21:45:02.153339032 +0100 +++ dillo_patched/src/url.h 2003-11-12 08:16:28.038808992 +0100 @@ -57,7 +57,7 @@ #define URL_ALT_(u) u->alt #define URL_POS_(u) u->scrolling_position #define URL_STR_(u) a_Url_str(u) -#define URL_ILLEGAL_CHARS(u) url->illegal_chars +#define URL_ILLEGAL_CHARS_(u) url->illegal_chars /* * Access methods that always return a string: @@ -77,7 +77,7 @@ #define URL_ALT(u) NPTR2STR(URL_ALT_(u)) #define URL_POS(u) URL_POS_(u) #define URL_STR(u) NPTR2STR(URL_STR_(u)) - +#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u)) /* URL-camp compare methods */

2 2

Cookies disabled
by William Trenker Nov. 12, 2003

Nov. 12, 2003

When dillo starts a console message indicates that cookies are disabled. Is there a way to enable cookies? Thanks, Bill

3 2

help
by Pavankumar P Nov. 12, 2003

Nov. 12, 2003

---------------------------------------------------NOTIFICATION-------------- -------------------------------------------- The subject line for this message is prohibited by Symantec AVF and the message was quarantined. The Subject Line of the message falls under restricted category. If you think that the message is valid please raise a call through helpdesk for further clarifications and release of the same." Please note this message will be retained for 3 Days for claim, after which it will be purged. ----------------------------------------------------------------------------- ----------------------------------------------- ID:MTV01EX01::SYQ69c2e949 DISCLAIMER: This message (including attachment if any) is confidential and may be privileged. Before opening attachments please check them for viruses and defects. MindTree Consulting Private Limited (MindTree) will not be responsible for any viruses or defects or any forwarded attachments emanating either from within MindTree or outside. If you have received this message by mistake please notify the sender by return e-mail and delete this message from your system. Any unauthorized use or dissemination of this message in whole or in part is strictly prohibited. Please note that e-mails are susceptible to change and MindTree shall not be liable for any improper, untimely or incomplete transmission.

1 0

[PATCH] Version 14 of tab/frames/kbnav patch is ready
by Frank de Lange Nov. 12, 2003

Nov. 12, 2003

Hi'all, The next version (14) of my tab/frame/keyboard navigation patch is ready (see bottom of this message for download instructions). /* ATTENTION */ Version 13 of the patch was missing a line, which made it segfault when clicking on some images. That is fixed in this release. This is the ONLY difference between version 13 and version 14. I sent a small patch to the mailing list which fixes this problem in version 13, if you already downloaded version 13 you can apply that patch instead of downloading version 14. The filenames for version 13 and version 14 are the same, if you are in doubt which version you have run md5sum on the file and compare the result with that in this message. /* and now we continue with our scheduled program */ Keyboard navigation has grown up, it is more or less complete now. There have been many internal changes, leading to a much more robust implementation. Links are now highlighted in a distinct way, with a dashed inverse frame around highlighted text. Link navigation should now be reliable in any direction (up, down, left, right). Scrolling movements are minimized, the code starts looking for links in the currently visible part of the document. The Tab/Shift-Tab keys now really work as advertised, they can also be used to move focus between frames. If something doesn't work they way it should (or the way you *think* it should), I want to know! For more info on keyboard navigation, see the doc/Keyboard_Navigation.txt document (after applying the patch, naturally...). More information on tabs can be found in doc/Browser_Tabs.txt, for frames see doc/Browser_Frames.txt. The mailing list archives are also a good place to look for answers to questions relating to this patch. Tabs, Frames and browser bloat ============================== version: 0.8.0-pre patch: dillo-20031110-tabs.patch.gz unpatched: 295956 bytes patched, no tabs, no frames: 312660 bytes patched, with tabs, no frames: 318964 bytes patched, no tabs, with frames: 329076 bytes patched, with tabs, with frames: 335604 bytes (gcc 3.2.2, binutils 2.13.90.0.18, CFLAGS "-Os") Download instructions ===================== The patch is made against 20031110@10:27 CVS. Do not forget to run ./autogen.sh after applying the patch. You can find the patch on the usual (ad-happy, use an ad-blocking proxy or sane browser) site: http://www.geocities.com/ikbenfrank/ More specifically: Dillo 0.8.0-pre (CVS) ===================== http://www.geocities.com/ikbenfrank/dillo-20031110-tabs.patch.gz size: 100110 bytes (gzipped, as downloaded) 449102 bytes (uncompressed) md5sum: 4e11fbbac0945882f8bdedbd0b0f31ac (gzipped, as downloaded) 95f3d0aa78939fd9105d921665a87072 (uncompressed) As always, check the site for the most recent version Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

3 4

DPI's and 0.7.3
by William Trenker Nov. 11, 2003

Nov. 11, 2003

Will the download and ftp dpi's in CVS work with Dillo 0.7.3? If so, how do I build them? Or do I have to wait until version 0.8 is available? Thanks, Bill

1 0

Latest parser changes
by Jorge Arellano Cid Nov. 11, 2003

Nov. 11, 2003

Hi there! After all the trouble with trying to convince Slashdot's webmasters to fix their HTML (because of the loftier importance of adhering to standards), and considering Andreas S. comment on that dillo was making a weird rendering only, but not helping to find the cause to fix the problem, I started a more in-depth review of it. As time passed the code I was developing turned more and more interesting and finally here you have it! This is a quote from the ChangeLog: * Adapted the generic parser to make HTML error detection, providing the line number and a hint (expected tag) in the error message! * Added 'show_html_wanings' option to dillorc (boolean). * Added information about optional, required and forbidden end tags. * Modified the parser's handling of closing tags to account for elements with an optional close tag, and for more accurate diagnosis messages. * Added 'use_old_parser' option to dillorc (boolean). * Fixed the handling of HEAD and BODY elements to account for their double optional condition (both open and close tags are optional). This basically means that now dillo will detect and print useful error messages about bad-formed HTML. After using it for a while it helped me to find bugs I have overseen for months and it proved very accurate and helpful! (it even catched one at the W3C site! :) I hope it will be a good tool for webmasters, and for people authoring simple web pages. In our side, it will help to polish our HTML parsing. For instance, it soon became clear that we're sometimes pulling tags when they should stay. For instance: <p> <ol><li> One <li> two </ol> </p> <- detects an error here. because <ol> anticipatedly cleans <p> from the stack. This may look not relevant, but when trying to build a DOM tree it certainly is! Some comments: The new parsing behaviour makes sites render different from what they used to. Sometimes they show better, some others worse. After all it is bad-formed HTML what we're dealing with. For instance: heise.de a bit worst but usable. slashdot.org renders ok. sf.net worst but usable. Please bear in mind that now dillo can diagnose these errors at render time so, as a user, now you can send a meaningful error report to a site's webmaster! (for instance slashdot is diagnosed on-the-fly). Our experience is that most webmasters welcome this reports. Finally, remember that you can turn off the HTML error messages show_html_wanings=NO and that you can fall back to the old parser: use_old_parser=YES Enjoy! (I hope ;) Jorge.-

1 0

libpng detection again...
by Jorge Arellano Cid Nov. 11, 2003

Nov. 11, 2003

Hi, We've been through this several times, and today I received one more suggestion that may work: The whole point is replacing the current line in configure.in with something better ;). <current line> CPPFLAGS="$CPPFLAGS `$PNG_CONFIG --I_opts`" </current line> Kelson and Raphael had to patch for SUSE 8.1: http://article.gmane.org/gmane.comp.web.dillo.devel/1011/match=libpng http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-April/000532.html Basically: <patched line> CPPFLAGS="$CPPFLAGS -I/usr/local/include/libpng12" </patched line> and here's the new candidate: <candidate line> CPPFLAGS="$CPPFLAGS `$PNG_CONFIG --cppflags`" </candidate line> At least it looks clean! The funny thing is that on my box, the "candidate" and "current" give different results, but it works with either one! :-) Worth a try? Surely. Please give a test to the candidate and tell us how it works for you. Cheers Jorge.-

3 2

[ATTENTION][PATCH] New version of tab/frame patch (13) has error, new version later today
by Frank de Lange Nov. 10, 2003

Nov. 10, 2003

Hi'all, As some of you may have noticed, the last version of the tab/frame patch segfaults when clicking on some images. This is caused by a missing line in html.c:346: static gboolean Html_image_menu(GtkWidget *widget, GdkEventButton *event, DilloDoc *dd) should be: static gboolean Html_image_menu(GtkWidget *widget, gint32 x, gint32 y, GdkEventButton *event, DilloDoc *dd) You can either apply the patch which comes with this message, or wait for a new release (14) of the patch which solves this issue. No, I do not know why this line was missing... Thanks to Johannes Hofmann for notifying me of this problem! Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] --- dillo_tabs/src/html.c~ 2003-11-10 12:38:45.171994080 +0100 +++ dillo_tabs/src/html.c 2003-11-10 17:14:28.530021384 +0100 @@ -343,8 +343,9 @@ /* * Popup the image menu ("button_press_event" callback of image) */ -static gboolean Html_image_menu(GtkWidget *widget, GdkEventButton *event, - DilloDoc *dd) +static gboolean Html_image_menu(GtkWidget *widget, + gint32 x, gint32 y, GdkEventButton *event, + DilloDoc *dd) { DwImage *image = DW_IMAGE (widget); gboolean return_val;

2 1

Re: [Dillo-dev] [PATCH] Version 13 of tab/frames/kbnav patch is ready
by Frank de Lange Nov. 10, 2003

Nov. 10, 2003

Johannes Hofmann wrote: > Hi, > > thanks for your continued work on dillo! > > With the newest version (13) of your patch I encountered a segfault when > clicking on clickable images on FreeBSD-current: > > Program received signal SIGSEGV, Segmentation fault. > Html_image_menu (widget=0x811d500, event=0x10c, dd=0xee) at html.c:354 > 354 if (event->button == 3 && image->url) { > (gdb) p event > $1 = (GdkEventButton *) 0x10c > (gdb) p image > $2 = (DwImage *) 0x811d500 > (gdb) p image->url > $3 = (DilloUrl *) 0x8146a80 > (gdb) p event->button > Error accessing memory address 0x148: Bad address. I'll have a look at this asap... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

1 0

[PATCH] nit in dpid/Makefile.am
by Frank de Lange Nov. 10, 2003

Nov. 10, 2003

The makefile for dpid does not honour $DESTDIR, which can make package builds fail. Fix attached This fix is also in the latest versions of the tab/frame and kbnav patch. If this fix is applied to CVS, it will cause those patches to fail. This is NOT a problem, just ignore the reject message on dpid/Makefile.am Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] --- dillo/dpid/Makefile.am 2003-11-03 14:12:39.000000000 +0100 +++ dillo_kbnav/dpid/Makefile.am 2003-11-10 10:44:28.163417832 +0100 @@ -21,4 +21,4 @@ install-data-local : $(mkinstalldirs) $(DESTDIR)$(sysconfdir) - echo dpi_dir=$(libdir)/dillo/dpi > $(sysconfdir)/dpidrc + echo dpi_dir=$(libdir)/dillo/dpi > $(DESTDIR)$(sysconfdir)/dpidrc

1 0