- Dillo-dev - lists.mailman3.com

[PATCH] Version 4 of kbnav patch is ready
by Frank de Lange Nov. 21, 2003

Nov. 21, 2003

Hi'all, The next version (4) of my keyboard navigation patch is ready. See the end of this message for download instructions. Do note that the tab/frame patch already contains this functionality, so there is no need (and no way) to apply this patch on top of that or the other way around. This release does not add many new features. It does however fix most known bugs, which is a good enough reason for applying it I'd say... One new feature is that is is now possible to popup context menus with keyboard navigation. The default key binding is Alt-Enter (and Alt-KP_Enter), this can of course be changed using the appropriate preference incantation. For more info on what this patch does, see the doc/Keyboard_Navigation.txt document (after applying the patch, naturally...) Fixed bugs ---------- - all known segfaults - most 'weird navigation order' problems - related issue (now fixed in CVS): a_Findtext_search returned FALSE (instead of FINDTEXT_NOT_FOUND) when a search was performed on an empty page. Since this function is supposed to return a FindtextResult enum value (and the first value in that enum is FINDTEXT_SUCCESS) this made the focus code try to focus a link in an empty page leading to a segfault in the scrolled_window. TODO ==== - add x scrolling capability to Dillo (change anchors, URL_POS, scrolling functions, iterators, etc...). This is needed for better keyboard navigation on wide pages. Download instructions ===================== There is currently only one version of the patch, made against 2003119@14:09GMT CVS. As always, have a look at the patch website (http://www.geocities.com/ikbenfrank/) for the latest version of the patch. This patch does NOT apply on top of the tab/frame patch, and the tab/frame patch does not apply on top of this one! The tab/frame patch already contains this functionality, so it is not needed. http://www.geocities.com/ikbenfrank/dillo-200311211558-kbnav.patch.gz size: 30615 bytes (gzipped, as downloaded) 152903 bytes (uncompressed) md5sum: 29aa01c8c5eabe3c7294b975155255ce (gzipped, as downloaded) 5c848e7f0e281e3135392522c8a7f980 (uncompressed) Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

1 0

RE: [Dillo-dev] FLTK
by Eric Gaudet Nov. 21, 2003

Nov. 21, 2003

I will give it a try. > -----Original Message----- > From: Sebastian Geerken [mailto:s.geerken@ping.de] > Sent: Tuesday, October 14, 2003 1:55 PM > To: Dillo mailing list > Subject: Re: [Dillo-dev] FLTK > > > Hi! > > To have some facts for this discussion, there is a (basicly working) > patch for the Gtk2 port, at > <http://www.dillo.org/misc_files/gtk2.diff.gz>. > It is a slightly modified version of a patch, which Jörgen sent me > some time ago, and compiles with the current CVS (probably not with > 0.7.3). > > Sebastian > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)lists.auriga.wearlab.de > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev >

8 10

Re: kbnav3 patch test
by Jorge Arellano Cid Nov. 21, 2003

Nov. 21, 2003

Frank, > Jorge Arellano Cid wrote: > > >Hi Frank, > > > > After waiting for a week as you suggested, today I gave a > >review to the new kbnav patch. It feels good! > > > > After some testing I came across a page that produces a > >segfault. The attached patch is against today's CVS + a couple of > >compiler-warning removals. The page is also attached. Beware that > >the segfault is only caught when the new parser is used, and that > >the page has bad-html. The case is interesting though, because a > >weird widget tree is generated and iterators should be able to > >handle/survive them! > > > > Please give it a look. > > > > Cheers > > Jorge.- > > > I have taken a look at your patch-to-my-patch, but did not apply it to > the version I will publish later today. :-o > I did do some manual > reformatting to correct some tab-related problems Good! > (Emacs' use of tabs > messes up things sometimes, and the 2-space indent it uses are not > consistent with Dillo's conventions). Thanks, we strive to be style consistent. BTW, I didn't try to fix indentation in the patch, it was just to do a test run. > Some files seem to be missing from > the patch you sent me, I guess you did not make any changes to those? My mistake. > > I did not see anything in your patch which would have corrected any > compiler warnings by that way, with a possible exception for the > disputed URL_ILLEGAL_CHARS_ macro. In my patch I used > URL_ILLEGAL_CHARS_(u) in html.c, while you use URL_ILLEGAL_CHARS(u). In > the current patch I use URL_ILLEGAL_CHARS(u) as well. The end result > should be the same however now that both versions exist. What compiler > warnings did you get which were corrected by your modifications to my patch? focus.c: In function `Focus_state_find_list': focus.c:268: warning: `list' might be used uninitialized in this function focus.c: In function `Focus_state_find_link': focus.c:465: warning: `list' might be used uninitialized in this function gcc version 3.2.3 > > On that Tarot-page you added to the message, I can say that navigation > is still quirky. But so is the page, it produces 9 warnings about > misplaced </a> tags. If you look at the source, you'll notice that it > misses several closing </A> tags (causing Dillo to allocate links all > over the page). It also contains some links with <BR> in them, which > used to crash patched Dillo because of the problem with > a_Dw_page_construct_iterator (which used to always set the mask to > DW_CONTENT_ALL, I changed this to a user-settable mask like all other > iterators have). I guess you attached the page because of those crashes? Yes, for you to have a way to reproduce it. BTW, that is what I meant with: "page has bad-html". > I will probably publish a new version of the patch (4) today, together > with a new version of the tab/frame patch. That version should be more > or less ready to commit, as no serious problems have cropped up for > several days now. See the list for problems found and corrected > (including the one causing the Tarot page to crash by the way - see my > message dated Wed, 12 Nov 2003 11:00:58 +0100). Oh, I didn't find anything about it at GMANE !? Cheers Jorge.-

3 3

FORM:DICKSON M.
by MR Dickson Mubane. Nov. 20, 2003

Nov. 20, 2003

FGood Day Friend, With warm heart I offer my friendship, and my greetings, and I hope this letter meets you in good time. It will be surprising to you to receive this proposal from me since you do not know me personally. However, I am sincerely seeking your confidence in this transaction, which I propose with my free mind and as a person of integrity and from a family with high moral respect . My name is Dickson Mubane, the first son of Mapele Mubane, of the most popular black farmer from Zimbabwe, murdered in the land dispute in my country. As led by my instict, My motherand Idecided to contact you through email, after searching for contacts via the internet,as it is the only means I can contact anybody since I am cutting off ties with Zimbabwe for security and safety reasons. However, I apologize if this is not acceptable to you. The purpose of this letter is to seek your most needed assistance in a business venture. Due to the land and political problems in Zimbabwe, as a result of President Robert Mugabe's introduction of new Land Act Reform wholly affecting the rich white farmers and the few rich black farmers, and his desire to hold on to power for life, my father for saw the danger that came in Zimbabwe. Before he was murdered, he withdrewall of our business foreign accounts in dollars and sold up our sharesin major companies. We then went to SOUTH AFRICA to deposit the sum of US$50.million (Fifty million, US dollars),in a private security company. This money was deposited with this Private Security company for safety and security reasons, and was to be used for the purchase of land, new machines and chemicals establishment of new farms in Europe.President Mugabe's support for the violent Zimbabwean war veterans andsome lunatics in the society, led to the murder of my beloved fatherand other innocent lives. I was continually threatened to abandon myinheritance from my father after he was murdered. I resited for awhile, but when the danger became unbearable, and I survived two murderattempts, I fled Zimbabwe. I am currently staying in the Netherlands where I am seeking political asylum. In fact my decision to come hereto seek asylum, is because the security company from South Africa, hasa branch here, and they have moved the deposit from their office in Johannesburg down here. I need you to assist in receiving thisconsignment from the security compamy. Since the law of Netherlands prohibits a refugee (asylum seeker) to be involved in such transactions and my mother advised that it will be better for our foreign partner to help receive this fund to avoid any eye brown being raised by Robert Mugabe, this is why I am seeking a genuine and reliable partner,who will assist in receiving the funds and also investing it wisely in a profitable venture.You have to understand that this decision taken by me entrusts my future and in your hands, as a result of the safe keeping of this money. If you accept to assist me, all I want you to do for me, is to assist with arrangements to claim the deposit from the security company from their office here in The Netherlands, as it has now been transfered from Johannesburg,South Africa to their branch in The Netherlands. The company will be legally informed of you representing my family. For your assistance, I have two options for you. Firstly you can choose to have 10% of the money for your assistance, and helping my family investing this funds, or you can go into partnership with me for the proper profitable investment of the money in your country. Whichever the option you want, please to notify me in your reply. I have also set aside 1% of this money for all kinds of expenses that come our way in the process of this transaction, and 4% of the total sum for Charitydonation.If you prefer to accept the 10% for assisting in representing my family to receive this funds, then 85%will be left for my family.Please, I want you to maintain the absolute secrecy for the purpose of this transaction. I look forward to your reply and co-operation, and Ithank you in advance as I anticipate your co-operation.You can reach me on my private line which is or via email Sincerely, Dickson Mubane. PLEASE YOU CAN READ ABOUT PROBLEMS IN ZIMBABWE FROM THE LINKS BELOW. http://news.bbc.co.uk/1/hi/world/africa/918781.stm http://news.bbc.co.uk/1/hi/world/africa/715001.stm http://news.bbc.co.uk/1/hi/world/africa/1063785.stm

1 0

Re: [Dillo-dev] HTTPS Patch
by Indan Zupancic Nov. 20, 2003

Nov. 20, 2003

Hello, Sorry for the huge mail. :) >> # Moving the dns stuff to IO. >> # Move all the socket stuff into IO.c, the module that wants to handle >> opening the connection should also close it (all non-internet sockets, >> like files. Unix sockets may be added to IO.c.). > Gzilla had a flat design, we've come a long way to layer dillo > and to separate its code in modules. It's not what you think, what I meant was to move dns.c|h to the IO directory, not to move the code from those files into IO.c, I would never do that. What I want to do is to move the code into the modules where it belongs. I see no reason why the IO module shouldn't handle all the socket related stuff, currently http.c makes a new socket and connects it, then it passes it more or less to the IO module. It seems more logical and modular to me when the IO module does those TCP/IP specific things when http calls IO_new. Let the IO module do the IO, and the http module do the http related things, that's my opinion. I don't see the http module doing anything special with the dns info, so it probably makes more sense to let the IO module use the dns module too. You seperated the code in modules and layers, what I want to do now is to move code to the place it belongs, making Dillo in my opinion more modular, overall simpler and more flexible. Currently this has the effect that the IO modules becomes bigger and more complex, but it also means that the http module will be smaller and simpler, and that it's easier to add more http like modules in the future. What's bad about the current ccc functions? The problem is that currently not all modules can communicate blindly with other modules via ccc functions, because different ccc functions expect different parameters. Also most of the time modules know exactly with which module they talk, they have no choice, otherwise they don't know what parameters to give and expect. Now you use ccc functions like a sort of bad used void pointers: You know what you get, you know what you call, but still tunnel it through a typeless function. You mix a general API with module specific API's, making things only very confusing and unclear. All I want is a clear API. I see how ccc functions are usefull, and what their point is, but that is not my problem with them, the idea of a sort of linked list of functions is nice, but the implementation isn't very well if you ask me. Also the API used internally in Dillo isn't consistent. For example: Why call a_IO_new and not IO_ccc with OpStart? Things are unnecessary complicated and inflexible now. It's not easy to unravel the spaghetti, but it's doable, and when you're done you've a nice clean internal API that makes implementing library plugins a piece of cake. > It serves to isolate the query process from the answer process. > Also as dillo uses pipes to talk to itself, it makes sense to have read-only and write-only FDs. Of course it can be merged, but it may be not simple. With pipes it makes sense yes, but in general all other connections are bidirectional. Dillo uses mostly TCP, then it's one socket, one connection, one fd. And one IOData structure if you ask me. If you use one IOData structure that is also bidirectional, then all you need to do with pipes is to still use two IOData structures, but only for pipes. One IOData structure for each fd makes most sense to me. Connection caching. You say that Dillo has it, but when I open a website, and look with netstat, Dillo has no open connections. Same experience with debug output. Maybe Dillo has it with dpi connections, I don't know, didn't look at that code yet, but in general Dillo has no connection caching, at least not the kind I mean. The one I would want to have is that keeps connections open until the server closes them, or until they time out (I'm not sure if all connections should be cached, or only the one to the last domain/current site). > In the past that approach was used. ~/.dillo ended having a > splash file for each release. The point is that what's more memory consuming is the widget tree for rendering, not the source itself. I do not know (nor want to know ;) how you first implemented it, what I was thinking about is opening by default the about html file. To have something that does exactly the same as now, all you have to do is open by default e.g. /etc/dillo_splash.html. It takes about 5 lines, patch is written within 15 minutes, most work is getting rid of the old code. And instead of keeping that 10K splash info all the time in memory, you now don't use any memory at all for it, except the one to render it, but that's gone after going to another site (if we can tell the cache to not cache it anyway, but that's the same for the current implementation). Putting an about file integral into Dillo, that's what I consider being monolithic. There is nothing wrong with a distributed design, but my problem with you pushing everything into dpi plugins is that most of those things can be done in seperate modules, meaning that they can be library plugins as wel. It becomes scary when a simple "hello" dpi plugin is 150 lines of code, while the whole ssl support to IO.c is about the same (and much less when there is one IOData/fd). Now you get much more code that all does more or less the same, you may have kept the Dillo core clean and mean, but you get a ridiculous complicated and big plugin system, moving most of the code and functionality outside of Dillo (but in the same time making it twice as big). Now it's very tempting to make a dpi library that implements most used functions, as someone already discovered. What's the next step? Moving all the useful code from Dillo to that library so that even more code is shared I guess (and let Dillo use that library too). What you get is a weird attempt to make something that more or less resembles library plugins, but in, if you ask me, a very awkward way. Of course there are plugins that behave more like daemons, like the bookmark plugin, but then make it a real daemon, so that it can be used by even other browsers. With a flexible and clear internal API most plugins can be done with relative small and simple library plugins, and a few can be implemented as real daemons. >> # Add ftp support. > It has. Using wget for something as basic as ftp in a plugin isn't something that I would call ftp support. Dillo is not a graphical front end for wget, thus I do not think Dillo has ftp support. Wget has. > (this is old problem of sharing a single resource among several clients). An old problem that is solved long ago. Just use inter process communication, like file locks (you can unlock you know). Only what you need to add is an extra fstat to see if the file is edited, and if so, reload the cookies. No big deal if you ask me. > Yes I agree with that reusing dillo's http may come handy. What your mistake is, in my humble opinion, is that you treat https like a seperate protocol, instead of http over another kind of connection. My view is that http is just http over ssl, and that ssl should be a sort of sub-module of IO (or a module that's only used by IO, like dns would be in my way). If you take a look at my patch, you'll see that the changes in http.c and IO.c are minimal, most of the code is at the bottom of IO.c, it could be easily a seperate file (again, only if there is one IOdata per fd, but then the ssl code will be 50 lines or so). Currently proxy support has more impact on http than https support, and you should treat them in a similar way if you ask me. You don't want a seperate plugin or module for proxy http, why do you want one for https? If you mean with monolithic that it's part of the core code, then yes, my way is monolithic, but it's only very little code, modular, and much less monolithic than an embedded splash page. > the details of handling the possible errors should be solved by the client application depending on the protocol and what it is being used for. > So having a generic SSL/TLS gateway may look interesting but it > can get tricky to implement. Not at all. The openssl api supports error callback functions, so the SSL/TLS support in IO can be minimal, if modules need more control they can use the callback functions. All that is needed is a general behaviour that is sufficient in 90% of the cases, and the current implementation does exactly that. Because modules have access to the SSL structure they can have all control they want, if needed. There are more or less 3 types of errors: 1: Connection related errors. (handshake_failure etc) Not much choice how to handle this, retry or abort (all connection related errors, including ssl related things like unsupported something). 2: Bad use of the API. (illegal_parameter) Should never happen with a good implementation. 3: Certificate related errors. (6 out of the 8 errors you listed) Most certificate related things can be done with openssl callback functions, so it's very seperate of the rest, making it easy to add or change later, or to handle it as module. Maybe there's something needed to give the module a chance to do it's certificate (startup) things and setting up the error handling, but not much. All in all IO doesn't have to worry much about all those SSL errors. > It puzzles me: changing the IO engine, Only what will chance is that it does more what it should do, handling IO. > integrating parts of the code that were separated on purpose, That was a misunderstanding, I wouldn't do that, sorry for not being clear enough. > changing the internal API, getting rid of the CCC The current CCC API is not clear or flexible, nor simple. Maybe a more consistent CCC API is possible, maybe no CCC functions at all, I don't know yet, but I'm not simply getting rid of the CCC. > and porting to FLTK, we'd be talking about another browser. Well, porting to FLTK, FLTK has similar aims as Dillo (small and fast), so maybe it was best if it was implemented with FLTK in the first place, but it's too late for that now. I would think twice before porting Dillo to FLTK (making sure that FLTK is alive and actively developed is one thing I would do), but GTK 2 is currently just scary, so FLTK as long term option isn't that bad. Getting libraries smaller is always hard, and GTK 2 is 12 mb now? I also saw the benchmarks, all in all not very encouraging. There is also an existing UTF8 Dillo patch, so maybe it's an option to stick with GTK 1 for a while. I didn't make Dillo, nor do I have much GUI programming experience, so I'm the last one you should listen to when it comes to what widget set to use. But from the networking side, FLTK has a perfect API, only a thin layer on top of select/poll, making it possible to easily add, remove and change the poll events on fds. GTK has an undocumented way of removing fds, can only hope it cleans the io channels up too and so on, but it still has no way to change the events on a fd. GTK has a lot bloat in it's io channel implementation (it's bloat when you don't need all it's features). I looked a bit in GTK's online API, and found the "perfect" replacement for io channels, a bunch of GDK functions that do almost exactly what Dillo needs: http://developer.gnome.org/doc/API/gdk/gdk-input.html It gives us almost the same API as FLTK does, but instead of being a thin layer, it's implemented with io channels, so the bloat is still there, but no way around that with GTK (not without very ugly complicated stuff). Also I think that the hairy bug isn't there, nor will we get another by GTK caused hairy bug if Dillo uses this GDK API, because it does what we want and need, without adding extra complexity like io channels (sure, the bug wasn't GTK's fault you can say, but if the API was clear and simpler, it wouldn't happen). Also FLTK uses internally the same select/poll as for our fds, X communicates through unix sockets, so whole FLTK blocks when nothing happens, while it seems that GTK polls 50 times/second for events or something like that. It's just that I prefer FLTK's way of doing some things. :) > Making a web site (or page for it) requires time, if you're > willing to do that, go ahead but beware that we do not support unofficial patches so you'd have to answer all the incoming questions too. Hmm, a web page, mind if I use the code of the splash screen as a basis? I only want to make an installer so that it's easy for people who, for instance, don't know what cvs is, to get a patched Dillo version. The goal is to have some sort of centralized patch place, with patches that work with eachother and are up to date. It requires time, true, but I'm willing to spend time on Dillo. The installer has no priority though, would rather spend my time to unite the IOData structures, switch to the GDK api, and clean up the https patch for now. All the things I want to have different in Dillo I'm willing to change myself. I'm not saying you should change this or that so or so, I ask if you mind if I change or add some things a certain way, and if you agree that it's better that way. Greetings, Indan (I wonder how many people wil read this 13K monster :)

15 38

mail adress
by Sebastian Geerken Nov. 18, 2003

Nov. 18, 2003

Hi! Please send private mail to me via <s.geerken(a)ping.de>. Do not use <sgeerken(a)student.physik.uni-dortmund.de>, the latter causes some problems. Sebastian

1 0

Re: [Dillo-dev] tabs, https, ...
by Indan Zupancic Nov. 17, 2003

Nov. 17, 2003

Hello, Thank you for your kind offer, but as it looks now it's just Frank and me who could use a CVS branch, and perhaps the Dillo developers are willing to make a CVS branch too, then you don't have to be bothered with mirroring the base Dillo and serving it. Having one or more CVS branches would be great, the question is if the Dillo developers are willing to cooperate and provide them, or that we should make use of your offer. Let's see what Frank has to say about it. Greetings, Indan

1 0

tabs, https, ...
by taj＠www.linux.org.uk Nov. 17, 2003

Nov. 17, 2003

I've been following the dillo mail list for a while getting a feel for what is up; Good things! With the external patches, I'd be willing to toss in a cvs server that mirrors the base dillo and has modified branches for various interests or even one merged branch. The intent would be to just keep a seperate single repository for external work which dillo could merge portions that fit it's philosophy. The offer would include www,cvs,ftp and shell access for developers that post their nontrivial patches to the official mail-list. -- Trent Jarvi taj(a)www.linux.org.uk

1 0

gushort for port instead of guint
by Indan Zupancic Nov. 16, 2003

Nov. 16, 2003

Hello, Just a tiny cleanup, ports are always shorts, so no need to make it an int. It also makes the structure SocketData 4 bytes smaller because of less padding. Greetings, Indan diff -purN orig/src/IO/http.c https/src/IO/http.c --- orig/src/IO/http.c 2003-11-11 22:15:39.000000000 +0100 +++ https/src/IO/http.c 2003-11-15 18:26:01.000000000 +0100 @@ -58,7 +58,7 @@ G_STMT_START { typedef struct { gint SockFD; const DilloUrl *Url; /* reference to original URL */ - guint port; /* need a separate port in order to support PROXY */ + gushort port; /* need a separate port in order to support PROXY */ gboolean use_proxy; /* indicates whether to use proxy or not */ DilloWeb *web; /* reference to client's web structure */ GSList *addr_list; /* Holds the DNS answer */

2 2

Cross Compiling for arm
by Donald McKnight Nov. 13, 2003

Nov. 13, 2003

Hello, I recently downloaded 0.7.3 to cross compile on the gmate yopy 3700. with my first attempt I noticed the configure script grabbed all of my local variables such as /usr/local/lib instead of /opt/arm-linux/lib. This gave me libgtk.so cannot read symbols. I went though the configure and manually set the environment variables and was able to successfully compile dillo, however when I transfer the binary to arm it does not launch it just hangs. I have cross-compiled several apps using the same cross-compiler on my system. I am using slackware 9.1 kernel 2.4.22, but I don't think the version should matter. Has anyone ran into this before? Thanks Donald McKnight

2 2