- Dillo-dev - lists.mailman3.com

[PATCH] Use contrasting color for widget selections
by a1ex＠dismail.de May 22, 2025

May 22, 2025

Hi, Here is a cleaned up version of my previous patch. I have been testing it quite a bit and for me it is working OK with both dark and light backgrounds. Just to recap the issue: Dillo currently hard-codes the color black to be used as the widget selection color (checkmarks, radio buttons, etc). When using a dark background, these selections appear to be invisible. With this patch, we ensure that the selction is visible by contrasing the selection color against the background. Any feedback welcome. Regards, Alex --- a/dw/fltkui.cc Sun Apr 27 18:56:44 2025 +++ b/dw/fltkui.cc Thu May 22 15:02:20 2025 @@ -1171,8 +1171,11 @@ void FltkToggleButtonResource::setWidgetStyle (Fl_W core::style::Style *style) { FltkResource::setWidgetStyle(widget, style); - - widget->selection_color(FL_BLACK); + FltkColor *bg = (FltkColor*)style->backgroundColor; + int normal_bg = bg->colors[FltkColor::SHADING_NORMAL]; + int style_fg = ((FltkColor*)style->color)->colors[FltkColor::SHADING_NORMAL]; + Fl_Color fg = fl_contrast(style_fg, normal_bg); + widget->selection_color(fg); }

1 0

Question regarding styling input checkbox element
by a1ex＠dismail.de May 21, 2025

May 21, 2025

Hi, When using a dark css theme (I like to use a black background), putting a checkmark in a checkbox is invisible (black). I tried messing around with style.css with various configurations for input, but it seems impossible to make the checkmark anything other than black. It's not a huge issue, but when editing bookmarks it becomes a little annoying. Any suggestions, or is this just a limitation of the css implementation? Thanks, Alex

3 4

[PATCH] Revert "Use right button to close tabs by default"
by Plasma (David Paul) May 1, 2025

May 1, 2025

This reverts commit 6392699316bbdfd027862fa28050cd54253f25d4. --- Notes: This change addresses two issues: 1. This restores the ability to close a tab by middle-clicking on it. This matches long-supported behaviour of other browsers. 2. Right-clicking a tab is now no longer a destructive action. It is common user expectation that right-clicking may produce a contextual menu. This expectation should not result in a lost tab. dillorc | 2 +- src/prefs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dillorc b/dillorc index dbe36f53..a3d22adc 100644 --- a/dillorc +++ b/dillorc @@ -424,7 +424,7 @@ ui_tab_bg_color=#b7beb7 # A mouse's middle click over a tab closes the Tab. # With mousewheel mouses, right click feels way better (set to YES). -#right_click_closes_tab=YES +#right_click_closes_tab=NO # Scroll over tabs (using the mouse wheel) to switch among tabs. # If set to NO, the page will be scrolled instead. diff --git a/src/prefs.c b/src/prefs.c index a57c792c..09b693a2 100644 --- a/src/prefs.c +++ b/src/prefs.c @@ -81,7 +81,7 @@ void a_Prefs_init(void) prefs.load_stylesheets=TRUE; prefs.middle_click_drags_page = TRUE; prefs.middle_click_opens_new_tab = TRUE; - prefs.right_click_closes_tab = TRUE; + prefs.right_click_closes_tab = FALSE; prefs.scroll_switches_tabs = TRUE; prefs.scroll_switches_tabs_reverse = FALSE; prefs.no_proxy = dStrdup(PREFS_NO_PROXY); -- Plasma

2 2

[PATCH v2] middle click on nav buttons to open in new tab
by a1ex＠dismail.de April 30, 2025

April 30, 2025

Hi, Here is an updated version of the patch which addresses most of Rodrigos comments. Not sure how much more I can improve on it, but open to suggestions. Regards, Alex diff -upr a/doc/user_help.in.html b/doc/user_help.in.html --- a/doc/user_help.in.html Sun Apr 27 18:56:44 2025 +++ b/doc/user_help.in.html Wed Apr 30 16:47:28 2025 @@ -349,6 +349,9 @@ pressed while left-clicking a link. The same applies t form. A new tab can also be opened from the <code>File</code> menu or using the shortcut <code>Ctrl+T</code>. +To open the previous page in a new tab, middle-click the back button. To open +the next page in a new tab, middle-click the forward button. + Press <code>Shift</code> while opening a page in a new tab to focus the tab. If you want this behaviour to be the default, set the following option in the <a href="#dillorc">dillorc</a> configuration file: diff -upr a/src/nav.c b/src/nav.c --- a/src/nav.c Sun Apr 27 18:56:44 2025 +++ b/src/nav.c Wed Apr 30 16:49:55 2025 @@ -447,6 +447,19 @@ void a_Nav_back(BrowserWindow *bw) } /* + * Send the browser back to previous page in new tab + */ +void a_Nav_back_nt(BrowserWindow *bw) +{ + int idx = a_Nav_stack_ptr(bw); + + if (--idx >= 0){ + a_UIcmd_set_msg(bw, ""); + a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw, idx)), -1); + } +} + +/* * Send the browser to next page in the history list */ void a_Nav_forw(BrowserWindow *bw) @@ -457,6 +470,19 @@ void a_Nav_forw(BrowserWindow *bw) if (++idx < a_Nav_stack_size(bw)) { a_UIcmd_set_msg(bw, ""); Nav_open_url(bw, a_History_get_url(NAV_UIDX(bw,idx)), NULL, +1); + } +} + +/* + * Send the browser to next page in the history list in new tab + */ +void a_Nav_forw_nt(BrowserWindow *bw) +{ + int idx = a_Nav_stack_ptr(bw); + + if (++idx < a_Nav_stack_size(bw)) { + a_UIcmd_set_msg(bw, ""); + a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw, idx)), +1); } } diff -upr a/src/nav.h b/src/nav.h --- a/src/nav.h Sun Apr 27 18:56:44 2025 +++ b/src/nav.h Wed Apr 30 16:49:55 2025 @@ -18,7 +18,9 @@ void a_Nav_push(BrowserWindow *bw, const DilloUrl *url const DilloUrl *requester); void a_Nav_repush(BrowserWindow *bw); void a_Nav_back(BrowserWindow *bw); +void a_Nav_back_nt(BrowserWindow *bw); void a_Nav_forw(BrowserWindow *bw); +void a_Nav_forw_nt(BrowserWindow *bw); void a_Nav_home(BrowserWindow *bw); void a_Nav_reload(BrowserWindow *bw); void a_Nav_jump(BrowserWindow *bw, int offset, int new_bw); diff -upr a/src/ui.cc b/src/ui.cc --- a/src/ui.cc Sun Apr 27 18:56:44 2025 +++ b/src/ui.cc Wed Apr 30 16:49:55 2025 @@ -312,6 +312,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) case UI_BACK: if (b == FL_LEFT_MOUSE) { a_UIcmd_back(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_back_nt(a_UIcmd_get_bw_by_widget(wid)); } else if (b == FL_RIGHT_MOUSE) { a_UIcmd_back_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), wid->y() + wid->h()); @@ -320,6 +322,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) case UI_FORW: if (b == FL_LEFT_MOUSE) { a_UIcmd_forw(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_forw_nt(a_UIcmd_get_bw_by_widget(wid)); } else if (b == FL_RIGHT_MOUSE) { a_UIcmd_forw_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), wid->y() + wid->h()); diff -upr a/src/uicmd.cc b/src/uicmd.cc --- a/src/uicmd.cc Sun Apr 27 18:56:44 2025 +++ b/src/uicmd.cc Wed Apr 30 16:49:55 2025 @@ -868,6 +868,14 @@ void a_UIcmd_back(void *vbw) } /* + * Send the browser back to previous page in a new tab + */ +void a_UIcmd_back_nt(void *vbw) +{ + a_Nav_back_nt((BrowserWindow*)vbw); +} + +/* * Popup the navigation menu of the Back button */ void a_UIcmd_back_popup(void *vbw, int x, int y) @@ -881,6 +889,14 @@ void a_UIcmd_back_popup(void *vbw, int x, int y) void a_UIcmd_forw(void *vbw) { a_Nav_forw((BrowserWindow*)vbw); +} + +/* + * Send the browser to next page in the history list in new tab + */ +void a_UIcmd_forw_nt(void *vbw) +{ + a_Nav_forw_nt((BrowserWindow*)vbw); } /* diff -upr a/src/uicmd.hh b/src/uicmd.hh --- a/src/uicmd.hh Sun Apr 27 18:56:44 2025 +++ b/src/uicmd.hh Wed Apr 30 16:49:55 2025 @@ -29,8 +29,10 @@ void a_UIcmd_open_url(BrowserWindow *bw, const DilloUr void a_UIcmd_open_url_nw(BrowserWindow *bw, const DilloUrl *url); void a_UIcmd_open_url_nt(void *vbw, const DilloUrl *url, int focus); void a_UIcmd_back(void *vbw); +void a_UIcmd_back_nt(void *vbw); void a_UIcmd_back_popup(void *vbw, int x, int y); void a_UIcmd_forw(void *vbw); +void a_UIcmd_forw_nt(void *vbw); void a_UIcmd_forw_popup(void *vbw, int x, int y); void a_UIcmd_home(void *vbw); void a_UIcmd_zoom_in(void *vbw); diff -upr a/doc/user_help.in.html b/doc/user_help.in.html --- a/doc/user_help.in.html Sun Apr 27 18:56:44 2025 +++ b/doc/user_help.in.html Wed Apr 30 16:47:28 2025 @@ -349,6 +349,9 @@ pressed while left-clicking a link. The same applies t form. A new tab can also be opened from the <code>File</code> menu or using the shortcut <code>Ctrl+T</code>. +To open the previous page in a new tab, middle-click the back button. To open +the next page in a new tab, middle-click the forward button. + Press <code>Shift</code> while opening a page in a new tab to focus the tab. If you want this behaviour to be the default, set the following option in the <a href="#dillorc">dillorc</a> configuration file: diff -upr a/src/nav.c b/src/nav.c --- a/src/nav.c Sun Apr 27 18:56:44 2025 +++ b/src/nav.c Wed Apr 30 16:49:55 2025 @@ -447,6 +447,19 @@ void a_Nav_back(BrowserWindow *bw) } /* + * Send the browser back to previous page in new tab + */ +void a_Nav_back_nt(BrowserWindow *bw) +{ + int idx = a_Nav_stack_ptr(bw); + + if (--idx >= 0){ + a_UIcmd_set_msg(bw, ""); + a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw, idx)), -1); + } +} + +/* * Send the browser to next page in the history list */ void a_Nav_forw(BrowserWindow *bw) @@ -457,6 +470,19 @@ void a_Nav_forw(BrowserWindow *bw) if (++idx < a_Nav_stack_size(bw)) { a_UIcmd_set_msg(bw, ""); Nav_open_url(bw, a_History_get_url(NAV_UIDX(bw,idx)), NULL, +1); + } +} + +/* + * Send the browser to next page in the history list in new tab + */ +void a_Nav_forw_nt(BrowserWindow *bw) +{ + int idx = a_Nav_stack_ptr(bw); + + if (++idx < a_Nav_stack_size(bw)) { + a_UIcmd_set_msg(bw, ""); + a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw, idx)), +1); } } diff -upr a/src/nav.h b/src/nav.h --- a/src/nav.h Sun Apr 27 18:56:44 2025 +++ b/src/nav.h Wed Apr 30 16:49:55 2025 @@ -18,7 +18,9 @@ void a_Nav_push(BrowserWindow *bw, const DilloUrl *url const DilloUrl *requester); void a_Nav_repush(BrowserWindow *bw); void a_Nav_back(BrowserWindow *bw); +void a_Nav_back_nt(BrowserWindow *bw); void a_Nav_forw(BrowserWindow *bw); +void a_Nav_forw_nt(BrowserWindow *bw); void a_Nav_home(BrowserWindow *bw); void a_Nav_reload(BrowserWindow *bw); void a_Nav_jump(BrowserWindow *bw, int offset, int new_bw); diff -upr a/src/ui.cc b/src/ui.cc --- a/src/ui.cc Sun Apr 27 18:56:44 2025 +++ b/src/ui.cc Wed Apr 30 16:49:55 2025 @@ -312,6 +312,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) case UI_BACK: if (b == FL_LEFT_MOUSE) { a_UIcmd_back(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_back_nt(a_UIcmd_get_bw_by_widget(wid)); } else if (b == FL_RIGHT_MOUSE) { a_UIcmd_back_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), wid->y() + wid->h()); @@ -320,6 +322,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) case UI_FORW: if (b == FL_LEFT_MOUSE) { a_UIcmd_forw(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_forw_nt(a_UIcmd_get_bw_by_widget(wid)); } else if (b == FL_RIGHT_MOUSE) { a_UIcmd_forw_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), wid->y() + wid->h()); diff -upr a/src/uicmd.cc b/src/uicmd.cc --- a/src/uicmd.cc Sun Apr 27 18:56:44 2025 +++ b/src/uicmd.cc Wed Apr 30 16:49:55 2025 @@ -868,6 +868,14 @@ void a_UIcmd_back(void *vbw) } /* + * Send the browser back to previous page in a new tab + */ +void a_UIcmd_back_nt(void *vbw) +{ + a_Nav_back_nt((BrowserWindow*)vbw); +} + +/* * Popup the navigation menu of the Back button */ void a_UIcmd_back_popup(void *vbw, int x, int y) @@ -881,6 +889,14 @@ void a_UIcmd_back_popup(void *vbw, int x, int y) void a_UIcmd_forw(void *vbw) { a_Nav_forw((BrowserWindow*)vbw); +} + +/* + * Send the browser to next page in the history list in new tab + */ +void a_UIcmd_forw_nt(void *vbw) +{ + a_Nav_forw_nt((BrowserWindow*)vbw); } /* diff -upr a/src/uicmd.hh b/src/uicmd.hh --- a/src/uicmd.hh Sun Apr 27 18:56:44 2025 +++ b/src/uicmd.hh Wed Apr 30 16:49:55 2025 @@ -29,8 +29,10 @@ void a_UIcmd_open_url(BrowserWindow *bw, const DilloUr void a_UIcmd_open_url_nw(BrowserWindow *bw, const DilloUrl *url); void a_UIcmd_open_url_nt(void *vbw, const DilloUrl *url, int focus); void a_UIcmd_back(void *vbw); +void a_UIcmd_back_nt(void *vbw); void a_UIcmd_back_popup(void *vbw, int x, int y); void a_UIcmd_forw(void *vbw); +void a_UIcmd_forw_nt(void *vbw); void a_UIcmd_forw_popup(void *vbw, int x, int y); void a_UIcmd_home(void *vbw); void a_UIcmd_zoom_in(void *vbw);

2 2

[PATCH] Middle-click on back button to open prev. page in new tab
by a1ex＠dismail.de April 28, 2025

April 28, 2025

Hi list, Hope you are all doing well! I have a small feature idea: Sometimes I want to go back to the previous page, but also keep the current page open. Obviously I can go back and then open the last page in a new tab, but that can be annoying having to find and click on the link again. One solution is to make middle-clicking on the back button open the previous page in a new tab. Attached is a working proof-of-concept patch. Any feedback would be welcome! Regards, Alex diff -upr a/src/nav.c b/src/nav.c --- a/src/nav.c Mon Apr 21 21:42:32 2025 +++ b/src/nav.c Sun Apr 27 10:11:36 2025 @@ -447,6 +447,20 @@ void a_Nav_back(BrowserWindow *bw) } /* + * Send the browser back to previous page in new tab + */ +void a_Nav_back_nt(BrowserWindow *bw) +{ + int idx = a_Nav_stack_ptr(bw); + + a_Nav_cancel_expect(bw); + if (--idx >= 0){ + a_UIcmd_set_msg(bw, ""); + a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw,idx)), -1); + } +} + +/* * Send the browser to next page in the history list */ void a_Nav_forw(BrowserWindow *bw) diff -upr a/src/nav.h b/src/nav.h --- a/src/nav.h Mon Apr 21 21:42:32 2025 +++ b/src/nav.h Sun Apr 27 10:12:00 2025 @@ -18,6 +18,7 @@ void a_Nav_push(BrowserWindow *bw, const DilloUrl *url const DilloUrl *requester); void a_Nav_repush(BrowserWindow *bw); void a_Nav_back(BrowserWindow *bw); +void a_Nav_back_nt(BrowserWindow *bw); void a_Nav_forw(BrowserWindow *bw); void a_Nav_home(BrowserWindow *bw); void a_Nav_reload(BrowserWindow *bw); diff -upr a/src/ui.cc b/src/ui.cc --- a/src/ui.cc Mon Apr 21 21:42:32 2025 +++ b/src/ui.cc Sun Apr 27 10:13:45 2025 @@ -312,6 +312,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) case UI_BACK: if (b == FL_LEFT_MOUSE) { a_UIcmd_back(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_back_nt(a_UIcmd_get_bw_by_widget(wid)); } else if (b == FL_RIGHT_MOUSE) { a_UIcmd_back_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), wid->y() + wid->h()); diff -upr a/src/uicmd.cc b/src/uicmd.cc --- a/src/uicmd.cc Mon Apr 21 21:42:32 2025 +++ b/src/uicmd.cc Sun Apr 27 10:12:30 2025 @@ -868,6 +868,14 @@ void a_UIcmd_back(void *vbw) } /* + * Send the browser back to previous page in a new tab + */ +void a_UIcmd_back_nt(void *vbw) +{ + a_Nav_back_nt((BrowserWindow*)vbw); +} + +/* * Popup the navigation menu of the Back button */ void a_UIcmd_back_popup(void *vbw, int x, int y) diff -upr a/src/uicmd.hh b/src/uicmd.hh --- a/src/uicmd.hh Mon Apr 21 21:42:32 2025 +++ b/src/uicmd.hh Sun Apr 27 10:12:51 2025 @@ -29,6 +29,7 @@ void a_UIcmd_open_url(BrowserWindow *bw, const DilloUr void a_UIcmd_open_url_nw(BrowserWindow *bw, const DilloUrl *url); void a_UIcmd_open_url_nt(void *vbw, const DilloUrl *url, int focus); void a_UIcmd_back(void *vbw); +void a_UIcmd_back_nt(void *vbw); void a_UIcmd_back_popup(void *vbw, int x, int y); void a_UIcmd_forw(void *vbw); void a_UIcmd_forw_popup(void *vbw, int x, int y);

2 3

Image Redirects on the Wayback Machine
by Kevin Koster March 25, 2025

March 25, 2025

I keep needing to open pages at the Wayback Machine in Links (graphical mode) because Dillo won't load images there. I know this is because a while ago they started using redirects on the image links in their archived pages, and the old Dillo FAQ says: "If Dillo requests an image and receives a response containing a redirection (i.e., pointing to a different URL), the redirection is not followed. These have a strong tendency to be advertisements." https://dillo-browser.github.io/old/FAQ.html#q28 However it's a real pain since most of the good stuff on the Web seems to have gone offline. ~/.dillo/domainrc was added to solve similar problems with over-active blocking of images at different domains (next part of that FAQ answer). Could some sort of allow rule for image redirects be added in that too? Or is there an existing work-around for the Wayback Machine images that I haven't figured out? Example: The image link at the top of this archived webpage: http://web.archive.org/web/20001009182503/http://www.abc.net.au/defaultlo.h… http://web.archive.org/web/20001009182503im_/http://www.abc.net.au/img/abcb… Redirects to: http://web.archive.org/web/20000822094140im_/http://www.abc.net.au/img/abcb… which isn't loaded unless opened on its own via the right-click menu in Dillo.

2 3

Re: FOSDEM 2025 video
by Rodrigo Arias Feb. 9, 2025

Feb. 9, 2025

On Sun, Feb 09, 2025 at 01:07:32PM +0200, Schimon Jehudah wrote: >Congratulations! > >That was an interesting idea to present the slideshows via Dillo. > >What key bindings did you use to navigate? I used a custom patch to navigate to the next fragment (div). Still needs some polishing before I can merge it. Rodrigo.

1 0

FOSDEM 2025 video
by Rodrigo Arias Feb. 9, 2025

Feb. 9, 2025

Hi, I published a custom edit of the FOSDEM 2025 Dillo talk with the colors corrected and a black frame here: https://www.youtube.com/watch?v=sFJp8JDg8Yg It is also on the archive: https://archive.org/details/dillo-fosdem-2025 The official video was just published now: https://fosdem.org/2025/schedule/event/fosdem-2025-4100-resurrecting-the-mi… Best, Rodrigo.

1 0

Typos Dillo
by Gevel Tekens Feb. 5, 2025

Feb. 5, 2025

I do not have a github account, so I am sending a patch as well as the statements that enabled the patch. They have all been hand-checked. This is what I hope is a low-effort improvement and ahead of the FOSDEM 2025 presentation. Best regards GT

3 4

Dillo 3.2.0 released
by Rodrigo Arias Jan. 21, 2025

Jan. 21, 2025

Hi, The 3.2.0 version is finally released. Check the release notes here: https://dillo-browser.github.io/release/3.2.0/ Best, Rodrigo.

2 1