Segfault when loading web site
Good day, Dillo crashes when i open https://www.masterbrandcabinets.com/ $ dillo --version Dillo v3.3.0 Libraries: fltk/1.3.8 jpeg/2.1.2 png/1.6.58 webp/1.3.2 zlib/1.2.13 brotli/1.0.9 OpenSSL/1.1.1zh Features: +GIF +JPEG +PNG +SVG +WEBP +BROTLI +XEMBED +TLS +IPV6 +CTL $ dillo https://www.masterbrandcabinets.com/ ... NumPendingStyleSheets=8 NumPendingStyleSheets=9 NumPendingStyleSheets=10 Segmentation fault Best regards, -Ben
Hi, Ben Collver <bencollver@riseup.net> wrote:
Dillo crashes when i open https://www.masterbrandcabinets.com/
Here is the part in that page which seems to be the problem: 208: <input type="button" id="MB_search-submit" aria-label="Search"> I can replicate the crash with simply this: <input type="button"> It appears that Dillo is unable to cope with the fact that this site isn't providing a value attribute for the button input type. Other browsers handle this by an showing empty label on the button when missing the value attribute. Regards, Alex
Hi, Ben Collver <bencollver@riseup.net> wrote:
Dillo crashes when i open https://www.masterbrandcabinets.com/
Here is a lightly tested patch which seems to fix it: src/form.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/form.cc b/src/form.cc index e2f0c1c2..929f63b5 100644 --- a/src/form.cc +++ b/src/form.cc @@ -537,6 +537,9 @@ void Html_tag_open_input(DilloHtml *html, const char *tag, int tagsize) } } else if (!dStrAsciiCasecmp(type, "button")) { inp_type = DILLO_HTML_INPUT_BUTTON; + if (!value) { + value = dStrdup(""); + } if (value) { init_str = value; resource = factory->createLabelButtonResource(init_str); Regards, Alex
On Tue, Sep 22, 2026 at 09:25:57PM +0000, a1ex@dismail.de wrote:
Dillo crashes when i open https://www.masterbrandcabinets.com/
Here is a lightly tested patch which seems to fix it:
src/form.cc | 3 +++ 1 file changed, 3 insertions(+)
Thanks! I verified that this fixes the crash on my end.
participants (2)
-
a1ex＠dismail.de -
Ben Collver