- Dillo-dev - lists.mailman3.com

(no subject)
by bogus＠does.not.exist.com May 27, 2009

May 27, 2009

From: Jorge Arellano Cid <jcid(a)dillo.org> To: Dillo mailing list <dillo-dev(a)dillo.org> Cc: Bcc: Subject: Re: [Dillo-dev] patch: a binding for stop Reply-To: In-Reply-To: <20090527142256.GH6001(a)local.gobigwest.com> On Wed, May 27, 2009 at 02:22:57PM +0000, corvid wrote: > > Wondering whether we can come to a decision on this one.. I don't like much Esc for stop, but if that's FFs default, it may be better than another (as the Ctrl-x clash you spot). Afterall this is what configurable keybindings is suppossed to solve so Esc is OK for me as default. > > Jeremy wrote: > > On Wed, May 06, 2009 at 11:32:31AM -0400, Jorge Arellano Cid wrote: > > > > > > The other one I can think of as mnemonic is <ctrl>x. What do > > > people think? > > > > That clashes with "Cut". Select some text in the URL window and > > <ctrl>+x will delete it. I think it's not a good idea to grab > > something that (a) already has a conventional action, and (b) already > > performs that conventional action in the GUI. > > > > And while we're talking about conventional use: Dillo is highly > > unconventional when it uses <ctrl>+q to close a tab. Everyone else[1] > > uses <ctrl>+w to close a tab (<ctrl>+<shift>+q to close a window) and > > <ctrl>+q to quit. Which can be annoying when switching between the > > two. > > > > Firefox uses Escape to stop, and arora[2] uses <ctrl>+. . > > > > Regards, > > > > Jeremy Henty > > > > [1] ie. Firefox :-) > > [2] http://code.google.com/p/arora/ - WebKit+Qt-based browser. It > > looks very nice and may supplant Firefox as "the browser to fall back > > to when Dillo can't handle the page". > > -- Cheers Jorge.-

1 0

include guard naming
by corvid＠lavabit.com May 27, 2009

May 27, 2009

I was just going through and changing the include guards that don't follow the dillo convention, and then I glanced at http://en.wikipedia.org/wiki/Include_guard and it reminds me that the C++ standard prohibits '_'s at the beginning. Does anyone care enough to have an opinion? If we want to rm the leading or surrounding underscores, I might as well do that too before committing. [pop/smtp isn't working at the moment, so I'm sending this through webmail. Let's hope they doesn't mangle line wrapping or anything.]

3 4

[patch]: [doc]: escape some hash in the text
by onepoint＠starurchin.org May 27, 2009

May 27, 2009

When you're sick of bugs, clean up the docs! This escapes some '#' characters so that "#define" and "#include" appear properly in the text. It also silences some Doxygen warnings (it was trying to interpret those words as links). Regards, Jeremy Henty

2 1

Spotted a tiny dillo bug with tabs
by freya128＠yahoo.com May 24, 2009

May 24, 2009

Tiny bug: When dillo changes tabs it doesn't update the main window header thing. Also the same if you close a tab. This can lead to weird effects such as the top header thing having info about a webpage that you don't have open at all. Hope that helps! :) love Freya

2 1

[bug]: uint32_t not declared
by onepoint＠starurchin.org May 24, 2009

May 24, 2009

The latest tip fails to build for me. I don't have uint32_t. Which header should include it? I'm using gcc 4.1.2. Regards, Jeremy Henty

3 5

Latest on invalid image callback references
by onepoint＠starurchin.org May 23, 2009

May 23, 2009

The valgrind logs are still showing invalid memory accesses that happen when image callbacks refer to DilloImages that have been freed by a_Web_free(). This is after the imgref patch was applied, since when I've been running an essentially unpatched Dillo. My image tracing still shows that the image pipeline sometimes continues to run after a_Web_free() frees the image it is attached to. As far as I can tell there has been no recent change in the behaviour of this problem. I have just applied a patch I was considering earlier that makes a_Cache_stop_client() close the client. I've attached it for comments, but I won't suggest applying it until we can see whether it's made any difference. That will take a few days, as I still haven't found a reliable way to reproduce the bug so I will just have to wait a few days and see if it stops appearing in the logs. Please comment on whether this patch is the right way to fix this. Regards, Jeremy Henty PS. You'll probably notice fewer valgrind reports in my log pages in future because I just returned to full-time work so I won't be surfing from home nearly as much.

2 2

[rutkowski.adrian1@gmail.com: Re: [Dillo-dev] Dillo failed to compile with GCC 4.4.0]
by jcid＠dillo.org May 23, 2009

May 23, 2009

On Fri, May 22, 2009 at 06:51:16PM +0000, corvid wrote: > No need. Adrian went through a few rounds of sending me the error > msgs, I committed some consts, and then he reported: > > > Success! :) > > Now it compiles and runs whitout glitches. Excellent! -- Cheers Jorge.-

1 0

Dillo failed to compile with GCC 4.4.0
by rutkowski.adrian1＠gmail.com May 22, 2009

May 22, 2009

Hi, I'm trying to compile latest dillo hg snapshot with GCC 4.4.0 and got this error: g++ -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include -g -O2 -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT tablecell.o -MD -MP -MF .deps/tablecell.Tpo -c -o tablecell.o tablecell.cc tablecell.cc: In member function ?virtual void dw::TableCell::wordWrap(int)?: tablecell.cc:55: error: invalid conversion from ?const char*? to ?char*? make[2]: *** [tablecell.o] B??d 1 make[2]: Opuszczenie katalogu `/home/adrian/src/dillo/dw' make[1]: *** [all-recursive] B??d 1 make[1]: Opuszczenie katalogu `/home/adrian/src/dillo' make: *** [all] B??d 2 System is Arch Linux with latest gcc package (gcc-4.4.0-2). Adrian Rutkowski

4 4

Dillo failed to compile with GCC 4.4.0
by rutkowski.adrian1＠gmail.com May 22, 2009

May 22, 2009

On Fri, May 22, 2009 at 05:34:20PM +0000, corvid wrote: > Does this compile cleanly for you: > > diff -r 717e6ced084f src/uicmd.cc > --- a/src/uicmd.cc Fri May 22 17:16:18 2009 +0000 > +++ b/src/uicmd.cc Fri May 22 17:32:05 2009 +0000 > @@ -694,8 +694,8 @@ static char *UIcmd_make_save_filename(co > static char *UIcmd_make_save_filename(const char *pathstr) > { > size_t MaxLen = 64; > - char *FileName, *name, *newname, *o, *n; > - const char *dir = a_UIcmd_get_save_dir(); > + char *FileName, *newname, *o, *n; > + const char *name, *dir = a_UIcmd_get_save_dir(); > > if ((name = strrchr(pathstr, '/'))) { > if (strlen(++name) > MaxLen) { Yes that fixed it, now it stops here: g++ -DHAVE_CONFIG_H -I. -I.. -DDILLORC_SYS='"/usr/local/etc/dillorc"' -I/usr/local/include -I.. -I/usr/include/libpng12 -I/usr/local/include -Wno-non-virtual-dtor -g -O2 -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT html.o -MD -MP -MF .deps/html.Tpo -c -o html.o html.cc html.cc: In function ?void Html_tag_open_meta(DilloHtml*, const char*, int)?: html.cc:2812: error: invalid conversion from ?const char*? to ?char*? make[1]: *** [html.o] B??d 1 make[1]: Opuszczenie katalogu `/home/adrian/src/dillo/src' make: *** [all-recursive] B??d 1

1 0

image inputs, height and width attrs
by corvid＠lavabit.com May 19, 2009

May 19, 2009

I noticed that images in image inputs weren't scaling, but then I saw in the spec that INPUT isn't supposed to have height and width attrs anyway, so I don't know whether we should do anything about it.

2 2