- Dillo-dev - lists.mailman3.com

Re: patch: not-a-png message
by jcid＠dillo.org Feb. 29, 2008

Feb. 29, 2008

On Fri, Feb 29, 2008 at 04:42:05PM +0000, place wrote: > Just noticed this in my tree while making multipart diffs. I'd forgotten > about it... Committed. -- Cheers Jorge.-

1 0

[patch] add ctrl-f shortcut for findText
by Johannes.Hofmann＠gmx.de Feb. 29, 2008

Feb. 29, 2008

Hi, patch below adds ctrl-f shortcut for findText. BTW, shouldn't ctrl-b open the bookmarks page as it did in dillo1? Cheers, Johannes diff -r 44838cc1f38d src/ui.cc --- a/src/ui.cc Sun Feb 24 23:15:53 2008 +0100 +++ b/src/ui.cc Thu Feb 28 22:43:22 2008 +0100 @@ -702,7 +702,10 @@ int UI::handle(int event) // Handle these shortcuts here. if (event == SHORTCUT) { if (event_state(CTRL)) { - if (k == 'l') { + if (k == 'f') { + a_UIcmd_findtext_dialog((BrowserWindow*) user_data ()); + ret = 1; + } else if (k == 'l') { a_UIcmd_open_url_dialog(user_data()); ret = 1; } else if (k == 'n') {

2 1

[patch] use CURSOR_MOVE when drag scrolling
by Johannes.Hofmann＠gmx.de Feb. 28, 2008

Feb. 28, 2008

Hi, the patch below disallows drag scrolling over links where the middle mouse button is used to open the link in a new window. It also changes the cursor to CURSOR_MOVE when drag scrolling. Cheers, Johannes diff --git a/dw/fltkviewport.cc b/dw/fltkviewport.cc --- a/dw/fltkviewport.cc +++ b/dw/fltkviewport.cc @@ -233,11 +233,13 @@ int FltkViewport::handle (int event) case ::fltk::PUSH: take_focus(); if (::fltk::event_button() == ::fltk::MiddleButton) { - dragScrolling = 1; - dragX = ::fltk::event_x(); - dragY = ::fltk::event_y(); /* pass event so that middle click can open link in new window */ - FltkWidgetView::handle (event); + if (FltkWidgetView::handle (event) == 0) { + dragScrolling = 1; + dragX = ::fltk::event_x(); + dragY = ::fltk::event_y(); + setCursor (core::style::CURSOR_MOVE); + } return 1; } break; @@ -260,6 +262,7 @@ int FltkViewport::handle (int event) case ::fltk::RELEASE: if (::fltk::event_button() == ::fltk::MiddleButton) { dragScrolling = 0; + setCursor (core::style::CURSOR_DEFAULT); } break;

1 0

PATCH: small improvement to the "can't start dpid daemon" error message
by onepoint＠starurchin.org Feb. 24, 2008

Feb. 24, 2008

A common cause of the "can't start dpid daemon" error is clicking on a link with a typo'ed HREF that has an invalid URL scheme (eg. 'ttp://' instead of 'http://', to cite the real-life example that prompted this patch). But the error message gives *no* context that would help to diagnose the problem. If it cited the URL scheme it would save a lot of time. (I had to start Firefox before I realised what the problem was!) Here's a patch to do that. Jeremy Henty

2 1

[patch] fix redraw problem with findText
by Johannes.Hofmann＠gmx.de Feb. 24, 2008

Feb. 24, 2008

Hello, the patch below fixes the redraw problem with findText found by place that was introduced with my textblock optimization. Partial redraws were interfering with scrolling. The findText method is a nice test for this code path! I'm now experimenting with a redraw optimization that covers table based pages too. It's looking promising, but it needs some more work. Cheers, Johannes diff --git a/dw/fltkviewbase.cc b/dw/fltkviewbase.cc --- a/dw/fltkviewbase.cc +++ b/dw/fltkviewbase.cc @@ -85,6 +85,7 @@ void FltkViewBase::draw () } } + drawRegion.clear (); d &= ~DAMAGE_VALUE; } @@ -110,9 +111,12 @@ void FltkViewBase::draw () area.width = rect.w(); area.height = rect.h(); theLayout->expose (this, &area); + + if (! (d & DAMAGE_SCROLL)) { + drawRegion.clear (); + } } - drawRegion.clear (); } void FltkViewBase::drawChildWidgets () { diff --git a/dw/fltkviewport.cc b/dw/fltkviewport.cc --- a/dw/fltkviewport.cc +++ b/dw/fltkviewport.cc @@ -185,6 +185,7 @@ void FltkViewport::draw () int d = damage(); if (d & DAMAGE_SCROLL) { + set_damage (DAMAGE_SCROLL); scrollrect(cr, -scrollDX, -scrollDY, draw_area, this); d &= ~DAMAGE_SCROLL; set_damage (d);

2 1

[patch] optimize redraw after resize for textblocks
by Johannes.Hofmann＠gmx.de Feb. 21, 2008

Feb. 21, 2008

Hello, here comes my attempt to avoid unnecessary redraws caused by images that are not visible. The first patch makes some minor optimizations to the drawing code and disables the use of the asap parameter for better testing. The second patch replaces the general queueDrawTotal() in Layout::resizeIdle () with more specific redraw calls in widgets that can be topLevel. Currently only Textblock is optimized. The idea is that resizing child widgets in a textblock don't affect the layout of the textblock above the resizing widget. So only the area below needs to be redrawn. I think that does not hold for tables, but perhaps other optimizations are possible here? Ideas anyone? The effect is visible e.g. on http://chlamydia.fs.ei.tum.de/pub/DragonFly/packages/stable/DragonFly-1.10.… but not on table based pages. Cheers, Johannes

2 1

[patch] optimize redraw after resize for textblocks
by Johannes.Hofmann＠gmx.de Feb. 21, 2008

Feb. 21, 2008

Hi, On Thu, Feb 21, 2008 at 04:57:29AM +0000, place wrote: > Hi Johannes, > > I finally got around to applying this today... > Are you seeing any problems with text highlighting? > > If I repeat searches so that the page scrolls some -- but not far enough > for the previous instance to scroll off screen -- the previous instance > stays highlighted and the current instance isn't highlighted. > > It's entirely possible that I screwed something up, but when I > diffed my trees, I didn't notice anything wrong... No, I'm seeing this too now. I will try to fix it. Thanks for testing, Johannes

1 0

Dillo screenshot on my ipaq
by akemnade＠tzi.de Feb. 18, 2008

Feb. 18, 2008

Hi, I have finally taken the time to make dillo run on my ipaq. Screenshot: http://www.tzi.de/~akemnade/dillo-ipaq.png The big pitfall here is if you don't enable Xft/freetype in your fltk build, you can screw up things. fltk does not get the default fonts from the xserver on the ipaq, so due to missing error checking in fltk, dillo crashes when the first label gets rendered. But I guess, without freetype you won't get nice fonts anyway... dillo/dw does not need to be patched for that. fltk needs a bit of tweaking, I'll look if it is solved in the current version (I'm still using that r5917 snapshot). Greetings Andreas Kemnade

3 3

New table layout rocks!
by onepoint＠starurchin.org Feb. 14, 2008

Feb. 14, 2008

I've been collecting web pages that Dillo misrendered: truncated images, overlapping text, pages clipped at the right, etc. I'm really pleased to announce that the latest Dillo handles them all. This is a major improvement! I'm assuming this is the new table layout code at work. Regards, Jeremy Henty

5 31

[patch] fix HomeKey/EndKey behaviour
by Johannes.Hofmann＠gmx.de Feb. 7, 2008

Feb. 7, 2008

Hi the patch below makes HomeKey and EndKey work as it did in dillo1. I think I had introduced the current behaviour that also adjusts the x-position but it is pretty annoying on wide pages. Cheers, Johannes diff -r 1c41f9a73971 dw/fltkviewport.cc --- a/dw/fltkviewport.cc Sun Feb 03 21:13:11 2008 +0100 +++ b/dw/fltkviewport.cc Wed Feb 06 18:16:41 2008 +0100 @@ -292,11 +292,11 @@ int FltkViewport::handle (int event) return 1; case HomeKey: - scrollTo (0, 0); + scrollTo (scrollX, 0); return 1; case EndKey: - scrollTo (canvasWidth, canvasHeight); /* gets adjusted in scroll() */ + scrollTo (scrollX, canvasHeight); /* gets adjusted in scroll() */ return 1; } }

2 1