- Dillo-dev - lists.mailman3.com

Q: why does Nav_stack_clean() free the data and Nav_stack_truncate() not?
by onepoint＠starurchin.org May 25, 2008

May 25, 2008

While reviewing nav.c to figure out the reload crash bug I noticed something that seems inconsistent: both Nav_stack_truncate() and Nav_stack_clean() remove items from the navigation stack, yet Nav_stack_truncate() does not free the data it removes and Nav_stack_clean() does. Is this a bug? If not, what haven't I understood? Regards, Jeremy Henty

2 3

Profiling works!
by onepoint＠starurchin.org May 24, 2008

May 24, 2008

I added -pg to LDFLAGS, CFLAGS and CXXFLAGS and dillo generated a nice gmon.prof ! However, it puts it in /tmp (perhaps that's why it didn't seem to be working). Dillo also dumps its core to /tmp when it crashes, perhaps for the same reason? Regards, Jeremy Henty

2 2

patch: trim Local_Buf
by corvid＠lavabit.com May 24, 2008

May 24, 2008

3 2

Uncluttering dillo, part II: the findbar
by 4winter＠informatik.uni-hamburg.de May 24, 2008

May 24, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar. There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints. Jorge, could you update your coding conventions with respect to c++ specific language features? Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0pmoPmwNWhsaZYRAi1VAJwO/e+JWmCoMsjOF/hYuF4X1DUOWwCePB96 +X++Veu0Gyv854m0TxSwI7Q= =rc5Z -----END PGP SIGNATURE-----

4 9

memory statistics
by Johannes.Hofmann＠gmx.de May 23, 2008

May 23, 2008

Hi, to see which part of dillo consumes which amount of memory, I hacked together a version of dlib.c that counts memory that was allocated via dMalloc(). A malloc_tag allows to assign the mallocs to specific parts in the code. In the patch below I use malloc_tag = 1 for cache stuff, malloc_tag = 2 for text strings that are passed dw2 and malloc_tag = 0 for everything else. It's fun to see how memory get's allocated and free'd while loading. Here is the output once the huge mysql manual page is loaded: ====> malloc size 5185114 26967623 6602392 0 So that's 6M for text strings, 26M cache and 5M other. Of course there is also all the dw2 stuff that is not taken into account here. BTW, textblock delete's the text strings that are allocated using malloc(). That's not allowed and might cause unexpected behaviour on some platforms. Cheers, Johannes

3 10

patch: free parse data
by corvid＠lavabit.com May 23, 2008

May 23, 2008

Johannes had suggested freeing Local_Buf when parsing was completed...

2 1

RFC: human interface guidelines
by 4winter＠informatik.uni-hamburg.de May 21, 2008

May 21, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) I was thinking about improving the dillo experience by adding some functionality / shortcuts people have come to expect. But what people expect is influenced by their background, their choice of desktop environment and platform. We could pick one / some user interface guideline(s) ([1] lists some) and try to adhere to it / them. Or we could pick one popular browser and copy its 'feel'. Attached are two patches mapping 'reload' to F5 and 'help' to F1. Let me know what you think of them and the whole interface thing. Justus 1: http://en.wikipedia.org/wiki/Human_Interface_Guidelines - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0jvoPmwNWhsaZYRAveJAJ9ROk+E0VWLzK6G99qcTlpNjeB5igCeJ7r9 Grz4wtWQ+BIEbWrIY8PDCFg= =JnX2 -----END PGP SIGNATURE-----

2 1

[patch] minor memory reduction
by Johannes.Hofmann＠gmx.de May 21, 2008

May 21, 2008

Hi, attached is a small patch to improve memory usage. It creates a single word for a sequence of spaces in PRE mode instead of one word per character. The second part is just a minor simplification. Cheers, Johannes

2 4

Uncluttering dillos UI - getting rid of the dialog boxes
by 4winter＠informatik.uni-hamburg.de May 21, 2008

May 21, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) somewhere deep inside the "Future of Dillo" monster thread I suggested to get rid of the location dialog box but Johannes pointed out that this breaks the fullscreen mode. So, here is my proposed solution: * on ctrl-l: focus location bar * if in fullscreen mode: temporarily show toolbars until the user pressed enter I am not familiar with the fltk event model, so I just hijacked the existing event handler which works reasonably well. It would be nice to also capture any "on-blur" events, but I could use some hints (the fltk2 documentation only mentions 6 WHEN_* events, though some googling suggests that there might be UNFOCUS events... uh?). Anyway, the patch is attached. let me know what you think. Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILd5xoPmwNWhsaZYRApqEAJ9glSSkR3Q9oU0BmmUf9/ErG/ItfwCfVs5M asgEwaQAMk4ggsfzO2toTc0= =MHCi -----END PGP SIGNATURE-----

3 10

Keyboard shortcuts & fullscreen button
by 4winter＠informatik.uni-hamburg.de May 21, 2008

May 21, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The UI constructor creates a button for the fullscreen mode, but it is not added to anything: // Make the full screen button (to be attached to the viewport later) // TODO: attach to the viewport FullScreen = new HighlightButton(0,0,15,15); [...] Any idea why this was postponed? Should it be enabled now? Also I noticed, that the way events are handled is somewhat lax with respect to modifier keys. The code just checks if ctrl is pressed, not if ctrl but none of the other modifiers are pressed. This makes ctrl-l equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is this a bug or a feature? Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILwMvoPmwNWhsaZYRAmHYAJ49XUO6F6mBTG+CbWAzfN5yknkrKgCfQOjB QzlODEtqUdlztUo6tHuluUE= =hCHy -----END PGP SIGNATURE-----

2 3