- Dillo-dev - lists.mailman3.com

Hooked a decoder for text/plain with charset.
by jcid＠dillo.org June 1, 2008

June 1, 2008

Hi, Just committed this patch. It makes things like: http://separat-lib.narod.ru/master.txt work. -- Cheers Jorge.-

2 8

[patch]: html.cc: DilloHtmlInput::connectTo()
by onepoint＠starurchin.org May 30, 2008

May 30, 2008

This implements DilloHtmlInput::connectTo() which is called by DilloHtmlForm::addInput and connects the input to the form. This is another API milestone: now only DilloHtmlForm methods access DilloHtmlForm::form_receiver . We are nearly done with the DilloHtmlForm API, there only a few locations left that directly access DilloHtmlForm data members. Regards,

2 2

[patch]: html.cc: remove DilloHtmlInput::widget
by onepoint＠starurchin.org May 30, 2008

May 30, 2008

It turns out that the embed and widget members of the DilloHtmlInput class are always the same, so we can remove widget. Patch attached. Regards, Jeremy Henty

2 1

[patch]: html.cc: DilloHtmlForm::getRadioInput()
by onepoint＠starurchin.org May 30, 2008

May 30, 2008

This refactors code that looks for a radio input with a given name into a new method DilloHtmlForm::getRadioInput() . This marks a DilloHtmlForm API milestone: now only DilloHtmlForm member functions access the inputs data member. Everything else that needs to get an input from a form goes through the API. Regards, Jeremy Henty

2 1

[patch]: html.cc: remove MSG_HTML and rename Html_msg() to DilloHtml::message()
by onepoint＠starurchin.org May 30, 2008

May 30, 2008

Self-explanatory, I hope. This is a useful bit of yak-shaving to prepare for more refactoring of form handling code. The reasons for removing MSG_HTML are: * It doesn't belong in msg.h since it can only work when used in http.cc . * It's a UI function not a debugging function like the other MSG_* so it's misleading for it to look similar to the MSG_* macros. * Using it has no advantage over simply calling the function that it wraps. * It's fragile because it requires html to be in scope and have the right value. Regards, Jeremy Henty

2 1

Re: patch: cache Data allocation
by jcid＠dillo.org May 29, 2008

May 29, 2008

On Thu, May 29, 2008 at 05:51:02PM +0000, corvid wrote: > This is to make my unref()s cleaner. > As it was in the prototype code, I would always unref at IOClose time. > This made the reference count negative for file not found, which I didn't > like. I could've tested for GotHeader, but it seemed more natural to > test for data before unref()ing data. I'd prefer GotHeader because that's what Cache_process_queue() tests for, and thus Data doesn't become an implicit flag. > I think it's all right for me to put that Cache_process_queue(entry) inside > an entry->Data test -- at least I couldn't find anything bad happening. BTW, funny as it may seem, I don't yet know what data unref you're talking about! :-) -- Cheers Jorge.-

2 1

[patch]: simplify a_Html_form_event_handler()
by onepoint＠starurchin.org May 29, 2008

May 29, 2008

The a_Html_form_event_handler() function displays an amusing anti-pattern (which I wish I knew the name of) where it's not given enough data and has to go searching for the missing information. Specifically, it gets a pointer to the DilloHtml of the page, but not not the DilloHtmlForm that submitted it, so it has to search the form list of the DilloHtml to find the form. This patch passes the DilloHtmlForm to the handler and adds a pointer from the DilloHtmlForm to the DilloHtml , so the handler can now directly access the form and the html without messing around. Regards, Jeremy Henty

2 3

[patch]: convert Html_submit_form2() to DilloHtmlForm::buildQueryUrl()
by onepoint＠starurchin.org May 29, 2008

May 29, 2008

The function Html_submit_form2() does two jobs rolled into one: most of its code creates a url from a DilloHtmlForm and a few lines push the url to a DilloHtml . This patch takes advantage of the fact that Html_submit_form2() is only called from a_Html_form_event_handler() ; it moves the url push out into the caller and the rest of the code into a new method "DilloUrl *DilloHtmlForm::buildQueryUrl()". This separates concerns nicely: the DilloHtmlForm creates the url and a_Html_form_event_handler() pushes it to the DilloHtml . We're getting close to having a proper API for DilloHtmlForm , unfortunately some of the remaining code is very messy. I'll do the rest of the easy stuff and then summarise what's left. Regards, Jeremy Henty

2 1

Previous patches a la camelCase
by onepoint＠starurchin.org May 29, 2008

May 29, 2008

In case Jorge prefers them, here are revised versions of today's patches with camelCased method names. Regards, Jeremy Henty

2 1

[patch]: html.cc: change Html_add_input() to HtmlForm::add_input()
by onepoint＠starurchin.org May 29, 2008

May 29, 2008

This changes the Html_add_input() function to an HtmlForm::add_input() method. As before I'm submitting this as a "change diff" + "move diff" to make it easier to review. Reviewers please tell me if it makes things harder instead! Regards, Jeremy Henty

2 1