- Dillo-dev - lists.mailman3.com

[patch] Cleanup of IO.c
by Indan Zupancic Nov. 29, 2003

Nov. 29, 2003

Hi, Just cleaned IO.c up, so nothing fundamental changed. Besides some cleanups in multiple functions this are the two major changes: Removal of a_IO_write_chunks, mainly because it isn't used anywhere and it doesn't add any real functionality, it does the same only in a different way. Thanks to CVS it is easy to add it back when you really needed, if you want. Removal of the ValidIOs list. This is the logical next step after g_source_remove was discovered, because the extra indirection isn't needed anymore. All in all the result is a much smaller IO.c (400 lines instead of 700), smaller Dillo (about 3K with -O2), and O(1) behaviour instead of O(n) in the IO engine. The changes have really no negative points as far as I can tell. Link to the patch: http://www.xs4all.nl/~dorinek/dillo/IO-cleanup.patch.gz Greetings, Indan

7 9

Re: [Dillo-dev] [patch] Cleanup of IO.c
by Indan Zupancic Nov. 27, 2003

Nov. 27, 2003

Hi, > I do not understand your disapointing very well and maybe because that i sound rude, excuseme then. Go read Dillo's website, go read the new developer info, go read the files in Dillo's doc dir. Then spend a reasonable amount of time coding for Dillo and cleaning up _their_ mess in IO.c. Then send a patch to the mailing list and wait one week. Let's see if you're disappointed or not. Keep in mind that CVS didn't change the last 6 days, and the last few changes were small, and also don't forget that Jorge claims that he's busy with Dillo full time. Dillo claims to have nice, modular, clean code, and then you encounter some ugly code and try to fix it... I'm afraid I sound rude sometimes too, but we're just telling what we think, right? :) Greetings, Indan

1 0

patch: toggle force_my_colors
by Paul Pelzl Nov. 26, 2003

Nov. 26, 2003

Hi folks, I have attached a pair of Dillo patches. They add a toggle-able menu item to the right-button context menu, which enables/disables the force_my_colors preference on the fly. I find this useful for some occasional websites that Dillo renders rather poorly, as well as sites that simply choose a horrid color scheme. The first patch applies on top of Frank's monster patch v15; the second applies against Dillo CVS of 20031119. I hope others find it useful. Paul

2 2

[PATCH] Version 16 of tab/frame/kbnav/etc patch is ready
by Frank de Lange Nov. 26, 2003

Nov. 26, 2003

Hi'all, The next version (16) of my tab/frame/keyboard navigation patch is ready (see bottom of this message for download instructions). This is mainly a bug-fix and CVS resync release. For an overview of the new features in this release, see the posting I made to the list on version 15. Fixed bugs ---------- keyboard navigation - erroneously highlighted link after leaving a form element, was caused by wrong function call order in focus_next_link. Fixed. keywords - problem with keywords separated by more than one space is fixed. Keywords can now be separated by any whitespace character, including newlines (but don't forget that you still have to enclose the whole keywords string in double quotes for the parser to recognize it!). splash screem - the splash screen is now installed in $(datadir)/dillo/dillo.html CVS date/time ============= The patch is made against CVS as it was on 20031124@13:18 GMT. It should apply against CVS as it was on 20031121(a)21.33 GMT and later. For those who can not or do not want to use CVS, a snapshot can be found here: http://www.geocities.com/ikbenfrank/dillo-200311241318.tar.gz Tabs, Frames and browser bloat ============================== version: 0.8.0-pre patch: dillo-20031124-tabs.patch.gz unpatched: 297204 bytes patched: 333460 bytes (gcc 3.2.2, binutils 2.13.90.0.18, CFLAGS "-Os") Download instructions ===================== The patch is made against 20031124@13:18 GMT CVS. Do not forget to run ./autogen.sh after applying the patch. You can find the patch on the usual (ad-happy, use an ad-blocking proxy or sane browser) site: http://www.geocities.com/ikbenfrank/ More specifically: Dillo 0.8.0-pre (CVS) ===================== http://www.geocities.com/ikbenfrank/dillo-20031124-tabs.patch.gz size: 117192 bytes (gzipped, as downloaded) 531247 bytes (uncompressed) md5sum: 387f4dd85ead27de04d6527cc71504f5 (gzipped, as downloaded) 23ef8335f885d5657c75c7e9e0e18a3c (uncompressed) As always, check the site for the most recent version Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

3 8

patched dillo via Arch
by Paul Pelzl Nov. 26, 2003

Nov. 26, 2003

If anyone on the list is using GNU Arch, you can obtain: Dillo CVS + Frank's tab/frame/kbnav/etc. patch v16 + Indan's HTTPS patch v2 + my toggle-force-my-colors patch integrated into branch dillo--tabframe-pelzl--16.0 . The archive is: pelzlpj(a)eecs.umich.edu--2003 ftp://pelzlpj.dyndns.org/pub/paul/tla/2003 If you find this useful, please send me a private email. If no one cares, I won't bother to announce this archive in the future. Paul

2 1

Re: [Dillo-dev] patched dillo via Arch
by Frank de Lange Nov. 26, 2003

Nov. 26, 2003

Paul Pelzl wrote: >I wouldn't mind setting up a patches list, but only if there is demand >for it. Is patch discussion creating too much traffic on the wearlab >mailing list? If not, then it seems like keeping patch discussion on >the list would give the patches more exposure. > >Anyone else have an opinion? > >Paul > > > I think that patch traffic belongs on this list, as it is quite often relevant for all of Dillo (patched or unpatched). It also keeps the patches in sight for users/developers of unpatched Dillo, which should generate exposure. If/when the patches really take on a life of theirselves it is time to move, but that time has not arrived as far as I'm concerned. Good initiative btw, the Archive. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

1 0

kbnav bugs anyone?
by Frank de Lange Nov. 25, 2003

Nov. 25, 2003

Hi'all, I just noticed that kbnav does not do the right thing when tabbing out of a mouse-selected form field. Instead of going to the next field, it starts at the first form field/button on the page. I'll resolve this for the next patch. If anyone has any other problems with kbnav (or tabs or frames, but that is another patch...) let me know. I'd like to resolve problems in the current feature set before adding anything new... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

1 0

[PATCH] HTTPS version 2.
by Indan Zupancic Nov. 25, 2003

Nov. 25, 2003

Hi, I updated my https patch, can get it from: http://www.xs4all.nl/~dorinek/dillo/dillo-https.patch.gz I will update the installer tomorrow. Not much time, so here the readme text, which can be found at http://www.xs4all.nl/~dorinek/dillo/readme.txt: ------------------------------------------------------------------------ Last updated: 24 November 2003 This patch adds https support to the Dillo CVS version (Pre 0.80). FILES: * Latest https patch is called dillo-https.patch.gz. BUGS: * Dillo will crash if you reload a https webpage very fast multiple times. But you can't do that because I was so mean to edit the refresh function so that you can't reload faster than once per second, which makes no sense anyway. With fast reloads I mean clicking absurdly fast: I can't do it while holding my mouse in a normal way. Keeping Ctrl+R pressed is too though fast though: It aborts the previous reload before it can make a connection. TODO: * Proper proxy support. Tell me if you need it. Now proxy may work only if it uses https with the proxy port and if https is just http over ssl with proxies too (which is the case with the only proxy I know). * Fancy stuff like auto ACCEPT_SESSION for cookies for https connections, auto refresh every 15 minutes or so to keep the ssl connection alive, etc. (things to make Dillo work better with webmail) * Realy fix the weird bug. I tried it, and I gave up for now. STATS: With CFLAGS="-O2 -s" (Os is much slower than O2), gcc 3.2.2 347K, 355368 bytes: unpatched 344K, 351816 bytes: patched, configure --disable-https 346K, 353928 bytes: patched Yes, Dillo becomes smaller after my patch. I cleaned up IO.c a lot. CHANGELOG: - Synchronized to the current CVS. - Added better proxy handling: no idea if proxy works or not though. - Made it harder to crash: needs more fast reloads now (~10 instead of 3). - Prevented fast reloads so that Dillo can't crash anymore. :p - Cleanup of IO.c (smaller, faster, better). - Cleanup of all the https code (bigger, faster, better). - Proper autoconfiguring thanks to Paul Pelzl's patch. Thanks Paul. :) Enjoy, Indan P.S. If you reply, please don't include the whole email you reply to, only the parts you're replying to, or nothing at all. If everyone quotes everything every time you'll get huge emails very fast...

2 1

Proposal: United Dillo
by Indan Zupancic Nov. 24, 2003

Nov. 24, 2003

Hello, With "united Dillo" I mean that there is always just one Dillo running per user, so when you start Dillo while it is already running, then the current one will open a new window. I made a patch as proof of concept, see: http://www.xs4all.nl/~dorinek/dillo This approach has two big advantages: 1) Always one Dillo has less overhead than running multiple instances at the same time. 2) Automatic synchronization/no need for synchronization anymore. First advantage is in the spirit of Dillo, wanting to be small, light and fast. Second advantage means that doing certain things will be much simpler, like having always cookies, no need to synchronize plugins, meaning that dpid is not really needed anymore, because most of the points from the problem list are solved (see Dpid.txt). Problems that aren't solved: * Forks can be expensive (Dillo had to fork its dpis). But dpid does much more than simply forking: it forks and then starts up an external program (which often also forks and starts up wget). Beside, if Dillo uses library plugins then there is no need to fork at all. * It increments dillo's core size. The patch adds about 70 lines of code to dillo.c and increases dillo with about 1 K. It is true that if you get rid of dpid then more code is needed in Dillo's core. But that's only moving the code to some other place, no real increase if you ask me. Having a seperate dpid has much more overhead at runtime (seperate process versus bigger executable). You can always make a plugin handling library, then it isn't part of Dillo's core. Of course a united Dillo has problems/disadvantages too: It is sometimes still needed to synchronize multiple windows. If it's not implemented carefully, you may lose functionality (aka command line options). A user can't run more than one Dillo instance. Sometimes it's wanted to run multiple Dillo's, for instance two different versions. But that isn't possible at all, or if version awareness is added, without losing synchronization. What do you think about it? Greetings, Indan

6 13

[PATCH] Version 5 of kbnav patch is ready
by Frank de Lange Nov. 24, 2003

Nov. 24, 2003

Hi'all, The next version (5) of my keyboard navigation patch is ready. See the end of this message for download instructions. Do note that the tab/frame patch already contains this functionality, so there is no need (and no way) to apply this patch on top of that or the other way around. This release does not add any new features, it is mainly a bug fix and CVS resync release. For more info on what this patch does, see the doc/Keyboard_Navigation.txt document (after applying the patch, naturally...) Fixed bugs ---------- - erroneously highlighted link after leaving a form element, was caused by wrong function call order in focus_next_link. Fixed. CVS date/time ============= The patch is made against CVS as it was on 20031124@13:18 GMT. It should apply against CVS as it was on 20031121(a)21.33 GMT and later. For those who can not or do not want to use CVS, a snapshot can be found here: http://www.geocities.com/ikbenfrank/dillo-200311241318.tar.gz Download instructions ===================== There is currently only one version of the patch, made against 2003124@13:18GMT CVS. As always, have a look at the patch website (http://www.geocities.com/ikbenfrank/) for the latest version of the patch. This patch does NOT apply on top of the tab/frame patch, and the tab/frame patch does not apply on top of this one! The tab/frame patch already contains this functionality, so it is not needed. http://www.geocities.com/ikbenfrank/dillo-200311241458-kbnav.patch.gz size: 30633 bytes (gzipped, as downloaded) 152984 bytes (uncompressed) md5sum: 0ed60695cab750669f3d50c201bdf217 (gzipped, as downloaded) 20aeb6b96e551cd8f4fa65ac5d74ef9e (uncompressed) Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

1 0