- Dillo-dev - lists.mailman3.com

dillo.cc cleanup and bugfix
by p37sitdu＠lavabit.com June 18, 2012

June 18, 2012

Reordered #includes. Fixed --geometry flag. It is --geometry in man page but -geometry in usage and only -geometry is recognized by program. Simplified getCmdOption. Removed State enum, it was overkill. It is also possible to remove support for mandatory arguments (opt_argc < 0) as it is not used, but it does not add LOC so I left it there. Removed check for about:blank as start_page, it is not a special case.

4 9

Dillo working directory
by p37sitdu＠lavabit.com June 15, 2012

June 15, 2012

In Paths::init Dillo changes working directory to /tmp. This way every time I try to open some page stored on the hard disk (Ctrl-O) I have to start in /tmp. What is the reason for changing WD to /tmp? BTW oldWorkingDir is not used anywhere.

1 2

[patch] VOIDP2INT, INT2VOIDP and pointer size
by p37sitdu＠lavabit.com June 13, 2012

June 13, 2012

Now (long) is used for converting (void *) to integer. This patch replaces (long) with intptr_t. I don't think this fixes the real problem. When VOIDP2INT and INT2VOIDP macros are used, it is possible that converted type won't fit into intptr_t. It is better to rewrite code that uses these macros in portable way and remove these macros. Anyway, using intptr_t is better than using (long), (long long) or introducing more autoconf dependency.

4 3

[patch] HTML parser bugfix
by p37sitdu＠lavabit.com June 12, 2012

June 12, 2012

The following HTML fragment is shown as BUG<">abc by Dillo. It is valid (checked with validator.w3.org) HTML. In Firefox it is shown as abc with '>BUG<' tooltip. <div title=">BUG<">abc</div> What happens is that Dillo see < character inside quotes, shows bug "attribute lacks closing quote" and breaks out of tag parsing loop. In fact it is not possible to say if there is a bug in HTML at that point. In WWW you can see this bug on http://reddit.com. Each entry on this page contains votehash', null, event)" > and bug meter shows bugs for them. Attached patch removes logic that tries to detect unterminated quoted attributes and fixes this bug.

4 8

[customercare@dotster.com: Case Number: 01278137 - New Comment Added - ref:_00D30S5t._50060JcXjd:ref]
by jcid＠dillo.org June 7, 2012

June 7, 2012

FYI -- Cheers Jorge.-

1 0

dillo.org web site
by jcid＠dillo.org June 7, 2012

June 7, 2012

Hi there, The domain was renewed, but I still can't see the website from Chile, although when I log to the wearlab it works [1]. Is everybody seeing having the same problem? [1] lynx www.dillo.org -- Cheers Jorge.-

6 15

[patch] dlib cleanup
by p37sitdu＠lavabit.com June 5, 2012

June 5, 2012

malloc.diff: added perror calls for malloc and realloc errors dstr.diff: dStr* functions cleanup dlist.diff: replaced recursive QuickSort with qsort from stdlib.h. Tested with file.dpi where it is used for sorting directory listing.

3 4

[patch] typedefs and identifiers with leading underscores
by p37sitdu＠lavabit.com June 3, 2012

June 3, 2012

There is no reason to have a name for structs when we just want to typedef them. BTW identifiers that begin with underscore are reserved. Attached patch fixes all typedefs.

1 1

[patch] downloads dpi progress bar
by p37sitdu＠lavabit.com June 3, 2012

June 3, 2012

Now progress bar is implemented as custom widget on top of Fl_Widget class. But FLTK already has Fl_Progress class for the same thing. Progress bar looks the same with two exceptions: 1. No tooltip: it is not displayed for Fl_Progress even when set. Normally progress bars, labels and other widgets for status information don't have tooltips so I think it is ok. 2. When downloading file without Content-Length, progress bar is always empty. With current implementation it changes for one percent on every update and remains somewhere in the middle when download is finished. For me keeping it at zero looks better. Patch and python HTTP server for testing downloads without Content-Length attached.

1 0

dillorc and src/keysrc
by p37sitdu＠lavabit.com May 28, 2012

May 28, 2012

dillorc is in the root of repo and keysrc is in src/keysrc. Not a serious issue, but I think keysrc should be located in root too.

2 2