- Dillo-dev - lists.mailman3.com

Redraw storms
by onepoint＠starurchin.org Sept. 23, 2008

Sept. 23, 2008

Since dillo got tabs I'm seeing "redraw storms": sometimes after opening a new tab every movement of the mouse triggers a redraw. It doesn't seem to depend on the number of tabs. Usually it will go away eventually (just after a tab is closed). I upgraded to the latest FLTK2 snapshot but it has made no difference. Is anyone else seeing this? Regards, Jeremy Henty

4 11

Redraw storms: the trigger
by onepoint＠starurchin.org Sept. 23, 2008

Sept. 23, 2008

I think the redraw storms start whenever the main window is resized horizontally and there are too many tabs to fit in the horizontal space (so that the tab menu button has appeared). Vertical resizes do not cause the problem. It is also safe to resize horizontally or vertically before the tab menu button appears. Once the storm has started it stops whenever the tab menu button disappears, whether this is due to closing some tabs or widening the window. The storm starts again whenever the tab menu button reappears, whether or not there has been any more resizing. Do other people see this? Jeremy Henty

1 0

patch: fonts, utf-8 tabs
by corvid＠lavabit.com Sept. 21, 2008

Sept. 21, 2008

The ui.cc changes are so that I can make a tabs screenshot with Asian script at some point. Similarly, the dialog.cc change is so that I can see Asian characters in source. Kept forgetting to deal with that...

1 0

patch: making some concessions to aesthetics...
by corvid＠lavabit.com Sept. 21, 2008

Sept. 21, 2008

I've decided to admit that highlighting checkboxes and radio buttons is always hideous. I had been trying to avoid the special case, but I know the horribleness would jump right out at someone trying dillo2... (And I decreased the RELIEF_X_THICKNESS because 5 makes <button>s look weird at my low resolution)

1 0

[patch] minor optimization in StyleAttrs::equals()
by Johannes.Hofmann＠gmx.de Sept. 20, 2008

Sept. 20, 2008

Hi, this patch adds a missing optimization to StyleAttrs::equals(). Similar checks are already in place in other equals() methods. Cheers, Johannes

2 1

[patch] fixup resizable of after tab removal
by Johannes.Hofmann＠gmx.de Sept. 19, 2008

Sept. 19, 2008

Hi, I was seeing crashes when removing tabs. The reason is that when we accidentally remove and delete the resizable of the TabGroup, fltk still tries to access it. Attached patch fixes that. It also moves the hide/showLabel functionality into CustTabGroup. Cheers, Johannes

1 0

8.68% of my time in assert()?
by corvid＠lavabit.com Sept. 19, 2008

Sept. 19, 2008

Turning off bounds checking for get and getRef does get rid of nearly all of the assert()s, but I was just trying -Winline and discovered: ./lout/misc.hh: In function 'void lout::misc::assert(bool, const char*, ...)': ./lout/misc.hh:36: warning: function 'void lout::misc::assert(bool, const char* , ...)' can never be inlined because it uses variable argument lists .. Earlier I'd said assert() was not cheap, but I was still uncertain about how -g and -pg might be affecting inlining. Now I _know_ that assert() is not cheap.

3 10

Confused by the comment to CustInput::handle()
by onepoint＠starurchin.org Sept. 19, 2008

Sept. 19, 2008

In dillo2/src/ui.cc, CustInput::handle() has a comment saying that it disables CTRL+{o,r,HomeKey,EndKey}, yet it only seems to disable CTRL+o . I think CTRL+r used to be disabled too, so that CTRL+r would reload the page even if the URL widget had the focus. Here's a one-line patch to restore that. What should we do about CTRL+{HomeKey,EndKey}? I prefer HomeKey and EndKey to scroll the main window even when the URL has the focus. Wasn't that the behaviour originally? It certainly doesn't happen now. Regards, Jeremy Henty

2 2

Latest libpng fixes crashes
by onepoint＠starurchin.org Sept. 18, 2008

Sept. 18, 2008

I recently looked at why dillo almost always crashed when viewing http://www.packtpub.com/article/transaction-model-of-postgresql and discovered it was happening in the depths of libpng. Luckily libpng-1.2.32 fixes this problem, so if you have been seeing unexpected crashes that might be due to PNG images then I recommend upgrading libpng. Regards, Jeremy Henty

1 0

patch: scroll upon resize
by corvid＠lavabit.com Sept. 17, 2008

Sept. 17, 2008

You know how - you are scrolled down or to the right - you make the viewport larger - the scrollbar disappears - you can only get the rest of the document back by hitting some arrow keys or something This seems to fix it, although my usual dw disclaimer applies: I don't know whether this is necessarily the right place for the change. PS When making the viewport very narrow and then maximizing, I notice that the location bar does not go back to showing the whole address. I don't know whether that's dillo's fault or fltk's fault. PPS Amazing how much code we need for dealing with scrolling and scrollbars...

3 4