- Dillo-dev - lists.mailman3.com

Q: why does Nav_stack_clean() free the data and Nav_stack_truncate() not?
by onepoint＠starurchin.org May 25, 2008

May 25, 2008

While reviewing nav.c to figure out the reload crash bug I noticed something that seems inconsistent: both Nav_stack_truncate() and Nav_stack_clean() remove items from the navigation stack, yet Nav_stack_truncate() does not free the data it removes and Nav_stack_clean() does. Is this a bug? If not, what haven't I understood? Regards, Jeremy Henty

2 3

Profiling works!
by onepoint＠starurchin.org May 24, 2008

May 24, 2008

I added -pg to LDFLAGS, CFLAGS and CXXFLAGS and dillo generated a nice gmon.prof ! However, it puts it in /tmp (perhaps that's why it didn't seem to be working). Dillo also dumps its core to /tmp when it crashes, perhaps for the same reason? Regards, Jeremy Henty

2 2

patch: trim Local_Buf
by corvid＠lavabit.com May 24, 2008

May 24, 2008

3 2

Uncluttering dillo, part II: the findbar
by 4winter＠informatik.uni-hamburg.de May 24, 2008

May 24, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar. There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints. Jorge, could you update your coding conventions with respect to c++ specific language features? Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0pmoPmwNWhsaZYRAi1VAJwO/e+JWmCoMsjOF/hYuF4X1DUOWwCePB96 +X++Veu0Gyv854m0TxSwI7Q= =rc5Z -----END PGP SIGNATURE-----

4 9

memory statistics
by Johannes.Hofmann＠gmx.de May 23, 2008

May 23, 2008

Hi, to see which part of dillo consumes which amount of memory, I hacked together a version of dlib.c that counts memory that was allocated via dMalloc(). A malloc_tag allows to assign the mallocs to specific parts in the code. In the patch below I use malloc_tag = 1 for cache stuff, malloc_tag = 2 for text strings that are passed dw2 and malloc_tag = 0 for everything else. It's fun to see how memory get's allocated and free'd while loading. Here is the output once the huge mysql manual page is loaded: ====> malloc size 5185114 26967623 6602392 0 So that's 6M for text strings, 26M cache and 5M other. Of course there is also all the dw2 stuff that is not taken into account here. BTW, textblock delete's the text strings that are allocated using malloc(). That's not allowed and might cause unexpected behaviour on some platforms. Cheers, Johannes

3 10

patch: free parse data
by corvid＠lavabit.com May 23, 2008

May 23, 2008

Johannes had suggested freeing Local_Buf when parsing was completed...

2 1

RFC: human interface guidelines
by 4winter＠informatik.uni-hamburg.de May 21, 2008

May 21, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) I was thinking about improving the dillo experience by adding some functionality / shortcuts people have come to expect. But what people expect is influenced by their background, their choice of desktop environment and platform. We could pick one / some user interface guideline(s) ([1] lists some) and try to adhere to it / them. Or we could pick one popular browser and copy its 'feel'. Attached are two patches mapping 'reload' to F5 and 'help' to F1. Let me know what you think of them and the whole interface thing. Justus 1: http://en.wikipedia.org/wiki/Human_Interface_Guidelines - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0jvoPmwNWhsaZYRAveJAJ9ROk+E0VWLzK6G99qcTlpNjeB5igCeJ7r9 Grz4wtWQ+BIEbWrIY8PDCFg= =JnX2 -----END PGP SIGNATURE-----

2 1

[patch] minor memory reduction
by Johannes.Hofmann＠gmx.de May 21, 2008

May 21, 2008

Hi, attached is a small patch to improve memory usage. It creates a single word for a sequence of spaces in PRE mode instead of one word per character. The second part is just a minor simplification. Cheers, Johannes

2 4

Uncluttering dillos UI - getting rid of the dialog boxes
by 4winter＠informatik.uni-hamburg.de May 21, 2008

May 21, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) somewhere deep inside the "Future of Dillo" monster thread I suggested to get rid of the location dialog box but Johannes pointed out that this breaks the fullscreen mode. So, here is my proposed solution: * on ctrl-l: focus location bar * if in fullscreen mode: temporarily show toolbars until the user pressed enter I am not familiar with the fltk event model, so I just hijacked the existing event handler which works reasonably well. It would be nice to also capture any "on-blur" events, but I could use some hints (the fltk2 documentation only mentions 6 WHEN_* events, though some googling suggests that there might be UNFOCUS events... uh?). Anyway, the patch is attached. let me know what you think. Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILd5xoPmwNWhsaZYRApqEAJ9glSSkR3Q9oU0BmmUf9/ErG/ItfwCfVs5M asgEwaQAMk4ggsfzO2toTc0= =MHCi -----END PGP SIGNATURE-----

3 10

Keyboard shortcuts & fullscreen button
by 4winter＠informatik.uni-hamburg.de May 21, 2008

May 21, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The UI constructor creates a button for the fullscreen mode, but it is not added to anything: // Make the full screen button (to be attached to the viewport later) // TODO: attach to the viewport FullScreen = new HighlightButton(0,0,15,15); [...] Any idea why this was postponed? Should it be enabled now? Also I noticed, that the way events are handled is somewhat lax with respect to modifier keys. The code just checks if ctrl is pressed, not if ctrl but none of the other modifiers are pressed. This makes ctrl-l equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is this a bug or a feature? Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILwMvoPmwNWhsaZYRAmHYAJ49XUO6F6mBTG+CbWAzfN5yknkrKgCfQOjB QzlODEtqUdlztUo6tHuluUE= =hCHy -----END PGP SIGNATURE-----

2 3

Horizontal scrolling
by 4winter＠informatik.uni-hamburg.de May 19, 2008

May 19, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Huhu there :) attached is a tiny patch that enables the horizontal scrolling of the content of the main dillo widget. Unfortunately fltk supports this up to now (r6129) only on OSX. I do have a patch for fltk that enables this on x11, let's see if I can slip it in ;) Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIL0tNoPmwNWhsaZYRAmE+AJ9LN79iT4/nyt1JWJYt7BP1PYcFlQCeLV/g BRZ6xTrW7ER5rbDm7V5E1Hk= =SWKS -----END PGP SIGNATURE-----

2 1

website FAQ update
by corvid＠lavabit.com May 19, 2008

May 19, 2008

I made http://www.dillo.org/FAQ.corvid.html The old FAQ is still at http://www.dillo.org/FAQ.html for now. So if you have comments/find mistakes/whatever....

3 10

[patch] dillo and huge pages
by Johannes.Hofmann＠gmx.de May 19, 2008

May 19, 2008

Hi, to test how dillo behaves on huge pages, I downloaded the mysql manual as a single html page: http://downloads.mysql.com/docs/refman-5.1-en.html.tar.gz With this page I noticed that the drawRegion in FltkViewBase can grow pretty large which slows down loading the page. Attached patch limits the size of the drawRegion to 16 rectangles. With this patch (and HUGE_FILESIZE in cache.c increased to 16M) dillo works pretty well on this huge page. Better than dillo1 and firefox! One problem is that clicking on anchor links (to anchors within the page) reloads the page which take some time. Also memory usage gets pretty high (250M with images disabled). I'm experimenting with reducing the size of struct Word in textblock.hh by moving the highlight stuff out of struct Word and into Textblock. This brings memory usage down to 199M. However, I don't know the highlighting stuff enough to be sure I don't break anything. This probabely falls into the "premature optimization" category anyway. Cheers, Johannes

2 2

patch: dw configure args: rtfl and doublebuffer
by corvid＠lavabit.com May 19, 2008

May 19, 2008

I saw in the bug tracker that --disable-rtfl still turns on rtfl msgs. Did some reading. The third argument to AC_ARG_ENABLE is always run if the option was specified, regardless of the value. If the option is not specified, the fourth argument is run. --disable-FEATURE just becomes --enable-FEATURE=no. (I'll send a separate patch to Jorge to allow compilation with rtfl.)

2 1

Bug that aborts Dillo
by jcid＠dillo.org May 18, 2008

May 18, 2008

Hi there, I reviewed my personal notes on dillo segfaults and all of them but one are fixed now. This is: BUG: http://episteme.arstechnica.com/groupee/forums/a/tpc/f/96509133 /m/151006647731/r/264004847731 Aborts dillo. If you wget that URL to a local file, it's easier to debug because the problem is with a requested image. A negative number is propagated down from image.cc:199 #13 0x0807d083 in dw::Image::sizeAllocateImpl (this=0x81eca98,allocation=0xbfc69fb8) at image.cc:201 (gdb) p *allocation $4 = {x = 366, y = 941, width = 3, ascent = 2, descent = 1} (gdb) p dx $5 = 8 (gdb) p dy $6 = 26607 (gdb) allocation->width - dx = -5. from there width=-5 wreaks havoc. Please someone more seasoned in the (dx,dy) offsets give it a look. -- Cheers Jorge.-

2 2

Dillo freeze
by jcid＠dillo.org May 17, 2008

May 17, 2008

Hi there, Dillo freezes on this page: http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.24.6.tar.bz2.sign Dillo bug or FLTK2? -- Cheers Jorge.-

3 6

patch: some more window deletion
by corvid＠lavabit.com May 16, 2008

May 16, 2008

I thought I was going to have to remove the viewport from the UI because both UI and layout would want to delete it, but it appears that TopGroup gets informed of the deletion and everything turns out fine.

2 1

tabs - what are they?
by Johannes.Hofmann＠gmx.de May 15, 2008

May 15, 2008

Hi, while thinking about tabs I realized that I'm not really sure what they are. * On the one hand they could be implemented just as a GUI alternative to multiple bowser windows. * On the other hand they could be something like temporary bookmarks that are easily accessible e.g. via buttons below the panel. That way one would only need one layout and view. The only issue here would be that one would expect a separate navigation stack for each "tab". What do you think? Cheers, Johannes

2 2

Future of dillo2
by 4winter＠informatik.uni-hamburg.de May 13, 2008

May 13, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Diego wrote: >> With my recent patch (dpid-cleanup-and-DPIPATH.dillo2) one can use the >> attached script to run dillo in-tree which is nice if you just want to >> try it out but should also be useful for development purposes (easily >> manage different branches without the need to install them somewhere). > > The patch seems good to me, but i have not look it very deep or test it. Some more testing turned out that it's not enough to add another path to search for dpis. With no dpidrc fill_services_list fails: [dpid]: dpid.c:467: fill_services_list: Fatal error [dpid]: - Can't find the directory for dpis. This seems very non-plugin-like to me. What's the point in being able to have dpis in ~/.dillo/... but to actually use them you have to add them to your ~/.dillo/dpidrc. I mean it's okay up to this point, but consider you have one custom dpi in ~/.dillo/... : * in order to use it you have to create a custom dpidrc too * judging by a quick look at dpid.c/register_service I'd say that you have to copy the content of the system wide dpidrc file too since your custom one takes preference over the system wide one * now there's a package installed containing one more dpi. It might be doable to update the system wide dpidrc via a post-install script within the package (though thats error prone, you have to remove your entries on package removal etc.) * but what about the custom dpircs? You cannot have the post-install script modify those as well (well, you could, but naaa) > The idea is that each dpi can have its own files in its directory > (preferences, data, cache files ... ). I could go with preferences and data files, but caching feels like a no-no to me since on most installations the user is unable to write into those directories. Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIKgZ9oPmwNWhsaZYRAjL+AJ9SjhWBUNh5WcO51GkJLaqtDyjFEwCeMQkz jkTcvl8xIbP3EedZP8T72fc= =xAX5 -----END PGP SIGNATURE-----

1 0

Future of dillo2
by jcid＠dillo.org May 13, 2008

May 13, 2008

Hi there, This question: > What do you think of reviving use of the bug tracker > for the various little things that are easy to forget about? brings about a bigger topic: the future of dillo2. The goals of the project are: 1.- The democratization of internet information access 2.- Personal security and privacy 3.- High software efficiency I believe the key to achieving them are: a.- A larger development team. b.- A user community finding it useful. The vitality and development pace of the project are highly related to a). Point b), has been strong in the past; this is: judging from the received email feedback: http://www.dillo.org/emails.txt and from some surveys like: > On Sat, Aug 25, 2007 at 03:28:55AM +0200, Diego . wrote: > > DesktopLinux.com has published the results of its anual (desktop)linux poll > > The interesting thing is in the 3rd question: Which web browsers do you > > frequently use on your Linux desktop(s)? > > > > > http://www.desktoplinux.com/cgi-bin/survey/survey.cgi?view=archive&id=08132… > > > > The interesting thing is that a frozen project have enough users to win > > over 3 fully developed browsers :) (optimistic without cure) Point a) is key because it directly relates to the pace with which we pursue the moving target of Web browsing. Point b) is very important because if we end up with a browser that only a few people are willing to use, there's no point in it besides personal motivations. So: * Objective 1, is the result of a) and b). * Objective 2, needs the work of a). * Objective 3, is mainly achieved! How do we do it? i. - Increase the development team by adding 6+ new developers. ii.- Getting more involved with other projects. We could: * Attract new developers with a dillo2 release, leveraging the excellent documentation that we have. * Planning for CSS, floating objects and TABS. (this are important features to a nice browsing experience) * Coordinate with FLTK2, DSL (Damn small linux) and other lightweight distros, Debian installer team, MINIX3, etc. I don't want to miss the opportunity to thank the team for the excellent work during these months. Without you dillo2 wouldn't be so close to a release. Now, we need to plan, grow the number of developers, and bring dillo2 closer to its goals. These are just my views on the subject. Please share your thoughts, ideas and plans in this thread, so we can agree on a plan for the future. -- Cheers Jorge.-

8 22

Future of dillo2
by jcid＠dillo.org May 13, 2008

May 13, 2008

On Mon, May 12, 2008 at 10:30:14PM +0000, corvid wrote: > > On Mon, May 12, 2008 at 09:35:46PM +0000, corvid wrote: > > > > http://www.dillo.org/Plans.html > > > > > > Did you commit/make/whatever it? > > > I thought "What changed?" and looked at a cached version, > > > and didn't see any differences. > > > > Not much here AFAIR the form elements and the rewrite of tables > > have now a green ball (finished). > > > > The bulk of it is adding what "should" be added. :-) > > I see the problem now. > > You didn't update the alt tags :) Yes! Now they're updated, and the extra items added, some sorting made and it looks more like what we have. I believe if we can complete the high priority items and stabilize the code we'd have a release candidate in our hands. If Sebastian completes the floating objects in textblock, that'd be great for the release, because dillo2 would show much better rendering in DIV-based and TABLE-based pages Comments? -- Cheers Jorge.-

1 0

Future of dillo2
by jcid＠dillo.org May 13, 2008

May 13, 2008

On Mon, May 12, 2008 at 11:40:41PM +0200, Diego . wrote: > 2008/5/12 Jorge Arellano Cid <jcid(a)dillo.org>: > > > On Mon, May 12, 2008 at 03:51:42PM -0400, Jorge Arellano Cid wrote: > > > [...] > > > I'll try to update some pages in the site as soon as I find > > > some time. > > > > Just updated: > > > > http://www.dillo.org/cvs.html > > > > with directions on how to get dillo running. Developers, > > packagers, and experienced user should be pointed here. > > > > Somebody please check the directions work. :-P > > > > I doubt about the "exit" command, but i have not test the directions. "exit" is used as "logout" to get out of root. > and: > > > > http://www.dillo.org/Plans.html > > > > There is a line not updated under the "Current Plans for dillo2" text: > "--updated February 2007" > > It can be confusing. Ooops. Fixed. -- Cheers Jorge.-

1 0

Daily builds and tests / 0install feeds / PIE
by 4winter＠informatik.uni-hamburg.de May 11, 2008

May 11, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey hey :) I setup two boxes (one x86 running Debian lenny, one x86_64 running Ubuntu Hardy) to build daily snapshots of dillo2 (and fltk2). Tarballs, logs and screenshots are located at https://winter.gotdns.org/~teythoon/build/dillo2/ [suggestions for more interesting screenshots are welcome, like some testcases...] I also created a 0install feed (see http://0install.net/) for those daily builds. If you are on a "not that outdated" linux distribution (think of the libraries) on either x86 or x86_64 you can start dillo by running $ 0launch https://winter.gotdns.org/~teythoon/build/0feeds/dillo-fltk.xml If there is some interest in this I will try to make the builds more general (linking against older/more general versions of the required libraries etc). 0install feeds require programs to be position independent. Not like - -fpic or -pie but they should work where ever they and their files lie within the virtual file system. This is mostly true for dillo. dpid is located via PATH but the location to the dpis is (somewhat) hardcoded into the dpirc. So I went into dpid.c/register_all and poked around. Attached is a patch that allows me to specify an additional location for dpis via the environment variable DPIPATH. I also reorganized the code somewhat to minimize code duplication and I removed usr_srv_num since it was unused. Please let me know what you think :) Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIJw6poPmwNWhsaZYRAj4hAJ4rmvSQPPnHiGFQMXaTAGw3wg4JOQCeM9M3 oT6YvhD/s1ncdMQqAMifxgA= =NxaA -----END PGP SIGNATURE-----

1 0

[BUG]: anchors break when a page includes '<meta http-equiv="Content-Type" ...'
by onepoint＠starurchin.org May 11, 2008

May 11, 2008

If you navigate to a page with a '<meta http-equiv="Content-Type" ...' in the head element then any anchor in the URL is ignored. (This breaks my local cinema's web page because it puts listings and film descriptions on the same page and links them with anchors.) I think the reason is that the meta element forces the page to be reloaded by Nav_push() and this does not call a_Nav_expect_done(). Unfortunately a_Nav_expect_done() is responsible for calling a_UIcmd_set_scroll_by_fragment(), so any page pulled in by Nav_push() does not scroll to the anchor. Any ideas how to fix this? I having a hard time getting my head around this bit of the code. Regards, Jeremy Henty

4 16

[patch]: dillo2 configure.in update for latest GNU m4
by onepoint＠starurchin.org May 10, 2008

May 10, 2008

I just updated my auto* tools including GNU m4 and the dillo2 build broke because "AC_SUBST(src doc)" complains that "src doc" is not a valid shell tag. I guess that the macro used to split at spaces and iterate over the result whereas the new version no longer does so. Anyway, replacing "AC_SUBST(src doc)" with "AC_SUBST(src)" and "AC_SUBST(doc)" seems to fix things. Patch attached. Please comment. Jeremy Henty

2 2

does RGBA work for you?
by corvid＠lavabit.com May 9, 2008

May 9, 2008

(I'd seen that there was talk on the fltk forums recently about RGBA and images ending up with the wrong dimensions, but that's not my problem.) If you uncomment RGBA in test/dw_images_scaled.cc, does dragging the window around cause part of it to turn pinkish? (I'll attach a diff, even though it's not exactly difficult.) I had started by hacking up the dillo side to send RGBA, and it worked fairly well in general for images where every pixel is either completely opaque or completely transparent. Gradients didn't seem to work too well, and often these pink/red regions were showing up. So far it seems as if the value of green relative to the value of alpha is what can make it particularly lose its mind, but that's probably wrong. You know how first impressions are... I followed it down to fltk/src/x11/Image.cxx, by which point it had been transformed to ARGB which looked about right to me. Then there's lots of xrender and transforms and things I don't know anything about. I tried some setcolor and fillrect in FltkImgbuf::draw(), but it didn't seem to matter, so I guess that's not my problem... If the question is "Why bother?", dillo2/src/png.c currently just mixes in whatever the background color is the first time we see an image on the page.

2 2

Render to image
by kfa＠gmx.net May 8, 2008

May 8, 2008

Hi @, First of all, thanks guys for doing this great project :) Wondered if I could ask for a few pointers before digging my way through the source to see if I could do the following: I'm thinking of using Dillo as a rendering engine inside of another project. All I need is having it render offscreen to an image object of some kind, producing a click map for the links would be an added advantage. I know how to do this with Mozilla but that is such a heavyweight beast. I don't need any network code as well, all input material (html and media files) woud be provided by the enclosing application. Does anyone have a hint on where to start looking, which files / classes / libs out of the dillo package I would need for this? Thanks, Klaus

2 2

[patch] fix redraw issue on resize
by Johannes.Hofmann＠gmx.de May 7, 2008

May 7, 2008

Hi, attached patch fixes an obvious problem with the redraw optimization that results in artifacts when resizing the window. There may be other issues left. Cheers, Johannes

2 1

CVS glitch
by onepoint＠starurchin.org May 7, 2008

May 7, 2008

Just so you know, for some reason it took a long time for the latest patches to show up in CVS. Normally I update more or less as soon as I see Jorge's "committed" message and the patches appear, but this time I saw his acknowledgement late yesterday afternoon and the patches still weren't there by midnight. They turned up this morning so it was not a permanent failure. Did this affect anyone else? I've never seen it before! Jeremy Henty

2 2

[patch]: Refactor {FltkListResource,FltkOptionMenuResource}::sizeRequest()
by onepoint＠starurchin.org May 6, 2008

May 6, 2008

A simple refactoring: FltkListResource and FltkOptionMenuResource use the same code to determine the maximum string width. Jeremy Henty

2 2

[bugfix]: FltkSelectionResource leaks memory
by onepoint＠starurchin.org May 6, 2008

May 6, 2008

corvid pointed this out to me. Patch attached. Jeremy Henty

2 1

Test
by sgeerken＠dillo.org May 6, 2008

May 6, 2008

Hi, this is just a test message. Sebastian

1 0

ListResources: version 3
by onepoint＠starurchin.org May 6, 2008

May 6, 2008

I am attaching two patches that get ListResource selection working properly, ie. you can click items as you wish and FltkListResource::isSelected() will now return the correct value. The first patch is my previous selection patch, unchanged. The second is a small fix that I proposed in the lout::misc::StringBuffer fix thread: it makes FltkListResource::addItem call Widget::set_selected() on fltk::Item widgets, and the call to Menu::set_item() becomes conditional on a virtual boolean hook that defaults to false, but is redefined to true in FltkOptionMenuResource() . The second patch looks bigger than it really is: most of it is just reindenting a block of code that moved inside an "if" statement. (And diff doesn't help by insisting on choosing an unnecessarily complicated set of changes.) It's not a pretty hack, but it's simple and I am wary of making deeper changes until I understand the code better. Please comment, Jeremy Henty

4 5

Q: should we select option groups
by onepoint＠starurchin.org May 6, 2008

May 6, 2008

FLTK allows both Choice and MultiBrowsers to select group items as well as normal leaf items. The Dillo Selection widget currently ignores selected group items, which could be confusing if a user selects a group and expects the application to do something about it. On the other hand the HTML 4 spec[1] reads as though only options and not option groups can be selected, though it does not say so explicitly. What should Dillo do about this? [1] http://www.htmlhelp.com/reference/html40/forms/select.html

1 0

patch: dialog.cc window deletion
by corvid＠lavabit.com May 5, 2008

May 5, 2008

Using the crude tool of top(1), I learned that viewing the source of a 500K file meant losing 500K down the drain. - If I give the text to the TextDisplay's initial buffer, it knows that it owns it. - Window::destroy() doesn't delete. The header comment in fltk/src/Window.cxx says it's some sort of 'hide' function: "Hides the window and also deletes all window system information about the window, and thus returns it back to the state it was in before the first show(). It is harmless to call this if the window is already destroyed." - And while I was in there, I threw in some callback(window_close_cb, ...)s for closing windows using the window mgr instead of a button.

2 1

[patch]: FltkListResource::sizeRequest()
by onepoint＠starurchin.org May 5, 2008

May 5, 2008

Currently FltkListResource::sizeRequest() is a stub with some hardwired values that are not very useful. This patch replaces it with something more appropriate (closely following the existing implementation of FltkOptionMenuResource::sizeRequest() ). Comments are welcome, Jeremy Henty

1 0

[BUG]: html.cc: broken Dlist iteration
by onepoint＠starurchin.org May 5, 2008

May 5, 2008

Html_build_query_data() and Html_make_multipart_boundary() iterate over a Dlist while destructively modifying it *and* recalculating the list length each time, so the iteration terminates prematurely. This makes Html_build_query_data() mangle the result when an input returns multiple values: half of the values get attached to the next input! This patch fixes the problem by caching the length of the list before modifying it so that the entire list is processed. Regards, Jeremy Henty

2 1

[patch]: select multiple
by onepoint＠starurchin.org May 5, 2008

May 5, 2008

This patch implements the MULTIPLE attribute for SELECT elements. It's small but it depends on the various patches and bugfixes I have already posted. Please comment. Regards, Jeremy Henty

1 0

[BUG]: lout::misc::StringBuffer::clear() does not invalidate the string
by onepoint＠starurchin.org May 3, 2008

May 3, 2008

Well, *that* was a bit of a wild goose chase! Remember I complained of selection problems in ListResources? It was nothing of the kind. Instead test/dw-ui-test was spuriously reporting that things were still selected when everything was in fact unselected. And the cause was a bug in lout::misc::Stringbuffer ! lout::misc::StringBuffer::clear() omits to invalidate the internal cached string, so if you call lout::misc::StringBuffer::getChars() (which updates the cached string and marks it as valid), then lout::misc::StringBuffer::clear() and then *immediately* call lout::misc::StringBuffer::getChars() again, you get the contents of the StringBuffer before you cleared it (because the cached value has not been invalidated), instead of the empty string. D'oh! One-liner patch attached. Regards, Jeremy Henty

3 4

dillo-fltk on x86_64
by 4winter＠informatik.uni-hamburg.de May 2, 2008

May 2, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey@all :) I ran into some issues compiling dillo. I solved / worked around them, patches are attached. Here are my findings and my interpretations (let me know in case I am way off somewhere): dw2 === gcc-4.2 on linux/x86_64 complained about two casts in lout/object.cc: object.cc:118: error: cast from ?void*? to ?int? loses precision I felt it was nonsense to check the size of void* at runtime and used the preprocessor to choose which instruction to use based on the value of SIZEOF_VOID_P. dillo2 ====== There was another complaint by gcc: dialog.cc:249: error: cast from ?void*? to ?int? loses precision A parameter of type void* for a callback is used to carry a small integer (most likely the number of the button pressed or something). I solved this one by first casting to long and then to int. I saw this somewhere on the net, don't know if this is too hacky. dillo2/dpi ========== downloads.cc failed to compile since gcc couldn't find the fltk includes (I chose not to install them to /usr/local/lib), so I poked around in dpi/Makefile.am and managed to include LIBFLTK_CXXFLAGS into cxxflags (/me is an automake n00b). With my three patches applied dillo compiles and runs fine, however I had to create ~/.dillo and manually start dpid. Did I miss something here? Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFID6/ToPmwNWhsaZYRApgwAJsENlC0vsniya14RBTU8yrXVVjVyACff2HD GLM/iKxXf3UjBA6+GFOSE78= =JuDE -----END PGP SIGNATURE-----

5 19

[patch]: take 2: FtlkListResource
by onepoint＠starurchin.org May 1, 2008

May 1, 2008

Since Johannes' criticisms were (IIRC) mostly about my patch's complexity I hope he will look at a new patch that sticks to my original approach but is a lot simpler. I realised that if the user_data() of the Menu Widget items stored the index of the Item instead of the Item itself then FltkListResource could store the selections by index in a misc::SimpleVector<bool>. This means there is no need to wrap bools in object::Object pointers and no need to add instance methods to Items to make them Hashable. Most of the scaffolding of the previous patch just disappears (the line count decreases by a third). I don't want to dismiss Johannes' alternative suggestion out of hand, but I still think my approach has a lot going for it and I'd like people to have a chance to criticise my best shot at it. Comments are welcome! Jeremy Henty

2 1

[patch]: FtlkListResource select callbacks
by onepoint＠starurchin.org May 1, 2008

May 1, 2008

This is a first cut at making FltkListResource work properly. The resource maintains a hash of its items' selected status, the MultiBrowser widget gets a callback that updates the hash and isSelected() looks up the hash for the answer. It's the same technique I used for FltkOptionMenuResource , where the FLTK widgets are linked to their resources by user_data() and callback arguments. I added equals() and hashValue() methods to Items so they could be hash keys, and implemented an object::Object wrapper class for boolean values to be the hash values. The wrapper class is inside FltkListResource , though it could easily move to lout::object IMHO. The patch also enables the ListResource widget in test/dw-ui-test . Unfortunately it's still a little buggy. Specifying multiple selected items initially doesn't work right: they are all selected in the resource but only one is selected on the FLTK widget. Things also go out of sync when you select a group item: any previously selected item is unselected in the widget but not in the resource. I'll look into these further. Comments are welcome! Regards, Jeremy Henty

2 2

[patch] ignore SIGPIPE
by Johannes.Hofmann＠gmx.de April 30, 2008

April 30, 2008

Hello, this patch avoids exits on SIGPIPE. Currently this is only observed on DragonFly, but dillo1 had this too. Cheers, Johannes

2 1

[patch] cleanup iterator fix
by Johannes.Hofmann＠gmx.de April 30, 2008

April 30, 2008

Hi, now I noticed, that there is a more elegant way to create an iterator that is winded forward until its end. This restores symmetry between DeepIterator::next() and DeepIterator::prev(). Cheers, Johannes

2 1

[patch] two more tiny memory leaks
by Johannes.Hofmann＠gmx.de April 30, 2008

April 30, 2008

Hi, two more small leaks in dw2 found by valgrind. Cheers, Johannes

2 1

start on image maps (dw-part)
by Johannes.Hofmann＠gmx.de April 30, 2008

April 30, 2008

Hi, just to let you know, I just started with client side image maps (the dw-part). Below is an initial implementation of ImageMapsList. This is not yet ready at all, but perhaps someone might want have a look. Cheers, Johannes diff -r 877bbc03146b -r ebc6de688732 dw/image.cc --- a/dw/image.cc Thu Apr 17 22:14:42 2008 +0200 +++ b/dw/image.cc Mon Apr 21 21:03:51 2008 +0200 @@ -25,12 +25,44 @@ namespace dw { +ImageMapsList::ImageMap::ImageMap () +{ + shapesAndLinks = new container::typed::List <ShapeAndLink> (true); +} + +void ImageMapsList::ImageMap::add (core::Shape *shape, int link) { + ShapeAndLink *shapeAndLink = new ShapeAndLink (); + shapeAndLink->shape = shape; + shapeAndLink->link = link; + shapesAndLinks->append (shapeAndLink); +} + +int ImageMapsList::ImageMap::link (int x, int y) { + container::typed::Iterator <ShapeAndLink> it; + int link = -1; + + for (it = shapesAndLinks->iterator (); it.hasNext (); ) { + ShapeAndLink *shapeAndLink = it.getNext (); + + if (shapeAndLink->shape->isPointWithin (x, y)) { + link = shapeAndLink->link; + break; + } + } + + return link; +} + ImageMapsList::ImageMapsList () { + imageMaps = new container::typed::HashTable <object::Object, ImageMap> + (true, true); + currentMap = NULL; } ImageMapsList::~ImageMapsList () { + delete imageMaps; } /** @@ -42,6 +74,8 @@ ImageMapsList::~ImageMapsList () */ void ImageMapsList::startNewMap (object::Object *key) { + currentMap = new ImageMap (); + imageMaps->put (key, currentMap); } /** @@ -52,6 +86,7 @@ void ImageMapsList::startNewMap (object: */ void ImageMapsList::addShapeToCurrentMap (core::Shape *shape, int link) { + currentMap->add (shape, link); } // ---------------------------------------------------------------------- diff -r 877bbc03146b -r ebc6de688732 dw/image.hh --- a/dw/image.hh Thu Apr 17 22:14:42 2008 +0200 +++ b/dw/image.hh Mon Apr 21 21:03:51 2008 +0200 @@ -22,6 +22,27 @@ namespace dw { */ class ImageMapsList { +private: + class ImageMap: public object::Object { + private: + class ShapeAndLink: public object::Object { + public: + core::Shape *shape; + int link; + }; + + container::typed::List <ShapeAndLink> *shapesAndLinks; + public: + ImageMap (); + ~ImageMap (); + + void add (core::Shape *shape, int link); + int link (int x, int y); + }; + + container::typed::HashTable <object::Object, ImageMap> *imageMaps; + ImageMap *currentMap; + public: ImageMapsList (); ~ImageMapsList ();

3 20

patch: motionNotify and LEAVE
by corvid＠lavabit.com April 30, 2008

April 30, 2008

Since findtext has been in the news lately, I might as well at least provide this bit so that my code behaves better with dialogs.

2 3

[PATCH]: call widget->layout_damage() from FltkWidgetView::allocateFltkWidget
by onepoint＠starurchin.org April 30, 2008

April 30, 2008

This patch makes FltkWidgetView::allocateFltkWidget mark the FLTK widget's layout as damaged. This fixes dw::fltk::ui::FltkListResource (which is necessary to implement MULTIPLE SELECT inputs in forms). Currently a dw::fltk::ui::FltkListResource widget fails to display itself. (You can run test/dw-resource-test to see this). This is because the resource's fltk::MultiBrowser widget is created with a tiny size and later reallocated to the correct size. The viewport calls layout() each time, but this doesn't call widget->layout() unless the widget's layout is damaged. Unfortunately the layout is marked as damaged when the widget is created but *not* after it is resized, so MultiBrowser::layout() gets called when the widget is tiny, but not when it is the right size. Alas, MultiBrowser::draw() uses size information that was cached by MultiBrowser::layout() , so it behaves as though the widget is still tiny, concludes that none of the Items are visible and doesn't draw anything. This bug potentially bites all widgets, it's just sheer luck that only MultiBrowser is visibly affected. Other widgets are either simple enough to survive their layout() being called when they were a different size, or else smart enough to mark *themselves* as damaged so that the viewport calls their layout() at the right time. Regards, Jeremy Henty

2 3

patch: usemap <area shape=default>
by corvid＠lavabit.com April 30, 2008

April 30, 2008

shape=default is the background in a client-side image map.

2 1

Q: lout::Object::Bool ?
by onepoint＠starurchin.org April 30, 2008

April 30, 2008

I'm looking at properly implementing dw::fltk::ui::FltkListResource::isSelected() and I need to maintain a hash of Items to boolean values. However, lout::container::typed::HashTable requires the keys and values to inherit lout::object::Object . I could use lout::object::Integer values, but the really appropriate thing would be lout::object::Bool , which doesn't exist. Is it worth implementing lout::object::Bool or should I just use lout::object::Integer ? Regards, Jeremy Henty

1 0