- Dillo-dev - lists.mailman3.com

patch: clean up a_Html_add_image
by onepoint＠starurchin.org Feb. 8, 2009

Feb. 8, 2009

There is IMHO a nasty code smell around a_Html_add_new_image(): it takes a boolean parameter that determines whether or not it actually adds the image. It's only called from two other places, once with the parameter set to false and once with it set to true. This patch cleans things up by renaming a_Html_add_new_image() to a_Html_image_new(), removing the boolean parameter and making the caller add the image (or not) as appropriate. Perhaps it is a judgement call as to whether this is an improvement, but I feel that it is. Please comment. Regards, Jeremy Henty

4 7

patch: <s> line appearance
by corvid＠lavabit.com Feb. 8, 2009

Feb. 8, 2009

I was thinking that large text with a thin line through it looks odd. Turns out that there was also a problem with <sup> causing the <s> line to be too high. This looks about right to me with the few fonts I have around. I'm attaching an example html file as well. PS Might be good to go through that area of the code one day to see what opportunities there are to make it clearer...

3 4

name/id bug
by corvid＠lavabit.com Feb. 8, 2009

Feb. 8, 2009

<a name="a"></a> <p id="p"></p> <p> <a name="same" id="same"></a> gives HTML warning: line 2, 'id' and 'name' attribute of <a> tag differ HTML warning: line 4, Anchor names must be unique within the document Dillo would seem to be unhappy now that the id attr is checked before open_a checks the name attr -- but then it looks like the move was made in October (a88b4a31cb7a) and I have a dillo around from roughly Dec. 22 that does not have a problem with this. In any case, I don't know whether there are styleEngine issues with just sticking the id check back after the open.

3 11

Rendering XHTML 1.1
by Hole.destructor＠gmx.de Feb. 8, 2009

Feb. 8, 2009

Hello Dillo developers, since you are planing to release Dillo-2.1 in about a month, I am wondering whether there are plans to support XHTML 1.1, HTML 5 and XHTML 2 web pages in the near future? Thanks, Alexander.

2 1

Close-tab Button
by jorl17.8＠gmail.com Feb. 8, 2009

Feb. 8, 2009

S?b, 2009-02-07 ?s 23:38 -0300, Jorge Arellano Cid escreveu: > On Sat, Feb 07, 2009 at 09:57:52PM +0000, Jo?o Ricardo Louren?o wrote: > > S?b, 2009-02-07 ?s 18:33 -0300, Jorge Arellano Cid escreveu: > > > On Fri, Feb 06, 2009 at 05:56:28PM -0300, Jorge Arellano Cid wrote: > > > > On Mon, Feb 02, 2009 at 12:37:18AM +0000, Jo?o Ricardo Louren?o wrote: > > > > > Dom, 2009-02-01 ?s 14:51 -0300, Jorge Arellano Cid escreveu: > > > > > > On Sun, Feb 01, 2009 at 12:06:49AM +0000, Jo?o Ricardo Louren?o wrote: > > > > > > > Greetings to all. > > > > > > > > > > > > > > As a simple introduction may I say I thank you all for your work on > > > > > > > Dillo. > > > > > > > > > > > > > > Currently, I am trying to implement the Close-Tab button. I've been > > > > > > > discussing it with Jorge Arellano Cid and he suggested I 'brought-it' to > > > > > > > dillo-dev. > > > > > > > > > > > > > > FLTK Tabs don't support a close-tab button, as many of you have seen, > > > > > > > and the idea was to have a button at the end of the tabs list. > > > > > > > > > > > > > > For that, I created an fltk::Button widget in CustTabGroup. I position > > > > > > > this widget at the end of the tabs list and, then, I add() it to the > > > > > > > CustTabGroup's parent() (UI). > > > > > > > > > > > > > > After that, I set the UI's resizer() to be an InvisibleBox positioned in > > > > > > > such a way that it doesn't resize the button itself, but only moves it. > > > > > > > > > > > > > > Refreshing the button (when changing/adding/closing tabs) is done in the > > > > > > > handle() method of the CustTabGroup. > > > > > > > > > > > > > > Just a second ago I solved one of the problems, which was the fact that > > > > > > > tab_height() returned 0 in the constructor and resize() didn't work. I > > > > > > > worked around that by constructing the button only in event() if > > > > > > > tab_height()>0 and it hasn't been constructed yet. This way we can use > > > > > > > the correct height for the button. > > > > > > > > > > > > > > It may not seem reliable to do so many things in handle(). Any > > > > > > > suggestions? > > > > > > > > > > > > We need to get something working, review it, and then we may > > > > > > ask in fltk.general whether it could have side effects. > > > > > > > > > > > > > It is functional, only you can say if it fully suits Dillo's needs > > > > > > > though. > > > > > > > > > > > > Please post the patch here so we can look at it. > > > > > > > > > > > > > Unfortunately, there are some problems: > > > > > > > > > > > > > > The first one is the most-relevant one. When the list of tabs grows it > > > > > > > can go over the button. I have been trying to fix this, but I can't seem > > > > > > > to do it. > > > > > > > A possible way could (maybe) be to 'trick' the pager into thinking it > > > > > > > has less space left to draw the tabs, and that could possibly be > > > > > > > achieved using update_positions(), although I am having some problems > > > > > > > with that. > > > > > > > > > > > > Or maybe just tweaking the value. After all it's a workaround. > > > > > > > > > > > > > The second problem is a minor one, but annoying. I believe when CSS > > > > > > > rendering is triggered, the render area flickers and that is normal. > > > > > > > However, the way I implemented this (probably because of it being in > > > > > > > handle()) makes the Button also flash. > > > > > > > > > > > > A side affect of being a child of UI. > > > > > > > > > > > > > > > > So, as requested, here is what I have got until now. There is a > > > > > particular line I think is not necessary, I commented that specifically. > > > > > > > > I'm reviewing it now. > > > > > > Well, the good part is that it works and can be polished a bit. > > > The problem is side effects (e.g. redraw storms while moving the mouse > > > over the panel buttons, and who knows what else?). > > > > > > I tried a different approach and it almost worked OK, but after > > > resizing the window, the redraw storms are on the whole window. > > > > > > Frustrating... > > > > > > It looks like drawing the button in the pager could work. I'll > > > try to write some code this way. > > > > > > > Thanks. Redraw storms are visible when running it under valgrind. Also, > > parts of the code there were/are unnecessary. For instance, we could > > send the redraw() message only when adding a new tab and not > > continuously, but the redraw storms continue either way... > > > > Adding it to the pager seems the way to go there, but will you add it as > > a button, or a custom drawn widget? > > > > If you need any help, do say, I'll try to do my best, > > Attached goes a patch that behaves nicely. > Please polish it to a final state. It is commented. > > The button drawing code lacks the "X", the callback is not hooked, > and there's no tooltip, but it doesn't trigger redraw storms, > and feels right. > > Good luck! OK, I've already implemented update_positions() to prevent tabs from going over the button (grabbed it from FLTK and altered it). I don't think there is the need for a callback function, since it only calls a simple line. I've noticed that we have no checking if the button is visible or not, so it is working even though there are no tabs, I'll add a check for that in event() rather than in other places. Thanks, Jo?o

1 0

[patch]: fix leak in a_Cookies_get_query()
by onepoint＠starurchin.org Feb. 6, 2009

Feb. 6, 2009

This patch stops a_Cookies_get_query() leaking. However, I'm a little puzzled by the logic here. Why does a_Cookies_get_query() return a "Cookies2" header even if the cookies DPI returns nothing? Can't it just return NULL or an empty string? Wouldn't that be cleaner? Regards, Jeremy Henty

3 3

Re: view stylesheets from page menu
by Johannes.Hofmann＠gmx.de Feb. 6, 2009

Feb. 6, 2009

On Thu, Feb 05, 2009 at 08:19:03AM -0300, Jorge Arellano Cid wrote: > On Tue, Feb 03, 2009 at 08:00:12PM +0100, Hofmann Johannes wrote: > > Hi corvid, > > > > On Tue, Feb 03, 2009 at 05:13:27PM +0000, corvid wrote: > > > > > > (a rough quick patch just to get feedback) > > > I saw that Jorge added cssUrls, which provided an opportunity... > > > > Very nice! Just one small thing. The stylesheets entry does not get > > disabled on non-CSS pages here. Extending the check like this: > > > > + if (cssUrls && cssUrls->size () > 0) { > > > > helps. > > To me: It looks more like a developers feature than one for user level. Well, not more than "View page source". I think it's important and in the spirit of dillo to make the web as transparent for the user as possible. > > > > BTW: Viewing stylesheets in a normal browser window is really fast > > compared to the fltk text viewer we use for "View page source"! > > Yes, since a long time I've wanted to find some time to turn > "View page source" into a dpi. > > Maybe after the close-tab button I can give it a hand. > Yes, that would be great. Cheers, Johannes > -- > Cheers > Jorge.-

3 2

RE: Free HG performance
by CHalbersma.12＠westminster-mo.edu Feb. 6, 2009

Feb. 6, 2009

Souceforge always seemed pretty good at hosting open souce projects. Of course I could be wrong there. Christopher "Chewy" R. Halbersma

2 1

FreeHG performance
by onepoint＠starurchin.org Feb. 5, 2009

Feb. 5, 2009

Am I the only one getting very poor performance from FreeHG ? Quite often I get a 404 Not Found and right now it's hanging. Everyone confirms that Mercurial itself is really fast and I've seen other reports criticising FreeHG's performance. Perhaps we should think about moving host? It's not always easy to find time to devote to Dillo so it's rather aggravating when that time is wasted just waiting for a connection to the server. I'm committed enough to grit my teeth and wait but I can see it putting off would-be contributors. Just a thought, Jeremy Henty

5 14

Bad character coding for www.blisty.cz
by newman.x＠gmail.com Feb. 3, 2009

Feb. 3, 2009

Hi, I am affraid there ocurred regression in post-dillo-2.0 when compared to dillo-2.0. Look on the www.blisty.cz web page, on the top there's following sence (it's in Czech) "?t?te Britsk? listy speci?ln? upraven? pro va?e mobiln? telefony a PDA" but in current hg tip it's displayed as "?t?te Britsk? listy speci?ln? upraven? pro va?e mobiln? telefony a PDA" and of course, the whole page is displayed like in ISO-8859-1 coding. I noticed this first when the character coding code in post-dillo-2.0 was changed. When the page is saved to disk and opened it works as expected. It appeared that it is somehow related to default dillorc. 1) remove the ~/.dillo directory 2) dillo www.blisty.cz 3) --> PASS 4) quit dillo 5) dillo www.blisty.cz 6) --> FAIL Can anyone, please, have a look at this and say whether is it reproducible and, perhaps, fix it? :) Thanks, -- Regards, Michal Nowak

4 10

[patch]: fix signature of Html_add_new_linkimage()
by onepoint＠starurchin.org Feb. 2, 2009

Feb. 2, 2009

A small cleanup patch. * The return value of Html_add_new_linkimage() is never used, so it should return void. * There's no need to pass the url to Html_add_new_linkimage() as a (DilloUrl **), so just copy the (DilloUrl *) pointer. Regards, Jeremy Henty

2 2

Address Bar Text Clears
by crazycal00＠gmail.com Feb. 2, 2009

Feb. 2, 2009

Hi, Found kind of a bug but dunno if it really counts as one so i figured i'd run it past the mailing list first. open up a website, make sure to pick one that loads slowly and to type it in the address bar. as it's loading open up a new tab, now click back. the URL in the address bar field is empty. just thought i'd share. Calvin

3 3

FIELDSET element
by jcid＠dillo.org Feb. 1, 2009

Feb. 1, 2009

Hi, Now that we have align in CSS, it may be easy to add support for the FIELDSET element: http://www.w3.org/TR/html401/interact/forms.html#h-17.10 -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

1 1

What's left to do for dillo-2.1?
by onepoint＠starurchin.org Feb. 1, 2009

Feb. 1, 2009

I get the feeling we are close to releasing dillo-2.1. Do others agree? What's left to be done? Regards, Jeremy Henty

4 11

[Patch]: [v2]: fix URL leak in Html_tag_open_link()
by onepoint＠starurchin.org Feb. 1, 2009

Feb. 1, 2009

OK, I'm fairly sure this version is not as utterly broken as the previous one. :-) BTW, does a_Html_tag_open_link() really need to check the stylesheets preference twice? Jeremy Henty

3 3

Refactored prefs.c to a much smaller size!
by Johannes.Hofmann＠gmx.de Feb. 1, 2009

Feb. 1, 2009

Excellent!

1 0

patch: 30x response without Location == segfault
by corvid＠lavabit.com Feb. 1, 2009

Feb. 1, 2009

(new bug #886) The submitter got a 300 Multiple Choices without a Location header. from the RFC, If the server has a preferred choice of representation, it SHOULD include the specific URI for that representation in the Location field; user agents MAY use the Location field value for automatic redirection. and Unless it was a HEAD request, the response SHOULD include an entity containing a list of resource characteristics and location(s) from which the user or user agent can choose the one most appropriate. In this case, http://www.weather.gov/data/current_obs/PAFC.xml had no Location, and does have a body consisting of an HTML page giving alternatives. PS I think it might become more common for users to encounter Multiple Choices now that there's a pref for Accept-Language.

2 1

Re: unused parameter warning in http.c
by jcid＠dillo.org Feb. 1, 2009

Feb. 1, 2009

On Sat, Jan 31, 2009 at 10:09:28PM +0000, corvid wrote: > surprised me until I remembered that you turned on -W. > I didn't realize that plain C doesn't allow the name > to be left off in those cases. > > What is the usual trick for this? The manpage talks > about an 'unused' attribute, but that sounds like a gcc-ism. In the past, for C, I've used these couple: 1.- Add a dummy test for the unused var. 2.- Remove the parameter from the function and cast it to match. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

1 0

[Patch]: fix URL leak in Html_tag_open_link()
by onepoint＠starurchin.org Feb. 1, 2009

Feb. 1, 2009

If Html_tag_open_link() gets a link that it decides not to use because of the media attribute, it returns without freeing the URL object it just created. The fix is to postpone creating the URL until after all the checks that might cause the function to return. Patch and test case attached. Regards, Jeremy Henty

1 1

CSS branch merged!
by jcid＠dillo.org Jan. 31, 2009

Jan. 31, 2009

Hi there, The CSS branch was merged back into main! It has been stabilized and we can continue working from this basis towards our next release. I want to thank all of you involved in helping this happen. Having basic CSS support merged in, is quite an achievement! :-) -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

6 29

Window icon
by jcid＠dillo.org Jan. 31, 2009

Jan. 31, 2009

Hi, Does anyone feel like hooking the small dillo icon to its window? http://fltk.org/newsgroups.php?s18335+gfltk.general+v18348+T1 -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

1 0

Re: Dillo Source code
by jcid＠dillo.org Jan. 31, 2009

Jan. 31, 2009

Hi Jo?o, On Fri, Jan 30, 2009 at 09:38:18PM +0000, Jo?o Ricardo Louren?o wrote: > > > > I have never worked with tabs in FLTK, but I've been browsing the > > > documentation and have been trying to understand them. As for the > > > button, I've nearly got it, the only problem is finding a way to prevent > > > tabs from going over the button and that doesn't seem to be happening. > > > An alternative would be to have the button in the 'tool-bar' or limit > > > the number of tabs (doesn't seem nice right?). I'm trying to figure out > > > pagers to set some kind of limit... > > > > The button outside the tab-labels area would be confusing... > > > > > One other problem seems to be the fact that the button keeps resizing, > > > that's probably bad FLTK coding on my side, let's hope I can figure it > > > out. > > > > FLTK-2.0 widgets have a handle() method that handles events. > > They also have a draw() method that draws the widget. My first > > idea was to draw the button in the draw() method of the pager, > > and to hook its functionality in the handle() method. > > This is the way I'd explore. > > > > The canonical way would be to try to add a child button widget > > in the pager. It may not be possible though. > > Yes, I did try to think of adding a button widget in the pager, though > digging with the pager itself is quite a mess I'm trying to work out. > For now, I'm trying to move my hackish code into CustTabGroup and the > problem is that I can't seem to get the tab height... > > What I am doing (for now, which still suffers from the resizing bug, > since I did not touch pagers) is adding an fltk::Button, positioning it > correctly and making it visible. In order to have it visible I add() it > to the parent of a CustTabGroup instance (a UI, I believe), and this UI > is the one that resizes it, I should figure out a way of preventing > that. Is there another way of making it visible, not having it resize? > It's something I never dug before. I don't know why it is resizing. FLTK2 widgets need an explicit resize() call to enable it. Although there're exceptions. If you add it with a fixed size int the UI that should be it. > Adding a child button widget in the pager seems difficult in the 'real' > meaning of the word 'add'. As a pager isn't a group that seems > difficult, unless I do not use a widget but draw() it myself and then > handle() it correctly. Yes, the second option is where I'd start. There's the fltk.general forum for question like this: http://fltk.org/newsgroups.php?gfltk.general+T I haven't tried there yet and it would be interseting to know their advice. > > On to another issue. > > > > Browsing the code I noticed: > // WORKAROUND: limit the number of tabs because of a fltk bug > if (ui->tabs()->children() >= 127) > > And, then, browsing the FLTK code I found: > > static int p[128]; > ... > void TabGroup::draw() { > ... > int w[128]; > ... //code using w and p... > > I guess the problem is p being limited to 128...Probably fixing this > issue has been discussed earlier, but a hipothesis would be overriding > Fltk's code for TabGroup, anyway, that doesn't seem nice. Maybe we could > ask the FLTK people to change it, if they agreed with it. Having more > than 127 tabs open seems impossible but we never know. FLTK2 is beong stalled for some time now. The team is focused on the 1.3.x branch. I wouldn't expect a patch unless we send it to them. At some point in the future we may be switching to 1.3.x. (they seem to want to develop a compatibility layer for FLTK-2.0, so ATM it's better to wait). I'd focus on the close-tab issue. ;) -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

1 0

Still leaking CSS values
by onepoint＠starurchin.org Jan. 30, 2009

Jan. 30, 2009

The "0123456789" value in the stylesheet leaks. Test case and valgrind log attached. Regards, Jeremy Henty

2 2

<ol>'s leak the labels of their items
by onepoint＠starurchin.org Jan. 29, 2009

Jan. 29, 2009

Valgrind reports that <ol>s leak the labels of their items: each of the first 9 <li>s leaks 3 bytes, then they leak 4 bytes per <li> etc. The leaked memory is created by the line list_item->initWithText (dStrdup(buf), wordStyle); in Html_tag_open_li (in src/html.cc). The dStrdup()ed memory is never freed. I think that the problem is that the TextBlock destructor only deletes the content of a word if the content type is WIDGET or ANCHOR, whereas it should also handle the case when the content type is TEXT. Perhaps initWithText() should copy the string argument itself with new[] so that ~TextBlock could safely delete[] it? The only two references to initWithText() are in html.cc and one of the widget tests, so this would be an easy change. Regards, Jeremy Henty

3 20

dw::Image objects leak their mapKey
by onepoint＠starurchin.org Jan. 29, 2009

Jan. 29, 2009

This shows up under valgrind as a leak when the HTML includes an <img usemap="...">. Patch attached. Regards, Jeremy Henty

2 3

Tools button committed
by jcid＠dillo.org Jan. 27, 2009

Jan. 27, 2009

Hi, The tools button changeset was just committed. Please notice the options are global. It's quite useful as is and making per bw options seems not worth. Go check! :-) -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

2 2

Re: new font preferences
by Johannes.Hofmann＠gmx.de Jan. 26, 2009

Jan. 26, 2009

On Mon, Jan 26, 2009 at 04:58:55PM -0300, Jorge Arellano Cid wrote: > On Mon, Jan 26, 2009 at 07:14:08PM +0100, Hofmann Johannes wrote: > > Hi Jorge, > > > > do you have an opinion on the (incompatible) changes to the font > > preferences as proposed in > > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-January/005746.html > > > > I'd like to commit this if you agree. > > Oh yes, feel free to commit. Committed. > Just let dillo-dev know how to upgrade our custom dillorc! :-) > > At this point you're the most knowledgeable in font handling and > CSS, thus some basic explanation of settings/usage would be welcomed too. >From the checking comment: CSS 2.1 uses the following predefined font names: 'serif', 'sans-serif', 'cursive', 'fantasy', 'monospace'. Add preferences so that the user can set real font names for these. Basically the new "font_sans_serif" option is what "vw_fontame" used to be and "font_monospace" is equivalent to "fw_fontname". The other two options are new. http://www.w3.org/TR/CSS21/fonts.html#generic-font-families has some more information including font examples. Cheers, Johannes

1 0

dillo CSS and charset
by furaisanjin＠gmail.com Jan. 26, 2009

Jan. 26, 2009

Hi all. I created new subject thread since the original one becomes quite long and. I found one difference between dillo-2.0 and dillo-css. there was a_Decode_charset_init calling at Cache_parse_header in cache.c when HTTP server Content-Type was detected but there isn't this in dillo-css. Because if HTTP server Content-Type is same as META content-type, there isn't any chance to call a_Decode_charset_init. This is one reason why the page is drawn properly. I still don't figure out another timing issue yet. Regards, furaisanjin

4 31

Character entity parsing regression.
by jcid＠dillo.org Jan. 26, 2009

Jan. 26, 2009

Hi, There's a regression with the attached page. Squared boxes appear where nothing should be. I haven't dug since when. Can somebody please give it a look while I work on the tools button? TIA. -- Cheers Jorge.-

2 2

CSS parser leak
by onepoint＠starurchin.org Jan. 26, 2009

Jan. 26, 2009

Valgrind log attached. Jeremy Henty

2 5

switch to DILLO_HTML_PARSE_MODE_PRE depending on style
by Johannes.Hofmann＠gmx.de Jan. 26, 2009

Jan. 26, 2009

Hi, I'm experimenting with attached patch to make switching to DILLO_HTML_PARSE_MODE_PRE from CSS possible. Some online source browsers like cgit (http://hjemli.net/git/cgit/) use this to display sources or diffs. Please comment. Cheers, Johannes

2 2

inheriting background color
by corvid＠lavabit.com Jan. 24, 2009

Jan. 24, 2009

Is the idea that we should stick in inheritBackgroundColor whenever we encounter cases like the following? (I see the "get rid of this somehow" comment.) <head> <title></title> <style type="text/css"> body {background: #000000; color: #00ff00} </style> </head> <body> <SPAN STYLE='background:#fff6aa;'>link background dark( <SMALL><A HREF="/">link</A></SMALL> )</SPAN> <p> <SPAN STYLE='background:#fff6aa;'>link background light( <A HREF="/">link</A>) </SPAN> </body>

2 1

Valgrind errors: big improvement!
by onepoint＠starurchin.org Jan. 24, 2009

Jan. 24, 2009

The very latest dillo is vastly more valgrind-clean than before: I got no errors from my latest browsing session! I'll keep monitoring it and look at the leak reports too. Regards, Jeremy Henty

2 1

Valgrind errors
by onepoint＠starurchin.org Jan. 24, 2009

Jan. 24, 2009

I've been valgrinding Dillo to see what I find and this one keeps turning up. Some memory is accessed that was freed by a_Cache_set_content_type(). Regards, Jeremy Henty

4 8

Valgrind error: possible link to Imgbuf crash?
by onepoint＠starurchin.org Jan. 23, 2009

Jan. 23, 2009

Here's another valgrind error that I think might be related to the crashes I have been seeing. The gdb stack trace showed that a_Imgbuf_new() was calling a layout method with an invalid address for the layout object. The valgrind error shows a_Imgbuf_new() reading invalid memory when it calls Widget::getLayout(). It looks to me as though a_Imgbuf_new() is being passed an Image that has already been freed. Regards, Jeremy Henty

1 0

[patch]: control lout's MSG from the preferences
by onepoint＠starurchin.org Jan. 23, 2009

Jan. 23, 2009

This patch makes the dillorc show_msg preference control lout's MSG macros as well as dillo's. Please comment. Regards, Jeremy Henty

2 1

[patch]: fix DBG build of table.cc
by onepoint＠starurchin.org Jan. 22, 2009

Jan. 22, 2009

If you uncomment the #define of DBG in table.cc it won't compile. It looks as though most of the DBG code was fixed not to use the non-existent "result" variable, but one instance was left unchanged. Patch attached. Regards, Jeremy Henty

2 1

Crashes in dw::core::Layout::createImgbuf()
by onepoint＠starurchin.org Jan. 22, 2009

Jan. 22, 2009

For the last few days I have been getting occasional crashes inside dw::core::Layout::createImgbuf() when opening a new tab. It does not seem to be predictable: if I restart Dillo and reopen all the URLs I was just looking at it is fine. The gdb backtrace often shows ridiculous values for this: eg. the attached example has this=0x6. I've seen other impossibly small values for this, but sometimes the value seems more sensible. Any ideas? I'd like to investigate further but I don't know what to look for. Pointers are welcome! Regards, Jeremy Henty

2 2

[bug]: hang in Css_parse_delaration()
by onepoint＠starurchin.org Jan. 22, 2009

Jan. 22, 2009

A simple example that hangs the CSS parser. The contents of the css block are the critical thing: it doesn't seem to matter what the selector is but changing either the parameter or the value inside the block stops the hang. After aborting the stack trace varies, but always seems to be inside Css_parse_declaration(). (I've attached some example stacks.) The real-world page that triggered the bug: http://dialinf.wordpress.com/2009/01/21/ultraproducts-the-category-theoreti… Regards, Jeremy Henty

2 2

[bug]: hang in Css_parse_declaration()
by onepoint＠starurchin.org Jan. 19, 2009

Jan. 19, 2009

The following HTML makes dillo hang and burn 100% CPU. <html> <body> <span style="{}">a</span> </body> </html> The bug does not appear if the span contains no text, or only whitespace. The stack trace always ends inside Css_parse_declaration(). The line number varies, but seems to be always one of 809, 823 or 963. You can see the same bug online at http://www.nation.co.ke/News/-/1056/515354/-/u1acuw/-/index.html Regards, Jeremy Henty

2 2

Re: A couple of patches
by jcid＠dillo.org Jan. 19, 2009

Jan. 19, 2009

Hi Johannes, On Thu, Jan 15, 2009 at 10:07:37AM +0100, Hofmann Johannes wrote: > Hi Jorge, > > On Wed, Jan 14, 2009 at 07:07:00PM -0300, Jorge Arellano Cid wrote: > > Hi Johannes, > > > > Here go couple of patches. Please test and apply. > > Thanks, applied. > > > > > Note: the image background support is partial. It works well > > when coming back to a page. AFAIS the right solution is to decode > > transparent images to RGBA and let FLTK handle it. > > Yes, I think that would be the correct way to do it. > > > > > BTW, the CSS prototype seems stable enough to consider a merge. > > What do you think? > > Yes, it feels pretty stable and now that there is an option to > disable remote stylesheet loading, I think we can consider making > css-prototype the main branch of dillo. > However I'd like to have some issues fixed: > > * should load_stylesheets=NO only disable remote style-sheet loading > (as it does now), or should it disable all remote style processing > (e.g. style given in <style type="text/css"> </style>)? We can add a "parse_embedded_css" option. That way there's no ambiguity. My next task is to add the toolbox button mentioned in: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-December/005531.html It may hold CSS options akin to: [Tb Icon] .-------------------. .---------. | Change charset >|--------------------------------->| UTF-8 | | CSS >|-->.---------------. | Cp 1250 | | Free memory >|-. |* remote CSS | | ... | '-------------------' | |* embedded CSS | '---------' | |* use my CSS | | |* no CSS at all| | '---------------' | .------------------. '->| Images | | Local Files | | Everything unused | '-------------------' Note: '*' means a toggle option Note2: "use my CSS" replaces "Force my colors" We can polish from there. > * form.cc is not yet converted to the new style handling and widget > coloring is broken. OK. > * css-prototype displays e.g. table borders in the current color not > in shaded background-color as dillo-main does. > This is because CSS 2.1 states: > "If an element's border color is not specified with a border > property, user agents must use the value of the element's 'color' > property as the computed value for the border color. " > (http://www.w3.org/TR/CSS21/box.html#border-color-properties) > firefox however also uses a shaded background color. > I'd don't know how to deal with that at the moment. I'd say leave it as the standard says until it becomes an issue. In that case we can follow FF or decide better. > Then there is of course tons of issues with CSS, but we can improve > on that gradually. That's the idea. BTW, I have a question. How can a minimal font size be specified? Currently I have: body {font-size: 18px !important} in style.css, but often pages come with smaller fonts. e.g. http://www.linux.org.uk/Portaloo.cs For me is important because I have a problems reading tiny fonts, and my working laptop has a high screen resolution. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

3 4

CSS branch merged!
by furaisanjin＠gmail.com Jan. 18, 2009

Jan. 18, 2009

Sorry, I didn't sent e-mail to mailing list. 2009/1/18 furaisanjin <furaisanjin(a)gmail.com>: > Hi all. > > 2009/1/18 Hofmann Johannes <Johannes.Hofmann(a)gmx.de>: >> On Sat, Jan 17, 2009 at 11:51:37PM +0900, furaisanjin wrote: >>> Sorry, I mixed up 2 things. I guess default font is something I >>> specified in ~/.dillo/style.css if dillo can't find any fonts >>> specified in style. It seems that there is some timing issue when the >>> page is loaded. The first time somehow the page is unreadable but if I >>> goto to bookmark page and come back to the page, the page is readable. >> >> Argh, timing issues are bad. Can you please point me to a page where >> this happens? > > It seems that there are lots. I notice that Html_tag_open_meta doesn't > repush when charset is detected anymore. So I modified codes like > this. > > /* Cannot ask cache whether the content type was changed, as > * this code in another bw might have already changed it for us. > */ > if (a_Misc_content_type_cmp(html->content_type, new_content)) { > + a_Nav_repush(html->bw); > + html->stop_parser = true; > html->repush_after_head = true; > } > > This helps. I may not need to keep html->repush_after_head = true but > I'm not sure. I was wrong. This doesn't help all cases. The problem seems that when the page is repushed, somehow decoder_charset isn't called so that charset conversion doesn't happens. >>> Another issue is that if style sheet specified none Japanese font and >>> the font exists on my machine, then of course the page isn't readable >>> at all. This isn't dillo problem but style sheet problem. >> >> Do you have an example? How does firefox handle these pages? > > This (http://furaisanjin.blog.so-net.ne.jp) is one example. Firefox > shows something like this > (http://furaisanjin.blog.so-net.ne.jp/_images/blog/_9f7/furaisanjin/firefox.…) > and this is readable. However dillo shows something like this > (http://furaisanjin.blog.so-net.ne.jp/_images/blog/_9f7/furaisanjin/dillo.png) > and I can see only dotted squares. > > Style sheet page contains > > #banner h1{ > margin:0; > padding:80px 0 0 14px; > font-size:36px; > font-family: Helvetica; > } > > and Helvetica isn't suitable for Japanese. Regards, furaisanjin

1 0

CSS branch merged!
by Johannes.Hofmann＠gmx.de Jan. 17, 2009

Jan. 17, 2009

On Sat, Jan 17, 2009 at 11:51:37PM +0900, furaisanjin wrote: > Sorry, I mixed up 2 things. I guess default font is something I > specified in ~/.dillo/style.css if dillo can't find any fonts > specified in style. It seems that there is some timing issue when the > page is loaded. The first time somehow the page is unreadable but if I > goto to bookmark page and come back to the page, the page is readable. Argh, timing issues are bad. Can you please point me to a page where this happens? > > Another issue is that if style sheet specified none Japanese font and > the font exists on my machine, then of course the page isn't readable > at all. This isn't dillo problem but style sheet problem. Do you have an example? How does firefox handle these pages? Regards, Johannes

1 0

CSS branch merged!
by Johannes.Hofmann＠gmx.de Jan. 17, 2009

Jan. 17, 2009

On Sat, Jan 17, 2009 at 11:04:12PM +0900, furaisanjin wrote: > 2009/1/17 Hofmann Johannes <Johannes.Hofmann(a)gmx.de>: > > In this case dillo should try the three fonts given. At least > > "monospace" should exist and be mapped to some default monospace > > font. > > I don't have such font which name is "monospace" on my machine. > fc-list command doesn't show such name. What is the default mono space > font in the current CSS implementation? None. That part is not yet implemented. > > Because some pages written in Japanese contain fonts that I don't have > at all, I can't read such pages. See my answer to Jorge's mail on how to force a fixed font-family. Regards, Johannes

1 0

[patch]: add copyright and license declarations to dpid sources
by onepoint＠starurchin.org Jan. 17, 2009

Jan. 17, 2009

I checked all the *.{c,cc} files and found that a couple of the dpid/ files were missing copyrights too. Patch attached. Regards, Jeremy Henty

2 1

[patch]: add copyright and license declaration to cssparser.cc
by onepoint＠starurchin.org Jan. 17, 2009

Jan. 17, 2009

There's no copyright or license in cssparser.cc . Patch attached. Regards, Jeremy Henty

2 2

Re: patch: some consts
by Johannes.Hofmann＠gmx.de Jan. 17, 2009

Jan. 17, 2009

On Sat, Jan 17, 2009 at 01:09:12AM +0000, corvid wrote: > (and an unrelated static) > It was time for my occasional running of nm... > committed! Thanks, Johannes

1 0

focus after closing tab
by Johannes.Hofmann＠gmx.de Jan. 15, 2009

Jan. 15, 2009

Hi, sometimes when closing a tab it feels that dillo focuses the "wrong" tab. Therefore I made a patch that puts the focus back to the tab from which a tab was opened. That way I always get back to the "base page" when closing a tab. Howerver I'm not sure that this is always right, e.g. when opening multiple tabs from one base page, one might want to read one after the other without going back to the base page. What do you think, which page should be focused when closing a tab: * the tab from which the closed one was opened? * the tab to the left of the closed one? * the most recently opened one? Cheers, Johannes

3 4

Re: focus after closing tab
by sandshrew＠gmail.com Jan. 15, 2009

Jan. 15, 2009

I would vote for "the most recently opened one" too. -- Brain: an apparatus with which we think we think. - A. Bierce

1 0

CSS speed
by Johannes.Hofmann＠gmx.de Jan. 15, 2009

Jan. 15, 2009

Hi, pages with complex CSS feel a bit slow with the current css-prototype and gprof shows a huge number of CssSelector::match() calls. Attached is a patch that tries to improve that by: * putting CssSelectors into hashtables so that we only need to match against a small subset of CssSelectors. * avoiding repeated matches of CssSimpleSelectors against the same part of the doctree. Please test and report if there is a real world speedup. Cheers, Johannes

2 4