[patch]: fix signature of Html_add_new_linkimage()
A small cleanup patch. * The return value of Html_add_new_linkimage() is never used, so it should return void. * There's no need to pass the url to Html_add_new_linkimage() as a (DilloUrl **), so just copy the (DilloUrl *) pointer. Regards, Jeremy Henty
On Sun, Feb 01, 2009 at 08:45:06PM +0000, Jeremy Henty wrote:
A small cleanup patch.
* The return value of Html_add_new_linkimage() is never used, so it should return void.
Committed this part.
* There's no need to pass the url to Html_add_new_linkimage() as a (DilloUrl **), so just copy the (DilloUrl *) pointer.
It's used to emphasize the url parameter changes owner. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________
On Sun, Feb 01, 2009 at 08:56:41PM -0300, Jorge Arellano Cid wrote:
On Sun, Feb 01, 2009 at 08:45:06PM +0000, Jeremy Henty wrote:
* There's no need to pass the url to Html_add_new_linkimage() as a (DilloUrl **), so just copy the (DilloUrl *) pointer.
It's used to emphasize the url parameter changes owner.
Fair enough, but it didn't convey that to me at all. It just looked obviously wrong. I wonder if a comment would make the point better. Just a thought. Regards, Jeremy Henty
participants (2)
-
jcid＠dillo.org -
onepoint＠starurchin.org