- Dillo-dev - lists.mailman3.com

Patch to allow setting of initial position
by Jan Dittmer Dec. 3, 2003

Dec. 3, 2003

Hi, for a TV Terminal I needed dillo to come up at a different position than 0,0. As there is no window manager running I wrote a small patch which allows to set the initial position of the upper left corner. Essentially it just clones the geometry code and adds a config option position=<xpos>x<ypos>. If it is not set or 0x0 specified it just takes it's default position. Perhaps this is of some use to anyone else. (Patch is against 0.7.3) Thanks, Jan diff -u org/src/dillo.c jan/src/dillo.c --- org/src/dillo.c Tue Jul 22 22:51:22 2003 +++ jan/src/dillo.c Fri Nov 28 14:34:35 2003 @@ -268,6 +268,8 @@ /* a_Nav_init() has been moved into this call because it needs to be * initialized with the new browser_window structure */ bw = a_Interface_browser_window_new(prefs.width, prefs.height, xid); + if ((prefs.xpos + prefs.ypos) > 0) + gtk_widget_set_uposition(bw->main_window, prefs.xpos, prefs.ypos); a_Bookmarks_init(); diff -u org/src/prefs.c jan/src/prefs.c --- org/src/prefs.c Mon Jul 7 17:40:15 2003 +++ jan/src/prefs.c Fri Nov 28 14:39:21 2003 @@ -35,6 +35,7 @@ guint token; } symbols[] = { { "geometry", DRC_TOKEN_GEOMETRY }, + { "position", DRC_TOKEN_POSITION }, { "http_proxy", DRC_TOKEN_PROXY }, { "no_proxy", DRC_TOKEN_NOPROXY }, { "link_color", DRC_TOKEN_LINK_COLOR }, @@ -114,6 +115,18 @@ } } break; + case DRC_TOKEN_POSITION: { + gchar *ptr, *str = scanner->value.v_string; + gint xpos, ypos; + + if ( (ptr = strchr(str, 'x')) && (xpos = strtol(str,NULL,10)) && + (ypos = strtol(++ptr,NULL,10)) ){ + prefs.xpos = xpos; + prefs.ypos = ypos; + } + } + break; + case DRC_TOKEN_PROXY: a_Url_free(prefs.http_proxy); prefs.http_proxy = a_Url_new(scanner->value.v_string, NULL, 0, 0); @@ -329,6 +342,8 @@ prefs.width = D_GEOMETRY_DEFAULT_WIDTH; prefs.height = D_GEOMETRY_DEFAULT_HEIGHT; + prefs.xpos = D_GEOMETRY_DEFAULT_XPOS; + prefs.ypos = D_GEOMETRY_DEFAULT_YPOS; prefs.http_proxy = NULL; prefs.no_proxy = NULL; prefs.no_proxy_vec = NULL; diff -u org/src/prefs.h jan/src/prefs.h --- org/src/prefs.h Thu Jul 10 00:00:34 2003 +++ jan/src/prefs.h Fri Nov 28 14:37:17 2003 @@ -10,6 +10,8 @@ #define DILLO_HOME "http://www.dillo.org/" #define D_GEOMETRY_DEFAULT_WIDTH 640 #define D_GEOMETRY_DEFAULT_HEIGHT 550 +#define D_GEOMETRY_DEFAULT_XPOS 0 +#define D_GEOMETRY_DEFAULT_YPOS 0 #define DW_COLOR_DEFAULT_GREY 0xd6d6d6 #define DW_COLOR_DEFAULT_BLACK 0x000000 @@ -27,6 +29,7 @@ typedef enum { DRC_TOKEN_FIRST = G_TOKEN_LAST, DRC_TOKEN_GEOMETRY, + DRC_TOKEN_POSITION, DRC_TOKEN_PROXY, DRC_TOKEN_NOPROXY, DRC_TOKEN_LINK_COLOR, @@ -70,6 +73,8 @@ struct _DilloPrefs { gint width; gint height; + gint xpos; + gint ypos; DilloUrl *http_proxy; gchar *no_proxy; gchar **no_proxy_vec;

3 5

[ANNOUNCEMENT] Dillo-Patches mailing list
by Paul Pelzl Dec. 3, 2003

Dec. 3, 2003

The recent "Official Statement" from the core Dillo developers contained this item: > We strongly urge the "code modifiers" to find their own mailing list > for discussing their "code modification" ideas In response, I would like to announce the dillo-patches mailing list. This list will provide a place for both users and developers to discuss extensive modifications of the Dillo sources, which are beyond the scope of the Dillo Project itself. If you are interested in some of the significant feature-enhancement patches that have been posted on dillo-dev recently, then I hope you will subscribe to dillo-patches. - You can subscribe to the list by sending email to dillo-patches-request(a)freelists.org with 'subscribe' in the Subject field OR by logging into the Web interface at www.freelists.org. - To post on the mailing list, send email to dillo-patches(a)freelists.org . Only subscribers may post to the list. - There is a Dillo-Patches website available at http://www.freelists.org/webpage/dillo-patches . It has some information about the list, has links to the archives, and will guide people in finding patches. I hope that this list will help to resolve some of the recent difficulties on dillo-dev. Jorge (or whoever has web access): It would be helpful to provide a link to http://www.freelists.org/webpage/dillo-patches somewhere on the Dillo website. Paul

1 0

Official Statement
by Sebastian Geerken Dec. 1, 2003

Dec. 1, 2003

Hi! This is an official statement about Dillo project's management, by the Dillo core team (mainly core and steady developers). About project management: ------------------------- There's an interesting difference between a: "code contribution" and a "code modification". The Dillo project, as a SW project, is not simply its code base. Among others, it has a core team that defines the development plans, policies, time frames, and technical details. If a "patch" happens to be aligned with the goals and technical guidelines defined by the core team, it's regarded as a "code contribution". If it doesn't follow them, or clearly infringes them, it is a "code modification". A "code modification" doesn't belong to the project, and must be hosted and supported elsewhere. Obviously, the code modification author can try to convince the core team of the idea (with reasonable arguments, not rants nor pejorative sentences, according to our mailing list etiquette). The final decision is up to Dillo's core team, and if the patch continues to be regarded as a "code modification" it must be hosted, discussed and supported elsewhere. About the dillo-dev mailing list: --------------------------------- dillo-dev is not the standard discussion forum of the web. It has an outstanding tradition of polite and respectful communication. dillo-dev is being flooded with rude emails from "code modifiers" that not only disregard the mailing list guidelines, but also refer to the core team's work in pejorative terms. This creates a very unfriendly atmosphere which has been severely detrimental to the continued development of Dillo. This situation has led some members of the team to communicate directly with each other. This is very bad because it has resulted in a lot of messages unrelated to the project which confuse subscribers about the current direction of Dillo development. Messages which are outside the bounds defined in the guidelines at http://www.dillo.org/MList.html are ignored and will remain unanswered. We strongly urge the "code modifiers" to find their own mailing list for discussing their "code modification" ideas, and to stop violating our mailing list etiquette. Please do not post any replies to this statement on dillo-dev. If any comments about this statement are posted to dillo-dev we urge all our subscribers not to follow the thread. Sincerely, Dillo core team.

1 0

How do you un-subscribe to this list
by Ronald W. Henderson Nov. 30, 2003

Nov. 30, 2003

Folks: I looked on this site and do not know how to un-subscribe to this list. Thanks in advance...

3 2

[patch] Cleanup of IO.c
by Indan Zupancic Nov. 29, 2003

Nov. 29, 2003

Hi, Just cleaned IO.c up, so nothing fundamental changed. Besides some cleanups in multiple functions this are the two major changes: Removal of a_IO_write_chunks, mainly because it isn't used anywhere and it doesn't add any real functionality, it does the same only in a different way. Thanks to CVS it is easy to add it back when you really needed, if you want. Removal of the ValidIOs list. This is the logical next step after g_source_remove was discovered, because the extra indirection isn't needed anymore. All in all the result is a much smaller IO.c (400 lines instead of 700), smaller Dillo (about 3K with -O2), and O(1) behaviour instead of O(n) in the IO engine. The changes have really no negative points as far as I can tell. Link to the patch: http://www.xs4all.nl/~dorinek/dillo/IO-cleanup.patch.gz Greetings, Indan

7 9

Re: [Dillo-dev] [patch] Cleanup of IO.c
by Indan Zupancic Nov. 27, 2003

Nov. 27, 2003

Hi, > I do not understand your disapointing very well and maybe because that i sound rude, excuseme then. Go read Dillo's website, go read the new developer info, go read the files in Dillo's doc dir. Then spend a reasonable amount of time coding for Dillo and cleaning up _their_ mess in IO.c. Then send a patch to the mailing list and wait one week. Let's see if you're disappointed or not. Keep in mind that CVS didn't change the last 6 days, and the last few changes were small, and also don't forget that Jorge claims that he's busy with Dillo full time. Dillo claims to have nice, modular, clean code, and then you encounter some ugly code and try to fix it... I'm afraid I sound rude sometimes too, but we're just telling what we think, right? :) Greetings, Indan

1 0

patch: toggle force_my_colors
by Paul Pelzl Nov. 26, 2003

Nov. 26, 2003

Hi folks, I have attached a pair of Dillo patches. They add a toggle-able menu item to the right-button context menu, which enables/disables the force_my_colors preference on the fly. I find this useful for some occasional websites that Dillo renders rather poorly, as well as sites that simply choose a horrid color scheme. The first patch applies on top of Frank's monster patch v15; the second applies against Dillo CVS of 20031119. I hope others find it useful. Paul

2 2

[PATCH] Version 16 of tab/frame/kbnav/etc patch is ready
by Frank de Lange Nov. 26, 2003

Nov. 26, 2003

Hi'all, The next version (16) of my tab/frame/keyboard navigation patch is ready (see bottom of this message for download instructions). This is mainly a bug-fix and CVS resync release. For an overview of the new features in this release, see the posting I made to the list on version 15. Fixed bugs ---------- keyboard navigation - erroneously highlighted link after leaving a form element, was caused by wrong function call order in focus_next_link. Fixed. keywords - problem with keywords separated by more than one space is fixed. Keywords can now be separated by any whitespace character, including newlines (but don't forget that you still have to enclose the whole keywords string in double quotes for the parser to recognize it!). splash screem - the splash screen is now installed in $(datadir)/dillo/dillo.html CVS date/time ============= The patch is made against CVS as it was on 20031124@13:18 GMT. It should apply against CVS as it was on 20031121(a)21.33 GMT and later. For those who can not or do not want to use CVS, a snapshot can be found here: http://www.geocities.com/ikbenfrank/dillo-200311241318.tar.gz Tabs, Frames and browser bloat ============================== version: 0.8.0-pre patch: dillo-20031124-tabs.patch.gz unpatched: 297204 bytes patched: 333460 bytes (gcc 3.2.2, binutils 2.13.90.0.18, CFLAGS "-Os") Download instructions ===================== The patch is made against 20031124@13:18 GMT CVS. Do not forget to run ./autogen.sh after applying the patch. You can find the patch on the usual (ad-happy, use an ad-blocking proxy or sane browser) site: http://www.geocities.com/ikbenfrank/ More specifically: Dillo 0.8.0-pre (CVS) ===================== http://www.geocities.com/ikbenfrank/dillo-20031124-tabs.patch.gz size: 117192 bytes (gzipped, as downloaded) 531247 bytes (uncompressed) md5sum: 387f4dd85ead27de04d6527cc71504f5 (gzipped, as downloaded) 23ef8335f885d5657c75c7e9e0e18a3c (uncompressed) As always, check the site for the most recent version Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

3 8

patched dillo via Arch
by Paul Pelzl Nov. 26, 2003

Nov. 26, 2003

If anyone on the list is using GNU Arch, you can obtain: Dillo CVS + Frank's tab/frame/kbnav/etc. patch v16 + Indan's HTTPS patch v2 + my toggle-force-my-colors patch integrated into branch dillo--tabframe-pelzl--16.0 . The archive is: pelzlpj(a)eecs.umich.edu--2003 ftp://pelzlpj.dyndns.org/pub/paul/tla/2003 If you find this useful, please send me a private email. If no one cares, I won't bother to announce this archive in the future. Paul

2 1

Re: [Dillo-dev] patched dillo via Arch
by Frank de Lange Nov. 26, 2003

Nov. 26, 2003

Paul Pelzl wrote: >I wouldn't mind setting up a patches list, but only if there is demand >for it. Is patch discussion creating too much traffic on the wearlab >mailing list? If not, then it seems like keeping patch discussion on >the list would give the patches more exposure. > >Anyone else have an opinion? > >Paul > > > I think that patch traffic belongs on this list, as it is quite often relevant for all of Dillo (patched or unpatched). It also keeps the patches in sight for users/developers of unpatched Dillo, which should generate exposure. If/when the patches really take on a life of theirselves it is time to move, but that time has not arrived as far as I'm concerned. Good initiative btw, the Archive. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

1 0