February 2009 - Dillo-dev - lists.mailman3.com

style parsing on iframe
by furaisanjin＠gmail.com 11 Feb '09

11 Feb '09

Hi all. I'm wondering if it's necessary to parse style on iframe. I see a large bullet sometimes and this is one example page. http://www.oshiimamoru.com/news/news_r0807.htm The page contains this kind of iframe tag. <iframe src="http://rcm-jp.amazon.co.jp/e/cm?t=deizcom-22&o=9&p=8&l=as1&asins=4344980891…" style="width:120px;height:240px;" scrolling="no" marginwidth="0" marginheight="0" frameborder="0"> Regards, furaisanjin

1 0

google news link
by furaisanjin＠gmail.com 11 Feb '09

11 Feb '09

Hi all. I find that nothing happens when I click links on side bar within google news. On this page (http://news.google.com/news?ned=us) there are links such as World, U.S. and so on. None of them is clickable. Regards, furaisanjin

5 5

New mercurial repository
by jcid＠dillo.org 11 Feb '09

11 Feb '09

Hi, Good news: Andreas K. has just set a fast Hg repository for dillo. Try it at: http://hg.dillo.org/dillo I'll switch the web page to point to it after sending this email. Enjoy! :-) -- Cheers Jorge.-

3 2

ChangeLog
by jcid＠dillo.org 11 Feb '09

11 Feb '09

Hi, Johannes, corvid: it'd be good if you can update the ChangeLog file with your work. This ChangeLog is meant to be human-readable so please summarize as usual and highlight the important points. We have the full details in HG after all. -- Cheers Jorge.-

1 0

Close-tab Button
by jorl17.8＠gmail.com 09 Feb '09

09 Feb '09

Seg, 2009-02-09 ?s 21:23 +0000, Jo?o Ricardo Louren?o escreveu: > A simple update. > > I've fixed most issues I found. For instance, we were processing the > click on PUSH and not RELEASE, that was causing some problems and The > issue I talked about earlier (working while not visible). > > I've got a working tooltip, added to CustTabGroup. > > The only problem is drawing into the button. Should I use an image (or > multiple images, mouseover, etc...)? Should I add a cross ('X') to it? > > Adding a cross is easy, adding an image involves digging some more but > it is obviously doable. > > Thanks, > > Jo?o Oh, not to mention preventing tabs from going over the button. However, I was testing multiple clicks on the button and it seems that dragging the pressing, dragging and quickly releasing the mouse button makes the events not reach its destination - I'm guessing a DRAG messages is being sent, we have to prevent for that too. Jo?o

1 0

[patch] Search Previous
by jorl17.8＠gmail.com 09 Feb '09

09 Feb '09

Greetings. I 'spotted' a TODO on searching 'backwards' and decided to have a go at it. Basically, I implemented the Search Previous feature. I must say I have difficulties understanding the code behind FindtextState::search0(), so I did not base my code on it at all. Sure it could possibly be optimized, but it seems to do the job for now, I haven't found any bugs, if you find any, please do say. Additionally, I did not set any hotkeys for the search-previous action, maybe something like SHIFT+RETURN, since RETURN handles searching forwards? Also, I did not add any tests, and I only altered a line to make them compilable, but I might add some tests soon. Thanks, Jo?o

4 10

CSS update committed
by Johannes.Hofmann＠gmx.de 09 Feb '09

09 Feb '09

Hi, I just committed a major update of the CSS code. CSS values now have a type and the CSS parser can accept multiple types for one property. One example is font-size, which can either be a length or an enum (xx-small, x-small, ...). This fixes the font size issue on wikipedia.org. Cheers, Johannes

2 2

patch: clean up a_Html_add_image
by onepoint＠starurchin.org 08 Feb '09

08 Feb '09

There is IMHO a nasty code smell around a_Html_add_new_image(): it takes a boolean parameter that determines whether or not it actually adds the image. It's only called from two other places, once with the parameter set to false and once with it set to true. This patch cleans things up by renaming a_Html_add_new_image() to a_Html_image_new(), removing the boolean parameter and making the caller add the image (or not) as appropriate. Perhaps it is a judgement call as to whether this is an improvement, but I feel that it is. Please comment. Regards, Jeremy Henty

4 7

patch: <s> line appearance
by corvid＠lavabit.com 08 Feb '09

08 Feb '09

I was thinking that large text with a thin line through it looks odd. Turns out that there was also a problem with <sup> causing the <s> line to be too high. This looks about right to me with the few fonts I have around. I'm attaching an example html file as well. PS Might be good to go through that area of the code one day to see what opportunities there are to make it clearer...

3 4

name/id bug
by corvid＠lavabit.com 08 Feb '09

08 Feb '09

<a name="a"></a> <p id="p"></p> <p> <a name="same" id="same"></a> gives HTML warning: line 2, 'id' and 'name' attribute of <a> tag differ HTML warning: line 4, Anchor names must be unique within the document Dillo would seem to be unhappy now that the id attr is checked before open_a checks the name attr -- but then it looks like the move was made in October (a88b4a31cb7a) and I have a dillo around from roughly Dec. 22 that does not have a problem with this. In any case, I don't know whether there are styleEngine issues with just sticking the id check back after the open.

3 11