February 2009 - Dillo-dev - lists.mailman3.com

[patch]: fix a memory leak in a_Klist_free()
by onepoint＠starurchin.org 02 Mar '09

02 Mar '09

Subject line speaks for itself! Patch attached. Jeremy Henty

2 1

Re: css parsing numbers
by corvid＠lavabit.com 27 Feb '09

27 Feb '09

Johannes wrote: > On Wed, Feb 11, 2009 at 06:03:13PM +0000, corvid wrote: > > I tried > > font-size: .6in > > (we still love archaic measurements here) > > and it didn't work. > > > > The grammar says > > num [0-9]+|[0-9]*"."[0-9]+ > > > > Oh yes. That's Css_next_token() which is not recognizing ".6" as a > float... Attached. I'm too much of a css newbie to promise great testing, but I did cobble together the following and the right things seemed to happen: <html> <head> <style type="text/css"> hr.aaaaa {width: 1.5in} bbbbb {width: 2 in} </style> </head> <body> <hr style="width: 0.3in"> <hr style="width: .6in"> <hr style="width: 1 in"> <hr class="aaaaa"> <hr class="bbbbb"> </body </html>

2 4

libDw_fltk_a-fltk*.o naming
by corvid＠lavabit.com 26 Feb '09

26 Feb '09

Is there any reason not to shorten them to fltk*.o?

2 1

[patch] Configurable key bindings
by itsme_410＠yahoo.com 25 Feb '09

25 Feb '09

Hi Is it possible to have keybindings in the locator bar such as (perhaps configurable) ctrl-enter for www. and .com, Shift-Ctrl-enter for www. and .org, alt-ctrl-enter for www. and .edu and so on? That would really help! Thanks very much!! T > --- On Tue, 2/24/09, Scott Scriven > <dillo-dev(a)toykeeper.net> wrote: > > > From: Scott Scriven <dillo-dev(a)toykeeper.net> > > Subject: Re: [Dillo-dev] [patch] Configurable key > bindings > > To: dillo-dev(a)dillo.org > > Date: Tuesday, February 24, 2009, 3:15 PM > > * Tim Nieradzik <tim.nieradzik(a)gmx.de> wrote: > > > The other advantage of this implementation is > that > > we could > > > easily modify it to allow multiple key bindings > for > > one symbol. > > > > This is a good thing. > > > > > Therefore an "include" command for the > > dillorc should be > > > implemented. Then we could put something like > > "include > > > /usr/share/dillo/bindings/default" there, > as > > well as some > > > others. Now, if somebody wants to try different > key > > bindings, > > > you would just have to uncomment this particular > > line. There > > > is no need for replacing your local bindings just > to > > try others > > > out. > > > > An 'include' command would help me for other > > reasons, too. I > > split most of my config files into shared versus local > > portions, > > so I can have a base config on many hosts and tweak > > individual > > settings per host. > > > > > > Just my $0.02. > > > > > > -- Scott > > > > _______________________________________________ > > Dillo-dev mailing list > > Dillo-dev(a)dillo.org > > > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

1 0

Holiday week
by Hole.destructor＠gmx.de 23 Feb '09

23 Feb '09

Hello Jorge, > [ ] https dialog bombing issue. BUG#868 > When enabled, multiple https requests to the same site result > in dialog bombing. The https dpi is disabled by default in > Dillo. Anyway, in Debian, there's a security warning against > dillo for not checking certificates (I don't know what > version of dillo they use, nor why they enable https.) Debian (and Ubuntu) uses a strongly modified version of Dillo-0.8.6, which one can get officially from http://teki.jpn.ph/pc/software/index-e.shtml On the splash screen of debians Dillo it says, that Kiyo <webmaster[at]teki.jpn.ph> is the one to report problems to, so I guess he is the package maintainer or so. Best, Alexander.

1 0

[patch] Hiding panels by pressing "Escape"
by tim.nieradzik＠gmx.de 20 Feb '09

20 Feb '09

This small patch allows you to press the "Escape" key in order to hide the panels. It assumes that you are in the UI mode "UI_TEMPORARILY_SHOW_PANELS". --Tim

1 0

[patch] Reloading page by pressing "Enter" in the location box (bug #890)
by tim.nieradzik＠gmx.de 20 Feb '09

20 Feb '09

To whom it may concern, I have signed up on the dillo-dev mailing list and would like to introduce myself. My name is Tim Nieradzik. I am new to this mailing list, and I would like to contribute some patches. In the included attachment you will find my first contribution to the Dillo project. It allows users to reload the current page by pressing "Enter" in the location box (bug #890). Sincerely, Tim

1 0

Leaking image structures
by Johannes.Hofmann＠gmx.de 18 Feb '09

18 Feb '09

On Wed, Feb 18, 2009 at 08:26:52AM +0000, corvid wrote: > > On Wed, Feb 18, 2009 at 12:40:57AM +0000, corvid wrote: > > > > Can you please try attached patch with valgrind and image loading on > > > > and off. > > > > > > Is this a proposed patch for the tree or an experiment in leak-finding? > > > > For the tree, if it proofs to fix the leaks and doesn't cause > > others. > > If we always add Image, the code that loads images manually will think > it hasn't been loaded yet. > Ah ok. I guess I misunderstood Html_add_new_linkimage() completely. Please check the updated patch. Thanks, Johannes PS: The point of the patch is to actually do reference counting: Whenever we create a new reference (pointer) to an image, we call a_Image_ref(), when such a pointer is deleted we call a_Image_unref(). If I see it correctly, the permanent pointers to Image structures are in html->images and in the DilloWeb structure.

3 3

Fun with autocnf and mercurial
by onepoint＠starurchin.org 18 Feb '09

18 Feb '09

Here's a patch for discussion. Since I am parsing Dillo logs for debugging, I thought it would be neat if Dillo logged the mercurial revision. Patch attached. Thoughts? Does anyone know a better way to get the revision for a particular tag? Piping "hg tags" through a sed script is rather kludgy but I can't find a way to get mercurial to tell me directly. I log the qparent revision as well as the tip revision because I manage patches with Mercurial queues, so my qparent revision is the vanilla tip revision that I am currently based on. Also, I used printf() to log the revisions because neither MSG nor MSG_WARN produced anything. I don't know why. Can anyone explain? Regards, Jeremy Henty

3 11

Leaking image structures
by onepoint＠starurchin.org 18 Feb '09

18 Feb '09

One of the biggest leaks that valgrind reports is image structures. I'm attaching logs that show memory being allocated by a_Png_new() and cousins and not being freed. There are also frequent leaks of memory allocated by the image libraries from within the various image callbacks, but I suspect these are just another effect of the Dillo image structures not being freed. Unfortunately I'm having a hard time tracking these leaks down. They regularly appear after long browsing sessions, but I haven't found any single page that reproduces them. I suspect they are caused by some race condition inside the CCC rather than the HTML parser. I am browsing with image loading enabled, and if I understand the code correctly that means that the Web structures in the CCC own all the references to image structures. The fact that image structures are reference counted makes it hard to know when the structures should be freed anyway. Indeed, does Dillo even ensure that image structures are freed? Maybe this is just a symptom of incomplete cleanup at exit rather than a true leak? I've looked over the code and can't see any obvious leaks so I'm rather stuck. Any tips for tracking this down? Even if it's not a true leak it would be good to have a fix that cleaned up the valgrind logs. Regards, Jeremy Henty

4 5