January 2005 - Dillo-dev - lists.mailman3.com

[Dillo-dev]Re: dillo patch: entities (BUG#605)
by Jorge Arellano Cid 05 Jan '05

05 Jan '05

On Tue, Jan 04, 2005 at 01:33:01PM +0100, Matthias Franz wrote: > Hi Jorge, > > On Mon, Jan 03, 2005 at 12:05:59PM -0300, Jorge Arellano Cid wrote: > > I just reviewed and commited the patch. > > Great! > > > > > * The ';' at the end is no longer required. In fact, it is optional > > > according to the SGML spec (see also Sec. 5.3 of the HTML 4.01 spec). > > > Omitting the ';' produces a warning. > > > > When show_extra_warnings is set. > > > > I wonder if it is better to always rise the warning. Of course > > it is perfectly legal for SGML but IIRC XHTML requires the ';' > > and authors prefer to add it with a view to avoid problems, so a > > reminder should be welcome. e.g. www.linuxpackages.net. > > That depends on what the (extra) warnings are intended for. I thought > that ordinary HTML_MSG are for errors, so that (ideally - we/you don't > want to be 100% perfect) if show_extra_warnings is off, "no errors" means > that the page is valid HTML. If show_extra_warnings is on, then one gets > additonal warnings, for example about bad style, incompatibility with > XHTML etc. Of course, this is a design question. I also agree with this view. It provides a simple formal definition too ;). Let's keep it now and see what happens. > One more remark about the HTML error messages. I would suggest the > following: > > * Leave out the "HTML warning" at the beginning of each entry - all the > more that most entries are errors. > > * Introduce a macro HTML_ERROR for real error messages. It replaces > HTML_MSG (in most of the source code; internally it may call HTML_MSG). > > * Introduce a macro HTML_WARNING like > > #define HTML_WARNING(fmt...) if (prefs.show_extra_warnings) \ > HTML_MSG("warning: " ## fmt) > > (not tested - you get the idea). > > What do you think about it? It looks like a good idea. It's more correct to label them "HTML error" and "HTML warning" than as it is done currently. My main concern is about page authors taking it personal. ;-) The other point is that we'd have to be very accurate. The nesting detection is ok now, but we'd have to start taking into account whether we're dealing with HTML.(version) or XHTML for some messages. > > > I made a minor change to avoid the #ifdefs. > > good idea > > > > Ah, we're now raising a warning when a named entity is not > > found. I don't know whether our list is complete. It'd be good to > > check because we could be giving misleading warnings for a small > > yet unsupported set. > > OK, I'll do it. But give me some days ... -- Cheers Jorge.-

1 0

[Dillo-dev]Re: styles leak bug
by Jorge Arellano Cid 04 Jan '05

04 Jan '05

Hi Roberto, On Sun, Jan 02, 2005 at 01:28:07PM -0500, Roberto Sanchez wrote: > Jorge Arellano Cid wrote: > >=== > > > > Have you had the time to look into the styles leak bug? > > > > Only briefly. I also noticed that it occured on another webpage that > I developing for my church. I will let you know as soon I can figure > something out. Good news: I had some luck with an idea to test the origin of it. It's fixed in the CVS now! I'll try to pack the rc1 tarball tomorrow. -- Cheers Jorge.-

1 0

[Dillo-dev]2005
by Jorge Arellano Cid 04 Jan '05

04 Jan '05

Hi there! Please receive my best wishes for this new year. Our project has kept its advancing pace and we're very close to dillo-0.8.4-rc1. There's still a DwStyle leak to investigate and that's it. If it takes more than two days more, I'll pack rc1 anyway to start the testing cycle. This should be a short stage because this is mainly a bugfix release and it has proven very stable as from CVS. The idea is to have 0.8.4 before January 15. Althoug the mailing list has been a bit quiet, there's been good work going on in the background, with some new developers and several patches! (the CVS shows it). If destiny smiles, I could be on FOSDEM 2005 presenting Dillo on the embedded track and making contacts with a view to find a way to finally get a core team working full-time on it, thus boosting the development pace. Please join your best thinking, good wishes, and let's hope the best for this 2005! -- Cheers Jorge.-

2 1

[Dillo-dev]new file server dpi in CVS.
by Jorge Arellano Cid 04 Jan '05

04 Jan '05

Hi Dieter, I just finished the first prototype for the two-threads-only file server dpi. I've had this in mind for sometime because the old one, despite solving a deadlock race, used too much threads when the page requested too much different files (one per file). This can cause some problems on restricted environments as PDAs or uclibc for instance. I hope this solves the issues you told me on your LP64 machine. Ah, the CVS also has a lot more fixes of -Wconversion warnings. Urbi et orbi: please test these new dpis because the current CVS is very close to becoming dillo 0.8.4! How: dpidc stop make make install-strip (this avoids the upgrading problems with running dpis/dpid). ============ Have great hollydays and enjoy as much as you can! -- Cheers Jorge.- PS: Dieter: are you subscribed to dillo-dev?

2 2

[Dillo-dev]configurable page increment
by Scott Scriven 04 Jan '05

04 Jan '05

Hello. I'd like to make the page increment configurable. I liked the old half-page behavior, and would like to be able to use that instead of the current "96% of the viewport" method. However, I don't really know where to start, or how to hook into dillo's configuration system. Ideally, I'd like to set values for how much to scroll on each type of scroll event: PgUp/Dn, Space/BkSpace, arrows, and the mouse wheel. (96%, 50%, 1 line, and 2 lines, respectively) I've found the code which configures one of these events, thanks to a snippet early on this list ("0.96 * allocation->height"), but don't know where/how to handle the others. So, any hints? Or, alternately, does anyone with more of a clue feel like adding this? -- Scott

2 1

[Dillo-dev]Re: dillo: umask(0) in dpid/main.c?
by Jorge Arellano Cid 03 Jan '05

03 Jan '05

On Sun, Nov 28, 2004 at 01:03:23PM +0100, Richard Zidlicky wrote: > Hi, Hi. > I stumbled upon this as I noticed that bookmarks and saved files > are world writable. Is there still a good reason to set umask > to 0 for all plugins? Good question! Basically the umask(0) call is there because the "Linux Programming Second Edition Unleashed" recommends so as a standard for daemons ;). Now, looking into it, it makes much more sense to use 077 as a mask for dpis (i.e. only allowing the owner). > > Another detail I noticed while checking file creation > is this: > --- dillo-0.8.3/src/cookies.c.rz 2004-11-28 12:39:33.000000000 +0100 > +++ dillo-0.8.3/src/cookies.c 2004-11-28 12:40:22.000000000 +0100 > @@ -100,7 +100,7 @@ > > if ((F_in = fopen(filename, "r+")) == NULL) { > /* Create the file */ > - fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR); > + fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR, 0777); > if (fd != -1) { > if (init_str) > write(fd, init_str, strlen(init_str)); Well, with the proper mask set to 0077 this would not be required. If the need to add explicit permissions arise, it'd be 0077 too. Comments are welcome. -- Cheers Jorge.-

3 4