- Dillo-dev - lists.mailman3.com

viewport losing focus?
by corvid＠lavabit.com Oct. 5, 2008

Oct. 5, 2008

If I start dillo and open <TABLE width=2600> <TR><TD>text </TABLE> I can press right arrow, but then when I press left arrow, they stop working and I see the bottom half of "Label" written over the top of the back and forward buttons, suggesting that tabs may be involved somehow.

2 1

patch: fix dns to ipv6 resolution
by 4winter＠informatik.uni-hamburg.de Oct. 4, 2008

Oct. 4, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi everyone :) I noticed that ipv6 support in dillo2 is somewhat broken. With this tiny patch hostnames are properly resolved to ipv6 addresses and browsing over ipv6 works fine but entering a numeric address does not. Justus -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFI55eXoPmwNWhsaZYRAoCbAJ41ZA66N5zDWetCia5r4OUZmLfwngCfc0WT i2J3z0qscSGR1tuitxAX254= =GJLN -----END PGP SIGNATURE-----

2 1

Javascript engine
by jcid＠dillo.org Oct. 4, 2008

Oct. 4, 2008

Hi, Does anybody know about a lightweight javascript engine we can use with dillo? From what I've seen, SEE (Simple ECMAScript Engine), looks like a good candidate. Disclaimer: I'm a newbie on JavaScript. -- Cheers Jorge.-

2 1

what crashes remain?
by corvid＠lavabit.com Oct. 3, 2008

Oct. 3, 2008

It's still possible to crash dillo if you click on a remote link and quickly click on some images to load them. Doesn't crash every time, but typically within four tries or so. I had assumed it was the same thing as whatever was wrong with the menu crash, so I'd ignored it. If I stick a_Bw_stop_clients(bw, BW_Img); in the DilloHtml destructor, I can no longer get it to crash, but I randomly got a "Cache_process_queue Caught busy!!!" while browsing earlier today, so there's something wrong with just doing that. (Assuming it's related; I'm not in the habit of getting that MSG.) I can't think of any other crashes, but I don't remember whether Johannes still gets bus errors.

3 33

an experiment regarding cross site request forgery
by corvid＠lavabit.com Oct. 3, 2008

Oct. 3, 2008

Cross site request forgery is the one where the bad person sticks an image tag or some javascript or whatever on a page, and your privileges are used to do something. So my latest little experiment: out of the image urls your browser sees that have queries (the '?a=b&c=d&e=f'), how many are - just advertisement trash anyway - things you want where the request would work just as well with the query removed (e.g. forum software that likes to stick session ids on everything) - things that wouldn't still work but don't really matter (e.g. user icons) - things you need Here's a little bit of code that tries rejecting them. (If dillo had an option for such a thing someday, I imagine it would have a form more like "don't automatically load, and make it easier to know what the URL is before you load it manually")

4 11

feature freeze
by jcid＠dillo.org Oct. 3, 2008

Oct. 3, 2008

Hi, More or less we entered "feature freeze" mode implicitly. What is left pending? I remember: - the mini_bug.xpm FLTK2 fix. - the focused textarea callback issue. -- Cheers Jorge.-

5 13

findbar sometimes stops accepting input
by corvid＠lavabit.com Oct. 3, 2008

Oct. 3, 2008

I've seen this a couple times now...I can't remember whether it started before the last revision to findbar.cc. I can still highlight the findbar text, but I can't change it. I think closing/reopening the bar has always fixed it so far.

1 0

crash with reload and textarea
by Johannes.Hofmann＠gmx.de Oct. 2, 2008

Oct. 2, 2008

On Thu, Oct 02, 2008 at 07:12:31PM +0000, corvid wrote: > It doesn't seem to want to break for me, but > I wonder whether it bears some similarity to > this whole deal with my pending callbacks: > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-October/005000.html > Don't think so. The textarea thing turned out to be a small fltk2 bug: http://www.fltk.org/str.php?L2055 Cheers, Johannes

1 0

crash with reload and textarea
by Johannes.Hofmann＠gmx.de Oct. 2, 2008

Oct. 2, 2008

Hi, when using MALLOC_OPTIONS=GJPRZ on DragonFly which enables malloc debugging I get a crash when hitting Ctrl+r to reload a page with entered text in a textarea if the focus is still in the textarea. It seems that the Ctrl+r causes a callback on the already deleted fltk Input widget: Program received signal SIGBUS, Bus error. 0x0805310d in fltk::Widget::do_callback (this=0x284f5600) at /home/hofmann/soft//include/fltk/Widget.h:127 127 voiddo_callback()when{ callback_(this,user_data_); } (gdb) bt #0 0x0805310d in fltk::Widget::do_callback (this=0x284f5600) at /home/hofmann/soft//include/fltk/Widget.h:127 #1 0x080b75e3 in changed_stuff (i=0x28471480) at Input.cxx:49 #2 0x080b85dc in fltk::Input::replace (this=0x28471480, b=0, e=0, text=0x2856d280 "http://www.shiningsilence.com/dbsdlog/2008/10/01/3185.html#respond", ilen=66) at Input.cxx:826 #3 0x080bc4d8 in fltk::Input::insert (this=0x28471480, t=0x2856d280 "http://www.shiningsilence.com/dbsdlog/2008/10/01/3185.html#respond", l=66) at ../fltk/Input.h:86 #4 0x080b78f1 in fltk::Input::insert (this=0x28471480, text=0x2856d280 "http://www.shiningsilence.com/dbsdlog/2008/10/01/3185.html#respond") at Input.cxx:852 #5 0x08057aee in a_Web_dispatch_by_type (Type=0x2856f260 "text/html; charset=UTF-8", Web=0x2855a980, Call=0x2855a9d0, Data=0x2855a9d4) at web.cc:95 #6 0x08059b25 in Cache_process_queue (entry=0x285010c0) at cache.c:1050 On Linux export MALLOC_CHECK_=2 or valgrind should show similar results. Cheers, Johannes

2 2

Shift + {Left, Right}
by jcid＠dillo.org Oct. 2, 2008

Oct. 2, 2008

Hi there, Just committed a patch for making: SHIFT + {Left, Right} work even with the findbar focused. It took a long time to get it to work, but it improves Tab navigation a lot! Note: in uicmd.cc, + focus(child(i)); selected_child(child(i)); makes SHIFT+Right keep focus. SHIFT+Left doesn't work. I don't know why... -- Cheers Jorge.-

1 0

Basic authentication
by Christian.Kellermann＠nefkom.net Oct. 2, 2008

Oct. 2, 2008

Dear List, since I have not found any traces of discussion on this list about this topic I dare to ask where to place code handling basic authentication in dillo's source? As I see it the cache module is responsible for handling server responses. So I would at a first try add the code there. How can I connect to a UI dialog from here to get the necessary credentials? Maybe a possible solution looks like this: - react to 403 header and look for Authorization request - if there is one ask the user for username/pass + resend the request with the Authorisation header added + or display the 403 if the user aborts What do you think? I will come up with some example code to illustrate the idea in case this is not very clear. Kind regards, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

3 3

[patch] share button images between UIs
by Johannes.Hofmann＠gmx.de Oct. 1, 2008

Oct. 1, 2008

Hi, this is independent from the recent crashes. This patch shares the images between multiple UIs. What do you think? Cheers, Johannes

3 5

segfault -- callback + closed window?
by corvid＠lavabit.com Oct. 1, 2008

Oct. 1, 2008

I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image. Got: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127 Maybe that's just a part of life with callbacks...

3 9

source window's reluctance to show end of file
by corvid＠lavabit.com Sept. 30, 2008

Sept. 30, 2008

I've been assuming all along that everyone sees this problem, but then I don't think anyone has ever mentioned it, so I wonder whether it only shows up on my slow machine. Thus far it's always been easier for me to resize the window -- thereby causing whatever refiguring is necessary -- than to dig through TextDisplay to find out what goes wrong when line numbers are turned on.

2 3

Window close dialog
by jcid＠dillo.org Sept. 30, 2008

Sept. 30, 2008

Hi, Can somebody please make the dialog for closing a window with tabs open? -- Cheers Jorge.-

2 4

patch: changeLinkColor
by Johannes.Hofmann＠gmx.de Sept. 30, 2008

Sept. 30, 2008

On Sun, Sep 28, 2008 at 02:54:56PM -0400, Jorge Arellano Cid wrote: > On Sun, Sep 28, 2008 at 05:55:10PM +0000, corvid wrote: > > Encouraged by the idea that I am going in the right direction, I have > > made a new one with spaceStyle: > > Funny how we were working on the same patch a the same time! > > I had an ancient version, and gave it a review. > The link search is linear inside textblock. A linux gazette page > showed more than 33000 words to color a link. On bigger pages it may be worst. > It depends on the structure. For instance our bookmarks uses tables > and the link is usually found in less than 10 words. > > The patch in CVS reduce the 35000 steps to 1500 or so (the > sorted link list is sparse, so there's a penalty for looking > for an actual link to compare to). > Not sure I understand this optimization. It is assuming that link numbers are always increasing, right? Can we assume this in dw/*? src/html.cc seems to be implemented currently in way that this is true. But perhaps we could/should reuse link numbers for equal destination urls in the future? Or someone might just choose hashes of the url string as link number. BTW. with both implementations I now see issues with this example: <html> <body> <a href="http://www.dillo.org">dillo</a> <a href="http://slashdot.org">slashdot</a> <a href="http://www.dillo.org">dillo</a> </body> </html> When opening the first link in a new window, it doesn't change color in the original one. When opening it in a tab, the first one changes color. After a reload also the second one changes color. Am I missing something? Cheers, Johannes

3 6

Window close dialog
by jcid＠dillo.org Sept. 30, 2008

Sept. 30, 2008

On Mon, Sep 29, 2008 at 07:46:52PM +0200, Johannes Hofmann wrote: > Hi Jorge, > > On Mon, Sep 29, 2008 at 11:12:39AM -0400, Jorge Arellano Cid wrote: > > On Mon, Sep 29, 2008 at 04:03:55PM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > On Mon, Sep 29, 2008 at 09:48:58AM -0400, Jorge Arellano Cid wrote: > > > > Hi, > > > > > > > > Can somebody please make the dialog for closing a window > > > > with tabs open? > > > > > > "Close Window" only closes the current tab anyway. > > > > Yes. > > > > > "Exit Dillo" closes all windows including tabs. > > > So, do you think about a dialog in the "Exit Dillo" case when > > > there is more than one tab or more than one window or both? > > > > Both, plus the window manager's "close window" if there're open Tabs. > > > > > Do we have the number of open windows somewhere? > > > > In bw.cc's num_bws. > > > > just tried to implement that by creating a callback for the > fltk::Window. But then I noticed that user_data() of the windows is > already beeing used in ui.cc. > I don't understand why this is necessary. UI also contains a pointer > to the BrowserWindow (Bw). It helps the child widgets find their bw. e.g. search button, panel buttons, etc. They are nested in different ways depending on the panel shape choice so AFAIS there's no easy way to navigate up to the UI. One way solve it is to store the bw in the window's user_data(), thus a simple wid->window()->user_data() does the trick. Giving it some more thought, the danger of some function not belonging to the current UI geting the wrong bw is real, and it may end sending commands to the wrong bw. IOW: there's only one window for several tabs. When Tabs switch focus, the window()->user_data() is updated accordingly. If a background Tab requests its bw using window()->user_data() it will get the wrong one! (this may cause problems as the one reported by corvid.) If we can find an alternative method to get to a widget's bw (storing it in the CustTabGroup for instance), it'd be much better. -- Cheers Jorge.-

1 0

patch: show_msg=NO disable debug messages
by corvid＠lavabit.com Sept. 29, 2008

Sept. 29, 2008

tried turning off show_msg and saw how dillo is still somewhat chatty thanks to DEBUG_MSG. (Or would you prefer a show_debug_messages pref as suggested in dillo2rc? Hmm... thinking about the sentence "Generic messages (mainly for debugging specific parts)", I'd have to say that we use MSG for plenty of debugging messages and DEBUG_MSG for plenty of of-more-general-interest messages.)

3 2

patch: changeLinkColor
by Johannes.Hofmann＠gmx.de Sept. 28, 2008

Sept. 28, 2008

On Sun, Sep 28, 2008 at 07:42:14PM +0000, corvid wrote: > Jorge wrote: > > On Sun, Sep 28, 2008 at 05:55:10PM +0000, corvid wrote: > > > Encouraged by the idea that I am going in the right direction, I have > > > made a new one with spaceStyle: > > > > Funny how we were working on the same patch a the same time! > > > > I had an ancient version, and gave it a review. > > The link search is linear inside textblock. A linux gazette page > > showed more than 33000 words to color a link. On bigger pages it may be worst. > > It depends on the structure. For instance our bookmarks uses tables > > and the link is usually found in less than 10 words. > > > > The patch in CVS reduce the 35000 steps to 1500 or so (the > > sorted link list is sparse, so there's a penalty for looking > > for an actual link to compare to). > > > > Please apply the spaceStyle part, and send it to me. > > Do we know that all of the (TEXT -- putting WIDGET aside for the moment) > contents of a link will have the same style? First likely example I could > come up with is how about in a utopian future dillo where tooltips are > implemented and there's an ABBR inside? Oh right. Just think about: <html> <body> <a href="http://slashdot.org">slash<b>dot</b></a> </body> </html> After clicking, the dot is no longer bold. Cheers, Johannes

1 0

patch: changeLinkColor
by corvid＠lavabit.com Sept. 28, 2008

Sept. 28, 2008

I just took the 0.8.6 version and replaced everything in it with dillo2 versions. (well, then had to add in the widget part) The fact that it seems to be working is kind of shocking. As for whether this is still the right way to do it, I leave this matter for the experts. The registerName is because html.cc needs to have that working in order to call changeLinkColor.

2 3

panel_size=small hides the menubar
by onepoint＠starurchin.org Sept. 28, 2008

Sept. 28, 2008

If I add "panel_size=small" to ~/.dillo/dillo2rc then the menubar disappears! Huh? (~/.dillo/dillo2rc is otherwise identical to the default /etc/dill2rc) Regards, Jeremy Henty

2 2

Dillo in OSX
by Johannes.Hofmann＠gmx.de Sept. 27, 2008

Sept. 27, 2008

On Thu, Sep 04, 2008 at 04:09:30PM -0400, Jorge Arellano Cid wrote: > On Wed, Sep 03, 2008 at 06:28:49PM +0200, Johannes Hofmann wrote: > > On Tue, Sep 02, 2008 at 09:20:03AM -0400, Jorge Arellano Cid wrote: > > > On Mon, Sep 01, 2008 at 01:42:26PM +0200, Johannes Hofmann wrote: > > > > Hi Jorge, > > > > > > > > how did You setup the OSX box to get a compiler and header files? > > > > Did You install that huge XCode stuff, or is there another way? > > > > I may get access to an OSX box to try dillo on it. > > > > > > How do I disable the double-buffer? > > > > Use the --disable-doublebuffer option when configuring dw2. > > Oh, yes, I forgot... > (tried running ./configure --help in dillo2 not dw2) > > > > I tried dillo "as is" with clear_double_buffer() and without it, > > > and the result is the same... > > > > Yeah, dw2 implements doublebuffering internally, so that does not > > make a difference. > > I'll have access to that machine again sarting on September 12. > Just tried current dillo on OSX with --disable-doublebuffer. It works ok with some issues: * Some of the buttens disapear from time to time (Back button for example). * The font size seems a bit too large so that there is not enough space between words and lines. * Incoming data does not reliably trigger a page update. An additional event like a mouse movement is necessary. Apart from that it's quite nice. Tabs are working fine. Cheers, Johannes

2 1

SEGFAULT with mouse click
by jcid＠dillo.org Sept. 27, 2008

Sept. 27, 2008

On Thu, Sep 25, 2008 at 11:14:28PM -0700, Donald Chai wrote: > On Thu, Sep 25, 2008 at 3:58 PM, Jorge Arellano Cid <jcid(a)dillo.org> wrote: > > I just came accross an easy to reproduce segfault, that's > > present since long ago. > > > > Middle-clicking works OK right? > > > > Well, try middle-clicking a link with a two mouse button (i.e. > > pressing both at the same time). The link menu stays open and > > after a second click (e.g. left click to make it dissapear) > > it segfaults. > > [...] > > I see this problem as well. If I very quickly press the left then > right mouse button (NOT at the same time), then I get a segfault. > Dillo seems to try to select some text on the old page, after the new > page is loaded. This hinted me towards a timing issue and found this way to crash dillo (most probably akin to the "middle-click" bug): 1.- Left click over a remote URL link (to have some time while DNS is resolving) 2.- Move the mouse pointer out of the link and right-click to get the popup menu, before the new page starts downloading. 3.- Once the new page starts to show, click again to get rid of the popup, and it'll crash. -- Cheers Jorge.-

3 7

Icon for Dillo window
by jcid＠dillo.org Sept. 27, 2008

Sept. 27, 2008

Hi, I was thinking it'd be good to provide an icon for the WM to use. Does anybody know how to do it with FLTK2? -- Cheers Jorge.-

4 20

Tabs!!!
by jcid＠dillo.org Sept. 26, 2008

Sept. 26, 2008

Hi there, The tabs patch has grown to a quite usable state, so it was committed for you to test. I know we're close to the release so we can still rollback. It's just that I'd much like to have it in the main tree before dillo2 goes out. The patch comes with several assorted cleanups and normalizations. For instance: derived widgets now use the "Cust" prefix instead of "New", the window->user_data() holds a pointer to the current UI, and child widgets get it from there, etc. OK, so to the tabs... This implementation uses one UI per tab, and it's quite fast. You can switch tabs with the mouse, Shift+{Left, Right} or {Ctrl,Ctrl+Shift}+TAB. Use Ctrl+N, or middle click over a link to open a new tab (just as it was with new windows). Ctrl+Q closes the tab. The idea is that in the future the user can dillo2rc-choose whether to use windows or tabs, and windows with tabs. Some issues: 1.- Tab Tooltips are commented out because FLTK has problems with them. 2.- Shift+{Left, Right} work even when the location is focused. In the latter case you may need to click the right key twice for it to focus and work (don't know why, the Left key works OK). 3.- Currently there's no hidden tabs widget, when there's only one tab (haven't even tried, it may be as simple as hiding the group). 4.- There's no close tab icon in the tab label. 5.- No warning popup for close window with multiple open tabs. OK, please take it for a ride and test. Comments, fixes and patches are welcomed. -- Cheers Jorge.-

3 19

PATCH: select new tabs
by onepoint＠starurchin.org Sept. 26, 2008

Sept. 26, 2008

This patch is more of a call for discussion than a fix as it fiddles with the UI. It makes Dillo select the new tab after creating it. As a special case, middle-clicking a link does not select the new tab unless the Shift key is down. (This is the same behaviour as Firefox which saves learning a new set of reflexes.) What do people think? Regards, Jeremy Henty

5 7

cut off word ends with italic fonts
by Johannes.Hofmann＠gmx.de Sept. 26, 2008

Sept. 26, 2008

Hi, somtimes the end of italic words get cut off e.g. in <html> <body> <i><a href="foo">FUU</a>BAR</i> </body> </html> when seen with vw_fontname="helvetica". This is due to a change in html.cc (I think it was introduced with rev 1.36). This change sets the backgroundColor for all words which means that for each word, the bounding box get's drawn before the actual text. This obviously has a performance impact too. I'm not sure how to get back to the original behaviour (backgroundColor == NULL for normal words) without breaking anything. Can someone please have a look? Cheers, Johannes

4 13

SEGFAULT with mouse click
by jcid＠dillo.org Sept. 26, 2008

Sept. 26, 2008

Hi, I just came accross an easy to reproduce segfault, that's present since long ago. Middle-clicking works OK right? Well, try middle-clicking a link with a two mouse button (i.e. pressing both at the same time). The link menu stays open and after a second click (e.g. left click to make it dissapear) it segfaults. -- Cheers Jorge.-

2 3

patch: Re: [Dillo-dev] what's next
by corvid＠lavabit.com Sept. 25, 2008

Sept. 25, 2008

Johannes wrote (way back in June!): > * The cursor is not always updated properly when over a link. This > happens while page is rendered and also when drag-scrolling with > the middle mouse button. How about updating it from layout()?

3 6

release packaging
by akemnade＠tzi.de Sept. 25, 2008

Sept. 25, 2008

Hi, I have a question about release packaging: Currently you need to download three tarballs to compile dillo (fltk,dw,dillo). I doubt that any linux distribution has fltk2 packages at the moment. (and also not openembedded) What's the plan about that? Make one big tarball of everything (with some selected fltk snapshot) or do you expect the distributions to include a fltk2 package as soon as they see dillo-fltk? The question came to during thinking how to make bitbake files for openembedded. Regards, ndreas Kemnade

7 12

Redraw storms
by onepoint＠starurchin.org Sept. 23, 2008

Sept. 23, 2008

Since dillo got tabs I'm seeing "redraw storms": sometimes after opening a new tab every movement of the mouse triggers a redraw. It doesn't seem to depend on the number of tabs. Usually it will go away eventually (just after a tab is closed). I upgraded to the latest FLTK2 snapshot but it has made no difference. Is anyone else seeing this? Regards, Jeremy Henty

4 11

Redraw storms: the trigger
by onepoint＠starurchin.org Sept. 23, 2008

Sept. 23, 2008

I think the redraw storms start whenever the main window is resized horizontally and there are too many tabs to fit in the horizontal space (so that the tab menu button has appeared). Vertical resizes do not cause the problem. It is also safe to resize horizontally or vertically before the tab menu button appears. Once the storm has started it stops whenever the tab menu button disappears, whether this is due to closing some tabs or widening the window. The storm starts again whenever the tab menu button reappears, whether or not there has been any more resizing. Do other people see this? Jeremy Henty

1 0

patch: fonts, utf-8 tabs
by corvid＠lavabit.com Sept. 21, 2008

Sept. 21, 2008

The ui.cc changes are so that I can make a tabs screenshot with Asian script at some point. Similarly, the dialog.cc change is so that I can see Asian characters in source. Kept forgetting to deal with that...

1 0

patch: making some concessions to aesthetics...
by corvid＠lavabit.com Sept. 21, 2008

Sept. 21, 2008

I've decided to admit that highlighting checkboxes and radio buttons is always hideous. I had been trying to avoid the special case, but I know the horribleness would jump right out at someone trying dillo2... (And I decreased the RELIEF_X_THICKNESS because 5 makes <button>s look weird at my low resolution)

1 0

[patch] minor optimization in StyleAttrs::equals()
by Johannes.Hofmann＠gmx.de Sept. 20, 2008

Sept. 20, 2008

Hi, this patch adds a missing optimization to StyleAttrs::equals(). Similar checks are already in place in other equals() methods. Cheers, Johannes

2 1

[patch] fixup resizable of after tab removal
by Johannes.Hofmann＠gmx.de Sept. 19, 2008

Sept. 19, 2008

Hi, I was seeing crashes when removing tabs. The reason is that when we accidentally remove and delete the resizable of the TabGroup, fltk still tries to access it. Attached patch fixes that. It also moves the hide/showLabel functionality into CustTabGroup. Cheers, Johannes

1 0

8.68% of my time in assert()?
by corvid＠lavabit.com Sept. 19, 2008

Sept. 19, 2008

Turning off bounds checking for get and getRef does get rid of nearly all of the assert()s, but I was just trying -Winline and discovered: ./lout/misc.hh: In function 'void lout::misc::assert(bool, const char*, ...)': ./lout/misc.hh:36: warning: function 'void lout::misc::assert(bool, const char* , ...)' can never be inlined because it uses variable argument lists .. Earlier I'd said assert() was not cheap, but I was still uncertain about how -g and -pg might be affecting inlining. Now I _know_ that assert() is not cheap.

3 10

Confused by the comment to CustInput::handle()
by onepoint＠starurchin.org Sept. 19, 2008

Sept. 19, 2008

In dillo2/src/ui.cc, CustInput::handle() has a comment saying that it disables CTRL+{o,r,HomeKey,EndKey}, yet it only seems to disable CTRL+o . I think CTRL+r used to be disabled too, so that CTRL+r would reload the page even if the URL widget had the focus. Here's a one-line patch to restore that. What should we do about CTRL+{HomeKey,EndKey}? I prefer HomeKey and EndKey to scroll the main window even when the URL has the focus. Wasn't that the behaviour originally? It certainly doesn't happen now. Regards, Jeremy Henty

2 2

Latest libpng fixes crashes
by onepoint＠starurchin.org Sept. 18, 2008

Sept. 18, 2008

I recently looked at why dillo almost always crashed when viewing http://www.packtpub.com/article/transaction-model-of-postgresql and discovered it was happening in the depths of libpng. Luckily libpng-1.2.32 fixes this problem, so if you have been seeing unexpected crashes that might be due to PNG images then I recommend upgrading libpng. Regards, Jeremy Henty

1 0

patch: scroll upon resize
by corvid＠lavabit.com Sept. 17, 2008

Sept. 17, 2008

You know how - you are scrolled down or to the right - you make the viewport larger - the scrollbar disappears - you can only get the rest of the document back by hitting some arrow keys or something This seems to fix it, although my usual dw disclaimer applies: I don't know whether this is necessarily the right place for the change. PS When making the viewport very narrow and then maximizing, I notice that the location bar does not go back to showing the whole address. I don't know whether that's dillo's fault or fltk's fault. PPS Amazing how much code we need for dealing with scrolling and scrollbars...

3 4

load_images and multiple windows
by Johannes.Hofmann＠gmx.de Sept. 16, 2008

Sept. 16, 2008

Hi, the load_images button toggles the global prefs.load_images variable but the buttons of other browser windows are not updated accordingly. Should load_images be a per window variable, or should we update the buttons in all other windows? Also, when switching to load_images=true, the "Load images" entry in the popup menu get's deactivated, even though the images of the current page are not yet loaded. Cheers, Johannes

3 6

[patch] findbar appearance
by Johannes.Hofmann＠gmx.de Sept. 15, 2008

Sept. 15, 2008

Hi, attached path adjusts the findbar to match the appearance of the panel. Cheers, Johannes

1 0

patch: small mem leaks
by corvid＠lavabit.com Sept. 13, 2008

Sept. 13, 2008

Jeremy kindly provided the memory checking output that went with the valgrind logs from the other day. (I knew about the FullScreen one, but might as well comment it out until someone hooks it up.)

1 0

More Cache memory corruption
by onepoint＠starurchin.org Sept. 12, 2008

Sept. 12, 2008

Hi everyone! No, I'm not dead. I am sorry I haven't been able to spend much time on Dillo recently. I've been lurking and it's good to see Dillo getting lots of developer love. Now the bad news: this HTML almost invariably crashes Dillo: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="Content-Type" content="application/xhtml+xml; charset=iso-8859-1" /> </head> <body> </body> </html> The culprit is the <meta...> tag. Dillo always crashes in one of two ways: segmentation fault or glibc detecting memory corruption and aborting. In each case the backtrace from gdb is the same (verified by running Dillo 100 times (it only failed to crash twice)). The backtraces show that the Cache_* functions are freeing things they should not. Valgrind confirms this. I'm attaching backtraces and a valgrind log. I'm not sure how to debug this further. If anyone can suggest ways to trace this further I'll have a go. Looking forward to the dill2 release! This will be a great milestone. Jeremy Henty

3 3

Missing include directive for OpenBSD?
by Christian.Kellermann＠nefkom.net Sept. 12, 2008

Sept. 12, 2008

Dear List, I have not updated dillo2 for a long time. Now that I have done so I see that I have missed a lot! I needed the following tiny patch to allow compilation on my OpenBSD 4.3 System: Index: dw/style.cc =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/style.cc,v retrieving revision 1.10 diff -b -u -p -r1.10 style.cc --- dw/style.cc 5 Sep 2008 12:58:52 -0000 1.10 +++ dw/style.cc 7 Sep 2008 11:50:08 -0000 @@ -24,6 +24,7 @@ #include <string.h> #include <unistd.h> #include <ctype.h> +#include <sys/stdint.h> #include "core.hh" I am not sure whether this should have been caught by an autoconfig check. Can someone point me into the right direction so this can be changed to a proper patch? Thanks for your efforts and please keep up the good work! Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

3 6

patch: more widget coloring
by corvid＠lavabit.com Sept. 11, 2008

Sept. 11, 2008

My main forms testing page has bg #00ffff from when I was first experimenting with widget colors. Some time ago, fltk changed so that selected checkboxes and radio buttons use selection_color(). I had this set to the inverse of the background. Red. Not a good combination to say the least. Well, I finally got around to trying to fix it up a little. By the way, I was looking at that big page of inputs with differently-colored backgrounds that I made in February... At the time, I wrote that you guys had gotten the page down to 0:06 to load with clear_double_buffer(), immediate to load without it, and 0:09 to destroy the page. The good news is that it now takes the same amount of time with or without clear_double_buffer(), but the bad news is that it takes 0:12 to load and 0:48 to close.

3 7

[patch] remove asap parameter
by Johannes.Hofmann＠gmx.de Sept. 10, 2008

Sept. 10, 2008

Hi Jorge, any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now. Cheers, Johannes

2 6

assertion failed during wildly clicking on links
by akemnade＠tzi.de Sept. 10, 2008

Sept. 10, 2008

Hi, I have seen the following, when clikling multiple times very fast on a link: Nav_open_url: new url='http://www.dwd.de/sid_520SLCXTTJJbtdSgR7JTsLGvkNt6TkS9ssWxDtLpSvVZtPCcyjPG!…' Connecting to 141.38.3.62 DilloHtml(): content type: text/html; charset=UTF-8 *** [unknown] Assertion failed! *** anchor 'headline_color_324A92' not defined Aborted I tried www.dwd.de and then to click Wetter&Warnungen and the corresponding link. I have not looked into the source yet, but I think there is a ressource management problem. Greetings Andreas Kemnade

2 3

default font_factor
by Johannes.Hofmann＠gmx.de Sept. 8, 2008

Sept. 8, 2008

Hi, recently the the default font_factor was changed from 1.0 to 1.2. Is there a reason for this change? Cheers, Johannes

3 4

an example of page redraw problem when images load
by corvid＠lavabit.com Sept. 8, 2008

Sept. 8, 2008

With automatic image loading turned off, if I go to http://genode.org/documentation/developer-resources/walk_through , page down to the [IMG] below "The launchpad application starter", and click on it, the space to the right of the image still contains remnants of the text that used to be there.

3 7