- Dillo-dev - lists.mailman3.com

[patch]: use $(srcdir) in Make rules
by onepoint＠starurchin.org Dec. 19, 2008

Dec. 19, 2008

I was revising the autoconf docs and noticed that make rules should prefix all sources with $(srcdir) to support separate builds[1]. We don't do this, so here's a patch. (Patch generated with Mercurial Queues, BTW.) Jeremy Henty [1]: (autoconf.info)Installation Directory Variables

3 6

revision control and other project infrastructure
by dillo-dev＠toykeeper.net Dec. 18, 2008

Dec. 18, 2008

Hello. I noticed some recent messages about revision control and possibly switching to a DVCS. This makes me happy. :) So, I was wondering about general project infrastructure... things like bug trackers, todo lists, mailing lists, help forums, release management, news, patch queues and code review, code repositories, etc. What I've found so far is the following: dillo.org: - general project info - release tarballs - bug list - FAQ auriga.wearlab.de: - mailing lists - cvs freshmeat.net: release announcements freenode: IRC (inactive?) http://misc.andi.de1.cc/dillo/ : Packaging for Debian, Ubuntu, Openmoko http://www.hyperborea.org/software/dillo/ : Packaging for Red Hat http://freehg.org/u/dillo/css-prototype : Prototype CSS branch Is that about right? Did I miss anything? -- Scott

6 9

dillo_dbg_rendering
by corvid＠lavabit.com Dec. 16, 2008

Dec. 16, 2008

I'm finally bored enough to copy the cmdline code from dillo1. Does anyone care about the dillo_dbg_rendering option? It forces borders in table.cc.

2 1

shaded colors and css
by Johannes.Hofmann＠gmx.de Dec. 15, 2008

Dec. 15, 2008

Hello, mapping css properties to dw::core::style::Style members went very smooth, because Style was obviously implemented with css in mind. Just for the shaded color thing I can't find a corresponding concept in css. What exactly is the definition of a shaded color? Is it just a bit darker than the normal one? Does anyone know the corresponding concept in css? Cheers, Johannes

2 4

Plans for the near future
by jcid＠dillo.org Dec. 11, 2008

Dec. 11, 2008

Hi there, Sorry for the unresponsiveness. I'm too busy in my regular job these days... Besides that, I've read the mailing list and gave some thought to these interesting topics. 1.- CSS plan (basic) 2.- Basic authentication 3.- Toolbox Icon 4.- Gmail compatibility (at least read/send) 5.- Close icon in Tab label 6.- Switch to mercurial I believe our next release would attract more people if it had, at least, implemented a couple in the {1,2,3,4,5} set. ----------------- A bit more detail: ----------------- 1.- CSS plan (basic) a) I have to implement the network retrieval of CSS stylesheets, so Johannes can continue working from there. b) Deciding a basic CSS set (e.g. just colors) is the next step before including it in the main tree c) Hooking it to a dillorc preference and to point 3.- (Read below) 2.- Basic authentication a) I have to review this patch after working on point 1.- b) This is a very requested feature after CSS. It'd be great to have it working. 3.- Toolbox Icon a) Since a long time ago I'd like to have a Toolbox icon to the right of bookmarks with a drop down menu. Something like: [Tb Icon] .-------------------. .---------. | Change charset >|--------------------------------->| UTF-8 | | Force my colors >|-------------------->.-----. | Latin1 | | CSS >|---------->.-----. | On | | Cp 1250 | | Free memory >|--. | On | | Off | | ... | '-------------------' | | Off | '-----' '---------' | '-----' | .------------------. '->| Images | | Local Files | | Everything unused | '-------------------' 4.- Gmail compatibility (at least read/send) a) From what I read it's clear that at least it can be made to work with some tweaks. What do we need to have it working out of the box? b) It'd make a nice headline! ("Fast Read/Send from gmail"). 5.- Close icon in Tab label a) This is much needed as anyone using Tabs has experienced. b) Not too hard to implement, but I have to work on 1 and 2. 6.- Switch to mercurial a) From comments it looks like switching to Hg is a good idea. b) Yes, I'm only updating Mercurial these days as an experiment. c) Switching as soon as I have some time to do it. Probably after 1.- and 2.- -- Cheers Jorge.-

4 4

Dillo and Gmail
by daniel.victoria＠gmail.com Dec. 10, 2008

Dec. 10, 2008

Hi all, First off, I got to say, congrats on the great browser. I have an old laptop and firefox just takes ages to load. Dillo, on the other hand, is lightning fast! Great! The only thing I'm missing is Gmail. Does Dillo work with gmail? Do I need to do any special tricks? I compiled the latest DIllo2 from svn and I did enabled https so I can get past the login page but then I'm stuck at a warning page about a non-standard redirect and, the link on that page does not work. The link is: https://www.google.com/accounts/CheckCookie?continue=http%3A%2F%2Fmail.goog… Thanks for the great work Daniel

4 4

Thoughts on revision control
by onepoint＠starurchin.org Dec. 10, 2008

Dec. 10, 2008

I've been using git to manage the Dillo source locally. I just installed mercurial to experiment with. Things I like about git are the ability to rebase, ie. reorder patches. This is neat because I can develop a patch on top of my local modifications and then push it down the stack so that I submit a patch against the pristine source rather than my customised version. The ability to stash your current changes in a temporary branch is useful too. You could do all this with explicit branches, but it would be more involved and git gives you nice, quick and easy ways to do the same thing. Mercurial seems to be the same sort of beast, though perhaps it is a bit less of a "Swiss Army Chainsaw" than git. I'd be surprised if there were any real issues using either to manage Dillo since I doubt we'd be using anything more than the basic facilities that both offer. I'd prefer git but only out of laziness as it's the one I already know (which means I should probably investigate mercurial just to broaden my mind if nothing else). Regards, Jeremy Henty

2 2

empty html elements
by Johannes.Hofmann＠gmx.de Dec. 10, 2008

Dec. 10, 2008

Hi, while working on css I came across the following: <a class="d" name="INCR32"/> (found at [1]) dillo currently doesn't recognize that the element is empty. The relevant code is at html.cc:3530: /* Test for </x>, ReqTagClose, <x /> and <x/> */ if (*start == '/' || /* </x> */ html->ReqTagClose || /* request */ (tag[tagsize - 2] == '/' && /* XML: */ (isspace(tag[tagsize - 3]) || /* <x /> */ (size_t)tagsize == strlen(Tags[ni].name) + 3))) { /* <x/> */ We could simply drop the requirement for the blank before '/' which would lead to /* Test for </x>, ReqTagClose, <x /> and <x/> */ if (*start == '/' || /* </x> */ html->ReqTagClose || /* request */ (tag[tagsize - 2] == '/')) { /* XML */ or allow a '"' instead of the blank or keep things as they are, if XML requires a blank before the '/'. >From http://www.w3.org/TR/2006/REC-xml-20060816/#sec-starttags I'd say the blank is optional. What do you think? Cheers, Johannes [1] http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc/port…

5 11

how about a form menu?
by corvid＠lavabit.com Dec. 9, 2008

Dec. 9, 2008

I was playing around with making a form menu. So far: 1) Submit. Nicer from the user's perspective than prefs.generate_submit. 2) Reset. Not really needed when you can just press back and forward. 3) Show/Hide Hiddens. Lets you edit them, which I believe the user should have the power to do. ..and thinking of making an Info option to show submission charset and, oh, whatever else. What I have now is icky proof-of-concept code (although it's been working fine), so I want to see how well the idea goes over before trying to clean it up.

2 2

Html_tag_close_* called twice
by Johannes.Hofmann＠gmx.de Dec. 8, 2008

Dec. 8, 2008

Hi, corvid pointed out that Html_tag_close_* functions are getting called twice. This is causing problems when parsing <style>...</style> contents in Html_tag_close_style() as done in css-prototype now. We could work around this somehow, but wouldn't it be cleaner to make sure Html_tag_close_* is called just once, when an element is closed? Cheers, Johannes

2 1

[ladislav@distrowatch.com: Re: Donation for Dillo]
by jcid＠dillo.org Dec. 7, 2008

Dec. 7, 2008

FYI, -- Cheers Jorge.-

1 0

[patch]: Basic Authentication (updated)
by onepoint＠starurchin.org Dec. 6, 2008

Dec. 6, 2008

New version, slightly amended as per previous comments. Changes: * Fixed a memory leak in Realm_add_path(). * Case-insensitive comparison in Host_from_url(). * Moved the Auth header to between Accept-Encoding and Host in a_Http_make_query_str(). Please comment, Jeremy Henty

2 2

css progress
by Johannes.Hofmann＠gmx.de Dec. 4, 2008

Dec. 4, 2008

Hi, http://freehg.org/u/dillo/css-prototype now contains an extended CSS parser that can handle more complex CSS selectors. With this, some other changes, manual stylesheet download, and some tweaking, the fltk homepage looks like this: http://www.ecademix.com/JohannesHofmann/tmp/dillo-fltk.png Cheers, Johannes

3 7

dialog to change charset
by corvid＠lavabit.com Dec. 2, 2008

Dec. 2, 2008

I know that Jorge finds a charset selection dialog where the user has to know what to enter to be insufficiently user-friendly, but I don't know a nice alternative, and this can go in the dillo-dev archives for anyone who wants it.

3 7

Re: patch: middle-click submits in new window/tab
by jcid＠dillo.org Dec. 1, 2008

Dec. 1, 2008

On Fri, Nov 28, 2008 at 10:08:21PM +0000, corvid wrote: > > Now if I go to: > > > > http://www.dillo.org/bugtrack/Dremove.html > > > > and fill the entries with the keyboard, then TAB to the submit > > button and press ENTER, nothing happens. > > > > Doing the same, with the unpatched version, works OK here... > > Here's one with the widgetCallback stuff changed in fltkui.cc > Middle click submits in new tab was committed! With this minor changes: * A compiler warning fix * An event_key() test instead of event_button() because the latter may return garbage. It may be safer. BTW, now it submits with Enter but not with Space. -- Cheers Jorge.-

2 2

Basic Authentication: what's happening here?
by onepoint＠starurchin.org Nov. 28, 2008

Nov. 28, 2008

OK, after reviewing the links people sent in (thanks!) and the discussion at [1] I decided not to create a DPI. I've hit a strange problem with getting the page to reload after the user confirms the user/password dialog. I show the dialog in Cache_parse_header() by calling fltk::Window::exec() and set a new CA_Reload flag (which is just like CA_Redirect, but simpler) if the user confirms. Cache_process_queue() then handles the CA_Reload. *But* Cache_process_queue() runs before the window is closed, and therefore before the flag is set. It looks as though the rest of the data comes in asynchronously while the dialog is still showing. If I change a_Auth_do_auth() to return immediately instead of showing a dialog then Cache_process_queue() runs after the flag is set, as I would expect. Is there any way to stop this happening, or do I have to postpone showing the dialog until Cache_process_queue() runs? Patch attached if you wish to experiment (it doesn't do authentication but it demonstrates the problem with the dialog). Regards, Jeremy Henty [1] http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-October/005023.html

2 4

Q: Thoughts on a user/password dialog for an HTTP AUTH dpi?
by onepoint＠starurchin.org Nov. 27, 2008

Nov. 27, 2008

I'm implementing an HTTP AUTH dpi (based on the cookies dpi) and I'd appreciate comments on how I'm doing it. (Motivation: (a) I'm tired of the irony of having to use Firefox to log on to the FLTK Trac Wiki to update the Dillo page, (b) this will be a useful primer for hacking on the https dpi.) The problem is that the dpi must prompt the user for a username and password but src/dialog.cc only supports dialogs that present a choice of buttons. I think I'll have to add a_Dialog_user_passwd() to src/dialog.cc to create a modal dialog, return the clicked button and write the contents of the dialog entries into a struct. Then I can add a wrapper for it to src/dpiapi.c and hook it into a_Capi_ccc(). That will let the dpi query the user. Is this a good way to do it or is there a smarter way? All comments and advice are welcome. Regards, Jeremy Henty

4 6

experimental patch: tooltip decodes urlencoded Location
by corvid＠lavabit.com Nov. 25, 2008

Nov. 25, 2008

For example, if you go to el.wikipedia.org, it redirects to http://el.wikipedia.org/wiki/%CE%9A%CF%8D%CF%81%CE%B9%CE%B1_%CE%A3%CE%B5%CE… and the location tooltip shows that this means http://el.wikipedia.org/wiki/?????_??????

1 0

css todo
by Johannes.Hofmann＠gmx.de Nov. 23, 2008

Nov. 23, 2008

Hi, here's the current todo list: * convert more of html.cc and form.cc to the new style handling. see Html_tag_open_a() as an example. Basically every style change that happens due to an HTML attribute (e.g. bgcolor="black") should be handled by passing a corresponding hint in CSS form to the styleEnginge using the setNonCssHints() methods. This way these attributes can be overridden e.g. by the user stylesheet as defined in the CSS standard. Other styling that is fixed for the HTML element in question (e.g. font size changes caused by <small>) should be replaced by corresponding entries in the user-agent stylesheet (see CssContext::buildUserAgentStyle()). There is an example user-agent stylesheet at http://www.w3.org/TR/CSS21/sample.html One of the more complex parts to convert is list handling (Html_tag_open_li()). * Reenable shaded colors as default for table borders. However CSS21 states (http://www.w3.org/TR/CSS21/box.html#border-color-properties) "If an element's border color is not specified with a border property, user agents must use the value of the element's 'color' property as the computed value for the border color." Not sure what to do here. What do you think? * Switch "width" and "height" handling from dw::core::style::Length to CssLength. Problem is how to handle relative lengths as they occur in Html_parse_length_or_multi_length(). They don't seem to exist in the CSS model. * Remove functions from html.cc that are now empty (e.g. Html_tag_open_em()). DilloHtml should be able to handle NULL for TagOpenFunct and TagCloseFunct of TagInfo. Or we could use a default function. * Enhance the CSS parser (or tokenizer) to properly ignore CSS comments. * Enhance the CSS parser to handle more complex CSS selector definitions (see http://www.w3.org/TR/CSS21/selector.html) * Figure out how to implement more complex selectors in the CssSelector class. At the same time think about how to speed up selector matching (currently on every opening tag all selectors are checked). Cheers, Johannes

1 0

css-prototype repository has moved
by Johannes.Hofmann＠gmx.de Nov. 23, 2008

Nov. 23, 2008

Hi, at freehg.org I created a new account "dillo" which now holds the css-prototype repository and a copy of current cvs which I will update regularily: http://freehg.org/u/dillo/css-prototype http://freehg.org/u/dillo/main Cheers, Johannes

1 0

New developers?
by jcid＠dillo.org Nov. 22, 2008

Nov. 22, 2008

Hi, Some people have written me expressing their will to join as developers. They have introduced themselves, asked questions and for some advice. I've answered, hinted and made suggestions. Since all of them have remained silent, I wonder whether they are concentrated studying the code, or simply changed their mind... Are you still there? -- Cheers Jorge.-

2 1

[jcid@dillo.org: Re: CSS merge looks great!]
by jcid＠dillo.org Nov. 22, 2008

Nov. 22, 2008

FYI, -- Cheers Jorge.-

2 2

A warning about HTTPS and proxies
by corvid＠lavabit.com Nov. 21, 2008

Nov. 21, 2008

In the dillo 2.0 dillorc, I had written that HTTPS uses wget, and that configuring wget to use a proxy would therefore send https traffic through it. That's wrong; I was repeating outdated information. Right now, HTTPS will not use a proxy at all. I bring this to your attention in case it matters to those using Tor and the like. ------ In other news, have you noticed that the dillo website is particularly speedy now? Andreas turned on HTTP compression :)

1 0

[Johannes.Hofmann@gmx.de: Re: CSS merge looks great!]
by jcid＠dillo.org Nov. 21, 2008

Nov. 21, 2008

FYI, -- Cheers Jorge.-

1 0

[Johannes.Hofmann@gmx.de: Re: CSS merge looks great!]
by jcid＠dillo.org Nov. 21, 2008

Nov. 21, 2008

FYI, -- Cheers Jorge.-

1 0

[jcid@dillo.org: CSS merge looks great!]
by jcid＠dillo.org Nov. 21, 2008

Nov. 21, 2008

FYI, -- Cheers Jorge.-

1 0

a list of what dillo2 runs on
by corvid＠lavabit.com Nov. 20, 2008

Nov. 20, 2008

I want to get the status of everything in order to update http://www.dillo.org/Compatibility.html for dillo2. Linux x86 - works DragonFlyBSD - works Linux x86-64 - Justus was and is making snapshots, but I don't know whether he uses them much. Solaris 10 - Justus reported that it was running, but I believe it was just a quick test. OSX - Jorge reports that it works but is currently flaky. *BSD - Some of the mailing list traffic in October was devoted to getting them working. Presumably it would have been mentioned here if they had stopped working since, but... other - no idea. Looking back at what I just wrote, let me clarify that I meant that dillo2-on-osx is flaky, not that Jorge is flaky :)

9 16

Pending issues
by jcid＠dillo.org Nov. 18, 2008

Nov. 18, 2008

Hi there, For those of you that wrote me willing to join the project as developers, and to the older ones too ;), here's a pending list of simple matters that need patches. Just in case! 1.- Check the "pending issues" dillo thread in FLTK' site: http://fltk.org/newsgroups.php?gfltk.general+T (search for "dillo") there you'll find a few and some hints too. 2.- CLI From dillo1: $ dillo1 --help Usage: dillo [OPTIONS] [URL|FILE]... Options: -x, --xid XID Open first Dillo window in an existing GtkSocket which window ID is XID (decimal). -v, --version Display version info and exit. -h, --help Display this help text and exit. -f, --fullwindow Start in full window mode: hide address bar, navigation buttons, menu, and status bar. -l, --local Don't follow links for this URL(s). -g, -geometry GEO Set initial window position where GEO is <width>x<height>{+-}<x>{+-}<y> -D, --debug-rendering Draw additionaly several lines in a web page, representing its structure. For debugging. URL URL to browse. FILE Local FILE to vie We need to mimic this. The only complex point is XID option. We don't yet know how to do window embedding by XID with FLTK2. Asking in FLTK general may help. I hope this gets somebody started. /me goes back, to CSS. -- Cheers Jorge.-

6 24

RE: what dillo2 runs on.
by CHalbersma.12＠westminster-mo.edu Nov. 17, 2008

Nov. 17, 2008

I've been able to get dillo2 to compile and run on a Damn Small Linux box. Obviously you need to compile fltk2 first but dillo2 seems to run although it does have some troubles. As soon as I find them I hope to be able to post a DSL package. CRH On Mon, Aug 18, 2008 at 02:24:21AM +0000, corvid wrote: > I want to get the status of everything in order to update > http://www.dillo.org/Compatibility.html for dillo2. > > Linux x86 - works > DragonFlyBSD - works > > Linux x86-64 - Justus was and is making snapshots, but I don't know whether > he uses them much. > Solaris 10 - Justus reported that it was running, but I believe it was just > a quick test. > OSX - Jorge reports that it works but is currently flaky. > > *BSD - Some of the mailing list traffic in October was devoted to getting > them working. Presumably it would have been mentioned here if they > had stopped working since, but... > > other - no idea. > > Looking back at what I just wrote, let me clarify that I meant that > dillo2-on-osx is flaky, not that Jorge is flaky :) > Debian Linux m68k works (cvs 14 Nov 2008) -- Qne's mind, once stretched by a new idea, never regains its original dimensions. -Oliver Wendell Holmes

1 0

Strange mouse/keyboard issues
by james＠bsdgroup.org Nov. 15, 2008

Nov. 15, 2008

Hello everyone, I have two somewhat similar issues related to dillo and losing keyboard/mouse focus. This could be an issue with fltk2. The first involves mouse clicks registering on different buttons. When running e17 if you start dillo in one virtual screen then switch to another and then back again, when you a user tried to click the back button instead the forward/home button was highlighted. The problem was fixed by forcing the dillo window to redraw. The second issue involves running dillo with dwm in one tag then switching to another tag and then back again. This time keystrokes seem to get lost. To fix this problem I have to toggle the dwm meta key (in my case this is the windows key, but it could be ctrl or alt instead). Has anyone else seen similar issues? Thanks. -- James Turner BSD Group Consulting http://www.bsdgroup.org

2 1

more css progress
by Johannes.Hofmann＠gmx.de Nov. 13, 2008

Nov. 13, 2008

Hi, the dillo-css-prototype is now able to parse a user stylesheet from ~/.dillo/style.css if it exists. This allows to modify the appearance in various ways. Currently I have the following in my ~/.dillo/style.css: body {margin-left: 10mm; margin-top: 10mm; background-color: #F5F5F5;} :link {color: gray !important; text-decoration: none; font-weight: bolder; } :visited {color: olive !important; text-decoration: none; font-weight: bolder; } Note that I'm no designer so the result may hurt your eyes! Cheers, Johannes

1 0

css progress
by Johannes.Hofmann＠gmx.de Nov. 12, 2008

Nov. 12, 2008

Hi, I just pushed my latest changes to the css prototype repository. The css parser from dillo-0.8.0-css-3 is now integrated and working. The user agent style is parsed from a char buffer (see CssContext::buildUserAgentStyle() in css.cc). Of course the code is still full of bugs and missing stuff, but it shows that things basically work as expected. This is starting to be fun! Cheers, Johannes

1 0

the Http_must_use_proxy change in CVS
by corvid＠lavabit.com Nov. 11, 2008

Nov. 11, 2008

Is something missing? It gives me a warning because we're sending it a char* now.

2 1

Greetings! -- With Patches :-)
by list-jcr＠designtools.org Nov. 11, 2008

Nov. 11, 2008

Hi list, I guess the best way to show up on a development list is with patches, so I've attached two of them. The diffs were created against cvs with: $ cd /home/jcr/dillo-src/dillo2 $ cvs -d$CVS_DILLO diff -u There was no mention on the site about the preferred diff format, but since I found a few patches in the list archives using "universal" I figured it was the safest bet. Though I've read the docs on dillo.org about submitting bug reports first, and then patches, the first of the patches below is to a feature that has not yet been committed. The first is to fix an over-sight in the following post/patch posted to this mailing list: http://article.gmane.org/gmane.comp.web.dillo.devel/6248 The above patch does not take into consideration font size, so the result can be microscopic/unreadable fonts. I've added the code to scale the font in the same way as you scale other fonts in dillo. Though I've read enough of the dillo docs and code to grasp the basics of formatting, I'm unsure if my formatting of the continuation (split line) is "correct" according to your standards. There are other places in the dillo UI where font handling is still incorrect and can result in unreadable fonts. Some of this is the fault of fltk, since as far as I know there is no ~/.gtkrc equivalent to set defaults for the tool kit. With luck, I'll find and fix them. The second patch is for BUG #832 --If I read things correctly, I'm supposed to file a bug report first, assign it to myself, and then send in patches. Unfortunately, I screwed up pasting my email address in the "submitter" section due to the fact that dillo doesn't actually copy selected text in a form (i.e. with the select/paste of the plain old X Window System). If you want to correct the submitter on the bug to my email address, it would be appreciated. There was no way I could correct it myself. On all popup menus in dillo, you have a non-typical and non-functional "label" (or better said "title") on the displayed popup menu. This was my first adventute into fltk, but according to the fltk2 docs, if you set the "label" of the popup menu to NULL, the "label" will not be shown. You can do it one of two ways, (1) setting the lable to NULL in the instantiation of the class or (2) using the ->label() member function to set the label to NULL. I opted for the former because it's more clean than the latter. Though there were "Accelerator" key bindings in the labels (such as "&PAGE OPTIONS" to get enable win32 meun-ish "<ALT>-P" activation), they don't actually work since the popup menu type ("POPUP123") means they are completely hidden until activated by the mouse buttons. There is still a popup menu placement issue (annoyance) with the Bug Meter when running dillo in full screen (or to the bottom edge of your screen) but it seems to be caused by the fltk "remember last selected" option. It does not properly realize the bottom edge of the screen/window, so some popup menu options are off-screen and you need a mouse-wheel movement to access them. Anyhow, I hope this helps. Kind Regards, Jon Index: src/dillo.cc =================================================================== RCS file: /sfhome/cvs/dillo/dillo2/src/dillo.cc,v retrieving revision 1.15 diff -u -r1.15 dillo.cc --- src/dillo.cc 10 Oct 2008 20:39:34 -0000 1.15 +++ src/dillo.cc 9 Nov 2008 19:43:45 -0000 @@ -21,9 +21,10 @@ #include <stdio.h> #include <unistd.h> #include <stdlib.h> +#include <math.h> /* for rint() */ #include <time.h> #include <signal.h> - +#include <fltk/Font.h> #include <fltk/Window.h> #include <fltk/TabGroup.h> #include <fltk/run.h> @@ -108,6 +109,16 @@ // WORKAROUND: sometimes the default pager triggers redraw storms fltk::TabGroup::default_pager(fltk::PAGER_SHRINK); + // Fix UI Fonts + fltk::Font *dfont = fltk::font(prefs.vw_fontname, 0); + if (dfont) { + fltk::Widget::default_style->textfont(dfont); + fltk::Widget::default_style->textsize( + (int) rint(14.0 * prefs.font_factor)); + fltk::Widget::default_style->labelfont(dfont); + } + + // Create a new UI/bw pair BrowserWindow *bw = a_UIcmd_browser_window_new(0, 0, NULL); Index: src/menu.cc =================================================================== RCS file: /sfhome/cvs/dillo/dillo2/src/menu.cc,v retrieving revision 1.23 diff -u -r1.23 menu.cc --- src/menu.cc 22 Oct 2008 18:05:38 -0000 1.23 +++ src/menu.cc 9 Nov 2008 19:43:46 -0000 @@ -308,7 +308,7 @@ if (!pm) { Item *i; - pm = new PopupMenu(0,0,0,0,"&PAGE OPTIONS"); + pm = new PopupMenu(0,0,0,0,NULL); pm->begin(); i = new Item("View page Source"); i->callback(Menu_view_page_source_cb); @@ -360,7 +360,7 @@ popup_url = a_Url_dup(url); if (!pm) { Item *i; - pm = new PopupMenu(0,0,0,0,"&LINK OPTIONS"); + pm = new PopupMenu(0,0,0,0,NULL); //pm->callback(Menu_link_cb, url); pm->begin(); i = new Item("Open Link in New Window"); @@ -404,7 +404,7 @@ if (!pm) { Item *i; - pm = new PopupMenu(0,0,0,0,"&IMAGE OPTIONS"); + pm = new PopupMenu(0,0,0,0,NULL); pm->begin(); i = new Item("Isolate Image"); i->callback(Menu_open_url_cb); @@ -478,10 +478,10 @@ new Divider(); i = new Item("Exit Dillo", ALT+'q', filemenu_cb, (void*)"ed"); pm->type(PopupMenu::POPUP123); + pm->label(wid->visible() ? NULL : "File"); pm->end(); } - pm->label(wid->visible() ? NULL : "File"); a_Timeout_add(0.0, Menu_popup_cb2, (void *)pm); } @@ -498,7 +498,7 @@ popup_url = a_Url_dup(url); if (!pm) { Item *i; - pm = new PopupMenu(0,0,0,0,"&BUG METER OPTIONS"); + pm = new PopupMenu(0,0,0,0,NULL); pm->begin(); i = new Item("Validate URL with W3C"); i->callback(Menu_bugmeter_validate_w3c_cb); @@ -536,9 +536,9 @@ dFree(history_list); if (direction == -1) { - pm = new PopupMenu(0,0,0,0, "&PREVIOUS PAGES"); + pm = new PopupMenu(0,0,0,0,NULL); } else { - pm = new PopupMenu(0,0,0,0, "&FOLLOWING PAGES"); + pm = new PopupMenu(0,0,0,0,NULL); } // Get a list of URLs for this popup

3 9

Re: patch: middle-click submits in new window/tab
by jcid＠dillo.org Nov. 10, 2008

Nov. 10, 2008

On Mon, Oct 20, 2008 at 02:49:41PM +0000, corvid wrote: > I could say that it was for the sake of consistency with link behavior, > but really it was because it seemed like a dilloishly simple way > to get the equivalent of pages-remember-form-data. The consistency part is a strong argument. Also interesting is the way we can have a workaround to remember form data, before a more usual way of handling it is implemented. > > (But: who will ever discover that it exists or recognize what it > makes possible?) It may be stated in the FAQ. > 1) fltkui: it might be better to stuff all of the button event stuff > into a bag like fltkviewbase/layout do with EventButton. It certainly > looks nicer having something like a shift mask hidden away in a nice > tidy box, but I wasn't sure that it was actually worth doing. Hmm, I'd say if it's going to be a definitive patch, it's worth the effort. > 2) form: carrying around buttonNo+shifted for a long time > is not pleasing, but oh well. Agreed. Now that Johannes is interested in implementing FORM "memory", I'd say it can be stored in an URL/form-data array. I haven't checked how other browsers (e.g. FF) solve the problem of privacy (aka. when it's desirable to remember data), but most probably a quick look will shed some light. BTW, I can't compile the patch here because: make[2]: Entering directory `/home/jcid/C/Dillo/d2/dillo2-cur/test' form.cc: In member function 'void form::Form::addButtonResource(const char*, dw::core::ui::ButtonResource*, const char*)': form.cc:241: error: cannot allocate an object of abstract type 'form::Form::FormClickedReceiver' form.hh:124: note: because the following virtual functions are pure within 'form::Form::FormClickedReceiver': ../dw/ui.hh:338: note: virtual void dw::core::ui::ButtonResource::ClickedReceiver::clicked(dw::core::ui::ButtonReso urce*, int, int) make[2]: *** [form.o] Error 1 make[2]: Leaving directory `/home/jcid/C/Dillo/d2/dillo2-cur/test' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/jcid/C/Dillo/d2/dillo2-cur' BTW2: * The patch changes from "Activate" to "Clicked" signal. * It also seems to change the logic in DilloHtmlInput::activate() - it makes me wonder whether pressing enter on other form widgets may submit. Anyway, it'd be good if you can coordinate with Johannes and decide what approach to take, and send a new patch for it. I'd prefer Johannes to keep working in the CSS front, and you to make the definitive patch, but this is for you guys to decide. -- Cheers Jorge.-

3 3

patch: prefs.vw_fontname as fltk ui's default font
by corvid＠lavabit.com Nov. 10, 2008

Nov. 10, 2008

I was changing the font in a few more places that can take arbitrary user text -- and then having to change it for neighbouring things so that the difference isn't too jarring -- and I reached the point where it seemed like it may be best just to change the font for everything.

3 4

patch: click elsewhere on page, fltk widget loses focus
by corvid＠lavabit.com Nov. 10, 2008

Nov. 10, 2008

{my usual dw disclaimer}, but it's been working just fine so far.

3 2

rebased patch: print numeric addresses instead of pointer
by 4winter＠informatik.uni-hamburg.de Nov. 9, 2008

Nov. 9, 2008

Skipped content of type multipart/mixed

2 2

patch: savefile url name
by corvid＠lavabit.com Nov. 9, 2008

Nov. 9, 2008

Anyway, here's a patch that I've had sitting around for a while. I have a bad habit of hitting space to page down when the Location field still has focus, which would break things when trying to save...

2 1

Few more dillo issues
by sandshrew＠gmail.com Nov. 8, 2008

Nov. 8, 2008

Issues: 1) ssl dpi looping when entering: http://www.elitehackers.info/forums 2) logging into kde forum (forum.kde.org) and gmail (which I reported earlier) doesn't seem to work for same reasons. I guess there should be much more similar cases.

1 0

Re: css prototype on freehg.org
by jcid＠dillo.org Nov. 7, 2008

Nov. 7, 2008

Hi, We've been arranging some CSS things behind the scenes with Johannes (he'll forward some past mails here soon). On Fri, Oct 31, 2008 at 05:00:54PM +0100, Johannes Hofmann wrote: > Hi Jorge, > > I just created a repository > http://freehg.org/u/jh33/dillo-css-prototype/ > > freehg.org is a free mercurial hosting service. > This gives access to the newest version of the css prototyping work. > Also you can check whether you like mercurial. > > To get a copy of the repository call > > hg clone http://freehg.org/u/jh33/dillo-css-prototype/ > > and start hacking. You can commit locally using > > hg commit OK, I'll make some patches with Hg once I grasp how this distributed model works. On the current code, basically it looks OK to me. i.e. we can continue working from that basis (having in mind that it's still in a flux state and that a validation is pending on whether the model is able to handle the current functionality in html.cc). My main comment is that the code needs more comments! :) Accurate comments are written when the code is developed (every detail is in the brain then). I've tried in the past to develop first and comment later, and found it only works OK for small code projects. As with CSS we don't have a main expert (yet), the team will be trying to understand and develop at the same time, and thus comments are very necessary. Even something like "I don't know how to implement this part" helps! I'd suggest to use the same format that's in css.cc. e.g. /** \todo dummy only */ with a view to integrate it smoothly with doxygen docs. in the future. Some specific examples: 1.- What do these functions do? - style0() - startElement() - endElement() 2.- On memory handling, there are some places with: // html->styleEngine->style () = // Style::create (HT2LT(html), &style_attrs); // old_style->unref (); or // (html->styleEngine->style ())->unref (); Why are they commented and left in the code? Is proper memory handling pending, is there a design decision to be made before getting rid of them? 3.- With regard, for instance, to font_factor and visited link color. Do they belong to buildUserAgentStyle() or buildUserStyle() or elsewhere? 4.- strdup/free should be dStrdup/dFree (Please let me use this extremely simple case to make my first Hg patch :-) I know this was just a prototype for the CSS implementation idea, but considering that we don't have any better, and that we agreed on it, now it has attained the status of "official CSS merge effort". ;-) From now comments are paramount, and we may eventually get to a dw-like quality docs in the future. Bottom line: Great, let's get started! -- Cheers Jorge.-

2 1

[jcid@dillo.org: Re: css prototype on freehg.org]
by Johannes.Hofmann＠gmx.de Nov. 7, 2008

Nov. 7, 2008

----- Forwarded message from Jorge Arellano Cid <jcid(a)dillo.org> ----- Date: Thu, 6 Nov 2008 14:05:33 -0300 From: Jorge Arellano Cid <jcid(a)dillo.org> To: Johannes Hofmann <Johannes.Hofmann(a)gmx.de> Subject: Re: css prototype on freehg.org On Thu, Nov 06, 2008 at 05:31:34PM +0100, Johannes Hofmann wrote: > > > > I'm currently reviewing the CSS work you uploaded! > > > > On Fri, Oct 31, 2008 at 05:00:54PM +0100, Johannes Hofmann wrote: > > > Hi Jorge, > > > > > > I just created a repository > > > http://freehg.org/u/jh33/dillo-css-prototype/ > > > > > > freehg.org is a free mercurial hosting service. > > > This gives access to the newest version of the css prototyping work. > > > Also you can check whether you like mercurial. > > > > Hmm, that's another topic that needs a resolution: > > to git or to hg? > > Featurewise there is hardly a difference. I prefer mercurial because > of it's nice and simple ui. > Just recently there was the same discussion for DragonFlyBSD: > http://leaf.dragonflybsd.org/mailarchive/kernel/2008-10/msg00144.html Yes, I also like simple UIs. > > [...] > > Do you have a recommended quick-start guide? > > http://www.selenic.com/mercurial/wiki/index.cgi/QuickStart > > and a bit longer: > > http://www.selenic.com/mercurial/wiki/index.cgi/Tutorial > > and a lot longer: > > http://hgbook.red-bean.com/hgbook.html Thanks. > > > > > I didn't send this to the list, because I want to be sure that you > > > are ok with this step. > > > > Which one, the mercurial or the CSS code? > > Both. Publishing CSS prototype in a separate repository. For now the Hg repository is OK. I'm yet to grasp the distributed workflow model. It seems our old CVS needs an update. > > > > As far as CSS, after the first review it looks OK, and > > seems the way to go. I'm going more in depth now to try to > > understand how it works and fits in the plan. > > Great. Please keep in mind that the current work tries to find a > proper interface between CSS stuff and the code in html.cc. > It needs to be verified that the concept covers all the edge cases. > One is probabely the table code that stores a separate > table_cell_style on the stack. > Is this to hold cell properties that were set in the <table> or <tr> > tags? I'll check. Most probably that's the case though. e.g. bgcolor. OK, once I've grasped the concept, I'll tell you what I find. > > > Also the CSS prototype contains some code from dillo-0.8.0-css-3 > > > that doesn't have license headers. Can you contact Sebastian to ask > > > if it is ok to use stuff from his prototype? > > > > I have an email from him (long time ago) where he advocates > > on making the CSS prototype code more visible from the website, > > to attract developers. He also said he was working on floating objects! > > > > I'll try to contact him and see what's up with him... > > > > As from his email, and conversations we had long ago, > > I believe it's quite safe to use the code. > > Great. It seems to contain a pretty complete CSS parser. > > Cheers, > Johannes > > PS: We should probabely take this discussion to the list. It's a bit > quiet there. What do You think? Sure, feel free to forward the thread (or relevant parts). -- Cheers Jorge.- ----- End forwarded message -----

1 0

Dillo too fast?
by thomas-forum＠orgis.org Nov. 7, 2008

Nov. 7, 2008

Did anyone else encounter this from google? Not sure if this is something specific in dillo's network behaviour... > We're sorry... > ... but your query looks similar to automated requests from a computer virus or spyware application. To protect our users, > we can't process your request right now. It's at least the second time I got this now, after issuing a search, seeing that there was a typo, resissuing. It is not that rare that this happens, but it is rare that google slaps me in the face for it ... and I _think_ it has been dillo before, too. But not sure. Anyhow, does someone know what is behind that "virus check"? > If you're continually receiving this error, you may be able to resolve the problem by deleting your Google cookie and > revisiting Google. For browser-specific instructions, please consult your browser's online support center. Hm... I don't have any cookie from 'em. Perhaps that is the key? Alrighty then, Thomas.

3 2

Another mention of Dillo-2
by onepoint＠starurchin.org Nov. 6, 2008

Nov. 6, 2008

"Dillo 2.0 is fast, but limited" http://www.linux.com/feature/151983 Summary: "It's *fast*, even faster than Dillo-1, but too limited to be of use to much people.". It singles out lack of JavaScript, pointing out that most business sites need it (although I'd imagine most business sites would need full SSL support too). Jeremy Henty

1 0

Repost: D_SUN_LEN cleanup (and a typo fix)
by onepoint＠starurchin.org Nov. 5, 2008

Nov. 5, 2008

This is a repost of three tidy-up patches that have been left hanging without resolution. Please comment. 1. Remove unused D_SUN_LEN declarations from DPIs. (The DPIs connect to their sockets with accept() which doesn't use D_SUN_LEN.) 2. Use D_SUN_LEN whenever calling connect() on a struct sockaddr_un. (Some of the calls already did this, this patch makes all of them do so.) 3. Update a GPL reference in a comment from version 2 to version 3. Regards, Jeremy Henty

2 1

Re: Interested in joining dillo project
by jcid＠dillo.org Nov. 5, 2008

Nov. 5, 2008

On Fri, Oct 31, 2008 at 11:43:35PM +0100, PHELIZOT Yvan wrote: > Hi, > > That me again. And i have a lot of questions: > About management: > * Does we have a functionnalities/features list? We had one inside the funding initiative in the past. It was purposedly removed from the web site because it was not updated (obsolete), and because the funding effort yielded no results. You can still find some info here: http://www.dillo.org/funding/funding.html (go to "Technical Overview"). > For example, i have > seen that png and jpeg are not supported, so does it included in the > file...? That's false. Where did you find that misinformation? > * Is there a task list? to know what to do and with which priority > > Dev : > * How many developpers, testers, ... work on the project? Please check the website. "Current Plans", "Authors", etc. > Software: > * Does the software has a "quirk" mode? Something akin, give read to dillorc. w3c_plus_heuristics=YES -- Cheers Jorge.-

1 0

[patch]: fix the download GUI resize bug
by onepoint＠starurchin.org Oct. 30, 2008

Oct. 30, 2008

There's a bug in the downloads GUI that stops the download items resizing when the window does. The resizable of the window should be the scrollgroup, not the packedgroup. Fixing this means we don't need to explicitly resize the scrollgroup after removing an item (because the window has already resized it) so I took that out. Patch attached. Regards, Jeremy Henty

3 9

reduce warnings with gcc-4.3 [PATCH]
by thomas-forum＠orgis.org Oct. 30, 2008

Oct. 30, 2008

Skipped content of type multipart/mixed

4 5

css
by Johannes.Hofmann＠gmx.de Oct. 30, 2008

Oct. 30, 2008

Hi, here comes my proposal to get css support started. Note that I'm new to this stuff so I will probabely simplify things a lot and miss many issues that will have to be addressed later on. * Separate out the style handling from html.cc in a new class StyleEngine (better name welcome). This class will be fed the html tree via a SAX like interface as the document is parsed and will hand out the current Style object. * Initially StyleEngine will be implemented to just mimic the current behaviour of html.cc. So after this step everything should work as currently. * Then we can design the data structures to hold parsed css data and make StyleEngine use these structures which will be statically filled initially. Again dillo should work as it does now. * Next we can implement a css parser that is able to fill the data structures from the last step. Now we should already be able to set a fixed user style sheet. * Hooking up the css parser to automatically load css information as referenced in html pages would be next. * In parallel to all this we would need to make floating objects work in dw/textblock.cc. This approach has some issues. In contrast to http://www.dillo.org/CSS.html it would only be possible to apply style information that is available when starting parsing of a document. However we could start rendering with what style information is available and reload once all css files have been loaded. Currently dillo parses attributes on demand. So we don't have a complete list of attributes and their values. As StyleEngine might access any attribute, we might need to change this. Comments or more advanced plans would be more than welcome! Cheers, Johannes

3 6

Q: D_SUN_LEN , dpi programs and socket programming
by onepoint＠starurchin.org Oct. 30, 2008

Oct. 30, 2008

The bookmarks and cookies dpis define D_SUN_LEN but don't use it. D_SUN_LEN is used elsewhere by dillo (when calling connect()) and dpid (when calling bind()), but all the dpi programs call accept() with sizeof(struct sockaddr_un) instead of D_SUN_LEN(address). Shouldn't we delete the definition of D_SUN_LEN from the dpi programs since they don't use it? Or maybe they should use it? Which? Regards, Jeremy Henty

2 4