- Dillo-dev - lists.mailman3.com

Server-side CSS detection?
by rn214＠cam.ac.uk March 7, 2009

March 7, 2009

Dear All, I've just joined this list, so I hope I'm posting this in the right place. I'm a webmaster, and I want to make sure that my site works properly in all browsers including dillo. However, some of the new code (*) in my site relies on CSS properties such as display:none and does not gracefully degrade. If a browser has no CSS support, the newest stuff breaks in a very ugly manner, whereas most of the CSS I've written to date fails gracefully (we don't really care if some text-colour is wrong). So my question is, how can I detect CSS support server-side? I don't need to know precise details of the CSS-support; I just want a simple yes/no. So Netscape 4.6 would be "yes", whereas Dillo 0.8, and links/lynx/w3m/googlebot would be "no". I don't want to do it by user-agent sniffing, and, if at all possible, I don't want to rely on javascript (there are plenty of people who have CSS-capable browsers with JS turned off). I've had no luck from google, so I thought I'd ask here, as you'll know the best way to do this. Thank you for your help, Regards, Richard (*) for example, I display HTML tooltips like this: span.tool { position: relative; cursor: help; } span.tool span.tip { display: none;} span.tool:hover span.tip { display: block; z-index: 100; position: absolute; top: 1.6em; left: 0; width: auto; padding: 6px; border: #F00;} <span class='tool'>this is the link <span class='tip'>Here is some <b>html</b> for the tooltip </span> </span> i.e. the tool.tip is normally hidden by display:none, but is displayed as result of the hover action. If a browser doesn't support the CSS display:none property, that will render in a very ugly way, with the tooltip contents displayed inline. So I want to have a way to fall-back (server-side) to: <span title='this is the tooltip, without html'>this is the link </span> My intention is to do this server-side, using a session-variable after testing whether the client supports CSS. But how?

2 1

[patch]: typo fix
by onepoint＠starurchin.org March 6, 2009

March 6, 2009

Nothing else to say, really. Attached. Regards, Jeremy Henty

2 1

Css_next_token() bug
by Johannes.Hofmann＠gmx.de March 6, 2009

March 6, 2009

Hi, can someone (corvid?) please have a look at attached patch that fixes a bug in Css_next_token() (at least I think so). Consider: <div style="font-family: '\''; background-color: red;">foo bar</div> In firefox the background is red, in current dillo not, because the string '\'' is not parsed properly. As I'm still uncertain whether to go the re2c way (there the problem does not exist), I'd like to have this fixed in the standard version. However as the code is pretty subtle it would be nice if someone could have a look. Cheers, Johannes

2 2

allow_white_bg and contrast_visited_color
by Johannes.Hofmann＠gmx.de March 6, 2009

March 6, 2009

On Thu, Mar 05, 2009 at 10:39:23PM +0000, corvid wrote: Committed. Thanks, Johannes

1 0

RFC: Dillo presentation
by onepoint＠starurchin.org March 6, 2009

March 6, 2009

I have agreed to give presentation on Dillo to my local Linux Users Group this Thursday. Naturally I'm leaving it until the last minute to write anything! :-) I am attaching my crib list of essential points to cover. My aim is to give a very short talk covering * project goals * history (Dillo-1, Dillo-2.0, Dillo-2.1, soon) * development model * supported features * architecture (DPI, Dw) * future I'd very much appreciate any comments people have, particularly if you think there's anything important I have missed out. This is your chance to tell me what to tell them. (Just bear in mind that I aim to be brief, so I can't go into large amounts of detail.) Regards, Jeremy Henty

4 5

allow_white_bg and contrast_visited_color
by Johannes.Hofmann＠gmx.de March 5, 2009

March 5, 2009

Hi, as we seem to have agreed on using CSS for style customization intead of dillorc settings, I'm trying to get rid of these: link_color: visited_color: text_color: bg_color: force_my_colors: The same thing can more or less be expressed with a custom user stylesheet, so I want to remove them. The problem is non-HTML pages (plain). I would propose to simulate <body><pre> in this case and use the corresponding style. allow_white_bg: This can't be expressed with CSS. We could detect a white background in StyleEngine (like we detect font sizes smaller than font_min_size), but what color should we use instead in this case (note that it must be different enough from the text color)? contrast_visited_color: This one is hard. Consider we want to render a visited link. >From StyleEngine we get a background and a text color, but we don't know what the text color would have been if the link would not be visited. So we can't enforce a color that is different from that. Generally (and even more with CSS), background- and text-colors can change arbitrarily within a page. So there is not a background and a text color per page. standard_widget_colors: Not sure about this one. On the one hand I think that CSS support broke this. On the other hand CSS allows the page author to directly set colors of form widgets. corvid, can you please have a look? Cheers, Johannes

2 2

clipping image inputs
by corvid＠lavabit.com March 5, 2009

March 5, 2009

With <input type="image" name="name1" src="whatever" WIDTH="80" HEIGHT="14" alt="name1name1name1name1"> <input type="image" name="name2" src="whatever" width="9" height="14" alt="name2name2name2name2"> the long alt text doesn't clip. It looks like the embed knows that it's 80 pixels wide (at least the child widget area stuff in Textblock::drawLine seemed to have the right idea), but the image thinks it's 188 (in my case). PS I have "white-space: nowrap" pretty much working, but I don't know what I'm doing in Textblock very well, so it's definitely not going into this release.

2 5

improving CSS performance
by Johannes.Hofmann＠gmx.de March 5, 2009

March 5, 2009

Hi, I just commited http://hg.dillo.org/dillo?cs=11c6f887d649 which improves CSS performance by avoiding unnecessary style computations. Please give it a thorough testing. Cheers, Johannes

1 0

Re: css parsing numbers
by Johannes.Hofmann＠gmx.de March 3, 2009

March 3, 2009

On Fri, Feb 27, 2009 at 03:29:55PM +0000, corvid wrote: > > On Fri, Feb 27, 2009 at 02:26:03PM +0000, corvid wrote: > > > > Committed. I hoped to be able to make that code a bit shorter, but > > > > could not find a reasonable solution... > > > > > > Yeah. In any case, it's just going to get worse/rearranged again > > > for negative numbers... > > > > Exactly. I started my simplification attempts, added negative number > > support - and blew it all up :) > > I'm really considering a flex based scanner now. What do you think? > > I only touched flex very briefly for a class at school long ago, > and I don't remember anything from the experience, but the > idea interests me since it has to be less trouble than trying > to do it by hand... > I think we just need to try it. Attached is a minimal standalone example based on the "Lexical scanner" from the appendix of the CSS 2.1 spec. To compile it use: flex cssscanner.l gcc -o cssscanner lex.yy.c -lfl It reads from stdin. Cheers, Johannes

2 7

minor leak with CustShrinkTabPager
by Johannes.Hofmann＠gmx.de March 2, 2009

March 2, 2009

Hi, thanks to Jeremy's valgrind log at http://starurchin.org/dillo/valgrind.html I noticed a minor leak with CustShrinkTabPager(). The TabGroup::pager() method internally clones the passed pager, so it must be deleted afterwards, e.g. like this: diff -r 9b0b8ae9b06a src/uicmd.cc --- a/src/uicmd.ccSun Mar 01 12:34:00 2009 +0100 +++ b/src/uicmd.ccMon Mar 02 08:57:02 2009 +0100 @@ -225,7 +225,9 @@ public: CustTabGroup (int x, int y, int ww, int wh, const char *lbl=0) : TabGroup(x,y,ww,wh,lbl) { - this->pager(new CustShrinkTabPager()); + CustShrinkTabPager *cp = new CustShrinkTabPager(); + this->pager(cp); + delete cp; toolTip = new Tooltip; tooltipEnabled = false; buttonPushed = false; Alternatively we could keep one copy around in a static member. Cheers, Johannes

2 1

[bgreer101@earthlink.net: Dillo2 working great with Crux-PPC!]
by jcid＠dillo.org March 2, 2009

March 2, 2009

-- Cheers Jorge.-

1 0

patches, bundles, etc
by dillo-dev＠toykeeper.net March 2, 2009

March 2, 2009

BTW, what's the policy on submitting sizable changes with multiple revisions, such as the configurable keybindings? Is it okay to send a changeset bundle, or do the changes need to be flattened into a single patch? It probably doesn't matter for small changes, but it might be nice to include the history for large changes. -- Scott

7 8

[patch]: remove the workaround for FLTK bug #2084.
by onepoint＠starurchin.org March 2, 2009

March 2, 2009

The dillo source includes a workaround for FLTK bug #2084[1] which was fixed in revision 6507. We currently recommend[2] revision 6525 or later. There's no need to include this workaround any more, so let's remove it. Regards, Jeremy Henty [1] http://www.fltk.org/str.php?L2084 [2] http://www.dillo.org/source.html

2 1

[patch]: fix a memory leak in a_Klist_free()
by onepoint＠starurchin.org March 2, 2009

March 2, 2009

Subject line speaks for itself! Patch attached. Jeremy Henty

2 1

Re: css parsing numbers
by corvid＠lavabit.com Feb. 27, 2009

Feb. 27, 2009

Johannes wrote: > On Wed, Feb 11, 2009 at 06:03:13PM +0000, corvid wrote: > > I tried > > font-size: .6in > > (we still love archaic measurements here) > > and it didn't work. > > > > The grammar says > > num [0-9]+|[0-9]*"."[0-9]+ > > > > Oh yes. That's Css_next_token() which is not recognizing ".6" as a > float... Attached. I'm too much of a css newbie to promise great testing, but I did cobble together the following and the right things seemed to happen: <html> <head> <style type="text/css"> hr.aaaaa {width: 1.5in} bbbbb {width: 2 in} </style> </head> <body> <hr style="width: 0.3in"> <hr style="width: .6in"> <hr style="width: 1 in"> <hr class="aaaaa"> <hr class="bbbbb"> </body </html>

2 4

libDw_fltk_a-fltk*.o naming
by corvid＠lavabit.com Feb. 26, 2009

Feb. 26, 2009

Is there any reason not to shorten them to fltk*.o?

2 1

[patch] Configurable key bindings
by itsme_410＠yahoo.com Feb. 25, 2009

Feb. 25, 2009

Hi Is it possible to have keybindings in the locator bar such as (perhaps configurable) ctrl-enter for www. and .com, Shift-Ctrl-enter for www. and .org, alt-ctrl-enter for www. and .edu and so on? That would really help! Thanks very much!! T > --- On Tue, 2/24/09, Scott Scriven > <dillo-dev(a)toykeeper.net> wrote: > > > From: Scott Scriven <dillo-dev(a)toykeeper.net> > > Subject: Re: [Dillo-dev] [patch] Configurable key > bindings > > To: dillo-dev(a)dillo.org > > Date: Tuesday, February 24, 2009, 3:15 PM > > * Tim Nieradzik <tim.nieradzik(a)gmx.de> wrote: > > > The other advantage of this implementation is > that > > we could > > > easily modify it to allow multiple key bindings > for > > one symbol. > > > > This is a good thing. > > > > > Therefore an "include" command for the > > dillorc should be > > > implemented. Then we could put something like > > "include > > > /usr/share/dillo/bindings/default" there, > as > > well as some > > > others. Now, if somebody wants to try different > key > > bindings, > > > you would just have to uncomment this particular > > line. There > > > is no need for replacing your local bindings just > to > > try others > > > out. > > > > An 'include' command would help me for other > > reasons, too. I > > split most of my config files into shared versus local > > portions, > > so I can have a base config on many hosts and tweak > > individual > > settings per host. > > > > > > Just my $0.02. > > > > > > -- Scott > > > > _______________________________________________ > > Dillo-dev mailing list > > Dillo-dev(a)dillo.org > > > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

1 0

Holiday week
by Hole.destructor＠gmx.de Feb. 23, 2009

Feb. 23, 2009

Hello Jorge, > [ ] https dialog bombing issue. BUG#868 > When enabled, multiple https requests to the same site result > in dialog bombing. The https dpi is disabled by default in > Dillo. Anyway, in Debian, there's a security warning against > dillo for not checking certificates (I don't know what > version of dillo they use, nor why they enable https.) Debian (and Ubuntu) uses a strongly modified version of Dillo-0.8.6, which one can get officially from http://teki.jpn.ph/pc/software/index-e.shtml On the splash screen of debians Dillo it says, that Kiyo <webmaster[at]teki.jpn.ph> is the one to report problems to, so I guess he is the package maintainer or so. Best, Alexander.

1 0

[patch] Hiding panels by pressing "Escape"
by tim.nieradzik＠gmx.de Feb. 20, 2009

Feb. 20, 2009

This small patch allows you to press the "Escape" key in order to hide the panels. It assumes that you are in the UI mode "UI_TEMPORARILY_SHOW_PANELS". --Tim

1 0

[patch] Reloading page by pressing "Enter" in the location box (bug #890)
by tim.nieradzik＠gmx.de Feb. 20, 2009

Feb. 20, 2009

To whom it may concern, I have signed up on the dillo-dev mailing list and would like to introduce myself. My name is Tim Nieradzik. I am new to this mailing list, and I would like to contribute some patches. In the included attachment you will find my first contribution to the Dillo project. It allows users to reload the current page by pressing "Enter" in the location box (bug #890). Sincerely, Tim

1 0

Leaking image structures
by Johannes.Hofmann＠gmx.de Feb. 18, 2009

Feb. 18, 2009

On Wed, Feb 18, 2009 at 08:26:52AM +0000, corvid wrote: > > On Wed, Feb 18, 2009 at 12:40:57AM +0000, corvid wrote: > > > > Can you please try attached patch with valgrind and image loading on > > > > and off. > > > > > > Is this a proposed patch for the tree or an experiment in leak-finding? > > > > For the tree, if it proofs to fix the leaks and doesn't cause > > others. > > If we always add Image, the code that loads images manually will think > it hasn't been loaded yet. > Ah ok. I guess I misunderstood Html_add_new_linkimage() completely. Please check the updated patch. Thanks, Johannes PS: The point of the patch is to actually do reference counting: Whenever we create a new reference (pointer) to an image, we call a_Image_ref(), when such a pointer is deleted we call a_Image_unref(). If I see it correctly, the permanent pointers to Image structures are in html->images and in the DilloWeb structure.

3 3

Fun with autocnf and mercurial
by onepoint＠starurchin.org Feb. 18, 2009

Feb. 18, 2009

Here's a patch for discussion. Since I am parsing Dillo logs for debugging, I thought it would be neat if Dillo logged the mercurial revision. Patch attached. Thoughts? Does anyone know a better way to get the revision for a particular tag? Piping "hg tags" through a sed script is rather kludgy but I can't find a way to get mercurial to tell me directly. I log the qparent revision as well as the tip revision because I manage patches with Mercurial queues, so my qparent revision is the vanilla tip revision that I am currently based on. Also, I used printf() to log the revisions because neither MSG nor MSG_WARN produced anything. I don't know why. Can anyone explain? Regards, Jeremy Henty

3 11

Leaking image structures
by onepoint＠starurchin.org Feb. 18, 2009

Feb. 18, 2009

One of the biggest leaks that valgrind reports is image structures. I'm attaching logs that show memory being allocated by a_Png_new() and cousins and not being freed. There are also frequent leaks of memory allocated by the image libraries from within the various image callbacks, but I suspect these are just another effect of the Dillo image structures not being freed. Unfortunately I'm having a hard time tracking these leaks down. They regularly appear after long browsing sessions, but I haven't found any single page that reproduces them. I suspect they are caused by some race condition inside the CCC rather than the HTML parser. I am browsing with image loading enabled, and if I understand the code correctly that means that the Web structures in the CCC own all the references to image structures. The fact that image structures are reference counted makes it hard to know when the structures should be freed anyway. Indeed, does Dillo even ensure that image structures are freed? Maybe this is just a symptom of incomplete cleanup at exit rather than a true leak? I've looked over the code and can't see any obvious leaks so I'm rather stuck. Any tips for tracking this down? Even if it's not a true leak it would be good to have a fix that cleaned up the valgrind logs. Regards, Jeremy Henty

4 5

META charset without MIME type
by corvid＠lavabit.com Feb. 17, 2009

Feb. 17, 2009

Jorge wrote: > summary: Fixed handling of META's content-type with no MIME type > (e.g. only charset). Is that legal? It doesn't sound legal.

2 6

a policy for dillorc vs. style.css conflicts?
by corvid＠lavabit.com Feb. 16, 2009

Feb. 16, 2009

I was just looking at some of the prefs that I don't think are doing anything right now, e.g., link_color, force_my_colors... I could stuff them into buildUserStyle(), but I don't know which should prevail in case of conflicts. I can't remember whether I've already mentioned that I've been wondering whether it might be reasonable to rip a bunch of color stuff out of dillorc and expect a dillo user to be able to deal with a well-commented sample style.css instead.

3 16

ChangeLog link
by jcid＠dillo.org Feb. 16, 2009

Feb. 16, 2009

Hi, Does anybody know how to ask hgweb for the "tip" ChangeLog file? (The current link is set to a specific version). -- Cheers Jorge.-

1 0

Repush and scroll position
by jcid＠dillo.org Feb. 16, 2009

Feb. 16, 2009

Hi, Patch b134ea74331b is to make repush remmeber the scrolling position. This is, if you load a page, start scrolling and the stylesheet arrives after that, it will no longer go back to the top. Please test. -- Cheers Jorge.-

3 7

[patch] Search Previous
by jorl17.8＠gmail.com Feb. 15, 2009

Feb. 15, 2009

Qui, 2009-02-12 ?s 19:38 +0000, corvid escreveu: > I updated the UTF-8 sampler search bar screenshot > to show off the nifty new button :) > > Great, thanks! Onto another subject I've been trying to understand what's going on in CharIterator::prev() and have been running tests and I have a question regarding iterator.hh. In the following code: inline static bool charsEqual (char c1, char c2, bool caseSens) { return caseSens ? c1 == c2 : tolower (c1) == tolower (c2) || (isspace (c1) && isspace (c2)); } Why are we checking if c1 and c2 are spaces? This is the code that, according to my tests, is wrecking the search-previous functionality. Thanks, Jo?o

4 10

patch: optgroup for OptionMenu
by corvid＠lavabit.com Feb. 14, 2009

Feb. 14, 2009

I've had this kicking around in my tree for months...finally got around to implementing the max string width for OptionMenu and doing a little polishing. Here it treats optgroup, option, and /optgroup as types of options because when I tried keeping options inside optgroup structures, it turned out to be messier. The idea is that if this is accepted, I will later do some renaming. (Not enabled for ListResource yet because the straightforward approach did not result in something very usable...)

2 3

patch: SELECT size > 1 !multiple
by corvid＠lavabit.com Feb. 13, 2009

Feb. 13, 2009

When I was working on the SELECT size code recently, I enabled using the plain fltk::Browser if size > 1 and multiple was not set. I didn't realize that the callbacks for a plain Browser and a MultiBrowser behave differently.

2 1

relative urls
by Johannes.Hofmann＠gmx.de Feb. 13, 2009

Feb. 13, 2009

Hi, if I'm interpreting http://www.w3.org/Addressing/rfc1808.txt correctly (check "5.1. Normal Examples"), dillo does not handle relative urls with queries correctly. In case of queries it truncates the filename. Anchors are handled correctly. You can see the difference here: <a href="#foo">#foo</a> <a href="?foo=bar">?foo=bar</a> Please check attached patch. Cheers, Johannes

2 4

Close-tab Button
by jorl17.8＠gmail.com Feb. 13, 2009

Feb. 13, 2009

Greetings to all. As a simple introduction may I say I thank you all for your work on Dillo. Currently, I am trying to implement the Close-Tab button. I've been discussing it with Jorge Arellano Cid and he suggested I 'brought-it' to dillo-dev. FLTK Tabs don't support a close-tab button, as many of you have seen, and the idea was to have a button at the end of the tabs list. For that, I created an fltk::Button widget in CustTabGroup. I position this widget at the end of the tabs list and, then, I add() it to the CustTabGroup's parent() (UI). After that, I set the UI's resizer() to be an InvisibleBox positioned in such a way that it doesn't resize the button itself, but only moves it. Refreshing the button (when changing/adding/closing tabs) is done in the handle() method of the CustTabGroup. Just a second ago I solved one of the problems, which was the fact that tab_height() returned 0 in the constructor and resize() didn't work. I worked around that by constructing the button only in event() if tab_height()>0 and it hasn't been constructed yet. This way we can use the correct height for the button. It may not seem reliable to do so many things in handle(). Any suggestions? It is functional, only you can say if it fully suits Dillo's needs though. Unfortunately, there are some problems: The first one is the most-relevant one. When the list of tabs grows it can go over the button. I have been trying to fix this, but I can't seem to do it. A possible way could (maybe) be to 'trick' the pager into thinking it has less space left to draw the tabs, and that could possibly be achieved using update_positions(), although I am having some problems with that. The second problem is a minor one, but annoying. I believe when CSS rendering is triggered, the render area flickers and that is normal. However, the way I implemented this (probably because of it being in handle()) makes the Button also flash. Thanks, Jo?o

5 17

Close-tab Button
by rogutes＠googlemail.com Feb. 12, 2009

Feb. 12, 2009

Hello, Some redrawing bug got uncovered with the close-tab button. Open dillo, click on bookmarks, hit ctrl-t and ctrl-q - the "km" part of the "Bookmarks" tab title is shown in white on the "Clear the URL box". Now click ctrl-t and the close-tab button - the whole "Bookmarks" title is shown in white over the toolbar. In the first case, it is hardly noticeable, but it is when using the new button. -- -- Rogut?s Sparnuotos

4 3

style parsing on iframe
by furaisanjin＠gmail.com Feb. 11, 2009

Feb. 11, 2009

Hi all. I'm wondering if it's necessary to parse style on iframe. I see a large bullet sometimes and this is one example page. http://www.oshiimamoru.com/news/news_r0807.htm The page contains this kind of iframe tag. <iframe src="http://rcm-jp.amazon.co.jp/e/cm?t=deizcom-22&o=9&p=8&l=as1&asins=4344980891…" style="width:120px;height:240px;" scrolling="no" marginwidth="0" marginheight="0" frameborder="0"> Regards, furaisanjin

1 0

google news link
by furaisanjin＠gmail.com Feb. 11, 2009

Feb. 11, 2009

Hi all. I find that nothing happens when I click links on side bar within google news. On this page (http://news.google.com/news?ned=us) there are links such as World, U.S. and so on. None of them is clickable. Regards, furaisanjin

5 5

New mercurial repository
by jcid＠dillo.org Feb. 11, 2009

Feb. 11, 2009

Hi, Good news: Andreas K. has just set a fast Hg repository for dillo. Try it at: http://hg.dillo.org/dillo I'll switch the web page to point to it after sending this email. Enjoy! :-) -- Cheers Jorge.-

3 2

ChangeLog
by jcid＠dillo.org Feb. 11, 2009

Feb. 11, 2009

Hi, Johannes, corvid: it'd be good if you can update the ChangeLog file with your work. This ChangeLog is meant to be human-readable so please summarize as usual and highlight the important points. We have the full details in HG after all. -- Cheers Jorge.-

1 0

Close-tab Button
by jorl17.8＠gmail.com Feb. 9, 2009

Feb. 9, 2009

Seg, 2009-02-09 ?s 21:23 +0000, Jo?o Ricardo Louren?o escreveu: > A simple update. > > I've fixed most issues I found. For instance, we were processing the > click on PUSH and not RELEASE, that was causing some problems and The > issue I talked about earlier (working while not visible). > > I've got a working tooltip, added to CustTabGroup. > > The only problem is drawing into the button. Should I use an image (or > multiple images, mouseover, etc...)? Should I add a cross ('X') to it? > > Adding a cross is easy, adding an image involves digging some more but > it is obviously doable. > > Thanks, > > Jo?o Oh, not to mention preventing tabs from going over the button. However, I was testing multiple clicks on the button and it seems that dragging the pressing, dragging and quickly releasing the mouse button makes the events not reach its destination - I'm guessing a DRAG messages is being sent, we have to prevent for that too. Jo?o

1 0

[patch] Search Previous
by jorl17.8＠gmail.com Feb. 9, 2009

Feb. 9, 2009

Greetings. I 'spotted' a TODO on searching 'backwards' and decided to have a go at it. Basically, I implemented the Search Previous feature. I must say I have difficulties understanding the code behind FindtextState::search0(), so I did not base my code on it at all. Sure it could possibly be optimized, but it seems to do the job for now, I haven't found any bugs, if you find any, please do say. Additionally, I did not set any hotkeys for the search-previous action, maybe something like SHIFT+RETURN, since RETURN handles searching forwards? Also, I did not add any tests, and I only altered a line to make them compilable, but I might add some tests soon. Thanks, Jo?o

4 10

CSS update committed
by Johannes.Hofmann＠gmx.de Feb. 9, 2009

Feb. 9, 2009

Hi, I just committed a major update of the CSS code. CSS values now have a type and the CSS parser can accept multiple types for one property. One example is font-size, which can either be a length or an enum (xx-small, x-small, ...). This fixes the font size issue on wikipedia.org. Cheers, Johannes

2 2

patch: clean up a_Html_add_image
by onepoint＠starurchin.org Feb. 8, 2009

Feb. 8, 2009

There is IMHO a nasty code smell around a_Html_add_new_image(): it takes a boolean parameter that determines whether or not it actually adds the image. It's only called from two other places, once with the parameter set to false and once with it set to true. This patch cleans things up by renaming a_Html_add_new_image() to a_Html_image_new(), removing the boolean parameter and making the caller add the image (or not) as appropriate. Perhaps it is a judgement call as to whether this is an improvement, but I feel that it is. Please comment. Regards, Jeremy Henty

4 7

patch: <s> line appearance
by corvid＠lavabit.com Feb. 8, 2009

Feb. 8, 2009

I was thinking that large text with a thin line through it looks odd. Turns out that there was also a problem with <sup> causing the <s> line to be too high. This looks about right to me with the few fonts I have around. I'm attaching an example html file as well. PS Might be good to go through that area of the code one day to see what opportunities there are to make it clearer...

3 4

name/id bug
by corvid＠lavabit.com Feb. 8, 2009

Feb. 8, 2009

<a name="a"></a> <p id="p"></p> <p> <a name="same" id="same"></a> gives HTML warning: line 2, 'id' and 'name' attribute of <a> tag differ HTML warning: line 4, Anchor names must be unique within the document Dillo would seem to be unhappy now that the id attr is checked before open_a checks the name attr -- but then it looks like the move was made in October (a88b4a31cb7a) and I have a dillo around from roughly Dec. 22 that does not have a problem with this. In any case, I don't know whether there are styleEngine issues with just sticking the id check back after the open.

3 11

Rendering XHTML 1.1
by Hole.destructor＠gmx.de Feb. 8, 2009

Feb. 8, 2009

Hello Dillo developers, since you are planing to release Dillo-2.1 in about a month, I am wondering whether there are plans to support XHTML 1.1, HTML 5 and XHTML 2 web pages in the near future? Thanks, Alexander.

2 1

Close-tab Button
by jorl17.8＠gmail.com Feb. 8, 2009

Feb. 8, 2009

S?b, 2009-02-07 ?s 23:38 -0300, Jorge Arellano Cid escreveu: > On Sat, Feb 07, 2009 at 09:57:52PM +0000, Jo?o Ricardo Louren?o wrote: > > S?b, 2009-02-07 ?s 18:33 -0300, Jorge Arellano Cid escreveu: > > > On Fri, Feb 06, 2009 at 05:56:28PM -0300, Jorge Arellano Cid wrote: > > > > On Mon, Feb 02, 2009 at 12:37:18AM +0000, Jo?o Ricardo Louren?o wrote: > > > > > Dom, 2009-02-01 ?s 14:51 -0300, Jorge Arellano Cid escreveu: > > > > > > On Sun, Feb 01, 2009 at 12:06:49AM +0000, Jo?o Ricardo Louren?o wrote: > > > > > > > Greetings to all. > > > > > > > > > > > > > > As a simple introduction may I say I thank you all for your work on > > > > > > > Dillo. > > > > > > > > > > > > > > Currently, I am trying to implement the Close-Tab button. I've been > > > > > > > discussing it with Jorge Arellano Cid and he suggested I 'brought-it' to > > > > > > > dillo-dev. > > > > > > > > > > > > > > FLTK Tabs don't support a close-tab button, as many of you have seen, > > > > > > > and the idea was to have a button at the end of the tabs list. > > > > > > > > > > > > > > For that, I created an fltk::Button widget in CustTabGroup. I position > > > > > > > this widget at the end of the tabs list and, then, I add() it to the > > > > > > > CustTabGroup's parent() (UI). > > > > > > > > > > > > > > After that, I set the UI's resizer() to be an InvisibleBox positioned in > > > > > > > such a way that it doesn't resize the button itself, but only moves it. > > > > > > > > > > > > > > Refreshing the button (when changing/adding/closing tabs) is done in the > > > > > > > handle() method of the CustTabGroup. > > > > > > > > > > > > > > Just a second ago I solved one of the problems, which was the fact that > > > > > > > tab_height() returned 0 in the constructor and resize() didn't work. I > > > > > > > worked around that by constructing the button only in event() if > > > > > > > tab_height()>0 and it hasn't been constructed yet. This way we can use > > > > > > > the correct height for the button. > > > > > > > > > > > > > > It may not seem reliable to do so many things in handle(). Any > > > > > > > suggestions? > > > > > > > > > > > > We need to get something working, review it, and then we may > > > > > > ask in fltk.general whether it could have side effects. > > > > > > > > > > > > > It is functional, only you can say if it fully suits Dillo's needs > > > > > > > though. > > > > > > > > > > > > Please post the patch here so we can look at it. > > > > > > > > > > > > > Unfortunately, there are some problems: > > > > > > > > > > > > > > The first one is the most-relevant one. When the list of tabs grows it > > > > > > > can go over the button. I have been trying to fix this, but I can't seem > > > > > > > to do it. > > > > > > > A possible way could (maybe) be to 'trick' the pager into thinking it > > > > > > > has less space left to draw the tabs, and that could possibly be > > > > > > > achieved using update_positions(), although I am having some problems > > > > > > > with that. > > > > > > > > > > > > Or maybe just tweaking the value. After all it's a workaround. > > > > > > > > > > > > > The second problem is a minor one, but annoying. I believe when CSS > > > > > > > rendering is triggered, the render area flickers and that is normal. > > > > > > > However, the way I implemented this (probably because of it being in > > > > > > > handle()) makes the Button also flash. > > > > > > > > > > > > A side affect of being a child of UI. > > > > > > > > > > > > > > > > So, as requested, here is what I have got until now. There is a > > > > > particular line I think is not necessary, I commented that specifically. > > > > > > > > I'm reviewing it now. > > > > > > Well, the good part is that it works and can be polished a bit. > > > The problem is side effects (e.g. redraw storms while moving the mouse > > > over the panel buttons, and who knows what else?). > > > > > > I tried a different approach and it almost worked OK, but after > > > resizing the window, the redraw storms are on the whole window. > > > > > > Frustrating... > > > > > > It looks like drawing the button in the pager could work. I'll > > > try to write some code this way. > > > > > > > Thanks. Redraw storms are visible when running it under valgrind. Also, > > parts of the code there were/are unnecessary. For instance, we could > > send the redraw() message only when adding a new tab and not > > continuously, but the redraw storms continue either way... > > > > Adding it to the pager seems the way to go there, but will you add it as > > a button, or a custom drawn widget? > > > > If you need any help, do say, I'll try to do my best, > > Attached goes a patch that behaves nicely. > Please polish it to a final state. It is commented. > > The button drawing code lacks the "X", the callback is not hooked, > and there's no tooltip, but it doesn't trigger redraw storms, > and feels right. > > Good luck! OK, I've already implemented update_positions() to prevent tabs from going over the button (grabbed it from FLTK and altered it). I don't think there is the need for a callback function, since it only calls a simple line. I've noticed that we have no checking if the button is visible or not, so it is working even though there are no tabs, I'll add a check for that in event() rather than in other places. Thanks, Jo?o

1 0

[patch]: fix leak in a_Cookies_get_query()
by onepoint＠starurchin.org Feb. 6, 2009

Feb. 6, 2009

This patch stops a_Cookies_get_query() leaking. However, I'm a little puzzled by the logic here. Why does a_Cookies_get_query() return a "Cookies2" header even if the cookies DPI returns nothing? Can't it just return NULL or an empty string? Wouldn't that be cleaner? Regards, Jeremy Henty

3 3

Re: view stylesheets from page menu
by Johannes.Hofmann＠gmx.de Feb. 6, 2009

Feb. 6, 2009

On Thu, Feb 05, 2009 at 08:19:03AM -0300, Jorge Arellano Cid wrote: > On Tue, Feb 03, 2009 at 08:00:12PM +0100, Hofmann Johannes wrote: > > Hi corvid, > > > > On Tue, Feb 03, 2009 at 05:13:27PM +0000, corvid wrote: > > > > > > (a rough quick patch just to get feedback) > > > I saw that Jorge added cssUrls, which provided an opportunity... > > > > Very nice! Just one small thing. The stylesheets entry does not get > > disabled on non-CSS pages here. Extending the check like this: > > > > + if (cssUrls && cssUrls->size () > 0) { > > > > helps. > > To me: It looks more like a developers feature than one for user level. Well, not more than "View page source". I think it's important and in the spirit of dillo to make the web as transparent for the user as possible. > > > > BTW: Viewing stylesheets in a normal browser window is really fast > > compared to the fltk text viewer we use for "View page source"! > > Yes, since a long time I've wanted to find some time to turn > "View page source" into a dpi. > > Maybe after the close-tab button I can give it a hand. > Yes, that would be great. Cheers, Johannes > -- > Cheers > Jorge.-

3 2

RE: Free HG performance
by CHalbersma.12＠westminster-mo.edu Feb. 6, 2009

Feb. 6, 2009

Souceforge always seemed pretty good at hosting open souce projects. Of course I could be wrong there. Christopher "Chewy" R. Halbersma

2 1

FreeHG performance
by onepoint＠starurchin.org Feb. 5, 2009

Feb. 5, 2009

Am I the only one getting very poor performance from FreeHG ? Quite often I get a 404 Not Found and right now it's hanging. Everyone confirms that Mercurial itself is really fast and I've seen other reports criticising FreeHG's performance. Perhaps we should think about moving host? It's not always easy to find time to devote to Dillo so it's rather aggravating when that time is wasted just waiting for a connection to the server. I'm committed enough to grit my teeth and wait but I can see it putting off would-be contributors. Just a thought, Jeremy Henty

5 14

Bad character coding for www.blisty.cz
by newman.x＠gmail.com Feb. 3, 2009

Feb. 3, 2009

Hi, I am affraid there ocurred regression in post-dillo-2.0 when compared to dillo-2.0. Look on the www.blisty.cz web page, on the top there's following sence (it's in Czech) "?t?te Britsk? listy speci?ln? upraven? pro va?e mobiln? telefony a PDA" but in current hg tip it's displayed as "?t?te Britsk? listy speci?ln? upraven? pro va?e mobiln? telefony a PDA" and of course, the whole page is displayed like in ISO-8859-1 coding. I noticed this first when the character coding code in post-dillo-2.0 was changed. When the page is saved to disk and opened it works as expected. It appeared that it is somehow related to default dillorc. 1) remove the ~/.dillo directory 2) dillo www.blisty.cz 3) --> PASS 4) quit dillo 5) dillo www.blisty.cz 6) --> FAIL Can anyone, please, have a look at this and say whether is it reproducible and, perhaps, fix it? :) Thanks, -- Regards, Michal Nowak

4 10