- Dillo-dev - lists.mailman3.com

CustChoice
by corvid＠lavabit.com Jan. 28, 2013

Jan. 28, 2013

I was looking into why the search dialog would no longer let me tab to the search engine list and press down arrow to switch between them... It seems that, once Jorge added a CustChoice in fltkui.cc, the dialog code started to use _that_ one and not its own. (I would've expected something to complain about there being two CustChoice::handle()s in that case...) Would it be considered incorrect in any way if fltkui.cc's CustChoice and CustInput2 were put inside dw::fltk::ui?

2 5

Another SGI compiler problem
by csoren＠isd.net Jan. 27, 2013

Jan. 27, 2013

> > Any problem if you change > bool FltkToggleButtonResource::FltkToggleButtonResource::isActivated () > to > bool FltkToggleButtonResource::isActivated () > ? > Thanks that worked!

1 0

Another SGi compiler problem
by csoren＠isd.net Jan. 24, 2013

Jan. 24, 2013

> > > > Greets all, > > > > I'm trying to compile on Silicon Graphics (IRIX O.S.) > > using their MIPSPro 7.4 > > compiler, but getting this error in dialog.cc: > > > > <pre> > > cc-1028 CC: ERROR File = dialog.cc, Line = 180 > > The expression used must have a constant value. > > > > memset(pm, '\0', sizeof(Fl_Menu_Item[n_it+1])); > > ^ > > </pre> > > > > Thoughts? > > You may try something like: > > memset(pm, '\0', (n_it+1)*sizeof(Fl_Menu_Item)); > > -- > Cheers > Jorge.- Thanks Jorge that worked! :) Fourteen files compiled so far but then this happened in fltkflatview.cc: ---------------------------------------------- cc-3168 CC: ERROR File = fltkui.cc, Line = 782 A name followed by "::" must be a class or namespace name. bool FltkToggleButtonResource::FltkToggleButtonResource::isActivated () ^ cc-1443 CC: ERROR File = fltkui.cc, Line = 782 "dw::fltk::ui::FltkToggleButtonResource::FltkToggleButtonResource" is not a class template. bool FltkToggleButtonResource::FltkToggleButtonResource::isActivated () ^ 2 errors detected in the compilation of "fltkflatview.cc". ----------------------------------------------- Thoughts?

2 1

[patch] dCalloc
by p37sitdu＠lavabit.com Jan. 23, 2013

Jan. 23, 2013

dNew macro hides multiplication and can lead to integer overflows. Patch implements dCalloc and replaces dNew with dCalloc wrapper so no integer overflows are possible: http://www.inventati.org/noname/dillo/dlib/dcalloc.patch dwrite.patch is moved to http://www.inventati.org/noname/dillo/dlib/

1 0

_t suffix
by p37sitdu＠lavabit.com Jan. 23, 2013

Jan. 23, 2013

Suffix _t is reverved by POSIX and should not be used: <http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html> I have made patches that remove _t suffix from some modules: http://www.inventati.org/noname/dillo/_t/

1 0

line wrap for Japanese
by furaisanjin＠gmail.com Jan. 23, 2013

Jan. 23, 2013

Hello all. It seems that change set de05508cbbbd causes the line wrap problem for Japanese. Certain lines become very long and I don't see appropriate line wrap in the middle. Regards, furaisanjin

2 2

dereferencing type-punned pointer warning
by Johannes.Hofmann＠gmx.de Jan. 22, 2013

Jan. 22, 2013

Hi, line 135 in lout object.cc: return ((int*)&value)[0] ^ ((int*)&value)[1]; causes the following error on 64bit systems for me: warning: dereferencing type-punned pointer will break strict-aliasing rules Can we replace it like this: diff -r dd6f2d1eb15a lout/object.cc --- a/lout/object.cc Mon Jan 14 10:26:37 2013 -0300 +++ b/lout/object.cc Mon Jan 14 21:56:46 2013 +0100 @@ -21,6 +21,7 @@ #include "object.hh" #include <stdio.h> +#include <stdint.h> #include <config.h> namespace lout { @@ -132,7 +133,7 @@ // Combine both parts of the pointer value *itself*, not what it // points to, by first referencing it (operator "&"), then // dereferencing it again (operator "[]"). - return ((int*)&value)[0] ^ ((int*)&value)[1]; + return ((intptr_t)value >> 32) ^ ((intptr_t)value); #endif } Cheers, Johannes

2 1

[patch] Scrollbar thickness from dillorc
by podarcis＠lavabit.com Jan. 21, 2013

Jan. 21, 2013

Scrollbars currently have the hardcoded thickness 15. This can be too small to operate dillo on large screens or with fingers on a touch screen. The supplied patch does the following: - Adds the prefence "scrollbar_tickness" to dillorc. - Reads the value into the prefences (Note: added a type UINT32 to prefsparse.cc) - Sets this value to the FltkViewport with the new method FltkViewport::setScrollbarThickness(). Note: I deliberately did no check for value 0, which can therefore be used to make the scrollbars invisible. Scrolling can then still be achieved with the cursor keys. This could be called a feature. Cheers, podarcis

3 4

drawing highlighting
by corvid＠lavabit.com Jan. 19, 2013

Jan. 19, 2013

I was looking at draw() calls for the view, and I saw how there was a call for every time that the mouse moved when highlighting even though the text highlighted didn't necessarily change. Here's quick code to demonstrate that there are plenty of redundant ones. I don't know the iterator code well enough to know whether that's the right place to do anything about it, though...

2 2

[patch] disable SSLv2 support
by p37sitdu＠lavabit.com Jan. 18, 2013

Jan. 18, 2013

http://www.inventati.org/noname/dillo/https-no-SSLv2.patch I have found HTTPS server that Dillo was unable to connect to. After defining SILENT to 0 in https.c I found that SSL_connect failed. Adding ERR_print_errors_fp(stderr) showed error "SSL23_GET_SERVER_HELLO:unknown protocol". Disabling SSLv2 support fixed the problem for me. And SSLv2 is insecure so it must be disabled anyway.

2 1

[patch] dWrite
by p37sitdu＠lavabit.com Jan. 18, 2013

Jan. 18, 2013

http://www.inventati.org/noname/dillo/dwrite.patch Removed Dpi_blocking_write from src/IO/dpi.c and moved similar code to dlib. Also fixes ckd_write in dpid/dpid_common.c: it handled EINTR, but did not handle situation when number of bytes written is less then requested. Now it uses dWrite.

1 0

[patch] a_Dpip_send_cmd
by p37sitdu＠lavabit.com Jan. 15, 2013

Jan. 15, 2013

http://www.inventati.org/noname/dillo/dpip-send-cmd.patch Patch adds a_Dpip_send_cmd and helper function a_Dpip_vbuild_cmd. This way common pattern d_cmd = a_Dpip_build_cmd(format, ...); st = a_Dpip_dsh_write_str(sh, flush, d_cmd); dFree(d_cmd); can be replaced with st = a_Dpip_send_cmd(sh, flush, format, ...);

2 2

tooltip in the way when typing
by corvid＠lavabit.com Jan. 15, 2013

Jan. 15, 2013

With fltk's built-in tooltip system, Fl::handle_(), upon receipt of a FL_KEYBOARD event, calls Fl_Tooltip::enter((Fl_Widget*)0); to hide the tooltip. Once in a while, after giving a text input focus, I'm careless with the mouse, moving it away and then back over the input, putting a tooltip over what I'm typing. (And presumably textareas could have that happen as well...) Here's one way that it could be dealt with:

1 0

mare patches for dpid
by p37sitdu＠lavabit.com Jan. 14, 2013

Jan. 14, 2013

http://www.inventati.org/noname/dillo/dpid-dclose.patch http://www.inventati.org/noname/dillo/dpid-no_dotfiles.patch

2 1

Patch for xembed (text corrected)
by podarcis＠lavabit.com Jan. 14, 2013

Jan. 14, 2013

Hi all, Here is a patch to make embedding dillo into an X-window work. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff -r 9bad41ea1dde src/xembed.cc --- a/src/xembed.cc Wed Dec 05 13:03:04 2012 +0100 +++ b/src/xembed.cc Sun Dec 09 10:12:36 2012 +0100 // TODO: Implement more XEMBED support; -void Xembed::show() { +void Xembed::create() { createInternal(xid); setXembedInfo(1); Fl::event_dispatch(event_handler); diff -r 9bad41ea1dde src/xembed.hh --- a/src/xembed.hh Wed Dec 05 13:03:04 2012 +0100 +++ b/src/xembed.hh Sun Dec 09 10:12:36 2012 +0100 @@ -14,10 +14,11 @@ public: Xembed(uint32_t xid, int _w, int _h) : Fl_Window(_w, _h) { - this->xid = xid; + this->xid = xid; create(); }; - void show(); + void create(); int handle(int event); + void resize(int x, int y, int w, int h); }; #endif ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tested with this FLTK program: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #include <FL/Fl.H> #include <FL/Fl_Window.H> #include <FL/x.H> #include <cstdio> #include <iostream> #include <sstream> #include <string> using namespace std; int main( int argc_, char *argv_[] ) { Fl_Window dw( 800, 600, "dillo embedded" ); dw.resizable( &dw ); dw.show(); cout << "dw.xid = " << (unsigned long)fl_xid(&dw) << endl; ostringstream cmd; cmd << "dillo -f -g " << dw.w() << "x" << dw.h() << " --xid " << (unsigned long)fl_xid(&dw); if ( argc_ > 1 ) cmd << " " << argv_[1]; cmd << " &"; cout << "system '" << cmd.str() << "'" << endl; system( cmd.str().c_str() ); return Fl::run(); } ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ What does NOT work is automatic resizing of the embedded dillo window, when the size is changed. This would be nice to have. I do not know enough of the embedding stuff, but I wonder if the static int event_handler() ever gets called with type ClientMessage - at least I could not make it get there.. podarcis

4 11

ui colors again
by corvid＠lavabit.com Jan. 13, 2013

Jan. 13, 2013

Today I dug up the old ui colors patch from last September, ripped out the part that used system colors as defaults that was a problem*, and played around with it a little. I really like configurable colors, so, since I haven't heard anyone say anything like feature freeze yet, I'll make another push for this thing. One difference from the previous code is that I'm using inactive() on the images for inactive toolbar buttons because our gray pixmaps tend not to look so good with different UI colors. It might be good to pull it somewhat closer to the background color, but I'm not sure yet. * Under X, FLTK tries to "Read colors that KDE writes to the xrdb database", which may or may not work fine for those people running KDE, but...

3 20

font_factor
by johannes.hofmann＠gmx.de Jan. 12, 2013

Jan. 12, 2013

On Tue, Jan 08, 2013 at 11:55:42PM +0000, corvid wrote: > > I wrote: > > In styleengine, we use font_factor for calculation of larger and x-small > > and so forth, but we don't apply it when given an ordinary font size like > > 11px. > > Just to double-check: That's not intended behaviour, right? > sorry for the delay... This is intentional, but we know that there is a usability issue. In CSS px, mm, pt etc. define absolute sizes [1]. So if we want to adhere to the CSS spec strictly I think we can't just scale them. On the other hand web designers just use px without thinking about the implications. Also other browsers allow scaling of those fonts afaik. I think we have the following options: * ignore CSS and apply font_factor also to absolute font sizes * implement a zoom feature that displays everything larger (also images etc. * check other browsers for more alternatives [1] http://www.w3.org/TR/CSS21/fonts.html#font-size-props

4 3

[patch] list.h cleanup
by p37sitdu＠lavabit.com Jan. 12, 2013

Jan. 12, 2013

http://www.inventati.org/noname/dillo/list.h.patch

1 0

Intermitent internet access
by jcid＠dillo.org Jan. 11, 2013

Jan. 11, 2013

Hi, FYI, I'm away from home and with intermitent Internet connection. -- Cheers Jorge.-

1 0

White on white for the active tab
by onepoint＠starurchin.org Jan. 11, 2013

Jan. 11, 2013

I am getting white text on a white background for the active tab. I haven't changed any colours form the defaults. Why would this be? Regards, Jeremy Henty

3 3

[patch] modified a_Dialog_choice5 to accept any number alternatives
by p37sitdu＠lavabit.com Jan. 11, 2013

Jan. 11, 2013

-5 LOC, nothing is changed visually

3 2

namespace comments in dw/*
by corvid＠lavabit.com Jan. 11, 2013

Jan. 11, 2013

p37sitdu wrote: > Copied comments are almost in every source file. Committed.

1 0

patches
by p37sitdu＠lavabit.com Jan. 11, 2013

Jan. 11, 2013

I have uploaded some of my patches that were not commited (yet) to http://www.inventati.org/noname/dillo/ so it is easier to track them. Descriptions are embedded inside.

1 1

drawing areas with negative coordinates
by corvid＠lavabit.com Jan. 9, 2013

Jan. 9, 2013

Just something I noticed. There aren't an overwhelming number of them, so it seems like...not too big of a deal. I have the impression that it generally means that something is being drawn while an allocation somewhere is still (-1, -1, 1, 1). diff -r 35fb41bd0cdb dw/fltkviewbase.cc --- a/dw/fltkviewbase.cc Wed Jan 09 16:40:25 2013 +0000 +++ b/dw/fltkviewbase.cc Wed Jan 09 17:17:36 2013 +0000 @@ -431,8 +431,14 @@ void FltkViewBase::queueDraw (core::Rectangle *area) { - drawRegion.addRectangle (area); - damage (FL_DAMAGE_USER1); + static int counter = 0; + if (area->y < 0) { + MSG("%d let's not draw (%d,%d) w %d h %d\n", counter++, area->x, area->y, + area->width, area->height); + } else { + drawRegion.addRectangle (area); + damage (FL_DAMAGE_USER1); + } } void FltkViewBase::queueDrawTotal ()

1 0

[patch] dClose
by p37sitdu＠lavabit.com Jan. 9, 2013

Jan. 9, 2013

Merged a_Misc_close_fd, Dpi_close_fd and Http_socket_close into dClose and moved it into dlib. Replaced close calls with calls to dClose.

2 1

[patch] consistent file save UI behaviour for overwriting files
by onepoint＠starurchin.org Jan. 8, 2013

Jan. 8, 2013

The UI for downloading files is split between Dillo (which prompts for a file to save to) and the downloads DPI (which prompts for another file if the first file already exists). This leads to inconsistent behaviour for "Save link as file" depending on whether the URL is cached or not - if it is cached then any existing file is silently overwritten but if it is not cached we go to the downloads DPI which prompts before overwriting anything. These two patches move the UI logic from the downloads DPI into Dillo. This puts all the UI logic in the same place and ensures consistent behaviour for "Save link as file" whether or not the URL is cached. http://starurchin.org/dillo/patch/downloads-dpi_file_test_remove.html http://starurchin.org/dillo/patch/uicmd-cc_file_test_add.html Comments? Shall I push this? Regards, Jeremy Henty

2 2

dillo3.0.2 Irix
by corvid＠lavabit.com Jan. 8, 2013

Jan. 8, 2013

Jan wrote: > Nothing new with this patch. I found out it is not random, it > depends on the length: > > I can open: > > file:/tmp/12345678901234567890123.jpg > > but > > file:/tmp/123456789012345678901234.jpg > > returns a 404 32-byte limit? The first thing that popped into my mind was that sufficiently ancient systems would have path length limits like 32, but I don't see why that would apply here... dpi/file.c's File_normalize_path() has a "Dstr *ds = dStr_sized_new(32)". You could change the number and see whether anything happens. Although if Dstr should have problems resizing itself on irix, I'd be very surprised that dillo could even run at all.

1 0

dillo3.0.2 Irix
by diegel＠work.de Jan. 8, 2013

Jan. 8, 2013

Hello, I try to port dillo 3.0.2 to Irix: fltk 1.3 compiles fine with gcc 4.7. test/demo runs without errors. dillo compiles also with gcc 4.7, there is only a problem with setenv in dpi/downloads.cc, that can be resolved using putenv. dillo starts correctly, but is not able to display any website or file: > dillo paths: Cannot open file '/usr/people/diegel/.dillo/dillorc' paths: Using /usr/local/etc/dillo/dillorc paths: Cannot open file '/usr/people/diegel/.dillo/keysrc' paths: Using /usr/local/etc/dillo/keysrc dillo_dns_init: Here we go! (threaded) Disabling cookies. ** WARNING **: preferred sans-serif font "DejaVu Sans" not found. ** WARNING **: preferred serif font "DejaVu Serif" not found. ** WARNING **: preferred monospace font "DejaVu Sans Mono" not found. ** WARNING **: preferred cursive font "URW Chancery L" not found. ** WARNING **: preferred fantasy font "DejaVu Sans" not found. Nav_open_url: new url='about:splash' Nav_open_url: new url='http://www.dillo.org/' Dns_server [0]: www.dillo.org is 134.102.206.165 Connecting to 134.102.206.165 Nav_open_url: new url='file:/usr/people/diegel/dillo/www.dillo.org/index.html' I also tried with --disable-threaded-dns but same result. Any idea how to debug this problem? Thank you, Jan

2 3

Gopher DPI
by p37sitdu＠lavabit.com Jan. 8, 2013

Jan. 8, 2013

Added telnet:// URI support (type '8').

1 0

Scripts in dillo
by sgeerken＠dillo.org Jan. 7, 2013

Jan. 7, 2013

Hi! This is something which has been laying around for several years: At <http://www.dillo.org/~sgeerken/objman-test-0.0.1.tar.bz2>, you'll find some code which may be useful for dealing with scripts in dillo. Currently not very much: - After configure && make, run test/guile-test and look what happens. Look at the code. - Run doxygen and read some documentation. Of course, until a full script implementation, there is still much work to be done (and I'll work on different things in the next time), but perhaps you'll have some fun with it. This uses Guile, so suggesting Scheme as a script language. The only reason for this is that I happen to be a bit familiar with libguile. It is simple to integrate other interpreters. Sebastian

1 0

autotools
by p37sitdu＠lavabit.com Jan. 5, 2013

Jan. 5, 2013

There is autogen.sh in source tree. It can be replaced with "autoreconf -i" or simply removed. According to ChangeLog of autoconf, autoreconf has been there for at least 10 years. I also looked at configure.ac. In attached patch I added dillo URL, used AS_HELP_STRING to format help lines, replaced AC_ERROR with AC_MSG_ERROR (it was renamed) and replaced -D flags with AC_DEFINE. If no config.h is used, flags should be added to DEFS variable, but with config.h they should be defined in config.h using AC_DEFINE. The problem is that not all files include config.h. I added #includes where necessary, but to avoid problems when some files see defines and some files don't, config.h should be included by every .c and .cc file before all other includes.

1 0

[patch] remove redundant check in cache.c
by p37sitdu＠lavabit.com Jan. 5, 2013

Jan. 5, 2013

2 1

hanging in textblock
by corvid＠lavabit.com Jan. 4, 2013

Jan. 4, 2013

http://graphicssoft.about.com/od/aboutgraphics/a/bitmapvector.htm #0 0x080929ad in dw::Textblock::findParagraphOfWord (this=0x82268b0, wordIndex=81) at textblock.cc:1228 #1 0x0809a3c7 in dw::Textblock::fillParagraphs (this=0x82268b0) at textblock_linebreaking.cc:1115 #2 0x0809169c in dw::Textblock::getExtremesImpl (this=0x82268b0, extremes=0xbfffe828) at textblock.cc:299 #3 0x080b48cc in dw::core::Widget::getExtremes (this=0x82268b0, extremes=0xbfffe828) at widget.cc:194 #4 0x08098276 in dw::Textblock::accumulateWordExtremes ( this=this at entry=0x822b460, firstWord=firstWord at entry=10, lastWord=lastWord at entry=11, maxOfMinWidth=maxOfMinWidth at entry=0xbfffe898, sumOfMaxWidth=sumOfMaxWidth at entry=0xbfffe89c) at textblock_linebreaking.cc:412 #5 0x08099eab in dw::Textblock::addLine (this=this at entry=0x822b460, firstWord=firstWord at entry=10, lastWord=lastWord at entry=11, temporary=temporary at entry=false) at textblock_linebreaking.cc:328 #6 0x0809aca0 in dw::Textblock::wordWrap (this=0x822b460, wordIndex=11, wrapAll=false) at textblock_linebreaking.cc:596 #7 0x0809a278 in dw::Textblock::rewrap (this=0x822b460) at textblock_linebreaking.cc:1071 #8 0x080914fc in dw::Textblock::sizeRequestImpl (this=0x822b460, requisition=0x8244898) at textblock.cc:217 #9 0x080b483f in dw::core::Widget::sizeRequest (this=0x822b460, requisition=0x8244898) at widget.cc:177 #10 0x08091b92 in dw::Textblock::calcWidgetSize (this=0x82dae38, widget=0x822b460, size=0x8244898) at textblock.cc:768 #11 0x0809a2ba in dw::Textblock::rewrap (this=0x82dae38) at textblock_linebreaking.cc:1069 #12 0x080914fc in dw::Textblock::sizeRequestImpl (this=0x82dae38, requisition=0x8258078) at textblock.cc:217 #13 0x080b483f in dw::core::Widget::sizeRequest (this=0x82dae38, requisition=0x8258078) at widget.cc:177 #14 0x08091b92 in dw::Textblock::calcWidgetSize (this=0x82e1300, widget=0x82dae38, size=0x8258078) at textblock.cc:768 #15 0x0809a2ba in dw::Textblock::rewrap (this=0x82e1300) at textblock_linebreaking.cc:1069 #16 0x080914fc in dw::Textblock::sizeRequestImpl (this=0x82e1300, requisition=0x824bd80) at textblock.cc:217 #17 0x080b483f in dw::core::Widget::sizeRequest (this=0x82e1300, requisition=0x824bd80) at widget.cc:177 #18 0x08091b92 in dw::Textblock::calcWidgetSize (this=0x822d870, widget=0x82e1300, size=0x824bd80) at textblock.cc:768 #19 0x0809a2ba in dw::Textblock::rewrap (this=0x822d870) at textblock_linebreaking.cc:1069 #20 0x080914fc in dw::Textblock::sizeRequestImpl (this=0x822d870, requisition=0x81e64b8) at textblock.cc:217 #21 0x080b483f in dw::core::Widget::sizeRequest (this=0x822d870, requisition=0x81e64b8) at widget.cc:177 #22 0x08091b92 in dw::Textblock::calcWidgetSize (this=0x8278530, widget=0x822d870, size=0x81e64b8) at textblock.cc:768 #23 0x0809a2ba in dw::Textblock::rewrap (this=0x8278530) at textblock_linebreaking.cc:1069 #24 0x080914fc in dw::Textblock::sizeRequestImpl (this=0x8278530, requisition=0xbfffee40) at textblock.cc:217 #25 0x080b483f in dw::core::Widget::sizeRequest (this=0x8278530, requisition=0xbfffee40) at widget.cc:177 #26 0x080ade2c in dw::core::Layout::resizeIdle (this=0x820f448) at layout.cc:667 #27 0x0809faa8 in dw::fltk::FltkPlatform::generalIdle (this=0x820f410) at fltkplatform.cc:630 #28 0x080ef3b1 in call_idle () at Fl_add_idle.cxx:40 #29 0x080b88e4 in Fl::wait (time_to_wait=1e+20) at Fl.cxx:496 #30 0x080b89c0 in Fl::run () at Fl.cxx:529 #31 0x0804f7f9 in main (argc=1, argv=0xbffff044) at dillo.cc:498

2 3

wizard, switching between UIs
by corvid＠lavabit.com Jan. 2, 2013

Jan. 2, 2013

Yesterday I was playing with ctrl-tab, of course, and I noticed how the state of the focused tab would sometimes change. I went through a few rounds of fixing this in different ways before finding something that didn't seem icky. Detailed comment in patch.

2 3

Render bug
by Hole.destructor＠gmx.de Jan. 2, 2013

Jan. 2, 2013

Dear Dillo developers, sorry for not creating a proper bug report, but the "How to reproduce" message field is too small for the example file. :) The issue ========= After closing the "Save As" dialog, the background color of the HTML page is not redrawn correctly (leaving white rectangles instead of the background color). How to reproduce ================ 1. open the appended html file (note the grey background) 2. click on "file" link 3. move the "Save As" window over the grey background 4. close the "Save As" window --> parts of the background are drawn white, instead of grey Best, Alex

3 3

CAPI ignores download requests when not in cache or handled by the downloads DPI.
by onepoint＠starurchin.org Jan. 2, 2013

Jan. 2, 2013

I wondered why "Save link as" silently failed on some of my local web pages if I had not already visited the link. It turns out they were "file:///" links and "Save link as" sends a download request which the CAPI silently ignores if the URL is not cached and is not handled by the downloads DPI. I added a MSG_WARN to log this but haven't changed any behaviour. I still found it surprising and was wondering if it could be improved? Regards, Jeremy Henty

4 5

hyphenator valgrind error
by corvid＠lavabit.com Jan. 2, 2013

Jan. 2, 2013

==30983== Invalid read of size 1 ==30983== at 0x81151B6: fl_utf8back (fl_utf.c:259) ==30983== by 0x80A2320: dw::fltk::FltkPlatform::prevGlyph(char const*, int) (fltkplatform.cc:599) ==30983== by 0x809EDA3: dw::Hyphenator::hyphenateSingleWord(dw::core::Platform*, char*, int, lout::misc::SimpleVector<int>*) (hyphenator.cc:327) ==30983== by 0x809E9F2: dw::Hyphenator::hyphenateWord(dw::core::Platform*, char const*, int*) (hyphenator.cc:256) ==30983== by 0x809C087: dw::Textblock::hyphenateWord(int) (textblock_linebreaking.cc:762) ==30983== by 0x809BB6E: dw::Textblock::wordWrap(int, bool) (textblock_linebreaking.cc:609) ==30983== by 0x809B6A9: dw::Textblock::processWord(int) (textblock_linebreaking.cc:441) ==30983== by 0x8098753: dw::Textblock::addText0(char const*, unsigned int, short, dw::core::style::Style*, dw::core::Requisition*) (textblock.cc:1694) ==30983== by 0x8097B02: dw::Textblock::addText(char const*, unsigned int, dw::core::style::Style*) (textblock.cc:1478) ==30983== by 0x8073F5C: Html_process_word(DilloHtml*, char const*, int) (html.cc:1216) ==30983== by 0x807A348: Html_write_raw(DilloHtml*, char*, int, int) (html.cc:3923) ==30983== by 0x80727A9: DilloHtml::write(char*, int, int) (html.cc:531) ==30983== Address 0x661e6bf is 1 bytes before a block of size 16 alloc'd ==30983== at 0x402AC41: malloc (vg_replace_malloc.c:270) ==30983== by 0x80A223F: dw::fltk::FltkPlatform::textToLower(char const*, int) (fltkplatform.cc:584) ==30983== by 0x809E86A: dw::Hyphenator::hyphenateWord(dw::core::Platform*, char const*, int*) (hyphenator.cc:223) ==30983== by 0x809C087: dw::Textblock::hyphenateWord(int) (textblock_linebreaking.cc:762) ==30983== by 0x809BB6E: dw::Textblock::wordWrap(int, bool) (textblock_linebreaking.cc:609) ==30983== by 0x809B6A9: dw::Textblock::processWord(int) (textblock_linebreaking.cc:441) ==30983== by 0x8098753: dw::Textblock::addText0(char const*, unsigned int, short, dw::core::style::Style*, dw::core::Requisition*) (textblock.cc:1694) ==30983== by 0x8097B02: dw::Textblock::addText(char const*, unsigned int, dw::core::style::Style*) (textblock.cc:1478) ==30983== by 0x8073F5C: Html_process_word(DilloHtml*, char const*, int) (html.cc:1216) ==30983== by 0x807A348: Html_write_raw(DilloHtml*, char*, int, int) (html.cc:3923) ==30983== by 0x80727A9: DilloHtml::write(char*, int, int) (html.cc:531) ==30983== by 0x8079D85: Html_callback(int, _CacheClient*) (html.cc:3799)

2 2

Dpi_connect_socket retry
by p37sitdu＠lavabit.com Jan. 1, 2013

Jan. 1, 2013

Dpi_connect_socket function from src/IO/dpi.c (also duplicated in test/cookies.c) has retry argument. It is set to TRUE on first call, and Dpi_connect_socket calls itself recursively with retry == FALSE in case of error. This retry function is not working. If connection fails, at line 645 sock_fd is set, but ret is still set to -1. Even if the second attempt to connect is successful, -1 is returned and conected sock_fd is lost. It is possible to fix it by adding "ret = sock_fd", but I think it is better to just remove retries completely. It is unlikely that connecting using loopback interface will fail on first try and succeed on retry. Also, comment says "the server closes sock_fd on error". However, sock_fd should still be closed by client to free allocated file descriptor. OS don't know if Dillo is going to read from it (in which case error such as ECONNRESET should happen) so file descriptor can't be reused. File descriptor should be closed in case of error in a_Dpip_build_cmd too. Patch to fix this function and its calls in src/IO/dpi.c and test/cookies.c is attached.

2 6

show_url pref
by corvid＠lavabit.com Dec. 30, 2012

Dec. 30, 2012

Since it's been broken throughout the dillo3 era, the other day I made it so that you can't disable it -- and now I'm wondering what the value is in even having the pref. Removing Location doesn't give us room for anything more important. It's kind of like having a show_viewport preference.

2 1

PATCH: uicmd.cc prefs.save_dir cleanup
by onepoint＠starurchin.org Dec. 30, 2012

Dec. 30, 2012

uicmd.cc exports a get()/set() interface to the default save directory that is never used elsewhere, and used only trivially internally. It also rereads prefs.save_dir at every save, which is redundant. It would be simpler to have an init() interface that is called once. There would be no change to the user. Patch attached. Thoughts? Regards, Jeremy Henty

2 2

findbar behaviour
by corvid＠lavabit.com Dec. 28, 2012

Dec. 28, 2012

When I want to change the case-sensitivity of a search, I don't like having to switch to the mouse and aim it toward the little checkbox. So I looked up why we disable tabbing to the other widgets (and found nothing). Then a little experimentation showed that triggering shortcuts causes widgets to get focus, which we don't want. With that answered, I tried letting the input do its own callbacks upon Enter or Shift-Enter, and letting everything accept focus. This isn't heavily tested, but I wanted to see how the idea goes over first...

2 8

ctrl-PageUp/Down
by corvid＠lavabit.com Dec. 28, 2012

Dec. 28, 2012

I notice that ctrl-PageUp/Down for cycling through tabs doesn't work when a Fl_Input has focus. I can fix that if anyone cares...

2 2

Ctrl-Tab and tabs
by Johannes.Hofmann＠gmx.de Dec. 28, 2012

Dec. 28, 2012

Hi, it seems that Ctrl-Tab no longer cycles tabs if an input field is focused. I did like the previous behaviour better, where Ctrl-Tab cycled tabs independent of where the focus was. Cheers, Johannes

4 4

penalty_em_dash_*
by jcid＠dillo.org Dec. 28, 2012

Dec. 28, 2012

Hi Sebastian, While checking the penalty_em_dash_* patch, I noticed it would be good to add and comment the hyphenation preferences in dillorc. -- Cheers Jorge.-

2 1

textarea key bindings
by corvid＠lavabit.com Dec. 27, 2012

Dec. 27, 2012

In bug 1112, Alexander asked for ctrl-backspace to work a word at a time. I put together the attached and he reports that it's working well.

1 0

show_tooltip=NO
by corvid＠lavabit.com Dec. 26, 2012

Dec. 26, 2012

tipwin still shows tooltips when show_tooltip=NO.

2 1

vsource/dpip endless loop
by corvid＠lavabit.com Dec. 26, 2012

Dec. 26, 2012

I have a recentish version of the html5 working draft as one page, and it's over 6 megs. If I view source on it, this is rather slow and gives me time to hit Escape and Ctrl-W. Then top shows vsource using all of the processor until I kill it. (gdb) bt #0 0x0804a843 in a_Dpip_dsh_read_token (dsh=0x9e7ae18, blocking=1) at dpip.c:455 #1 0x080491f9 in send_html_text (sh=0x9e7ae18, url=0x9e7ced6 "file:/home/corvid/html5.html.gz", data_size=6402268) at vsource.c:121 #2 0x08049460 in main () at vsource.c:219

2 2

How to link to a specific bug report?
by abe＠deuxchevaux.org Dec. 24, 2012

Dec. 24, 2012

Hi, I just submitted a (forwarded) bug report (#1113) and would like to link to it directly. Is there any query string parameter where I can enter the bug number? Neither "bug_number" like for the volunteer and remove CGI scripts does work nor does what=1113. In case there isn't such a featre yet, I'd be happy if you could at least e.g. <a name="1113">...</a> jump mark. Thta should be quite easy with regards to the CGI script's current output. TIA. Kind regards, Axel -- /~\ Plain Text Ribbon Campaign | Axel Beckert \ / Say No to HTML in E-Mail and News | abe at deuxchevaux.org (Mail) X See http://www.asciiribbon.org/ | abe at noone.org (Mail+Jabber) / \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)

2 2

Extensions for hyphenation
by sgeerken＠dillo.org Dec. 23, 2012

Dec. 23, 2012

Hi! At http://flpsed.org/hgweb/dillo_hyphen, you'll find some extensions for hyphenation I've not yet merged into the main repository. Still needs some documentation, but here is an overview: There are now configuration variables for dillorc (see source): penalties for hyphens, as well as the left and right side of an em-dash. The suffix "_2" means that this value is used for lines following a line which ends already with a hyphen. When this value is larger, two adjacent lines ending with a hyphen are avoided. For values, see the definition of the "badness". Typical values: 0 = Penalty used for normal spaces. 1 = A justified line with spaces having 150% or 67% of the ideal space width has this as badness. 8 = A justified line with spaces twice as wide as ideally has this as badness. "inf" may be used (preventing a break in any case); also "-inf" (forcing a break), although the latter makes no sense and may lead to strange results. There is a text page, test/hyphens-etc.html, to play around. Sebastian

4 21

[patch] dns.c: missing break in a_Dns_dillohost_to_string
by p37sitdu＠lavabit.com Dec. 20, 2012

Dec. 20, 2012

Fix is attached.

2 1