- Dillo-dev - lists.mailman3.com

Warnings in src/IO/dpi.c and lout/misc.hh
by newman.x＠gmail.com April 2, 2009

April 2, 2009

Found this three warnings when compiling with gcc-4.3.2-7.i386: gcc -DHAVE_CONFIG_H -I. -I../.. -I/usr/local/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -g -O2 -DD_DNS_THREADED -D_REENTRANT -D_THREAD_SAFE -Wall -W -Waggregate-return -MT dpi.o -MD -MP -MF .deps/dpi.Tpo -c -o dpi.o dpi.c dpi.c: In function ?Dpi_get_dpid_uds_dir?: dpi.c:382: warning: ignoring return value of ?fgets?, declared with attribute warn_unused_result dpi.c: In function ?a_Dpi_bye_dpid?: dpi.c:733: warning: ignoring return value of ?write?, declared with attribute warn_unused_result g++ -DHAVE_CONFIG_H -I. -I.. -DDILLORC_SYS='"/usr/local/etc/dillorc"' -I/usr/local/include -I.. -I/usr/include/libpng12 -I/usr/include/freetype2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -Wno-non-virtual-dtor -g -O2 -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT styleengine.o -MD -MP -MF .deps/styleengine.Tpo -c -o styleengine.o styleengine.cc ../lout/misc.hh: In member function ?void StyleEngine::apply(dw::core::style::StyleAttrs*, CssPropertyList*)?: ../lout/misc.hh:181: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false -- Regards, Michal Nowak

3 5

http.c:500: warning: unused parameter ‘Data2’
by newman.x＠gmail.com April 2, 2009

April 2, 2009

gcc -DHAVE_CONFIG_H -I. -I../.. -I/usr/local/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -g -O2 -DD_DNS_THREADED -D_REENTRANT -D_THREAD_SAFE -Wall -W -Waggregate-return -MT http.o -MD -MP -MF .deps/http.Tpo -c -o http.o http.c http.c: In function ?a_Http_ccc?: http.c:500: warning: unused parameter ?Data2? gcc-4.3.2-7.i386 Emerged in recent days. -- Regards, Michal Nowak

2 1

[PATCH] startup window
by Johannes.Hofmann＠gmx.de April 2, 2009

April 2, 2009

Hi, attached patch adds a proper startup screen for dillo. Cheers, Johannes

5 6

Segfault on sites requiring authentication
by tim.nieradzik＠gmx.de April 2, 2009

April 2, 2009

Whenever I visit http://puppyisos.org/isos (puppy / linux), Dillo segfaults. The reason is that in some cases the variable Client_bw is NULL. However, some functions depend on it and access its member variables. Client_bw is initialized in Cache_process_queue() (src/cache.c). When authentication is required, this variable is passed over to Cache_auth_entry() which sets a timeout. Its callback (Cache_auth_callback()) opens up a dialog asking for the credentials and then calls a_Nav_reload() with the Client_bw as its first parameter. Finally in a_Nav_cancel_expect() Client_bw's member variable nav_expecting is used and as bw is NULL, Dillo segfaults. I came up with a small patch that removes Cache_auth_callback() and Cache_auth_entry() as I have not seen any advantages in delaying the authentication popup. The next thing I did was to show the dialog on condition that Client_bw is not NULL and that we have finished the transfer (At least I hope CA_Close is the proper flag for doing so). There were various unnecessary checks in src/nav.c. They compared bw with NULL. In my opinion the affected functions (a_Nav_expect_done, a_Nav_push and a_Nav_repush) should never be called if you cannot be sure that bw is not NUL. What is your view on this subject? Unfortunately, my approach does not solve the original problem that caused Client_bw being NULL. Furthermore, the patch introduces a new bug: The dialog pops up when reloading the site but after having entered the correct credentials or having pressed the ``Cancel'' button, it appears again. Any ideas? While digging deeper into the code, I noticed that we make heavy use of timers for popups and reloading pages? Is there any special reason for it? --Tim

2 5

tools button name (a very trivial matter)
by corvid＠lavabit.com March 29, 2009

March 29, 2009

I was going to update the dillorc comment for load_images (still mentions the old dedicated button), and... to developers, it's in the Tools button's menu now, but to users, it's the Settings button because that's what the tooltip says. We should standardize on one name or the other.

2 2

google login redirect
by furaisanjin＠gmail.com March 26, 2009

March 26, 2009

Hi all. I have noticed that google login redirect is something like this. <meta http-equiv="refresh" content="0; url='http://www.google.com/ .....> So generated redirect template looks like <table width='100%'><tr><td bgcolor='#ee0000'>Warning:</td> <td bgcolor='#8899aa' width='100%'> This page uses the NON-STANDARD meta refresh tag.<br> The HTML 4.01 SPEC (sec 7.4.4) recommends explicitly to avoid it.</td></tr> <tr><td bgcolor='#a0a0a0' colspan='2'>The author wanted you to go <a href=''http://www.google.com/ ... So dillo just navigates to the same page. This is the reason why we can't login. Regards, furaisanjin

4 10

Re: FLTK2 r6403
by corvid＠lavabit.com March 26, 2009

March 26, 2009

Nicol?s wrote: > Hi! Well, I am making the possible to compile Dillo in OSX. But with > the version of FLTK v6700 i can't pass the ./configure. > I am using the v6671, but there are some differences between the v6403 > (recomended in the README file). If anyone has the v6403, send it me > please =). 6700 is FLTK 1.3. You don't want that. The README says 6403 or newer. fltk-2.0.x-6671 should be fine.

1 0

Ohloh does not accept http://hg.dillo.org/dillo as Enlistment for the Dillo browser.
by wine.dev＠web.de March 25, 2009

March 25, 2009

Hi. Thanks for working on Dillo. I tried to update the Dillo Project Page on Ohloh, but the the repository failed on the id command. ...$hd id http://hg.dillo.org/dillo abort: cannot look up remote revision; remote repository does not support the 'lookup' capability! Which Mercurial version is used to serve dillo? -- By by ... Detlef

3 6

bug tracker doesn't work with dillo?
by Johannes.Hofmann＠gmx.de March 25, 2009

March 25, 2009

On Wed, Mar 25, 2009 at 12:37:54PM -0400, Jorge Arellano Cid wrote: > On Wed, Mar 25, 2009 at 05:19:48PM +0100, Hofmann Johannes wrote: > > On Wed, Mar 25, 2009 at 08:33:28AM -0400, Jorge Arellano Cid wrote: > > > On Wed, Mar 25, 2009 at 01:21:25AM +0100, Joerg Sonnenberger wrote: > > > > On Wed, Mar 25, 2009 at 12:03:05AM +0000, corvid wrote: > > > > > Jorge wrote: > > > > > > Skimming the code it looks like the cast to long for int is > > > > > > the way to go. If a: > > > > > > > > > > > > - URL_DATA(url)->len, content_type->str, > > > > > > + (long)URL_DATA(url)->len, content_type->str, > > > > > > > > > > > > solves it. I'd commit it and let the explanation come after > > > > > > the patch. > > > > > > > > > > I was thinking of adding long casts for the Content-Length headers > > > > > in file.c as well. Sound good? > > > > > > > > Shouldn't that be (s)size_t? > > > > > > The parameter is specified as %ld, so long seems OK. > > > > I think Joerg is suggesting to switch the len field of struct Dstr > > to size_t/ssize_t and to use this consistently (e.g. using %zd for > > printing it). > > Standard string functions also use size_t for string length. > > It took a long way to define 'len' as int. I wouldn't awake > that dragon. Ah ok. I will browse CVS history a bit :) Cheers, Johannes

2 1

bug tracker doesn't work with dillo?
by dillo-dev＠toykeeper.net March 25, 2009

March 25, 2009

* corvid <corvid(a)lavabit.com> wrote: > Oh, also, did 2.0 work for you? Yes. But how about something more specific... I ran 'hg bisect' on it and here is the result: The first bad revision is: changeset: 491:96a14e974cfb tag: 2.1-noCss user: corvid <corvid(a)lavabit.com> date: Thu Jan 15 18:33:04 2009 -0300 summary: Added the "http_language" dillorc option for setting HTTP's Accept-Language. The diff for that revision doesn't really tell me why it broke then... nothing obvious stands out. But r490 works and r491 doesn't. Maybe you'll see something I don't. :) -- Scott

5 8