- Dillo-dev - lists.mailman3.com

dillo man page
by corvid＠lavabit.com May 13, 2009

May 13, 2009

I tried making a little man page for dillo. 1) in order to be a proper, self-respecting unix program :) 2) good way of documenting the files, and I don't think environment variables were documented anywhere. I'd never made a proper man page before, but I think it's pretty close to how they're supposed to be... http://www.dillo.org/test/dillo.1 http://www.dillo.org/test/dillo.man.ascii http://www.dillo.org/test/dillo.man.html

2 1

[patch]: fix image logging messages
by onepoint＠starurchin.org May 11, 2009

May 11, 2009

This patch just tweaks the image debugging messages. It fixes the reported function names (currently a_*_new is reported as *_new) and enforces a consistent format. Regards, Jeremy Henty

2 1

Nav_repush() is hurting valgrind
by onepoint＠starurchin.org May 11, 2009

May 11, 2009

The valgrind logs[1] show a recent burst of errors from calls to Nav_repush(). Also, I'm currently trialling a patch to fix the image access errors from a_Cache_stop_client() [2]. I don't think it can be the cause of the Nav_repush() problems but I'd like a second opinion (I don't yet fully understand how this code should work). Regards, Jeremy Henty [1] http://starurchin.singularity/dillo/valgrind.html [2] http://starurchin.singularity/dillo/patch/make-a_Cache_stop_client-close-cl…

2 12

whitespace entities inside words
by corvid＠lavabit.com May 10, 2009

May 10, 2009

Is a whitespace entity inside a word supposed to be treated like normal whitespace? I thought it would be, but first I saw that adjacent   ... aren't collapsed, then I realized that we are leaving the space inside the word instead of calling addSpace, and then I saw that PrevWasSPC isn't set if the space was at the end of the word. If it's just something that no one ever got around to dealing with, I'll make a patch.

3 5

[patch]: (updated) replace DW2TB with HT2TB
by onepoint＠starurchin.org May 9, 2009

May 9, 2009

This is an updated version of the cleanup patch that replaces the convenience macro DW2TB with an even more convenient HT2TB. It doesn't change anything, but it reduces the noise in html.cc and form.cc . Please comment. Regards, Jeremy Henty

2 2

css and font specification [Re: Dillo2 + FLTK2 + NxLib running on mips linux]
by corvid＠lavabit.com May 9, 2009

May 9, 2009

----- Forwarded message from ?? ? ----- > I have try current version dillo + fltk base on X11 in X86 PC (Ubuntu) > with LC_LANG=zh_TW.UTF-8. > > Using default font_xxxx I can see chinese text and write chinese characters to text editor also works. > > But, I cannot see any chinese text after google search ??? > The same URL works on dillo + fltk base on nxlib. > > What I think is the FLTK already supports multi bytes characters well. > The problem is caused by others (I mean fonts / X11 configuration etc.) > Am I right ? (This came with screenshots showing that www.google.com.tw doesn't work.) If dillo doesn't parse embedded css, it works for me. The "body,td,a,p,.h{font-family:arial,sans-serif}" in the page overrides my font_* prefs. So I tried to add a !important rule to set font-family in style.css, e.g. * {font-family: "Bitstream Cyberbit" !important} but either it's impossible or I was getting the syntax wrong somehow. (This is not necessarily the same problem he's having, but...)

2 3

Image invalid access problems
by onepoint＠starurchin.org May 8, 2009

May 8, 2009

It's too early to be absolutely certain, but from the logging data I've been collecting it seems that invalid DilloImage accesses always come from this call sequence: a_Bw_stop_clients() -> a_Capi_stop_client() -> a_Cache_stop_client() -> Cache_client_dequeue() -> a_Web_free() -> a_Image_unref() -> Image_free() -> dFree() So the question is: why isn't this call sequence stopping the image callbacks from running before it dFree()s the image? When Cache_process_queue() sees that all the data has arrived for a client it executes "(Client->Callback)(CA_Close, Client);" before calling Cache_client_dequeue(). Perhaps the fix is for a_Cache_stop_client() to close the client too? Regards, Jeremy Henty PS: Interestingly, a_Bw_stop_clients() has a comment: /* * Stop the active clients of this bw's top page. * Note: rendering stops, but the cache continues to be fed. */ This seems to be talking about our problem: the cache is still running and therefore accessing the client, but the client has been freed.

1 0

[patch]: replace DW2TB with HT2TB
by onepoint＠starurchin.org May 8, 2009

May 8, 2009

I noticed that the convenience macro DW2TB is always used as DW2TB(html->dw) so it makes sense to use an even more convenient macro HT2TB to reduce DW2TB(html->dw) to HT2TB(html). Patch attached. Regards, Jeremy Henty

1 0

Applause: image resizing fix
by onepoint＠starurchin.org May 8, 2009

May 8, 2009

I spend a lot of time surfing the DoomWorld picture viewer[1] and so I'm used to the thumbnails at the bottom displaying random small chunks of the image instead of anything useful. But now I'm seeing proper previews, just as the site designers intended. It's *really* nice to see this working properly! Dillo just keeps getting better! Regards, Jeremy Henty [1]: eg. http://www.doomworld.com/php/screenie.php?dir=/images/newstuff/341/&filenam…

1 0

[patch]: more cleanups
by onepoint＠starurchin.org May 7, 2009

May 7, 2009

Three more cleanup patches: 1: Inline Cache_client_make_key() into Cache_client_enqueue(). Why have a separate function just to increment a variable? It's just as clear (and less noisy) to increment a static variable inside Cache_client_enqueue(). 2: The width and height arguments of a_Image_new() do nothing. The function itself ignores them and its callers always set them to 0. Since neither the function or its callers seem to care what these arguments are, why not remove them? 3: a_Web_dispatch_by_type() has a strange convention for its return type, it returns -1 to indicate failure. It's less confusing to use the common convention of a boolean: 1 indicates success and 0 indicates failure. Regards, Jeremy Henty

2 2