- Dillo-dev - lists.mailman3.com

Another SGi compiler problem
by csoren＠isd.net Jan. 24, 2013

Jan. 24, 2013

> > > > Greets all, > > > > I'm trying to compile on Silicon Graphics (IRIX O.S.) > > using their MIPSPro 7.4 > > compiler, but getting this error in dialog.cc: > > > > <pre> > > cc-1028 CC: ERROR File = dialog.cc, Line = 180 > > The expression used must have a constant value. > > > > memset(pm, '\0', sizeof(Fl_Menu_Item[n_it+1])); > > ^ > > </pre> > > > > Thoughts? > > You may try something like: > > memset(pm, '\0', (n_it+1)*sizeof(Fl_Menu_Item)); > > -- > Cheers > Jorge.- Thanks Jorge that worked! :) Fourteen files compiled so far but then this happened in fltkflatview.cc: ---------------------------------------------- cc-3168 CC: ERROR File = fltkui.cc, Line = 782 A name followed by "::" must be a class or namespace name. bool FltkToggleButtonResource<I>::FltkToggleButtonResource::isActivated () ^ cc-1443 CC: ERROR File = fltkui.cc, Line = 782 "dw::fltk::ui::FltkToggleButtonResource<I>::FltkToggleButtonResource" is not a class template. bool FltkToggleButtonResource<I>::FltkToggleButtonResource::isActivated () ^ 2 errors detected in the compilation of "fltkflatview.cc". ----------------------------------------------- Thoughts?

2 1

[patch] dCalloc
by p37sitdu＠lavabit.com Jan. 24, 2013

Jan. 24, 2013

dNew macro hides multiplication and can lead to integer overflows. Patch implements dCalloc and replaces dNew with dCalloc wrapper so no integer overflows are possible: http://www.inventati.org/noname/dillo/dlib/dcalloc.patch dwrite.patch is moved to http://www.inventati.org/noname/dillo/dlib/

1 0

_t suffix
by p37sitdu＠lavabit.com Jan. 23, 2013

Jan. 23, 2013

Suffix _t is reverved by POSIX and should not be used: <http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html> I have made patches that remove _t suffix from some modules: http://www.inventati.org/noname/dillo/_t/

1 0

line wrap for Japanese
by furaisanjin＠gmail.com Jan. 23, 2013

Jan. 23, 2013

Hello all. It seems that change set de05508cbbbd causes the line wrap problem for Japanese. Certain lines become very long and I don't see appropriate line wrap in the middle. Regards, furaisanjin

2 2

dereferencing type-punned pointer warning
by Johannes.Hofmann＠gmx.de Jan. 22, 2013

Jan. 22, 2013

Hi, line 135 in lout object.cc: return ((int*)&value)[0] ^ ((int*)&value)[1]; causes the following error on 64bit systems for me: warning: dereferencing type-punned pointer will break strict-aliasing rules Can we replace it like this: diff -r dd6f2d1eb15a lout/object.cc --- a/lout/object.cc Mon Jan 14 10:26:37 2013 -0300 +++ b/lout/object.cc Mon Jan 14 21:56:46 2013 +0100 @@ -21,6 +21,7 @@ #include "object.hh" #include <stdio.h> +#include <stdint.h> #include <config.h> namespace lout { @@ -132,7 +133,7 @@ // Combine both parts of the pointer value *itself*, not what it // points to, by first referencing it (operator "&"), then // dereferencing it again (operator "[]"). - return ((int*)&value)[0] ^ ((int*)&value)[1]; + return ((intptr_t)value >> 32) ^ ((intptr_t)value); #endif } Cheers, Johannes

2 1

[patch] Scrollbar thickness from dillorc
by podarcis＠lavabit.com Jan. 22, 2013

Jan. 22, 2013

Scrollbars currently have the hardcoded thickness 15. This can be too small to operate dillo on large screens or with fingers on a touch screen. The supplied patch does the following: - Adds the prefence "scrollbar_tickness" to dillorc. - Reads the value into the prefences (Note: added a type UINT32 to prefsparse.cc) - Sets this value to the FltkViewport with the new method FltkViewport::setScrollbarThickness(). Note: I deliberately did no check for value 0, which can therefore be used to make the scrollbars invisible. Scrolling can then still be achieved with the cursor keys. This could be called a feature. Cheers, podarcis

3 4

drawing highlighting
by corvid＠lavabit.com Jan. 19, 2013

Jan. 19, 2013

I was looking at draw() calls for the view, and I saw how there was a call for every time that the mouse moved when highlighting even though the text highlighted didn't necessarily change. Here's quick code to demonstrate that there are plenty of redundant ones. I don't know the iterator code well enough to know whether that's the right place to do anything about it, though...

2 2

[patch] disable SSLv2 support
by p37sitdu＠lavabit.com Jan. 18, 2013

Jan. 18, 2013

http://www.inventati.org/noname/dillo/https-no-SSLv2.patch I have found HTTPS server that Dillo was unable to connect to. After defining SILENT to 0 in https.c I found that SSL_connect failed. Adding ERR_print_errors_fp(stderr) showed error "SSL23_GET_SERVER_HELLO:unknown protocol". Disabling SSLv2 support fixed the problem for me. And SSLv2 is insecure so it must be disabled anyway.

2 1

[patch] dWrite
by p37sitdu＠lavabit.com Jan. 18, 2013

Jan. 18, 2013

http://www.inventati.org/noname/dillo/dwrite.patch Removed Dpi_blocking_write from src/IO/dpi.c and moved similar code to dlib. Also fixes ckd_write in dpid/dpid_common.c: it handled EINTR, but did not handle situation when number of bytes written is less then requested. Now it uses dWrite.

1 0

[patch] a_Dpip_send_cmd
by p37sitdu＠lavabit.com Jan. 16, 2013

Jan. 16, 2013

http://www.inventati.org/noname/dillo/dpip-send-cmd.patch Patch adds a_Dpip_send_cmd and helper function a_Dpip_vbuild_cmd. This way common pattern d_cmd = a_Dpip_build_cmd(format, ...); st = a_Dpip_dsh_write_str(sh, flush, d_cmd); dFree(d_cmd); can be replaced with st = a_Dpip_send_cmd(sh, flush, format, ...);

2 2