- Dillo-dev - lists.mailman3.com

BUGFIX set close_on_exec (FD_CLOEXEC)
by Raphael Barabas March 2, 2003

March 2, 2003

hello, in my neverending search for the perfect browser i stumbled across dillo. it looks great and quite usable, altough it's still alpha. unfortunately dillo 0.7.0 won't run on solaris8 (ultra30), so i wrote a fix. turns out every other os is affected by this bug, too. solaris just seems to be less forgiving in this matter :) to compile on solaris you may also need some workarounds, take a look at bugreports 402, 413 and 415. problem: solaris: see bugreport 416, dillo enters endless loop on startup, repeating "IO_write: Changing io->Buf (0)" linux: no immediate effect, although some filedescriptors are in state "open" for too long. i've not really looked into it but this should have negative effects in the long run. reason: in IO.c, function IO_submit, filedescriptor-flag close_on_exec is not set the right way (not at all). on solaris, as a direct result, non-blocking io will accidentally be handled via O_NDELAY instead of O_NONBLOCKING, resulting in an endless loop. patch: *** IO.c.org Sat Mar 1 21:56:13 2003 --- IO.c Sat Mar 1 21:56:54 2003 *************** *** 530,536 **** /* Set FD to background and to close on exec. */ fcntl(r_io->FD, F_SETFL, ! O_NONBLOCK | FD_CLOEXEC | fcntl(r_io->FD, F_GETFL)); if ( r_io->Op == IORead ) { g_io_add_watch(r_io->GioCh, G_IO_IN | G_IO_ERR | G_IO_HUP, --- 530,538 ---- /* Set FD to background and to close on exec. */ fcntl(r_io->FD, F_SETFL, ! O_NONBLOCK | fcntl(r_io->FD, F_GETFL)); ! fcntl(r_io->FD, F_SETFD, ! FD_CLOEXEC | fcntl(r_io->FD, F_GETFD)); if ( r_io->Op == IORead ) { g_io_add_watch(r_io->GioCh, G_IO_IN | G_IO_ERR | G_IO_HUP, disclaimer: this bugfix has been tested briefly on debian gnu/linux 2.4.20 and solaris 8. please review my code for correctness. also note that bugreport 417 has been proven wrong by this. regards, raphael

1 1

patch for POSIX file lock
by yangguilong March 2, 2003

March 2, 2003

I'm compiling dillo on Cygwin, which lacks of flock/lockf, but has support for POSIX file lock (fcntl()). To enable the cookies support, I write a patch for it. In hope that it will be useful for other platform having similar situation. diff -Nurp dillo-0.6.6/src/cookies.c dillo-0.6.6-cygwin/src/cookies.c --- dillo-0.6.6/src/cookies.c 2002-05-28 04:47:50.000000000 +0800 +++ dillo-0.6.6-cygwin/src/cookies.c 2003-03-01 10:23:56.000000000 +0800 @@ -130,6 +130,9 @@ void a_Cookies_init() GList *domain_cookies; char *filename; char line[LINE_MAXLEN]; +#ifndef HAVE_LOCKF + struct flock lck; +#endif Cookie_control_init(); @@ -145,7 +148,16 @@ void a_Cookies_init() } /* Try to get a lock from the file descriptor */ +#ifdef HAVE_LOCKF disabled = (lockf(fileno(file_stream), F_TLOCK, 0) == -1); +#else /* POSIX lock */ + lck.l_start = 0; /* start at beginning of file */ + lck.l_len = 0; /* lock entire file */ + lck.l_type = F_WRLCK; + lck.l_whence = SEEK_SET; /* absolute offset */ + + disabled = (fcntl(fileno(file_stream), F_SETLK, &lck) == -1); +#endif if (disabled) { DEBUG_MSG(10, "The cookies file has a file lock:\n" " disabling cookies in this dillo!\n"); @@ -278,6 +290,9 @@ static gboolean Cookies_freeall_cb(gpoin void a_Cookies_freeall() { int fd; +#ifndef HAVE_LOCKF + struct flock lck; +#endif if (disabled) return; @@ -288,7 +303,16 @@ void a_Cookies_freeall() g_hash_table_foreach_remove(cookies, Cookies_freeall_cb, NULL); +#ifdef HAVE_LOCKF lockf(fd, F_ULOCK, 0); +#else /* POSIX file lock */ + lck.l_start = 0; /* start at beginning of file */ + lck.l_len = 0; /* lock entire file */ + lck.l_type = F_UNLCK; + lck.l_whence = SEEK_SET; /* absolute offset */ + + fcntl(fileno(file_stream), F_SETLKW, &lck); +#endif fclose(file_stream); } --------------------------------------------- »¶Ó¹âÁÙ http://www.cmmail.com

1 0

Great work on Dillo! (fwd)
by Jorge Arellano Cid March 1, 2003

March 1, 2003

---------- Forwarded message ---------- Date: Wed, 26 Feb 2003 10:02:07 -0500 From: Alwyn Kerr <alkerr(a)yifan.net> To: jcid(a)softhome.net Subject: Great work on Dillo! Hi there, I'm writing to express how happy I am with Dillo. I'm a HUGE fan of software that is light-weight and Dillo would have to be the smallest, functional browser I've ever used. I find that it is especially useful for browsing documentation that's saved as a stack of HTML pages on disk. I mostly use it for reading the GTK API docs. when developing GTK applications. Anyway, before I'm done I was just wondering if future versions of Dillo might make tabs available for multiple pages? Once again, keep up the good work and please extend my happiness to the rest of the development team. Owen Klan ----------------------------------------------------- http://eo.yifan.net Free POP3/Web Email, File Manager, Calendar and Address Book

1 0

Bookmarks no longer work
by Albert Wagner March 1, 2003

March 1, 2003

I had some trouble with my system and had to manually kill several processes. Ever since then Dillo bookmarks no longer work. I get the following: Nav_open_url: Url=>dpi:/bm/< [connect]: Connection refused Not implemented How can I fix this?

3 5

Where can I find the flock->lockf patch?
by 阿贵 Feb. 26, 2003

Feb. 26, 2003

dillo-devHi, I'm going to build dillo on Windows, using Cygwin as porting tool and running envrionment. Guided by http://homepage.ntlworld.com/steven.obrien2/, I can build dillo-0.6.5 successfully. But there is no implmentation for lockf on Cygwin. So I'd like to know where can I find the flock->lockf patch. I want to apply a reverse patch on the new version of dillo. TIA. BTW: Please cc me, I'm not on the list. Hansom Young

1 0

Re: [Dillo-dev] segmentation fault
by andi Feb. 26, 2003

Feb. 26, 2003

> try a "real" compiler :-) ... 2.96 is not a real release (see > also http://gcc.gnu.org/gcc-2.96.html) I think redhat has > something like kcc or kgcc which is intended for kernel > compilation, but it is an official release. Ah i did not know about kgcc, thanks. I did not work either. Same problem, kgcc is gcc version egcs-2.91.66 by the way.

2 1

segmentation fault
by andi Feb. 26, 2003

Feb. 26, 2003

Hi, Thanks for this great project, i love dillo. There is just one problem with the 0.7 version. I get a segmentation fault every time i click on a link. I newly compiled dillo-0.7.0 without any errors and i starts perfectly, but if i move my mouse over a link the url in the status bar is follow by "?135070228,-1073744832" without the quotes and the numbers may vary. If i click on the link dillo exits permanently. If i type in any urls in the address field, there is no problem. Everything loads happily. --Output if i run it from the console: bash-2.05a$ ./dillo Setting locale to C... HTML warning: URL has 4 illegal characters (0x00-0x1F, 0x7F or space) HTML warning: hexadecimal color lacks leading '#' HTML warning: hexadecimal color is not in RRGGBB format. HTML warning: hexadecimal color lacks leading '#' HTML warning: hexadecimal color is not in RRGGBB format. dillorc:11: unexpected string constant "text-color", expected symbol dillorc:11: error: unexpected string constant "text-color", expected symbol dillo_dns_init: Here we go! The cookies file has a file lock: disabling cookies in this dillo! Nav_open_url: Url=>about:splash< IO_write: Changing io->Buf (4096) IO_write: EAGAIN IO_write: Changing io->Buf (4096) IO_write: EAGAIN Segmentation fault --My Versions: RedHat 7.3 GNU Make version 3.79.1 gcc version 2.96

1 0

Re: [Dillo-dev] present but cannot be compiled
by Akim Demaille Feb. 26, 2003

Feb. 26, 2003

| Hi, | there is probably something wrong with your mailer :-) | And there is no response, just the quotation ... | Jan Yes, I forgot the following piece of text, sorry: Please, report this to the package maintainers, as it's a configure.ac problem. The Autoconf 2.57 doc says: Previous versions of Autoconf merely checked whether the header was accepted by the preprocessor. This was changed because the old test was inappropriate for typical uses. Headers are typically used to compile, not merely to preprocess, and the old behavior sometimes accepted headers that clashed at compile-time. If you need to check whether a header is preprocessable, you can use `AC_PREPROC_IFELSE' (*note Running the Preprocessor::). This scheme, which improves the robustness of the test, also requires that you make sure that headers that must be included before the HEADER-FILE be part of the INCLUDES, (*note Default Includes::). If looking for `bar.h', which requires that `foo.h' be included before if it exists, we suggest the following scheme: AC_CHECK_HEADERS([foo.h]) AC_CHECK_HEADERS([bar.h], [], [], [#if HAVE_FOO_H # include <foo.h> # endif ]) Thanks! | On Feb 26 11:30:24, Akim Demaille wrote: : :| Hi, :| is is what I get with the current CVS (viz later). :| :| know that I don't have libpng, libjpeg etc installed :| y mistake, I was compiling on machine without them), :| t I mean the 'usability ... yes ; presence ... no' problem. :| this an autoconf bug, or is configure.in written badly ? :| :| e system is: :| :| Debian unstable :| kernel 2.4.19 (self compiled) :| autoconf 2.57 :| automake 1.6.3 :| gcc/cpp 3.2.2 :| :| :| e results follow. :| :| Jan :| :| :| s co dillo && cd dillo :| autogen.sh :| configure --prefix=$HOME :| ecking for a BSD-compatible install... /usr/bin/install -c :| ecking whether build environment is sane... yes :| ecking for gawk... gawk :| ecking whether make sets $(MAKE)... yes :| ecking for gcc... gcc :| ecking for C compiler default output... a.out :| ecking whether the C compiler works... yes :| ecking whether we are cross compiling... no :| ecking for suffix of executables... :| ecking for suffix of object files... o :| ecking whether we are using the GNU C compiler... yes :| ecking whether gcc accepts -g... yes :| ecking for gcc option to accept ANSI C... none needed :| ecking for style of include used by make... GNU :| ecking dependency style of gcc... gcc3 :| ecking for gcc option to accept ANSI C... none needed :| ecking for ranlib... ranlib :| ecking for gtk-config... /usr/bin/gtk-config :| ecking for GTK - version >= 1.2.0... yes :| ecking for jpeg_destroy_decompress in -ljpeg... no :| nfigure: WARNING: *** JPEG support will not be included *** :| ecking for pthread_create in -lpthread... yes :| ecking for zlibVersion in -lz... no :| ecking for png_check_sig in -lpng... no :| ecking for ANSI C header files... no :| ecking fcntl.h usability... yes :| ecking fcntl.h presence... no :| nfigure: WARNING: fcntl.h: accepted by the compiler, rejected by the preprocessor! :| nfigure: WARNING: fcntl.h: proceeding with the preprocessor's result :| nfigure: WARNING: ## ------------------------------------ ## :| nfigure: WARNING: ## Report this to bug-autoconf(a)gnu.org. ## :| nfigure: WARNING: ## ------------------------------------ ## :| ecking for fcntl.h... no :| ecking unistd.h usability... yes :| ecking unistd.h presence... no :| nfigure: WARNING: unistd.h: accepted by the compiler, rejected by the preprocessor! :| nfigure: WARNING: unistd.h: proceeding with the preprocessor's result :| nfigure: WARNING: ## ------------------------------------ ## :| nfigure: WARNING: ## Report this to bug-autoconf(a)gnu.org. ## :| nfigure: WARNING: ## ------------------------------------ ## :| ecking for unistd.h... no :| ecking sys/uio.h usability... yes :| ecking sys/uio.h presence... no :| nfigure: WARNING: sys/uio.h: accepted by the compiler, rejected by the preprocessor! :| nfigure: WARNING: sys/uio.h: proceeding with the preprocessor's result :| nfigure: WARNING: ## ------------------------------------ ## :| nfigure: WARNING: ## Report this to bug-autoconf(a)gnu.org. ## :| nfigure: WARNING: ## ------------------------------------ ## :| ecking for sys/uio.h... no :| ecking for socket... yes :| nfigure: creating ./config.status :| nfig.status: creating Makefile :| nfig.status: creating doc/Makefile :| nfig.status: creating src/Makefile :| nfig.status: creating src/IO/Makefile :| nfig.status: creating config.h :| nfig.status: executing depfiles commands :| :| : :_______________________________________________ :Dillo-dev mailing list :Dillo-dev@lists.auriga.wearlab.de :http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

1 0

configure problems
by Jan Stary Feb. 26, 2003

Feb. 26, 2003

Hi, this is what I get with the current CVS (viz later). I know that I don't have libpng, libjpeg etc installed (by mistake, I was compiling on machine without them), but I mean the 'usability ... yes ; presence ... no' problem. Is this an autoconf bug, or is configure.in written badly ? The system is: Debian unstable kernel 2.4.19 (self compiled) autoconf 2.57 automake 1.6.3 gcc/cpp 3.2.2 The results follow. Jan cvs co dillo && cd dillo ./autogen.sh ./configure --prefix=$HOME checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes checking for gcc... gcc checking for C compiler default output... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking for style of include used by make... GNU checking dependency style of gcc... gcc3 checking for gcc option to accept ANSI C... none needed checking for ranlib... ranlib checking for gtk-config... /usr/bin/gtk-config checking for GTK - version >= 1.2.0... yes checking for jpeg_destroy_decompress in -ljpeg... no configure: WARNING: *** JPEG support will not be included *** checking for pthread_create in -lpthread... yes checking for zlibVersion in -lz... no checking for png_check_sig in -lpng... no checking for ANSI C header files... no checking fcntl.h usability... yes checking fcntl.h presence... no configure: WARNING: fcntl.h: accepted by the compiler, rejected by the preprocessor! configure: WARNING: fcntl.h: proceeding with the preprocessor's result configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to bug-autoconf(a)gnu.org. ## configure: WARNING: ## ------------------------------------ ## checking for fcntl.h... no checking unistd.h usability... yes checking unistd.h presence... no configure: WARNING: unistd.h: accepted by the compiler, rejected by the preprocessor! configure: WARNING: unistd.h: proceeding with the preprocessor's result configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to bug-autoconf(a)gnu.org. ## configure: WARNING: ## ------------------------------------ ## checking for unistd.h... no checking sys/uio.h usability... yes checking sys/uio.h presence... no configure: WARNING: sys/uio.h: accepted by the compiler, rejected by the preprocessor! configure: WARNING: sys/uio.h: proceeding with the preprocessor's result configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to bug-autoconf(a)gnu.org. ## configure: WARNING: ## ------------------------------------ ## checking for sys/uio.h... no checking for socket... yes configure: creating ./config.status config.status: creating Makefile config.status: creating doc/Makefile config.status: creating src/Makefile config.status: creating src/IO/Makefile config.status: creating config.h config.status: executing depfiles commands

3 2

Website improvement / CVS page
by Sebastian Leske Feb. 22, 2003

Feb. 22, 2003

Hi, as I could not find some webmaster contact address at the website at http://dillo.auriga.wearlab.de/ , I'm posting to this list. I like the idea of providing some information on how to checkout the CVS version of dillo, so people without CVS experience can try it out. However, the information about CVS given on http://dillo.auriga.wearlab.de/cvs.html is incomplete. The page give the command to to a checkout, but it neglects to mention that you first have to do a login with an empty password. I'd propose you change the page to read: Check out from our server at wearLab! Just run these two commands: cvs -z3 -d:pserver:anonymous@auriga.wearlab.de:/sfhome/cvs/dillo login cvs -z3 -d:pserver:anonymous@auriga.wearlab.de:/sfhome/cvs/dillo co dillo When prompted for a password, just press Return. A new directory will be created with the current CVS version of dillo. Greetings and keep up the good work on Dillo! S.Leske PS: Please CC me on replies, I'm not subscribed.

3 4