- Dillo-dev - lists.mailman3.com

patch: small mem leaks
by corvid＠lavabit.com Sept. 13, 2008

Sept. 13, 2008

Jeremy kindly provided the memory checking output that went with the valgrind logs from the other day. (I knew about the FullScreen one, but might as well comment it out until someone hooks it up.)

1 0

More Cache memory corruption
by onepoint＠starurchin.org Sept. 12, 2008

Sept. 12, 2008

Hi everyone! No, I'm not dead. I am sorry I haven't been able to spend much time on Dillo recently. I've been lurking and it's good to see Dillo getting lots of developer love. Now the bad news: this HTML almost invariably crashes Dillo: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="Content-Type" content="application/xhtml+xml; charset=iso-8859-1" /> </head> <body> </body> </html> The culprit is the <meta...> tag. Dillo always crashes in one of two ways: segmentation fault or glibc detecting memory corruption and aborting. In each case the backtrace from gdb is the same (verified by running Dillo 100 times (it only failed to crash twice)). The backtraces show that the Cache_* functions are freeing things they should not. Valgrind confirms this. I'm attaching backtraces and a valgrind log. I'm not sure how to debug this further. If anyone can suggest ways to trace this further I'll have a go. Looking forward to the dill2 release! This will be a great milestone. Jeremy Henty

3 3

Missing include directive for OpenBSD?
by Christian.Kellermann＠nefkom.net Sept. 12, 2008

Sept. 12, 2008

Dear List, I have not updated dillo2 for a long time. Now that I have done so I see that I have missed a lot! I needed the following tiny patch to allow compilation on my OpenBSD 4.3 System: Index: dw/style.cc =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/style.cc,v retrieving revision 1.10 diff -b -u -p -r1.10 style.cc --- dw/style.cc 5 Sep 2008 12:58:52 -0000 1.10 +++ dw/style.cc 7 Sep 2008 11:50:08 -0000 @@ -24,6 +24,7 @@ #include <string.h> #include <unistd.h> #include <ctype.h> +#include <sys/stdint.h> #include "core.hh" I am not sure whether this should have been caught by an autoconfig check. Can someone point me into the right direction so this can be changed to a proper patch? Thanks for your efforts and please keep up the good work! Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

3 6

patch: more widget coloring
by corvid＠lavabit.com Sept. 11, 2008

Sept. 11, 2008

My main forms testing page has bg #00ffff from when I was first experimenting with widget colors. Some time ago, fltk changed so that selected checkboxes and radio buttons use selection_color(). I had this set to the inverse of the background. Red. Not a good combination to say the least. Well, I finally got around to trying to fix it up a little. By the way, I was looking at that big page of inputs with differently-colored backgrounds that I made in February... At the time, I wrote that you guys had gotten the page down to 0:06 to load with clear_double_buffer(), immediate to load without it, and 0:09 to destroy the page. The good news is that it now takes the same amount of time with or without clear_double_buffer(), but the bad news is that it takes 0:12 to load and 0:48 to close.

3 7

[patch] remove asap parameter
by Johannes.Hofmann＠gmx.de Sept. 10, 2008

Sept. 10, 2008

Hi Jorge, any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now. Cheers, Johannes

2 6

assertion failed during wildly clicking on links
by akemnade＠tzi.de Sept. 10, 2008

Sept. 10, 2008

Hi, I have seen the following, when clikling multiple times very fast on a link: Nav_open_url: new url='http://www.dwd.de/sid_520SLCXTTJJbtdSgR7JTsLGvkNt6TkS9ssWxDtLpSvVZtPCcyjPG!…' Connecting to 141.38.3.62 DilloHtml(): content type: text/html; charset=UTF-8 *** [unknown] Assertion failed! *** anchor 'headline_color_324A92' not defined Aborted I tried www.dwd.de and then to click Wetter&Warnungen and the corresponding link. I have not looked into the source yet, but I think there is a ressource management problem. Greetings Andreas Kemnade

2 3

default font_factor
by Johannes.Hofmann＠gmx.de Sept. 8, 2008

Sept. 8, 2008

Hi, recently the the default font_factor was changed from 1.0 to 1.2. Is there a reason for this change? Cheers, Johannes

3 4

an example of page redraw problem when images load
by corvid＠lavabit.com Sept. 8, 2008

Sept. 8, 2008

With automatic image loading turned off, if I go to http://genode.org/documentation/developer-resources/walk_through , page down to the [IMG] below "The launchpad application starter", and click on it, the space to the right of the image still contains remnants of the text that used to be there.

3 7

Fixed FltkViewBase::drawRectangle()
by Johannes.Hofmann＠gmx.de Sept. 7, 2008

Sept. 7, 2008

Hi Jorge, regarding the last change in fltkviewbase.cc: --- a/dw/fltkviewbase.ccSat Sep 06 19:51:25 2008 +0200 +++ b/dw/fltkviewbase.ccSun Sep 07 10:51:04 2008 +0200 @@ -384,7 +384,9 @@ setcolor(((FltkColor*)color)->colors[shading]); int x1 = translateCanvasXToViewX (x); int y1 = translateCanvasYToViewY (y); - ::fltk::Rectangle rect (x1, y1, width, height); + int x2 = translateCanvasXToViewX (x + width); + int y2 = translateCanvasYToViewY (y + height); + ::fltk::Rectangle rect (x1, y1, x2 - x1, y2 - y1); if (filled) fillrect (rect); else To me it looks like this change is only necessary, if translateCanvasXToViewX() would do some sort of scaling. Was there a real problem, or did you change it just for consistency? Cheers, Johannes

2 1

[patch] fix compilation on OpenBSD
by Johannes.Hofmann＠gmx.de Sept. 7, 2008

Sept. 7, 2008

Hi, this fixes compilation on OpenBSD. Please verify on Linux. Cheers, Johannes

1 0