- Dillo-dev - lists.mailman3.com

Re: css prototype on freehg.org
by jcid＠dillo.org Nov. 7, 2008

Nov. 7, 2008

Hi, We've been arranging some CSS things behind the scenes with Johannes (he'll forward some past mails here soon). On Fri, Oct 31, 2008 at 05:00:54PM +0100, Johannes Hofmann wrote: > Hi Jorge, > > I just created a repository > http://freehg.org/u/jh33/dillo-css-prototype/ > > freehg.org is a free mercurial hosting service. > This gives access to the newest version of the css prototyping work. > Also you can check whether you like mercurial. > > To get a copy of the repository call > > hg clone http://freehg.org/u/jh33/dillo-css-prototype/ > > and start hacking. You can commit locally using > > hg commit OK, I'll make some patches with Hg once I grasp how this distributed model works. On the current code, basically it looks OK to me. i.e. we can continue working from that basis (having in mind that it's still in a flux state and that a validation is pending on whether the model is able to handle the current functionality in html.cc). My main comment is that the code needs more comments! :) Accurate comments are written when the code is developed (every detail is in the brain then). I've tried in the past to develop first and comment later, and found it only works OK for small code projects. As with CSS we don't have a main expert (yet), the team will be trying to understand and develop at the same time, and thus comments are very necessary. Even something like "I don't know how to implement this part" helps! I'd suggest to use the same format that's in css.cc. e.g. /** \todo dummy only */ with a view to integrate it smoothly with doxygen docs. in the future. Some specific examples: 1.- What do these functions do? - style0() - startElement() - endElement() 2.- On memory handling, there are some places with: // html->styleEngine->style () = // Style::create (HT2LT(html), &style_attrs); // old_style->unref (); or // (html->styleEngine->style ())->unref (); Why are they commented and left in the code? Is proper memory handling pending, is there a design decision to be made before getting rid of them? 3.- With regard, for instance, to font_factor and visited link color. Do they belong to buildUserAgentStyle() or buildUserStyle() or elsewhere? 4.- strdup/free should be dStrdup/dFree (Please let me use this extremely simple case to make my first Hg patch :-) I know this was just a prototype for the CSS implementation idea, but considering that we don't have any better, and that we agreed on it, now it has attained the status of "official CSS merge effort". ;-) From now comments are paramount, and we may eventually get to a dw-like quality docs in the future. Bottom line: Great, let's get started! -- Cheers Jorge.-

2 1

[jcid@dillo.org: Re: css prototype on freehg.org]
by Johannes.Hofmann＠gmx.de Nov. 7, 2008

Nov. 7, 2008

----- Forwarded message from Jorge Arellano Cid <jcid(a)dillo.org> ----- Date: Thu, 6 Nov 2008 14:05:33 -0300 From: Jorge Arellano Cid <jcid(a)dillo.org> To: Johannes Hofmann <Johannes.Hofmann(a)gmx.de> Subject: Re: css prototype on freehg.org On Thu, Nov 06, 2008 at 05:31:34PM +0100, Johannes Hofmann wrote: > > > > I'm currently reviewing the CSS work you uploaded! > > > > On Fri, Oct 31, 2008 at 05:00:54PM +0100, Johannes Hofmann wrote: > > > Hi Jorge, > > > > > > I just created a repository > > > http://freehg.org/u/jh33/dillo-css-prototype/ > > > > > > freehg.org is a free mercurial hosting service. > > > This gives access to the newest version of the css prototyping work. > > > Also you can check whether you like mercurial. > > > > Hmm, that's another topic that needs a resolution: > > to git or to hg? > > Featurewise there is hardly a difference. I prefer mercurial because > of it's nice and simple ui. > Just recently there was the same discussion for DragonFlyBSD: > http://leaf.dragonflybsd.org/mailarchive/kernel/2008-10/msg00144.html Yes, I also like simple UIs. > > [...] > > Do you have a recommended quick-start guide? > > http://www.selenic.com/mercurial/wiki/index.cgi/QuickStart > > and a bit longer: > > http://www.selenic.com/mercurial/wiki/index.cgi/Tutorial > > and a lot longer: > > http://hgbook.red-bean.com/hgbook.html Thanks. > > > > > I didn't send this to the list, because I want to be sure that you > > > are ok with this step. > > > > Which one, the mercurial or the CSS code? > > Both. Publishing CSS prototype in a separate repository. For now the Hg repository is OK. I'm yet to grasp the distributed workflow model. It seems our old CVS needs an update. > > > > As far as CSS, after the first review it looks OK, and > > seems the way to go. I'm going more in depth now to try to > > understand how it works and fits in the plan. > > Great. Please keep in mind that the current work tries to find a > proper interface between CSS stuff and the code in html.cc. > It needs to be verified that the concept covers all the edge cases. > One is probabely the table code that stores a separate > table_cell_style on the stack. > Is this to hold cell properties that were set in the <table> or <tr> > tags? I'll check. Most probably that's the case though. e.g. bgcolor. OK, once I've grasped the concept, I'll tell you what I find. > > > Also the CSS prototype contains some code from dillo-0.8.0-css-3 > > > that doesn't have license headers. Can you contact Sebastian to ask > > > if it is ok to use stuff from his prototype? > > > > I have an email from him (long time ago) where he advocates > > on making the CSS prototype code more visible from the website, > > to attract developers. He also said he was working on floating objects! > > > > I'll try to contact him and see what's up with him... > > > > As from his email, and conversations we had long ago, > > I believe it's quite safe to use the code. > > Great. It seems to contain a pretty complete CSS parser. > > Cheers, > Johannes > > PS: We should probabely take this discussion to the list. It's a bit > quiet there. What do You think? Sure, feel free to forward the thread (or relevant parts). -- Cheers Jorge.- ----- End forwarded message -----

1 0

Dillo too fast?
by thomas-forum＠orgis.org Nov. 7, 2008

Nov. 7, 2008

Did anyone else encounter this from google? Not sure if this is something specific in dillo's network behaviour... > We're sorry... > ... but your query looks similar to automated requests from a computer virus or spyware application. To protect our users, > we can't process your request right now. It's at least the second time I got this now, after issuing a search, seeing that there was a typo, resissuing. It is not that rare that this happens, but it is rare that google slaps me in the face for it ... and I _think_ it has been dillo before, too. But not sure. Anyhow, does someone know what is behind that "virus check"? > If you're continually receiving this error, you may be able to resolve the problem by deleting your Google cookie and > revisiting Google. For browser-specific instructions, please consult your browser's online support center. Hm... I don't have any cookie from 'em. Perhaps that is the key? Alrighty then, Thomas.

3 2

Another mention of Dillo-2
by onepoint＠starurchin.org Nov. 6, 2008

Nov. 6, 2008

"Dillo 2.0 is fast, but limited" http://www.linux.com/feature/151983 Summary: "It's *fast*, even faster than Dillo-1, but too limited to be of use to much people.". It singles out lack of JavaScript, pointing out that most business sites need it (although I'd imagine most business sites would need full SSL support too). Jeremy Henty

1 0

Repost: D_SUN_LEN cleanup (and a typo fix)
by onepoint＠starurchin.org Nov. 5, 2008

Nov. 5, 2008

This is a repost of three tidy-up patches that have been left hanging without resolution. Please comment. 1. Remove unused D_SUN_LEN declarations from DPIs. (The DPIs connect to their sockets with accept() which doesn't use D_SUN_LEN.) 2. Use D_SUN_LEN whenever calling connect() on a struct sockaddr_un. (Some of the calls already did this, this patch makes all of them do so.) 3. Update a GPL reference in a comment from version 2 to version 3. Regards, Jeremy Henty

2 1

Re: Interested in joining dillo project
by jcid＠dillo.org Nov. 5, 2008

Nov. 5, 2008

On Fri, Oct 31, 2008 at 11:43:35PM +0100, PHELIZOT Yvan wrote: > Hi, > > That me again. And i have a lot of questions: > About management: > * Does we have a functionnalities/features list? We had one inside the funding initiative in the past. It was purposedly removed from the web site because it was not updated (obsolete), and because the funding effort yielded no results. You can still find some info here: http://www.dillo.org/funding/funding.html (go to "Technical Overview"). > For example, i have > seen that png and jpeg are not supported, so does it included in the > file...? That's false. Where did you find that misinformation? > * Is there a task list? to know what to do and with which priority > > Dev : > * How many developpers, testers, ... work on the project? Please check the website. "Current Plans", "Authors", etc. > Software: > * Does the software has a "quirk" mode? Something akin, give read to dillorc. w3c_plus_heuristics=YES -- Cheers Jorge.-

1 0

[patch]: fix the download GUI resize bug
by onepoint＠starurchin.org Oct. 30, 2008

Oct. 30, 2008

There's a bug in the downloads GUI that stops the download items resizing when the window does. The resizable of the window should be the scrollgroup, not the packedgroup. Fixing this means we don't need to explicitly resize the scrollgroup after removing an item (because the window has already resized it) so I took that out. Patch attached. Regards, Jeremy Henty

3 9

reduce warnings with gcc-4.3 [PATCH]
by thomas-forum＠orgis.org Oct. 30, 2008

Oct. 30, 2008

Skipped content of type multipart/mixed

4 5

css
by Johannes.Hofmann＠gmx.de Oct. 30, 2008

Oct. 30, 2008

Hi, here comes my proposal to get css support started. Note that I'm new to this stuff so I will probabely simplify things a lot and miss many issues that will have to be addressed later on. * Separate out the style handling from html.cc in a new class StyleEngine (better name welcome). This class will be fed the html tree via a SAX like interface as the document is parsed and will hand out the current Style object. * Initially StyleEngine will be implemented to just mimic the current behaviour of html.cc. So after this step everything should work as currently. * Then we can design the data structures to hold parsed css data and make StyleEngine use these structures which will be statically filled initially. Again dillo should work as it does now. * Next we can implement a css parser that is able to fill the data structures from the last step. Now we should already be able to set a fixed user style sheet. * Hooking up the css parser to automatically load css information as referenced in html pages would be next. * In parallel to all this we would need to make floating objects work in dw/textblock.cc. This approach has some issues. In contrast to http://www.dillo.org/CSS.html it would only be possible to apply style information that is available when starting parsing of a document. However we could start rendering with what style information is available and reload once all css files have been loaded. Currently dillo parses attributes on demand. So we don't have a complete list of attributes and their values. As StyleEngine might access any attribute, we might need to change this. Comments or more advanced plans would be more than welcome! Cheers, Johannes

3 6

Q: D_SUN_LEN , dpi programs and socket programming
by onepoint＠starurchin.org Oct. 30, 2008

Oct. 30, 2008

The bookmarks and cookies dpis define D_SUN_LEN but don't use it. D_SUN_LEN is used elsewhere by dillo (when calling connect()) and dpid (when calling bind()), but all the dpi programs call accept() with sizeof(struct sockaddr_un) instead of D_SUN_LEN(address). Shouldn't we delete the definition of D_SUN_LEN from the dpi programs since they don't use it? Or maybe they should use it? Which? Regards, Jeremy Henty

2 4