- Dillo-dev - lists.mailman3.com

<ol>'s leak the labels of their items
by onepoint＠starurchin.org Jan. 29, 2009

Jan. 29, 2009

Valgrind reports that <ol>s leak the labels of their items: each of the first 9 <li>s leaks 3 bytes, then they leak 4 bytes per <li> etc. The leaked memory is created by the line list_item->initWithText (dStrdup(buf), wordStyle); in Html_tag_open_li (in src/html.cc). The dStrdup()ed memory is never freed. I think that the problem is that the TextBlock destructor only deletes the content of a word if the content type is WIDGET or ANCHOR, whereas it should also handle the case when the content type is TEXT. Perhaps initWithText() should copy the string argument itself with new[] so that ~TextBlock could safely delete[] it? The only two references to initWithText() are in html.cc and one of the widget tests, so this would be an easy change. Regards, Jeremy Henty

3 20

dw::Image objects leak their mapKey
by onepoint＠starurchin.org Jan. 29, 2009

Jan. 29, 2009

This shows up under valgrind as a leak when the HTML includes an <img usemap="...">. Patch attached. Regards, Jeremy Henty

2 3

Tools button committed
by jcid＠dillo.org Jan. 27, 2009

Jan. 27, 2009

Hi, The tools button changeset was just committed. Please notice the options are global. It's quite useful as is and making per bw options seems not worth. Go check! :-) -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

2 2

Re: new font preferences
by Johannes.Hofmann＠gmx.de Jan. 26, 2009

Jan. 26, 2009

On Mon, Jan 26, 2009 at 04:58:55PM -0300, Jorge Arellano Cid wrote: > On Mon, Jan 26, 2009 at 07:14:08PM +0100, Hofmann Johannes wrote: > > Hi Jorge, > > > > do you have an opinion on the (incompatible) changes to the font > > preferences as proposed in > > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-January/005746.html > > > > I'd like to commit this if you agree. > > Oh yes, feel free to commit. Committed. > Just let dillo-dev know how to upgrade our custom dillorc! :-) > > At this point you're the most knowledgeable in font handling and > CSS, thus some basic explanation of settings/usage would be welcomed too. >From the checking comment: CSS 2.1 uses the following predefined font names: 'serif', 'sans-serif', 'cursive', 'fantasy', 'monospace'. Add preferences so that the user can set real font names for these. Basically the new "font_sans_serif" option is what "vw_fontame" used to be and "font_monospace" is equivalent to "fw_fontname". The other two options are new. http://www.w3.org/TR/CSS21/fonts.html#generic-font-families has some more information including font examples. Cheers, Johannes

1 0

dillo CSS and charset
by furaisanjin＠gmail.com Jan. 26, 2009

Jan. 26, 2009

Hi all. I created new subject thread since the original one becomes quite long and. I found one difference between dillo-2.0 and dillo-css. there was a_Decode_charset_init calling at Cache_parse_header in cache.c when HTTP server Content-Type was detected but there isn't this in dillo-css. Because if HTTP server Content-Type is same as META content-type, there isn't any chance to call a_Decode_charset_init. This is one reason why the page is drawn properly. I still don't figure out another timing issue yet. Regards, furaisanjin

4 31

Character entity parsing regression.
by jcid＠dillo.org Jan. 26, 2009

Jan. 26, 2009

Hi, There's a regression with the attached page. Squared boxes appear where nothing should be. I haven't dug since when. Can somebody please give it a look while I work on the tools button? TIA. -- Cheers Jorge.-

2 2

CSS parser leak
by onepoint＠starurchin.org Jan. 26, 2009

Jan. 26, 2009

Valgrind log attached. Jeremy Henty

2 5

switch to DILLO_HTML_PARSE_MODE_PRE depending on style
by Johannes.Hofmann＠gmx.de Jan. 26, 2009

Jan. 26, 2009

Hi, I'm experimenting with attached patch to make switching to DILLO_HTML_PARSE_MODE_PRE from CSS possible. Some online source browsers like cgit (http://hjemli.net/git/cgit/) use this to display sources or diffs. Please comment. Cheers, Johannes

2 2

inheriting background color
by corvid＠lavabit.com Jan. 24, 2009

Jan. 24, 2009

Is the idea that we should stick in inheritBackgroundColor whenever we encounter cases like the following? (I see the "get rid of this somehow" comment.) <head> <title></title> <style type="text/css"> body {background: #000000; color: #00ff00} </style> </head> <body> <SPAN STYLE='background:#fff6aa;'>link background dark( <SMALL><A HREF="/">link</A></SMALL> )</SPAN> <p> <SPAN STYLE='background:#fff6aa;'>link background light( <A HREF="/">link</A>) </SPAN> </body>

2 1

Valgrind errors: big improvement!
by onepoint＠starurchin.org Jan. 24, 2009

Jan. 24, 2009

The very latest dillo is vastly more valgrind-clean than before: I got no errors from my latest browsing session! I'll keep monitoring it and look at the leak reports too. Regards, Jeremy Henty

2 1