- Dillo-dev - lists.mailman3.com

allow_white_bg and contrast_visited_color
by Johannes.Hofmann＠gmx.de March 5, 2009

March 5, 2009

Hi, as we seem to have agreed on using CSS for style customization intead of dillorc settings, I'm trying to get rid of these: link_color: visited_color: text_color: bg_color: force_my_colors: The same thing can more or less be expressed with a custom user stylesheet, so I want to remove them. The problem is non-HTML pages (plain). I would propose to simulate <body><pre> in this case and use the corresponding style. allow_white_bg: This can't be expressed with CSS. We could detect a white background in StyleEngine (like we detect font sizes smaller than font_min_size), but what color should we use instead in this case (note that it must be different enough from the text color)? contrast_visited_color: This one is hard. Consider we want to render a visited link. >From StyleEngine we get a background and a text color, but we don't know what the text color would have been if the link would not be visited. So we can't enforce a color that is different from that. Generally (and even more with CSS), background- and text-colors can change arbitrarily within a page. So there is not a background and a text color per page. standard_widget_colors: Not sure about this one. On the one hand I think that CSS support broke this. On the other hand CSS allows the page author to directly set colors of form widgets. corvid, can you please have a look? Cheers, Johannes

2 2

clipping image inputs
by corvid＠lavabit.com March 5, 2009

March 5, 2009

With <input type="image" name="name1" src="whatever" WIDTH="80" HEIGHT="14" alt="name1name1name1name1"> <input type="image" name="name2" src="whatever" width="9" height="14" alt="name2name2name2name2"> the long alt text doesn't clip. It looks like the embed knows that it's 80 pixels wide (at least the child widget area stuff in Textblock::drawLine seemed to have the right idea), but the image thinks it's 188 (in my case). PS I have "white-space: nowrap" pretty much working, but I don't know what I'm doing in Textblock very well, so it's definitely not going into this release.

2 5

improving CSS performance
by Johannes.Hofmann＠gmx.de March 5, 2009

March 5, 2009

Hi, I just commited http://hg.dillo.org/dillo?cs=11c6f887d649 which improves CSS performance by avoiding unnecessary style computations. Please give it a thorough testing. Cheers, Johannes

1 0

Re: css parsing numbers
by Johannes.Hofmann＠gmx.de March 3, 2009

March 3, 2009

On Fri, Feb 27, 2009 at 03:29:55PM +0000, corvid wrote: > > On Fri, Feb 27, 2009 at 02:26:03PM +0000, corvid wrote: > > > > Committed. I hoped to be able to make that code a bit shorter, but > > > > could not find a reasonable solution... > > > > > > Yeah. In any case, it's just going to get worse/rearranged again > > > for negative numbers... > > > > Exactly. I started my simplification attempts, added negative number > > support - and blew it all up :) > > I'm really considering a flex based scanner now. What do you think? > > I only touched flex very briefly for a class at school long ago, > and I don't remember anything from the experience, but the > idea interests me since it has to be less trouble than trying > to do it by hand... > I think we just need to try it. Attached is a minimal standalone example based on the "Lexical scanner" from the appendix of the CSS 2.1 spec. To compile it use: flex cssscanner.l gcc -o cssscanner lex.yy.c -lfl It reads from stdin. Cheers, Johannes

2 7

minor leak with CustShrinkTabPager
by Johannes.Hofmann＠gmx.de March 2, 2009

March 2, 2009

Hi, thanks to Jeremy's valgrind log at http://starurchin.org/dillo/valgrind.html I noticed a minor leak with CustShrinkTabPager(). The TabGroup::pager() method internally clones the passed pager, so it must be deleted afterwards, e.g. like this: diff -r 9b0b8ae9b06a src/uicmd.cc --- a/src/uicmd.ccSun Mar 01 12:34:00 2009 +0100 +++ b/src/uicmd.ccMon Mar 02 08:57:02 2009 +0100 @@ -225,7 +225,9 @@ public: CustTabGroup (int x, int y, int ww, int wh, const char *lbl=0) : TabGroup(x,y,ww,wh,lbl) { - this->pager(new CustShrinkTabPager()); + CustShrinkTabPager *cp = new CustShrinkTabPager(); + this->pager(cp); + delete cp; toolTip = new Tooltip; tooltipEnabled = false; buttonPushed = false; Alternatively we could keep one copy around in a static member. Cheers, Johannes

2 1

[bgreer101@earthlink.net: Dillo2 working great with Crux-PPC!]
by jcid＠dillo.org March 2, 2009

March 2, 2009

-- Cheers Jorge.-

1 0

patches, bundles, etc
by dillo-dev＠toykeeper.net March 2, 2009

March 2, 2009

BTW, what's the policy on submitting sizable changes with multiple revisions, such as the configurable keybindings? Is it okay to send a changeset bundle, or do the changes need to be flattened into a single patch? It probably doesn't matter for small changes, but it might be nice to include the history for large changes. -- Scott

7 8

[patch]: remove the workaround for FLTK bug #2084.
by onepoint＠starurchin.org March 2, 2009

March 2, 2009

The dillo source includes a workaround for FLTK bug #2084[1] which was fixed in revision 6507. We currently recommend[2] revision 6525 or later. There's no need to include this workaround any more, so let's remove it. Regards, Jeremy Henty [1] http://www.fltk.org/str.php?L2084 [2] http://www.dillo.org/source.html

2 1

[patch]: fix a memory leak in a_Klist_free()
by onepoint＠starurchin.org March 2, 2009

March 2, 2009

Subject line speaks for itself! Patch attached. Jeremy Henty

2 1

Re: css parsing numbers
by corvid＠lavabit.com Feb. 27, 2009

Feb. 27, 2009

Johannes wrote: > On Wed, Feb 11, 2009 at 06:03:13PM +0000, corvid wrote: > > I tried > > font-size: .6in > > (we still love archaic measurements here) > > and it didn't work. > > > > The grammar says > > num [0-9]+|[0-9]*"."[0-9]+ > > > > Oh yes. That's Css_next_token() which is not recognizing ".6" as a > float... Attached. I'm too much of a css newbie to promise great testing, but I did cobble together the following and the right things seemed to happen: <html> <head> <style type="text/css"> hr.aaaaa {width: 1.5in} bbbbb {width: 2 in} </style> </head> <body> <hr style="width: 0.3in"> <hr style="width: .6in"> <hr style="width: 1 in"> <hr class="aaaaa"> <hr class="bbbbb"> </body </html>

2 4