- Dillo-dev - lists.mailman3.com

does RGBA work for you?
by corvid＠lavabit.com May 9, 2008

May 9, 2008

(I'd seen that there was talk on the fltk forums recently about RGBA and images ending up with the wrong dimensions, but that's not my problem.) If you uncomment RGBA in test/dw_images_scaled.cc, does dragging the window around cause part of it to turn pinkish? (I'll attach a diff, even though it's not exactly difficult.) I had started by hacking up the dillo side to send RGBA, and it worked fairly well in general for images where every pixel is either completely opaque or completely transparent. Gradients didn't seem to work too well, and often these pink/red regions were showing up. So far it seems as if the value of green relative to the value of alpha is what can make it particularly lose its mind, but that's probably wrong. You know how first impressions are... I followed it down to fltk/src/x11/Image.cxx, by which point it had been transformed to ARGB which looked about right to me. Then there's lots of xrender and transforms and things I don't know anything about. I tried some setcolor and fillrect in FltkImgbuf::draw(), but it didn't seem to matter, so I guess that's not my problem... If the question is "Why bother?", dillo2/src/png.c currently just mixes in whatever the background color is the first time we see an image on the page.

2 2

Render to image
by kfa＠gmx.net May 8, 2008

May 8, 2008

Hi @, First of all, thanks guys for doing this great project :) Wondered if I could ask for a few pointers before digging my way through the source to see if I could do the following: I'm thinking of using Dillo as a rendering engine inside of another project. All I need is having it render offscreen to an image object of some kind, producing a click map for the links would be an added advantage. I know how to do this with Mozilla but that is such a heavyweight beast. I don't need any network code as well, all input material (html and media files) woud be provided by the enclosing application. Does anyone have a hint on where to start looking, which files / classes / libs out of the dillo package I would need for this? Thanks, Klaus

2 2

[patch] fix redraw issue on resize
by Johannes.Hofmann＠gmx.de May 7, 2008

May 7, 2008

Hi, attached patch fixes an obvious problem with the redraw optimization that results in artifacts when resizing the window. There may be other issues left. Cheers, Johannes

2 1

CVS glitch
by onepoint＠starurchin.org May 7, 2008

May 7, 2008

Just so you know, for some reason it took a long time for the latest patches to show up in CVS. Normally I update more or less as soon as I see Jorge's "committed" message and the patches appear, but this time I saw his acknowledgement late yesterday afternoon and the patches still weren't there by midnight. They turned up this morning so it was not a permanent failure. Did this affect anyone else? I've never seen it before! Jeremy Henty

2 2

[patch]: Refactor {FltkListResource,FltkOptionMenuResource}::sizeRequest()
by onepoint＠starurchin.org May 6, 2008

May 6, 2008

A simple refactoring: FltkListResource and FltkOptionMenuResource use the same code to determine the maximum string width. Jeremy Henty

2 2

[bugfix]: FltkSelectionResource leaks memory
by onepoint＠starurchin.org May 6, 2008

May 6, 2008

corvid pointed this out to me. Patch attached. Jeremy Henty

2 1

Test
by sgeerken＠dillo.org May 6, 2008

May 6, 2008

Hi, this is just a test message. Sebastian

1 0

ListResources: version 3
by onepoint＠starurchin.org May 6, 2008

May 6, 2008

I am attaching two patches that get ListResource selection working properly, ie. you can click items as you wish and FltkListResource::isSelected() will now return the correct value. The first patch is my previous selection patch, unchanged. The second is a small fix that I proposed in the lout::misc::StringBuffer fix thread: it makes FltkListResource::addItem call Widget::set_selected() on fltk::Item widgets, and the call to Menu::set_item() becomes conditional on a virtual boolean hook that defaults to false, but is redefined to true in FltkOptionMenuResource() . The second patch looks bigger than it really is: most of it is just reindenting a block of code that moved inside an "if" statement. (And diff doesn't help by insisting on choosing an unnecessarily complicated set of changes.) It's not a pretty hack, but it's simple and I am wary of making deeper changes until I understand the code better. Please comment, Jeremy Henty

4 5

Q: should we select option groups
by onepoint＠starurchin.org May 6, 2008

May 6, 2008

FLTK allows both Choice and MultiBrowsers to select group items as well as normal leaf items. The Dillo Selection widget currently ignores selected group items, which could be confusing if a user selects a group and expects the application to do something about it. On the other hand the HTML 4 spec[1] reads as though only options and not option groups can be selected, though it does not say so explicitly. What should Dillo do about this? [1] http://www.htmlhelp.com/reference/html40/forms/select.html

1 0

patch: dialog.cc window deletion
by corvid＠lavabit.com May 5, 2008

May 5, 2008

Using the crude tool of top(1), I learned that viewing the source of a 500K file meant losing 500K down the drain. - If I give the text to the TextDisplay's initial buffer, it knows that it owns it. - Window::destroy() doesn't delete. The header comment in fltk/src/Window.cxx says it's some sort of 'hide' function: "Hides the window and also deletes all window system information about the window, and thus returns it back to the state it was in before the first show(). It is harmless to call this if the window is already destroyed." - And while I was in there, I threw in some callback(window_close_cb, ...)s for closing windows using the window mgr instead of a button.

2 1