- Dillo-dev - lists.mailman3.com

Missing include directive for OpenBSD?
by Christian.Kellermann＠nefkom.net Sept. 12, 2008

Sept. 12, 2008

Dear List, I have not updated dillo2 for a long time. Now that I have done so I see that I have missed a lot! I needed the following tiny patch to allow compilation on my OpenBSD 4.3 System: Index: dw/style.cc =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/style.cc,v retrieving revision 1.10 diff -b -u -p -r1.10 style.cc --- dw/style.cc 5 Sep 2008 12:58:52 -0000 1.10 +++ dw/style.cc 7 Sep 2008 11:50:08 -0000 @@ -24,6 +24,7 @@ #include <string.h> #include <unistd.h> #include <ctype.h> +#include <sys/stdint.h> #include "core.hh" I am not sure whether this should have been caught by an autoconfig check. Can someone point me into the right direction so this can be changed to a proper patch? Thanks for your efforts and please keep up the good work! Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

3 6

patch: more widget coloring
by corvid＠lavabit.com Sept. 11, 2008

Sept. 11, 2008

My main forms testing page has bg #00ffff from when I was first experimenting with widget colors. Some time ago, fltk changed so that selected checkboxes and radio buttons use selection_color(). I had this set to the inverse of the background. Red. Not a good combination to say the least. Well, I finally got around to trying to fix it up a little. By the way, I was looking at that big page of inputs with differently-colored backgrounds that I made in February... At the time, I wrote that you guys had gotten the page down to 0:06 to load with clear_double_buffer(), immediate to load without it, and 0:09 to destroy the page. The good news is that it now takes the same amount of time with or without clear_double_buffer(), but the bad news is that it takes 0:12 to load and 0:48 to close.

3 7

[patch] remove asap parameter
by Johannes.Hofmann＠gmx.de Sept. 10, 2008

Sept. 10, 2008

Hi Jorge, any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now. Cheers, Johannes

2 6

assertion failed during wildly clicking on links
by akemnade＠tzi.de Sept. 10, 2008

Sept. 10, 2008

Hi, I have seen the following, when clikling multiple times very fast on a link: Nav_open_url: new url='http://www.dwd.de/sid_520SLCXTTJJbtdSgR7JTsLGvkNt6TkS9ssWxDtLpSvVZtPCcyjPG!…' Connecting to 141.38.3.62 DilloHtml(): content type: text/html; charset=UTF-8 *** [unknown] Assertion failed! *** anchor 'headline_color_324A92' not defined Aborted I tried www.dwd.de and then to click Wetter&Warnungen and the corresponding link. I have not looked into the source yet, but I think there is a ressource management problem. Greetings Andreas Kemnade

2 3

default font_factor
by Johannes.Hofmann＠gmx.de Sept. 8, 2008

Sept. 8, 2008

Hi, recently the the default font_factor was changed from 1.0 to 1.2. Is there a reason for this change? Cheers, Johannes

3 4

an example of page redraw problem when images load
by corvid＠lavabit.com Sept. 8, 2008

Sept. 8, 2008

With automatic image loading turned off, if I go to http://genode.org/documentation/developer-resources/walk_through , page down to the [IMG] below "The launchpad application starter", and click on it, the space to the right of the image still contains remnants of the text that used to be there.

3 7

Fixed FltkViewBase::drawRectangle()
by Johannes.Hofmann＠gmx.de Sept. 7, 2008

Sept. 7, 2008

Hi Jorge, regarding the last change in fltkviewbase.cc: --- a/dw/fltkviewbase.ccSat Sep 06 19:51:25 2008 +0200 +++ b/dw/fltkviewbase.ccSun Sep 07 10:51:04 2008 +0200 @@ -384,7 +384,9 @@ setcolor(((FltkColor*)color)->colors[shading]); int x1 = translateCanvasXToViewX (x); int y1 = translateCanvasYToViewY (y); - ::fltk::Rectangle rect (x1, y1, width, height); + int x2 = translateCanvasXToViewX (x + width); + int y2 = translateCanvasYToViewY (y + height); + ::fltk::Rectangle rect (x1, y1, x2 - x1, y2 - y1); if (filled) fillrect (rect); else To me it looks like this change is only necessary, if translateCanvasXToViewX() would do some sort of scaling. Was there a real problem, or did you change it just for consistency? Cheers, Johannes

2 1

[patch] fix compilation on OpenBSD
by Johannes.Hofmann＠gmx.de Sept. 7, 2008

Sept. 7, 2008

Hi, this fixes compilation on OpenBSD. Please verify on Linux. Cheers, Johannes

1 0

8.68% of my time in assert()?
by corvid＠lavabit.com Sept. 6, 2008

Sept. 6, 2008

Recompiled with -O2 -pg. Moved back and forth between two pages (10k and 130k) repeatedly. gprof said: % cumulative self self total time seconds seconds calls ms/call ms/call name 27.43 0.79 0.79 517177 0.00 0.00 dw::Textblock::wordWrap(int) 10.42 1.09 0.30 45 6.67 51.95 Html_write_raw(DilloHtml*, char*, int, int) 8.68 1.34 0.25 5845490 0.00 0.00 lout::misc::assert(bool, char const*, ...) 5.38 1.50 0.16 183777 0.00 0.00 dw::Textblock::addWord(int, int, int, dw::core::style::Style*) 3.47 1.60 0.10 158682 0.00 0.01 dw::Textblock::addText(char const*, dw::core::style::Style*) 2.78 1.68 0.08 151303 0.00 0.00 Html_process_space(DilloHtml*, char const*, int) 2.78 1.76 0.08 143 0.56 0.70 dw::Textblock::sizeAllocateImpl(dw::core::Allocation*) 2.78 1.84 0.08 21 3.81 4.91 dw::Textblock::~Textblock() 2.43 1.91 0.07 145864 0.00 0.00 dw::Textblock::addSpace(dw::core::style::Style*) 2.43 1.98 0.07 38885 0.00 0.00 Html_tag_index(char const*) 2.43 2.05 0.07 utf8towc 1.74 2.10 0.05 517177 0.00 0.00 dw::Textblock::getWordExtremes(dw::Textblock::Word*, dw::core::Extremes*) 1.74 2.15 0.05 158682 0.00 0.00 dw::Textblock::calcTextSize(char const*, dw::core::style::Style*, dw::core::Requisition*) 1.74 2.20 0.05 75140 0.00 0.00 dw::Textblock::addLine(int, bool) 1.74 2.25 0.05 utf8decode 1.74 2.30 0.05 DilloHtml::HtmlLinkReceiver::~HtmlLinkReceiver() 1.56 2.34 0.05 13231 0.00 0.01 Html_get_attr2(DilloHtml*, char const*, int, char const*, int) 1.22 2.38 0.04 13351 0.00 0.00 dw::core::style::StyleAttrs::hashValue() 1.04 2.41 0.03 31375 0.00 0.00 Html_push_tag(DilloHtml*, int) 1.04 2.44 0.03 3861 0.01 0.02 a_Html_set_top_font(DilloHtml*, char const*, int, int, int) 1.04 2.47 0.03 193 0.16 0.23 dw::Textblock::rewrap() 0.69 2.49 0.02 73744 0.00 0.00 dStr_append_c 0.69 2.51 0.02 3020 0.01 0.02 a_Url_new ..(total 2.88 sec.) Naturally I thought that's a lot of time to spend in assert(). I wonder what would happen if I turned off BOUND_CHECKING in SimpleVector in lout/misc.hh. This gave % cumulative self self total time seconds seconds calls ms/call ms/call name 20.75 0.50 0.50 572066 0.00 0.00 dw::Textblock::wordWrap(int) 8.71 0.71 0.21 50 4.20 36.14 Html_write_raw(DilloHtml*, char*, int, int) 6.02 0.86 0.15 83051 0.00 0.00 dw::Textblock::addLine(int, bool) 5.81 1.00 0.14 202074 0.00 0.00 dw::Textblock::addWord(int, int, int, dw::core::style::Style*) 5.60 1.13 0.14 174493 0.00 0.01 dw::Textblock::addText(char const*, dw::core::style::Style*) 5.39 1.26 0.13 157 0.83 0.83 dw::Textblock::sizeAllocateImpl(dw::core::Allocation*) 4.56 1.37 0.11 utf8towc 3.53 1.46 0.09 42701 0.00 0.00 Html_tag_index(char const*) 2.90 1.53 0.07 14483 0.00 0.01 Html_get_attr2(DilloHtml*, char const*, int, char const*, int) 2.90 1.60 0.07 fltk::setfont(fltk::Font*, float) 2.49 1.66 0.06 174493 0.00 0.00 dw::Textblock::calcTextSize(char const*, dw::core::style::Style*, dw::core ::Requisition*) 2.49 1.72 0.06 34442 0.00 0.00 Html_tag_cleanup_at_close(DilloHtml*, int) 2.07 1.77 0.05 174517 0.00 0.00 dw::fltk::FltkPlatform::textWidth(dw::core::style::Font*, char const*, int ) 2.07 1.82 0.05 23 2.17 3.54 dw::Textblock::~Textblock() 2.07 1.87 0.05 fltk::getwidth(char const*, int) 1.66 1.91 0.04 166375 0.00 0.00 Html_process_space(DilloHtml*, char const*, int) 1.66 1.95 0.04 9528 0.00 0.01 Url_object_new 1.24 1.98 0.03 14615 0.00 0.00 dw::core::style::StyleAttrs::hashValue() 1.24 2.01 0.03 7820 0.00 0.00 dw::core::style::StyleAttrs::equals(lout::object::Object*) 1.24 2.04 0.03 212 0.14 0.14 dw::Textblock::rewrap() 0.83 2.06 0.02 160393 0.00 0.00 dw::Textblock::addSpace(dw::core::style::Style*) 0.83 2.08 0.02 11374 0.00 0.00 dw::core::style::drawBackground(dw::core::View*, dw::core::Rectangle*, int , int, int, int, dw::core::style::Style*, bool) 0.83 2.10 0.02 9521 0.00 0.00 a_Url_free .. [snip] .. 0.00 2.41 0.00 44 0.00 0.00 lout::misc::assert(bool, char const*, ...) ..(total 2.41 sec.) I don't know whether -pg affects the ability to inline... and bounds checking is important... but it makes one think that maybe SimpleVector's get() and getRef() might be made cheaper, or we might at least avoid gratuitously making repeated get()s, since it turns out that they are not free. (_and_ I could have run many more trials, but the idea that assert() was even capable of reaching that high was alarming)

3 5

a little experiment in showing form encoding as a tooltip
by corvid＠lavabit.com Sept. 5, 2008

Sept. 5, 2008

Currently, there's a MSG that tells you what encoding a form was submitted as -- once it's submitting it. Obviously that's of limited usefulness when you want to know beforehand what will happen to any Japanese that you might type in, but on other hand, so many pages have forms that MSGs ahead of time would be annoying, besides the fact that a page may have multiple forms with different accept-charset attrs... Add to that the fact that one has to learn the hard way that you should only paste utf-8 into dillo2 and not, say, windows-1257. (and latin-1 works because fltk assumes it's latin-1 and does the conversion) So my quick little experiment: text/password/textarea form controls display a tooltip that reads enter: UTF-8 when UTF-8 will be submitted, and enter: UTF-8 send as: [some other encoding] otherwise. And it would clear things up for every person who tried to use google.com and wondered why non-latin-1 wasn't working when the oh-so-glorious dillo2 is supposed to be all UTF-8ed up. After all, it works in Firefox, right? (I've read that google pulls this idiocy with all of the little browsers. w3m, elinks, etc. Ignores the Accept-Charset header and does what it wants based on the User-Agent.) A different option might be to have a form popup menu to show info such as submission encoding, hidden inputs, and so on. As for the code, unfortunately I have setTooltip()s all over the place because Style's Tooltip field is for real tooltips, not for char*s to stuff into pre-existing tooltips such as the fltk widgets have.

2 2