- Dillo-dev - lists.mailman3.com

[patch] minor optimization in StyleAttrs::equals()
by Johannes.Hofmann＠gmx.de Sept. 20, 2008

Sept. 20, 2008

Hi, this patch adds a missing optimization to StyleAttrs::equals(). Similar checks are already in place in other equals() methods. Cheers, Johannes

2 1

[patch] fixup resizable of after tab removal
by Johannes.Hofmann＠gmx.de Sept. 19, 2008

Sept. 19, 2008

Hi, I was seeing crashes when removing tabs. The reason is that when we accidentally remove and delete the resizable of the TabGroup, fltk still tries to access it. Attached patch fixes that. It also moves the hide/showLabel functionality into CustTabGroup. Cheers, Johannes

1 0

8.68% of my time in assert()?
by corvid＠lavabit.com Sept. 19, 2008

Sept. 19, 2008

Turning off bounds checking for get and getRef does get rid of nearly all of the assert()s, but I was just trying -Winline and discovered: ./lout/misc.hh: In function 'void lout::misc::assert(bool, const char*, ...)': ./lout/misc.hh:36: warning: function 'void lout::misc::assert(bool, const char* , ...)' can never be inlined because it uses variable argument lists .. Earlier I'd said assert() was not cheap, but I was still uncertain about how -g and -pg might be affecting inlining. Now I _know_ that assert() is not cheap.

3 10

Confused by the comment to CustInput::handle()
by onepoint＠starurchin.org Sept. 19, 2008

Sept. 19, 2008

In dillo2/src/ui.cc, CustInput::handle() has a comment saying that it disables CTRL+{o,r,HomeKey,EndKey}, yet it only seems to disable CTRL+o . I think CTRL+r used to be disabled too, so that CTRL+r would reload the page even if the URL widget had the focus. Here's a one-line patch to restore that. What should we do about CTRL+{HomeKey,EndKey}? I prefer HomeKey and EndKey to scroll the main window even when the URL has the focus. Wasn't that the behaviour originally? It certainly doesn't happen now. Regards, Jeremy Henty

2 2

Latest libpng fixes crashes
by onepoint＠starurchin.org Sept. 18, 2008

Sept. 18, 2008

I recently looked at why dillo almost always crashed when viewing http://www.packtpub.com/article/transaction-model-of-postgresql and discovered it was happening in the depths of libpng. Luckily libpng-1.2.32 fixes this problem, so if you have been seeing unexpected crashes that might be due to PNG images then I recommend upgrading libpng. Regards, Jeremy Henty

1 0

patch: scroll upon resize
by corvid＠lavabit.com Sept. 17, 2008

Sept. 17, 2008

You know how - you are scrolled down or to the right - you make the viewport larger - the scrollbar disappears - you can only get the rest of the document back by hitting some arrow keys or something This seems to fix it, although my usual dw disclaimer applies: I don't know whether this is necessarily the right place for the change. PS When making the viewport very narrow and then maximizing, I notice that the location bar does not go back to showing the whole address. I don't know whether that's dillo's fault or fltk's fault. PPS Amazing how much code we need for dealing with scrolling and scrollbars...

3 4

load_images and multiple windows
by Johannes.Hofmann＠gmx.de Sept. 16, 2008

Sept. 16, 2008

Hi, the load_images button toggles the global prefs.load_images variable but the buttons of other browser windows are not updated accordingly. Should load_images be a per window variable, or should we update the buttons in all other windows? Also, when switching to load_images=true, the "Load images" entry in the popup menu get's deactivated, even though the images of the current page are not yet loaded. Cheers, Johannes

3 6

[patch] findbar appearance
by Johannes.Hofmann＠gmx.de Sept. 15, 2008

Sept. 15, 2008

Hi, attached path adjusts the findbar to match the appearance of the panel. Cheers, Johannes

1 0

patch: small mem leaks
by corvid＠lavabit.com Sept. 13, 2008

Sept. 13, 2008

Jeremy kindly provided the memory checking output that went with the valgrind logs from the other day. (I knew about the FullScreen one, but might as well comment it out until someone hooks it up.)

1 0

More Cache memory corruption
by onepoint＠starurchin.org Sept. 12, 2008

Sept. 12, 2008

Hi everyone! No, I'm not dead. I am sorry I haven't been able to spend much time on Dillo recently. I've been lurking and it's good to see Dillo getting lots of developer love. Now the bad news: this HTML almost invariably crashes Dillo: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="Content-Type" content="application/xhtml+xml; charset=iso-8859-1" /> </head> <body> </body> </html> The culprit is the <meta...> tag. Dillo always crashes in one of two ways: segmentation fault or glibc detecting memory corruption and aborting. In each case the backtrace from gdb is the same (verified by running Dillo 100 times (it only failed to crash twice)). The backtraces show that the Cache_* functions are freeing things they should not. Valgrind confirms this. I'm attaching backtraces and a valgrind log. I'm not sure how to debug this further. If anyone can suggest ways to trace this further I'll have a go. Looking forward to the dill2 release! This will be a great milestone. Jeremy Henty

3 3