- Dillo-dev - lists.mailman3.com

Window close dialog
by jcid＠dillo.org Sept. 30, 2008

Sept. 30, 2008

Hi, Can somebody please make the dialog for closing a window with tabs open? -- Cheers Jorge.-

2 4

patch: changeLinkColor
by Johannes.Hofmann＠gmx.de Sept. 30, 2008

Sept. 30, 2008

On Sun, Sep 28, 2008 at 02:54:56PM -0400, Jorge Arellano Cid wrote: > On Sun, Sep 28, 2008 at 05:55:10PM +0000, corvid wrote: > > Encouraged by the idea that I am going in the right direction, I have > > made a new one with spaceStyle: > > Funny how we were working on the same patch a the same time! > > I had an ancient version, and gave it a review. > The link search is linear inside textblock. A linux gazette page > showed more than 33000 words to color a link. On bigger pages it may be worst. > It depends on the structure. For instance our bookmarks uses tables > and the link is usually found in less than 10 words. > > The patch in CVS reduce the 35000 steps to 1500 or so (the > sorted link list is sparse, so there's a penalty for looking > for an actual link to compare to). > Not sure I understand this optimization. It is assuming that link numbers are always increasing, right? Can we assume this in dw/*? src/html.cc seems to be implemented currently in way that this is true. But perhaps we could/should reuse link numbers for equal destination urls in the future? Or someone might just choose hashes of the url string as link number. BTW. with both implementations I now see issues with this example: <html> <body> <a href="http://www.dillo.org">dillo</a> <a href="http://slashdot.org">slashdot</a> <a href="http://www.dillo.org">dillo</a> </body> </html> When opening the first link in a new window, it doesn't change color in the original one. When opening it in a tab, the first one changes color. After a reload also the second one changes color. Am I missing something? Cheers, Johannes

3 6

Window close dialog
by jcid＠dillo.org Sept. 30, 2008

Sept. 30, 2008

On Mon, Sep 29, 2008 at 07:46:52PM +0200, Johannes Hofmann wrote: > Hi Jorge, > > On Mon, Sep 29, 2008 at 11:12:39AM -0400, Jorge Arellano Cid wrote: > > On Mon, Sep 29, 2008 at 04:03:55PM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > On Mon, Sep 29, 2008 at 09:48:58AM -0400, Jorge Arellano Cid wrote: > > > > Hi, > > > > > > > > Can somebody please make the dialog for closing a window > > > > with tabs open? > > > > > > "Close Window" only closes the current tab anyway. > > > > Yes. > > > > > "Exit Dillo" closes all windows including tabs. > > > So, do you think about a dialog in the "Exit Dillo" case when > > > there is more than one tab or more than one window or both? > > > > Both, plus the window manager's "close window" if there're open Tabs. > > > > > Do we have the number of open windows somewhere? > > > > In bw.cc's num_bws. > > > > just tried to implement that by creating a callback for the > fltk::Window. But then I noticed that user_data() of the windows is > already beeing used in ui.cc. > I don't understand why this is necessary. UI also contains a pointer > to the BrowserWindow (Bw). It helps the child widgets find their bw. e.g. search button, panel buttons, etc. They are nested in different ways depending on the panel shape choice so AFAIS there's no easy way to navigate up to the UI. One way solve it is to store the bw in the window's user_data(), thus a simple wid->window()->user_data() does the trick. Giving it some more thought, the danger of some function not belonging to the current UI geting the wrong bw is real, and it may end sending commands to the wrong bw. IOW: there's only one window for several tabs. When Tabs switch focus, the window()->user_data() is updated accordingly. If a background Tab requests its bw using window()->user_data() it will get the wrong one! (this may cause problems as the one reported by corvid.) If we can find an alternative method to get to a widget's bw (storing it in the CustTabGroup for instance), it'd be much better. -- Cheers Jorge.-

1 0

patch: show_msg=NO disable debug messages
by corvid＠lavabit.com Sept. 29, 2008

Sept. 29, 2008

tried turning off show_msg and saw how dillo is still somewhat chatty thanks to DEBUG_MSG. (Or would you prefer a show_debug_messages pref as suggested in dillo2rc? Hmm... thinking about the sentence "Generic messages (mainly for debugging specific parts)", I'd have to say that we use MSG for plenty of debugging messages and DEBUG_MSG for plenty of of-more-general-interest messages.)

3 2

patch: changeLinkColor
by Johannes.Hofmann＠gmx.de Sept. 28, 2008

Sept. 28, 2008

On Sun, Sep 28, 2008 at 07:42:14PM +0000, corvid wrote: > Jorge wrote: > > On Sun, Sep 28, 2008 at 05:55:10PM +0000, corvid wrote: > > > Encouraged by the idea that I am going in the right direction, I have > > > made a new one with spaceStyle: > > > > Funny how we were working on the same patch a the same time! > > > > I had an ancient version, and gave it a review. > > The link search is linear inside textblock. A linux gazette page > > showed more than 33000 words to color a link. On bigger pages it may be worst. > > It depends on the structure. For instance our bookmarks uses tables > > and the link is usually found in less than 10 words. > > > > The patch in CVS reduce the 35000 steps to 1500 or so (the > > sorted link list is sparse, so there's a penalty for looking > > for an actual link to compare to). > > > > Please apply the spaceStyle part, and send it to me. > > Do we know that all of the (TEXT -- putting WIDGET aside for the moment) > contents of a link will have the same style? First likely example I could > come up with is how about in a utopian future dillo where tooltips are > implemented and there's an ABBR inside? Oh right. Just think about: <html> <body> <a href="http://slashdot.org">slash<b>dot</b></a> </body> </html> After clicking, the dot is no longer bold. Cheers, Johannes

1 0

patch: changeLinkColor
by corvid＠lavabit.com Sept. 28, 2008

Sept. 28, 2008

I just took the 0.8.6 version and replaced everything in it with dillo2 versions. (well, then had to add in the widget part) The fact that it seems to be working is kind of shocking. As for whether this is still the right way to do it, I leave this matter for the experts. The registerName is because html.cc needs to have that working in order to call changeLinkColor.

2 3

panel_size=small hides the menubar
by onepoint＠starurchin.org Sept. 28, 2008

Sept. 28, 2008

If I add "panel_size=small" to ~/.dillo/dillo2rc then the menubar disappears! Huh? (~/.dillo/dillo2rc is otherwise identical to the default /etc/dill2rc) Regards, Jeremy Henty

2 2

Dillo in OSX
by Johannes.Hofmann＠gmx.de Sept. 27, 2008

Sept. 27, 2008

On Thu, Sep 04, 2008 at 04:09:30PM -0400, Jorge Arellano Cid wrote: > On Wed, Sep 03, 2008 at 06:28:49PM +0200, Johannes Hofmann wrote: > > On Tue, Sep 02, 2008 at 09:20:03AM -0400, Jorge Arellano Cid wrote: > > > On Mon, Sep 01, 2008 at 01:42:26PM +0200, Johannes Hofmann wrote: > > > > Hi Jorge, > > > > > > > > how did You setup the OSX box to get a compiler and header files? > > > > Did You install that huge XCode stuff, or is there another way? > > > > I may get access to an OSX box to try dillo on it. > > > > > > How do I disable the double-buffer? > > > > Use the --disable-doublebuffer option when configuring dw2. > > Oh, yes, I forgot... > (tried running ./configure --help in dillo2 not dw2) > > > > I tried dillo "as is" with clear_double_buffer() and without it, > > > and the result is the same... > > > > Yeah, dw2 implements doublebuffering internally, so that does not > > make a difference. > > I'll have access to that machine again sarting on September 12. > Just tried current dillo on OSX with --disable-doublebuffer. It works ok with some issues: * Some of the buttens disapear from time to time (Back button for example). * The font size seems a bit too large so that there is not enough space between words and lines. * Incoming data does not reliably trigger a page update. An additional event like a mouse movement is necessary. Apart from that it's quite nice. Tabs are working fine. Cheers, Johannes

2 1

SEGFAULT with mouse click
by jcid＠dillo.org Sept. 27, 2008

Sept. 27, 2008

On Thu, Sep 25, 2008 at 11:14:28PM -0700, Donald Chai wrote: > On Thu, Sep 25, 2008 at 3:58 PM, Jorge Arellano Cid <jcid(a)dillo.org> wrote: > > I just came accross an easy to reproduce segfault, that's > > present since long ago. > > > > Middle-clicking works OK right? > > > > Well, try middle-clicking a link with a two mouse button (i.e. > > pressing both at the same time). The link menu stays open and > > after a second click (e.g. left click to make it dissapear) > > it segfaults. > > [...] > > I see this problem as well. If I very quickly press the left then > right mouse button (NOT at the same time), then I get a segfault. > Dillo seems to try to select some text on the old page, after the new > page is loaded. This hinted me towards a timing issue and found this way to crash dillo (most probably akin to the "middle-click" bug): 1.- Left click over a remote URL link (to have some time while DNS is resolving) 2.- Move the mouse pointer out of the link and right-click to get the popup menu, before the new page starts downloading. 3.- Once the new page starts to show, click again to get rid of the popup, and it'll crash. -- Cheers Jorge.-

3 7

Icon for Dillo window
by jcid＠dillo.org Sept. 27, 2008

Sept. 27, 2008

Hi, I was thinking it'd be good to provide an icon for the WM to use. Does anybody know how to do it with FLTK2? -- Cheers Jorge.-

4 20