- Dillo-dev - lists.mailman3.com

ImageMagick for SVG and other image types?
by jgaffney＠lawrenceville.org 20 Jul '16

20 Jul '16

At this point Dillo supports the display of GIF, PNG, and JPG, but SVG is used heavily by sites like, for example, Wikipedia. Has the Magick++ library in ImageMagick been considered for supporting these other image formats? The FLTK people seem enthusiastic about the Imago library in spite of its alpha state of development; librsvg, which looks, at least to my untutored eye, like it requires a fair amount of voodoo to use, is apparently no longer actively supported and would at any rate only provide SVG support; but ImageMagick is pretty standard with Linux distributions, and the Magick++ interface makes conversions from any format to PNG for the purposes of display extremely easy. In src/misc.c, at the end of the image part of the else-if ladder in a_Misc_get_content_type_from_data(), one could add another "rung" that uses Data and Size to create a Magick::Blob, and from this a Magick::Image, then use Magick::Image.write() to write this to another Magick::Blob of type PNG, and then replace Data and Size with those of the resulting Magick::Blob. A try-catch block would catch the cases where Data is not an image. Altogether this sort of "cheat" would require very few lines of code to implement. And the Magick++-config utility could supply the needed -D..., -I..., -l... flags to the configure script. I'm not suggesting this is an ideal long-term solution, but in the interim would at least allow the display of other image types. The most recent mention of this on the mailing list seems to be Jorge's indication on 22 April 2016 that No, there's no SVG image support in dillo yet. It should not be hard to implement though, but it needs an effort similar to GIF or PNG or JPEG code. Patch welcomed! ;) But surely someone has thought of ImageMagick before. Are there objections to using it? And if so, maybe a flag could be set by the configure script to conditionally compile this in for those who want it? (If this is pursued, the configure script should probably also check that the version of ImageMagick is recent enough to have been patched against that serious exploit in just this sort of conversion code.) A test program shows that the invocation of ImageMagick and conversions really are as simple as the steps outlined above. But I would be happy to make an attempt at a patch, if you don't mind this being undertaken by an amateur.

1 1

cppcheck on Dillo source
by nick＠linicks.net 17 Jul '16

17 Jul '16

Hi all, While waiting for the Tour De France to start on TV, I ran cppcheck on Dillo source for something to do - a few errors were picked up! I have compacted the findings (with two comments from me)and attached it as a plain text file. Keep up the great work guys and thanks! Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

3 6

Problem related to generated content
by sgeerken＠dillo.org 10 Jul '16

10 Jul '16

Hi! I've come upon an interesting problem. Consider this HTML (stripped down from a real world example): <head> <style> .fc:after { content: ""; display: block; clear: both; } </style> </head> <body> <div class="fc"> <div style="float: left">main</div> </div> <div style="background:#404040; color:#ffffff">footer</div> </body> Firefox (and probably other browsers) renders black text "main" on white background above white text "footer" on dark gray background. Dillo 3.0.5 does the same, for the simple reason that it does not support floats. Dillo 3.1-dev, however, renders black text "main" and white text "footer" side by side on dark gray background, because "main" is within a float. (Which is, of course, difficult to read.) The reason why Firefox renders this as it does: the definition within <style> generates something like a block element before the text containing "footer", with "clear: both" as CSS attributes; something like: <body> <div class="fc"> <div style="float: left">main</div> </div> <div style="clear:both"></div> <div style="background:#404040; color:#ffffff">footer</div> </body> Aside from the fact that dillo has still problems with this ("footer" is too much to the right; I'll investigate this independently), this shows that dillo's limited capabilities regarding generated content, together with floats, causes some unpleasing rendering errors, which are furthermore laborious to analyse (and thus not so simple to be ignored). Has someone a feasible idea to deal with this? Sebastian

1 1

URL field / Loading page images / Refreshing DNS cache
by jgaffney＠lawrenceville.org 09 Jul '16

09 Jul '16

First, a huge thanks to all the Dillo team for their efforts: I just switched from 3.0.5 to the current snapshot to try out the mbedtls changes, and I am wowed not only by this, but by all the improvements in rendering, etc. Great work! A few suggestions, all very minor, that might be added to the back of the development queue: In the current snapshot, the navigation bar has changed, and the URL field does not seem to be taking into account font_factor -- with the result that the window is smaller than the font height. You can test this by setting, e.g., font_factor=2.0 in your dillorc (most dramatically for a tiny panel with small icons). The issue seems to be with this factor not being taken into account when bh and lh are set in make_panel() in ui.cc. As far as I can see, one can use the context menu to download individual images on a page, or use the panel to toggle image loading. But if one wants not to download images in general, but to download all the images for some one page (e.g., a weather forecast page), then one has to toggle downloading of images on and then off again. Maybe a command could be added to KeysCommand_t in keys.hh, bound by default to something like Ctrl-i in keys.cc, with a corresponding call to a_Html_load_images() in handle() in ui.cc? To make the switch to the current snapshot, I had, sadly, to terminate an instance of 3.0.5 that had been running continuously for 90 days without any issues. But to get that much up time it was necessary to add a little code so that SIGUSR1 would call a_Dns_freeall() and a_Dns_init(), otherwise (unless I am missing something) Dillo will persist in using the cached lookup indefinitely and not detect when the IP address has changed. So maybe some sort of key binding could be added that would flush the cache when needed? Thanks again for all your hard work!

4 5

patches #4634 and #4635
by jcid＠dillo.org 09 Jul '16

09 Jul '16

Hi corvid, Some comments: ----------------- Patch #4635: rm IO flags, as they are never used Yes, those linger from a time when shutdown() was used for handling sockets in dillo. Not necessary now since we use read() write() close(). ------------------ Patch #4634: freeing http socket, close FD that's being connected Why did you do this? (i.e. Is there a specific bug?). Beware the FD is closed inside IO.c (OpEnd|OpAbort). If you close it in Http_socket_free(), you are opening race conditions on file descriptors, and coding outside the design. Http_socket_free() is used with the CCC chains, that's why it doesn't close the FD, IO will do it by means of CCC; avoiding race conditions. I haven't tested the code yet, but I'd be amazed if resources don't stop to load at random. For instance, Http_socket_reuse(int Skey) would be activating and reporting success on a socket that's just been closed. Please review all the related patches and be more careful before committing. PD: IIRC I used lsof to check for FD leaks long ago. -- Cheers Jorge.-

1 0

an experiment using mbed TLS
by eocene＠gmx.com 08 Jul '16

08 Jul '16

I wanted to see what it would take to use mbed tls with dillo. I put a copy of the diff at http://www.dillo.org/test/mbedtls.diff and I mention it here in case someone should want that one day. That said, it looks like netsurf uses curl, and curl can use any tls library you care to mention. And I'm pretty sure netsurf does javascript.

5 17

URL field / Loading page images / Refreshing DNS cache
by jgaffney＠lawrenceville.org 08 Jul '16

08 Jul '16

Jorge Arellano Cid <jcid at dillo.org> writes: [...] >> As far as I can see, one can use the context menu to download >> individual images on a page, or use the panel to toggle image >> loading. But if one wants not to download images in general, but to >> download all the images for some one page (e.g., a weather forecast >> page), then one has to toggle downloading of images on and then off >> again. Maybe a command could be added to KeysCommand_t in keys.hh, >> bound by default to something like Ctrl-i in keys.cc, with a >> corresponding call to a_Html_load_images() in handle() in ui.cc? > > This is interesting. > >> To make the switch to the current snapshot, I had, sadly, to terminate >> an instance of 3.0.5 that had been running continuously for 90 days >> without any issues. > > Wow, it's good to know it can last that long. > > What you describe here is very interesting, in a way I've > come to suspect most users don't have the slightest clue. > > I mean, everyone of us (as dillo users) have *different* use cases. > There's no way we can guess what other people are doing outside of > our awareness realm. > > Now, you're not only a casual user, but one that uses dillo *a lot*, > and appreciate it as an everyday tool. > > That being stated, we are very interested in knowing your use case, > and all the details of it. There's potentially a lot we can learn from it, > and also improve yours/and-the-generic user experience as a result of > this learning. > > So please elaborate on why you like to have it running for that long time, > what do you do with it, how you do it, what problem does it solve that other > tools don't, why is it your choice. What you'd wish it had. I had been using Firefox (and still do, for trusted sites that require javascript), but looked around for another browser when the option to turn off javascript was removed from the preferences dialog -- when javascript is so often the vulnerability behind exploits, I didn't want a browser hoisting in javascript from all over the Internet at its own discretion. (It is still possible to turn javascript off in Firefox if one starts from a script that invokes a prefs.js with a legacy `user_pref("javascript.enabled", false);', or from the internal about:config page, but:) Dillo was one of the few browsers without javascript, and when I checked it out, I found that I agreed very much with Dillo's stated philosophy. And it has been my principal browser ever since. In fact, along with an xterm and Emacs, it's one of the three apps always running on my machine. Things I like about Dillo: Dillo doesn't even include javascript. (I cringe a bit when there is talk on the list about the possibility of including it -- if it is included at some point, I hope that there will be a #define to exclude that code at compile time.) Dillo is small and fast, which is nice not only for general browsing, but when invoking it through, e.g., Emacs to open a link. Dillo let's me configure things the way I like, and when it doesn't do something I want, the code base is accessible enough that I can modify it to do so. (I had in fact already implemented the suggestions I made, but didn't share any patches because, even beyond being an amateur, my hacks tend to be on the ugly side -- the loading of images per page, for example, required adding #include "html.hh" to ui.cc, indicating that I am certainly violating some logic of organization and encapsulation.) Dillo isn't phoning home or doing anything else behind my back, and it let's me easily block ad and other such sites in domainrc. Dillo doesn't try to do all sorts of exotic things, or invoke external apps to do them, with all of the potential security risks. With other browsers, you have to do a lot of work to try to prevent this sort of automagical behavior, and even if it's possible, you aren't left feeling at all confident about having prevented it. Like you, I like that Dillo caches DNS lookups, but of course IP addresses change from time to time for legitimate reasons, so there does need to be a way to flush the cache. Johannes's patch is a good one, but I also still like the idea of using the cache until I need it to refresh. Of course, one could simply start a new instance of Dillo, but I also like that it caches pages in a way that allows me to open a link to a previously visited page off-line, without trying to reconnect and reload it. And -- possibly a unique personal idiosyncrasy -- I like to see links I have visited displayed as visited. Other than that, there really isn't any reason not to be firing up a fresh instance of Dillo whenever it is needed. And probably a lot of other virtues in Dillo that just aren't coming to mind right now. > Some things may be possible, others not, a few may be solved in different > ways, etc. Just learning about those key tasks, or improving a single one, > would be a big gain for all of us. > > Your feedback as a dillo power-user is not only welcomed, it's asked for! > > >> Thanks again for all your hard work! > > Ack! > > > @all: if you're a dillo power-user, let us know about it!

1 0

CSS files downloaded only after reloading page
by Hole.destructor＠gmx.de 08 Jul '16

08 Jul '16

Hi Dillo developers, the dillo version from the repository seems to have problems downloading some CSS files the first time some pages are loaded. Though, the remaining CSS files are downloaded when the page is re-loaded using CTRL-r. Example page: https://netzpolitik.org/ Reproduce: 1) dillo https://netzpolitik.org/ -> styles from some CSS files seem to be missing 2) press CTRL-r -> some new CSS file is downloaded and styles are applied 3) press CTRL-r -> some new CSS file is downloaded and styles are applied Best regards, Alex

3 2

URL field / Loading page images / Refreshing DNS cache
by jgaffney＠lawrenceville.org 08 Jul '16

08 Jul '16

Johannes Hofmann <johannes.hofmann at gmx.de> writes: [...] >> > To make the switch to the current snapshot, I had, sadly, to terminate >> > an instance of 3.0.5 that had been running continuously for 90 days >> > without any issues. But to get that much up time it was necessary to >> > add a little code so that SIGUSR1 would call a_Dns_freeall() and >> > a_Dns_init(), otherwise (unless I am missing something) Dillo will >> > persist in using the cached lookup indefinitely and not detect when >> > the IP address has changed. So maybe some sort of key binding could >> > be added that would flush the cache when needed? >> >> good point. However I'd like to avoid another key-binding and rather >> do the right thing automatically. >> I could think of a general DNS entry timeout of a couple of seconds. >> In many cases DNS responses are cached at OS-level too respecting >> lifetime values given by the server. > > Firefox has an option to configure the DNS cache expiration > (network.dnsCacheExpiration). > Attached patch implements a similar feature for Dillo. > > Cheers, > Johannes That was fast! Thanks for this; I will try it out.

1 0

URL field / Loading page images / Refreshing DNS cache: Correction
by jgaffney＠lawrenceville.org 08 Jul '16

08 Jul '16

Jorge Arellano Cid <jcid at dillo.org> writes: > Hi John, > > On Thu, Jul 07, 2016 at 05:16:04PM -0400, John Gaffney wrote: >> [...] >> > In the current snapshot, the navigation bar has changed, and the URL >> > field does not seem to be taking into account font_factor -- with the >> > result that the window is smaller than the font height. You can test >> > this by setting, e.g., font_factor=2.0 in your dillorc (most >> > dramatically for a tiny panel with small icons). The issue seems to >> > be with this factor not being taken into account when bh and lh are >> > set in make_panel() in ui.cc. >> [...] >> >> I meant what is actually called the "location box," and on comparing >> the code for 3.0.5 to the snapshot of a few days ago, I see that there >> has been no change in the section of make_panel() in ui.cc that sets >> the values of bh, lh, etc. The change that has caused the problem is >> the addition of line 466 of ui.cc: >> >> i->textsize((int) rint(14.0 * prefs.font_factor)); >> >> But the height of the CustInput i is still set to lh, which does not >> take into account prefs.font_factor. > > Yes man. > > That was a quick patch (#4222 in Hg) for a larger font. > > I'll look at it after I finish a general rendering algorithm bug > I'm working in. > > Please be patient. > > BTW, do you really need a font size that enlarges the location box? or > would it be enough to clamp the font size to fit in? The second case is > a much simpler patch. No rush! I was just pointing out the issue; for myself, just commenting out the above line works just fine by reverting to the old behavior and smaller font size in the location bar.

1 0