- Dillo-dev - lists.mailman3.com

Leaking image structures
by Johannes.Hofmann＠gmx.de Feb. 18, 2009

Feb. 18, 2009

On Wed, Feb 18, 2009 at 08:26:52AM +0000, corvid wrote: > > On Wed, Feb 18, 2009 at 12:40:57AM +0000, corvid wrote: > > > > Can you please try attached patch with valgrind and image loading on > > > > and off. > > > > > > Is this a proposed patch for the tree or an experiment in leak-finding? > > > > For the tree, if it proofs to fix the leaks and doesn't cause > > others. > > If we always add Image, the code that loads images manually will think > it hasn't been loaded yet. > Ah ok. I guess I misunderstood Html_add_new_linkimage() completely. Please check the updated patch. Thanks, Johannes PS: The point of the patch is to actually do reference counting: Whenever we create a new reference (pointer) to an image, we call a_Image_ref(), when such a pointer is deleted we call a_Image_unref(). If I see it correctly, the permanent pointers to Image structures are in html->images and in the DilloWeb structure.

3 3

Fun with autocnf and mercurial
by onepoint＠starurchin.org Feb. 18, 2009

Feb. 18, 2009

Here's a patch for discussion. Since I am parsing Dillo logs for debugging, I thought it would be neat if Dillo logged the mercurial revision. Patch attached. Thoughts? Does anyone know a better way to get the revision for a particular tag? Piping "hg tags" through a sed script is rather kludgy but I can't find a way to get mercurial to tell me directly. I log the qparent revision as well as the tip revision because I manage patches with Mercurial queues, so my qparent revision is the vanilla tip revision that I am currently based on. Also, I used printf() to log the revisions because neither MSG nor MSG_WARN produced anything. I don't know why. Can anyone explain? Regards, Jeremy Henty

3 11

Leaking image structures
by onepoint＠starurchin.org Feb. 18, 2009

Feb. 18, 2009

One of the biggest leaks that valgrind reports is image structures. I'm attaching logs that show memory being allocated by a_Png_new() and cousins and not being freed. There are also frequent leaks of memory allocated by the image libraries from within the various image callbacks, but I suspect these are just another effect of the Dillo image structures not being freed. Unfortunately I'm having a hard time tracking these leaks down. They regularly appear after long browsing sessions, but I haven't found any single page that reproduces them. I suspect they are caused by some race condition inside the CCC rather than the HTML parser. I am browsing with image loading enabled, and if I understand the code correctly that means that the Web structures in the CCC own all the references to image structures. The fact that image structures are reference counted makes it hard to know when the structures should be freed anyway. Indeed, does Dillo even ensure that image structures are freed? Maybe this is just a symptom of incomplete cleanup at exit rather than a true leak? I've looked over the code and can't see any obvious leaks so I'm rather stuck. Any tips for tracking this down? Even if it's not a true leak it would be good to have a fix that cleaned up the valgrind logs. Regards, Jeremy Henty

4 5

META charset without MIME type
by corvid＠lavabit.com Feb. 17, 2009

Feb. 17, 2009

Jorge wrote: > summary: Fixed handling of META's content-type with no MIME type > (e.g. only charset). Is that legal? It doesn't sound legal.

2 6

a policy for dillorc vs. style.css conflicts?
by corvid＠lavabit.com Feb. 16, 2009

Feb. 16, 2009

I was just looking at some of the prefs that I don't think are doing anything right now, e.g., link_color, force_my_colors... I could stuff them into buildUserStyle(), but I don't know which should prevail in case of conflicts. I can't remember whether I've already mentioned that I've been wondering whether it might be reasonable to rip a bunch of color stuff out of dillorc and expect a dillo user to be able to deal with a well-commented sample style.css instead.

3 16

ChangeLog link
by jcid＠dillo.org Feb. 16, 2009

Feb. 16, 2009

Hi, Does anybody know how to ask hgweb for the "tip" ChangeLog file? (The current link is set to a specific version). -- Cheers Jorge.-

1 0

Repush and scroll position
by jcid＠dillo.org Feb. 16, 2009

Feb. 16, 2009

Hi, Patch b134ea74331b is to make repush remmeber the scrolling position. This is, if you load a page, start scrolling and the stylesheet arrives after that, it will no longer go back to the top. Please test. -- Cheers Jorge.-

3 7

[patch] Search Previous
by jorl17.8＠gmail.com Feb. 15, 2009

Feb. 15, 2009

Qui, 2009-02-12 ?s 19:38 +0000, corvid escreveu: > I updated the UTF-8 sampler search bar screenshot > to show off the nifty new button :) > > Great, thanks! Onto another subject I've been trying to understand what's going on in CharIterator::prev() and have been running tests and I have a question regarding iterator.hh. In the following code: inline static bool charsEqual (char c1, char c2, bool caseSens) { return caseSens ? c1 == c2 : tolower (c1) == tolower (c2) || (isspace (c1) && isspace (c2)); } Why are we checking if c1 and c2 are spaces? This is the code that, according to my tests, is wrecking the search-previous functionality. Thanks, Jo?o

4 10

patch: optgroup for OptionMenu
by corvid＠lavabit.com Feb. 14, 2009

Feb. 14, 2009

I've had this kicking around in my tree for months...finally got around to implementing the max string width for OptionMenu and doing a little polishing. Here it treats optgroup, option, and /optgroup as types of options because when I tried keeping options inside optgroup structures, it turned out to be messier. The idea is that if this is accepted, I will later do some renaming. (Not enabled for ListResource yet because the straightforward approach did not result in something very usable...)

2 3

patch: SELECT size > 1 !multiple
by corvid＠lavabit.com Feb. 13, 2009

Feb. 13, 2009

When I was working on the SELECT size code recently, I enabled using the plain fltk::Browser if size > 1 and multiple was not set. I didn't realize that the callbacks for a plain Browser and a MultiBrowser behave differently.

2 1