- Dillo-dev - lists.mailman3.com

[PATCH] Better-looking and -behaving message window
by Chris Palmer April 4, 2003

April 4, 2003

Hello, Rather than give it in diff -pru form, here is a new a_Interface_message_window function. I am giving it to you like this because it's easier for me (and probably you) -- my interface.c is extremely hacked right now. This function resembles the old one but is re-organized, has more comments, and produces a prettier message window. The OK button stays the same size no matter how big the window is, which I think is important. To see this message window in action, apply the patch to cache.c, below. Rather than have cache.c set the status bar label, I pop up a message window. I think users might not notice the status bar, and wonder why Dillo didn't respond when they tried to visit (e.g.) an FTP URL. Like all of what I've sent so far, these modifications affect the overall "polish" of Dillo -- its appearance and the organization of the code. If these are not wanted (my first two patches were ignored), please let me know why. Thanks. === /* * A general-purpose message window. */ void a_Interface_message_window(const char *title, const char *format, ... ) { GtkAccelGroup *accel_group; GtkWidget *window, *label, *button, *vbox, *hbox; static char msg[1024]; va_list argp; va_start(argp, format); vsnprintf(msg, 1024, format, argp); va_end(argp); /* Create the message window. */ window = gtk_window_new(GTK_WINDOW_DIALOG); gtk_window_set_wmclass(GTK_WINDOW(window), "message_dialog", "dillo"); gtk_window_set_title(GTK_WINDOW(window), title); gtk_window_set_position(GTK_WINDOW(window), GTK_WIN_POS_CENTER); gtk_container_border_width(GTK_CONTAINER(window), 5); gtk_signal_connect_object(GTK_OBJECT(window), "delete_event", (GtkSignalFunc)gtk_widget_destroy, (void*)window); /* Create the accel_group. */ accel_group = gtk_accel_group_new(); gtk_window_add_accel_group(GTK_WINDOW(window), accel_group); /* Create the label. */ label = gtk_label_new(msg); gtk_label_set_justify(GTK_LABEL(label), GTK_JUSTIFY_FILL); gtk_misc_set_padding(GTK_MISC(label), 20, 20); /* Create the OK button and its hbox. */ button = gtk_button_new_with_label(" OK "); gtk_signal_connect_object(GTK_OBJECT(button), "clicked", (GtkSignalFunc)gtk_widget_destroy, (void*)window); gtk_widget_add_accelerator(button, "clicked", accel_group, GDK_Escape, 0, GTK_ACCEL_LOCKED); hbox = gtk_hbox_new(FALSE, 0); gtk_box_pack_end(GTK_BOX(hbox), button, FALSE, FALSE, 0); /* Create and pack the vbox to put the label and the hbox in. */ vbox = gtk_vbox_new(FALSE, 5); gtk_box_pack_start(GTK_BOX(vbox), label, TRUE, TRUE, 0); gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0); gtk_container_add(GTK_CONTAINER(window), vbox); /* Show all the widgets. */ gtk_widget_show(label); gtk_widget_show(button); gtk_widget_show(hbox); gtk_widget_show(vbox); gtk_widget_grab_focus(button); gtk_widget_show(window); } === --- cache.c Thu Apr 3 15:22:59 2003 +++ cache.c.crp Thu Apr 3 15:22:39 2003 @@ -369,7 +369,9 @@ static gint Cache_open_url(DilloWeb *Web a_Cache_ccc, BCK, cccFunct, 1, 1); a_Chain_bcb(OpStart, entry->CCCQuery, (void *)entry->Url, Web); } else { - a_Interface_msg(Web->bw, "ERROR: unsupported protocol"); + a_Interface_message_window("Protocol Not Supported", + "Protocol \"%s\" is not supported.", + Url->scheme); a_Cache_ccc(OpAbort, 1, FWD, entry->CCCQuery, NULL, NULL); ClientKey = 0; /* aborted */ } Best, -- Chris music is what numbers feel like San Francisco, CA

2 1

Fix for bug 330 ("URL box should get input focus")
by Chris Palmer April 4, 2003

April 4, 2003

Hello, To cause the location box to get focus when a new window is created and after a URL is loaded, add this line gtk_widget_grab_focus(bw->location); to the end of the functions a_Interface_entry_open_url (last thing) and a_Interface_browser_window_new (just before the return statement at the end). -- Chris music is what numbers feel like San Francisco, CA

1 0

Suggestion
by Chris Palmer April 3, 2003

April 3, 2003

Hello, The icons available at http://dillo.auriga.wearlab.de/Icons/ are nifty. I suggest they be shipped with Dillo, and that the INSTALL file tell users how to use them. It might also be a good idea to replace the default icons with one of the other sets (I like the Konqueror ones). The rest look much better, imo. Best, -- Chris music is what numbers feel like San Francisco, CA

2 3

[PATCH] Move progress indicators to the status bar
by Chris Palmer April 3, 2003

April 3, 2003

Hello, This patch moves the progress indicator box to the status bar, where I think most users expect it. Also I think it looks better and uses screen space more effectively. Let me know if you have any trouble applying it. It's pretty simple, and it makes the code smaller (which is always good!). Best, -- Chris music is what numbers feel like San Francisco, CA

1 0

Terminology change for "full screen mode"
by Chris Palmer April 3, 2003

April 3, 2003

Hello, I propose changing the terms used to describe the button that hides or shows the control panel. This feature is great, btw! "Full screen" means to me that when I press the button, the browser window will grow to the size of the display, and possibly hide its window manager elements (frame, title bar, buttons, et c.). It doesn't mean to me that the control panel will be hidden. In my copy of the source, I've changed the tooltips for this button to "Show controls" and "Hide controls". But also, the names of the variables and functions that are related to this button should change, for easy readability. Do people agree with me that "hide/show controls" is better than "full screen on/off"? If so, I will create and submit a patch to change the variable and function names. Best, -- Chris music is what numbers feel like San Francisco, CA

1 0

[PATCH] New patch for to use $sysconfdir for etc directory
by Patrice Mandin April 3, 2003

April 3, 2003

Hello Dillo developpers, Here is a small patch that should end problems with dealing with the etc directory. I found this (elegant, imho) stuff in the sylpheed mail client sources. -- Patrice Mandin WWW: http://membres.lycos.fr/pmandin/ Programmeur Linux, Atari Spécialité: Développement, jeux

1 0

Re: configuration patch - Fix for bugs 386, 407, 392, 412 and notes on bugs 349, 408
by Jorge Arellano Cid April 3, 2003

April 3, 2003

Hi there! We're trying to fix our configure.in with Andreas. The latest CVS commit has a boat load of minor changes that require testing. Please refer to the subject line for BUG# numbers. On Sun, 23 Mar 2003, Andreas Schweitzer wrote: > Hi Jorge, > > This patch - mainly against configure.in - fixes > all these bugs - some of which are duplicates, actually. Sure. > The startegy I implemented is : > First check the headers, if not found return a big > warning and don't bother anything else. If found, > check how to link (that *should* work now). > That last test puts some nice HAVE_LIBPNG etc. in config.h, > but only if I don't fool with the "ACTION-IF-FOUND" and > "ACTION-IF-NOT-FOUND" fields. It is suggested to first check the headers and then the libraries, but every time I get into autoconf/automake I get a bad gut sensation. It is so confuse and messy... I checked the new code and decided to give more order to the whole stuff in there. This means some things changed, but the tests for jpeg and png remained (with some changes for zlib). > About libpng : Since version 1.2.2 it moved the headers > to libpng/png.h which is correct on all platforms I tested. > Since version 1.2.3 the install *should* create a link > to the old location, and there *should* be a libpng-config > script. Both these "shoulds" are only partially implemented > depending on platform/system. sigh. > But my libpng test should now find the header. > See also http://www.libpng.org/pub/png/png2002.html I added just a minor change. Hope it works! > The location of the system dillorc should NOT be > put in config.h according to the GNU docs, instead > everything with prefix/sysconfdir and similar stuff > should be defined on the command line. Hence, my > src/Makefile.am patch. This syntax of ' and " works on > a variety of systems (bash, ksh, csh, GNU make) finally. > Also, the current toplevel Makefile.am first tries > $(DESTDIR)$(sysconfdir) and then falls back on /etc > but the code in prefs.c does it the other way round. > One of them should probably be reverted. > And while writing this : the patch supplied on the > list will make dillorc be installed ONLY in > $(DESTDIR)$(sysconfdir) with no fall-back to /etc > but I think $(DESTDIR)$(sysconfdir) will be created > if necessary. I'm not sure of what to do here :(. For now I added Patrice's patch that simply adds: sysconf_DATA = dillorc in Makefile.am, and it works! The problem is we don't know what directory it gets in. :-) Currently if it is /usr/local/etc/ or /etc, it works, but if someone chooses /opt/weird/etc, it won't be found. If your solution fixes this, I'll switch to it. > About 349 : not sure if this really causes trouble. > I may have to do some major autoconf thing - like > trying with default and then trying with /usr/local > added - for each test, though (maybe a new macro ?). I removed the /usr/local stuff: -CPPFLAGS="$CPPFLAGS -I/usr/local/include" -LDFLAGS="$LDFLAGS -L/usr/local/lib" IMHO, it shouldn't be there, as the system SHOULD be configured in a way that programs are able to find system resources. Maybe this serves as a workaround: CPPFLAGS="$CPPFLAGS -I/usr/local/include" ./configure :-) > About 408: this seems to be caused by using libpng 1.0.12 (i.e. > the old libpng). On Debian it seems to be called that strangly. > The person should probably give more details or use libpng 1.2.X. Yes, that seems to be caused by an ancient libpng. We should give a warning. > Tested on > OpenBSD 3.2 (gcc 2.95, autoconf2.13, automake1.4) > FreeBSD 4.7 (gcc 2.95, autoconf2.13, automake1.4) > Linux 2.4.20 (gcc 3.2, autoconf2.57, automake1.7) Well, now without the forced "/usr/local/..." stuff, is different. I only hope we find the way to fix our configure stuff the right way... > To test it, it probably needs to go on a lot more platforms > but I hesitated to send it to the list. Feel free to forward > this mail as is to the list. I'm doing it right now!!! ...and the CVS has the new version. All the helpful feedback is very welcomed! Cheers Jorge.- PS: Get a new copy from CVS, ./autogen.sh, ./configure ...

3 3

font-colours
by thestar April 3, 2003

April 3, 2003

What's the latest update about dillo and css? Is this the reason why this site: http://www.linuxgames.com is so difficult to read?

2 1

Error DNS can't solve (null)
by Matthias Teege April 3, 2003

April 3, 2003

Moin, I'm running dillo 0.7.0 under FreeBSD and can browse my internal site without problems. If I try to use dillo with my squid proxy to access externel sites I get the error message above. The logfile og the DNS server logs also strange: 2003-03-31 17:16:42.617550500 query 41218 c0a8990a:0f89:34b3 1 . 2003-03-31 17:16:42.617790500 tx 0 1 . . c0a80015 2003-03-31 17:16:42.618661500 stats 41218 146743 1 0 2003-03-31 17:16:42.619053500 sent 41218 17 2003-03-31 17:16:50.878750500 query 41219 c0a8990a:0f8a:34b5 1 . 2003-03-31 17:16:50.878988500 tx 0 1 . . c0a80015 2003-03-31 17:16:50.879797500 stats 41219 146743 1 0 2003-03-31 17:16:50.880180500 sent 41219 17 What do I missing? Many thanks Matthias -- Matthias Teege -- http://www.mteege.de make world not war PGP-Key auf Anfrage

3 4

Re: [Dillo-dev] Re: configuration patch
by Sebastian Geerken April 2, 2003

April 2, 2003

On Wed, Apr 02, Phil Pennock wrote: > On 2003-04-02 at 20:19 +0200, Sebastian Geerken wrote: > > Why not use $(sysconfdir) in the code, as in the attached patch? > > Uhm, isn't $(sysconfdir) a directory, not a file? > > > diff -pru dillo1/src/prefs.c dillo2/src/prefs.c > > --- dillo1/src/prefs.c Wed Apr 2 19:40:36 2003 > > +++ dillo2/src/prefs.c Wed Apr 2 20:07:10 2003 > > @@ -250,10 +250,9 @@ static gint Prefs_load(void) > > file = a_Misc_prepend_user_home(".dillo/dillorc"); > > fd = open(file, O_RDONLY); > > g_free(file); > > - if (fd < 0 && (fd = open("/etc/dillorc", O_RDONLY)) < 0) > > - if ((fd = open("/usr/local/etc/dillorc", O_RDONLY)) < 0) > > - return FILE_NOT_FOUND; > > - > > + if (fd < 0 && (fd = open(DILLO_SYSCONFDIR, O_RDONLY)) < 0) > > + return FILE_NOT_FOUND; > > + > > fcntl(fd, F_SETFD, FD_CLOEXEC | fcntl(fd, F_GETFD)); > > > > scanner = g_scanner_new(NULL); > > I might be missing something, but your new open() is on a directory > there. Ah, yes, of course. This was just a suggestion, and should be simple to fix. Sebastian

1 0