January 2013 - Dillo-dev - lists.mailman3.com

font_factor
by johannes.hofmann＠gmx.de Jan. 12, 2013

Jan. 12, 2013

On Tue, Jan 08, 2013 at 11:55:42PM +0000, corvid wrote: > > I wrote: > > In styleengine, we use font_factor for calculation of larger and x-small > > and so forth, but we don't apply it when given an ordinary font size like > > 11px. > > Just to double-check: That's not intended behaviour, right? > sorry for the delay... This is intentional, but we know that there is a usability issue. In CSS px, mm, pt etc. define absolute sizes [1]. So if we want to adhere to the CSS spec strictly I think we can't just scale them. On the other hand web designers just use px without thinking about the implications. Also other browsers allow scaling of those fonts afaik. I think we have the following options: * ignore CSS and apply font_factor also to absolute font sizes * implement a zoom feature that displays everything larger (also images etc. * check other browsers for more alternatives [1] http://www.w3.org/TR/CSS21/fonts.html#font-size-props

4 3

[patch] list.h cleanup
by p37sitdu＠lavabit.com Jan. 12, 2013

Jan. 12, 2013

http://www.inventati.org/noname/dillo/list.h.patch

1 0

Intermitent internet access
by jcid＠dillo.org Jan. 11, 2013

Jan. 11, 2013

Hi, FYI, I'm away from home and with intermitent Internet connection. -- Cheers Jorge.-

1 0

White on white for the active tab
by onepoint＠starurchin.org Jan. 11, 2013

Jan. 11, 2013

I am getting white text on a white background for the active tab. I haven't changed any colours form the defaults. Why would this be? Regards, Jeremy Henty

3 3

[patch] modified a_Dialog_choice5 to accept any number alternatives
by p37sitdu＠lavabit.com Jan. 11, 2013

Jan. 11, 2013

-5 LOC, nothing is changed visually

3 2

namespace comments in dw/*
by corvid＠lavabit.com Jan. 11, 2013

Jan. 11, 2013

p37sitdu wrote: > Copied comments are almost in every source file. Committed.

1 0

patches
by p37sitdu＠lavabit.com Jan. 11, 2013

Jan. 11, 2013

I have uploaded some of my patches that were not commited (yet) to http://www.inventati.org/noname/dillo/ so it is easier to track them. Descriptions are embedded inside.

1 1

drawing areas with negative coordinates
by corvid＠lavabit.com Jan. 9, 2013

Jan. 9, 2013

Just something I noticed. There aren't an overwhelming number of them, so it seems like...not too big of a deal. I have the impression that it generally means that something is being drawn while an allocation somewhere is still (-1, -1, 1, 1). diff -r 35fb41bd0cdb dw/fltkviewbase.cc --- a/dw/fltkviewbase.cc Wed Jan 09 16:40:25 2013 +0000 +++ b/dw/fltkviewbase.cc Wed Jan 09 17:17:36 2013 +0000 @@ -431,8 +431,14 @@ void FltkViewBase::queueDraw (core::Rectangle *area) { - drawRegion.addRectangle (area); - damage (FL_DAMAGE_USER1); + static int counter = 0; + if (area->y < 0) { + MSG("%d let's not draw (%d,%d) w %d h %d\n", counter++, area->x, area->y, + area->width, area->height); + } else { + drawRegion.addRectangle (area); + damage (FL_DAMAGE_USER1); + } } void FltkViewBase::queueDrawTotal ()

1 0

[patch] dClose
by p37sitdu＠lavabit.com Jan. 9, 2013

Jan. 9, 2013

Merged a_Misc_close_fd, Dpi_close_fd and Http_socket_close into dClose and moved it into dlib. Replaced close calls with calls to dClose.

2 1

[patch] consistent file save UI behaviour for overwriting files
by onepoint＠starurchin.org Jan. 8, 2013

Jan. 8, 2013

The UI for downloading files is split between Dillo (which prompts for a file to save to) and the downloads DPI (which prompts for another file if the first file already exists). This leads to inconsistent behaviour for "Save link as file" depending on whether the URL is cached or not - if it is cached then any existing file is silently overwritten but if it is not cached we go to the downloads DPI which prompts before overwriting anything. These two patches move the UI logic from the downloads DPI into Dillo. This puts all the UI logic in the same place and ensures consistent behaviour for "Save link as file" whether or not the URL is cached. http://starurchin.org/dillo/patch/downloads-dpi_file_test_remove.html http://starurchin.org/dillo/patch/uicmd-cc_file_test_add.html Comments? Shall I push this? Regards, Jeremy Henty

2 2