December 2012 - Dillo-dev - lists.mailman3.com

BUG#1108
by jcid＠dillo.org 14 Dec '12

14 Dec '12

Hi there, This bug is a feature request: Bug: 1108 Impact: feature fault At: run time Type: other Comments: 3.0.2 Dillo goes to last viewed tab when closing a tab but when we use focus_new_tab=NO then we would like an option for when closing current tab Dillo would go to last *opened* tab (because we open tabs in the background). HTReproduce: ? focus_new_tab=NO in dillorc ? Open tab1 then a new tab2 and go to tab2 ? Open tabs in the background (tab3, tab4, tab5) with middle-clicks on links ? Close current tab2 ? Dillo focuses tab1 instead of tab5 ? new option: close_tab_focus=last_opened I just pushed a patch that sets this behaviour as default. The question is: Is it worth adding a dillorc option for this? -- Cheers Jorge.-

1 0

complex button layout and bgColor
by corvid＠lavabit.com 11 Dec '12

11 Dec '12

All of the copies of dillo that I happen to have around from the dillo3 era break on: <body text=white bgcolor=purple> <form> <button style="margin-top:200px">inside</button> </form> </body> I can get the purple if I add diff -r 0c1b7af7bf72 dw/ui.cc --- a/dw/ui.cc Mon Dec 10 22:55:07 2012 +0000 +++ b/dw/ui.cc Tue Dec 11 01:24:32 2012 +0000 @@ -285,6 +285,7 @@ layout = new Layout (createPlatform ()); setLayout (layout); layout->setWidget (widget); + layout->setBgColor (widget->getStyle()->backgroundColor); layout->connect (&layoutReceiver); } but I don't know how this is supposed to fit together.

1 0

Patch for xembed
by podarcis＠lavabit.com 10 Dec '12

10 Dec '12

Hi all, Here is a patch to make embedding dillo into an X-window work. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff -r 9bad41ea1dde src/xembed.cc --- a/src/xembed.cc Wed Dec 05 13:03:04 2012 +0100 +++ b/src/xembed.cc Sun Dec 09 10:12:36 2012 +0100 // TODO: Implement more XEMBED support; -void Xembed::show() { +void Xembed::create() { createInternal(xid); setXembedInfo(1); Fl::event_dispatch(event_handler); diff -r 9bad41ea1dde src/xembed.hh --- a/src/xembed.hh Wed Dec 05 13:03:04 2012 +0100 +++ b/src/xembed.hh Sun Dec 09 10:12:36 2012 +0100 @@ -14,10 +14,11 @@ public: Xembed(uint32_t xid, int _w, int _h) : Fl_Window(_w, _h) { - this->xid = xid; + this->xid = xid; create(); }; - void show(); + void create(); int handle(int event); + void resize(int x, int y, int w, int h); }; #endif ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tested with this FLTK program: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I do not know enough of the embedding stuff, but I wonder if the static int event_handler~~~~~~~~~~~~~~~ #include <FL/Fl.H> #include <FL/Fl_Window.H> #include <FL/x.H> #include <cstdio> #include <iostream> #include <sstream> #include <string> using namespace std; int main( int argc_, char *argv_[] ) { Fl_Window dw( 800, 600, "dillo embedded" ); dw.resizable( &dw ); dw.show(); cout << "dw.xid = " << (unsigned long)fl_xid(&dw) << endl; ostringstream cmd; cmd << "dillo -f -g " << dw.w() << "x" << dw.h() << " --xid " << (unsigned long)fl_xid(&dw); if ( argc_ > 1 ) cmd << " " << argv_[1]; cmd << " &"; cout << "system '" << cmd.str() << "'" << endl; system( cmd.str().c_str() ); return Fl::run(); } ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ What does NOT work is automatic resizing of the embedded dillo window, when the size is changed. This would be nice to have. podarcis

1 0

<button> rendering
by corvid＠lavabit.com 10 Dec '12

10 Dec '12

As Html_tag_open_button() says, /* * Buttons are rendered on one line, this is (at several levels) a * bit simpler. May be changed in the future. */ For some time I've wondered: How hard would it be to fix that?

1 0

BUG #1109
by jcid＠dillo.org 10 Dec '12

10 Dec '12

Hi, I contacted Sergio (submitter of BUG #1109), and here we have something weird. He reports crashes or weird behaviour. If you open [1] with dillo, the "Component:" selection list gets overdrawn over and over. Some more details here [2] (backtraces, etc). As from the backtraces, it crashed with event 11 (MOVE) inside a FLTK menu. I wonder what makes this particular menu different from the others in the same page. [1] https://bugzilla.redhat.com/query.cgi?format=advanced [2] https://bugzilla.redhat.com/show_bug.cgi?id=884778 -- Cheers Jorge.-

2 5

Unused?: the url tag in the DPI start_send_page command
by onepoint＠starurchin.org 09 Dec '12

09 Dec '12

Everything that sends the start_send_page DPI command also sends a url attribute with it, but I think this attribute is always ignored. Dillo processes the command in capi.c but it does nothing with it because the Cache is already set up to receive the following raw data. So it doesn't look at any attributes. The only other thing that receives a start_send_page is the view source DPI and it doesn't look at any of the attributes either (it extracts a url from the previous tag in the stream, which it then sends back to Dillo to be ignored). So what is this attribute for? Future use? Or is it something that just never got used? Regards, Jeremy Henty

2 2

rm test/fltk_browser
by corvid＠lavabit.com 09 Dec '12

09 Dec '12

I'd like to delete test/fltk_browser.cc. I was just reimplementing FltkListResource to use Fl_Browser instead of Fl_Tree (not to put in this release, although it seems to be working), and the existence of that little file doesn't...test anything, or make some obscure concepts clear, or anything...

2 1

[patch] dpid/dpid.c unused variable
by p37sitdu＠lavabit.com 07 Dec '12

07 Dec '12

Patch removes unused variable usr_srv_num.

2 1

ideographic, zero-width space
by corvid＠lavabit.com 06 Dec '12

06 Dec '12

Would it make the most sense for the handling of ideographic characters and zero-width space to go somewhere in textblock these days instead of html.cc?

2 1

Patch set: improve window titles
by onepoint＠starurchin.org 06 Dec '12

06 Dec '12

OK: here is the complete set: Patch: dpi-downloads_window_titles Nice window titles for the Downloads DPI (which is the only DPI that creates windows). http://starurchin.org/dillo/patch/dpi-downloads_window_titles.html Patch: dillo_window_titles Nice window titles for Dillo. http://starurchin.org/dillo/patch/dillo_window_titles.html Patch: dillo_window_titles_parameterise Make all the window titles parameters of the functions that create them instad of hardwiring them. Rename some variables (some titles were named "msg") and swap two function parameters for consistency. Titles may be NULL or empty, in which case we default to what we had before. NB: choice5 also handles a NULL msg, since msg may be read from a DPIP tag in a "dialog" DPI command and this returns NULL if the tag does not contain the key "msg". Patch: dpip-dialog_titles Make all DPIs that use the "dialog" command supply a title. (There is one instance of this in the hello DPI and many in the https DPI.) http://starurchin.org/dillo/patch/dpip-dialog_titles.html Please comment. There is nothing complicated or disruptive here - just some minor polishing of the GUI and the code base. No functionality is changed. I will push after the weekend if noone objects. (It's nice to be hacking on Dillo again!) Regards, Jeremy Henty

3 2