November 2010 - Dillo-dev - lists.mailman3.com

Dillo-Win32 patches - yet another update
by obeythepenguin＠gmail.com 18 Nov '10

18 Nov '10

After noticing some weird performance/stability issues in the latest Win32 build, I went back and noticed there was a bug in the dFcntl implementation, where non-blocking socket IO was never actually activated on Win32 (Unix and other platforms weren't affected). So I've updated the patches to fix that and a few other small things I discovered. First, the link: http://dillo-win32.sourceforge.net/patches.html Other changes: I've numbered the patches to reflect the dependency order, as much for my own sanity as anything. I've also removed the Html_css_repush_callback patch, since it breaks CSS streaming, though I've kept a copy on the off-chance there's ever a legitimate issue after all. I also have an updated testing build (binary and source) online if anyone wants to play with it. My build is still based on revision 1755, but that's only because the latest rendering code in hg's being worked on -- the patch applies, builds, and runs fine with the newest code as well. Johannes: I have not yet updated the DNS patch, but I intend to this weekend if I have the time. Thanks again for everyone's help and suggestions with this. I hope I have more to contribute in the future :-) Cheers, ~Benjamin

1 0

[bug]: CssParser::{nextToken, skipString}() skip an extra character.
by onepoint＠starurchin.org 16 Nov '10

16 Nov '10

The CssParser class has an unfortunate interaction between nextToken() and skipString(): they are both eager to call getChar(). The result is that when skipString() succeeds it has already getChar()-ed the character immediately after the string to be skipped, but nextToken() insists on calling getChar() again. This means that the character after the skipped string is also skipped. This causes two bugs. Firstly, if there is a completely empty CSS comment, ie. '/**/', then the closing '*/' is ignored (because it has already been partly skipped over). This generally causes most or all of the style to be ignored as the parser searches for the end of the comment. You can see this in the wild[1]! Secondly, if a token starts immediately after a CSS comment, then its first character is lost. The attached example shows both bugs. The first bug stops the red style from being applied to the <p> element, and the second bug applies the blue style to the <i> element instead of the <li> element. The quick fix is for skipString() to call ungetChar() before returning successfully (patch attached). Luckily only nextToken() calls skipString(). Should I push this, or is there a better way to do it? [1] http://layscience.net/node/1120

3 4

Dillo-Win32 patches, split and ready to merge
by obeythepenguin＠gmail.com 14 Nov '10

14 Nov '10

Here are the split Dillo-Win32 patches, ready to merge into the upstream tree: http://dillo-win32.sourceforge.net/patches.html I've cleaned up the code somewhat, such as removing the ugly conditionals from dsock.h. This version no longer includes the infamous "timeout kludge"; however, it must be built against a patched FLTK2 library, as the upstream implementation is still very badly broken. (The necessary patch is available from the Dillo-Win32 SourceForge site.) These patches produce a working ./src/dillo.exe. DPI has not yet been ported, as I presently have neither the time nor interest to do so. I'll probably get a binary package and installer up sometime in the next few days for anyone who wants to play around with the latest and greatest. Let me know if I need to double-check anything. Cheers, ~Benjamin

4 7

News from FLTK
by jcid＠dillo.org 10 Nov '10

10 Nov '10

Hi there, FYI: http://fltk.org/newsgroups.php?s9941+gfltk.development+v9960+T0 -- Cheers Jorge.-

2 1

vertical gaps
by jcid＠dillo.org 03 Nov '10

03 Nov '10

Hi, Just noticed large vertical rendering gaps with: http://www.monotone.ca/ Note1: dillo-2.1.1 doesn't have the problem Note2: I haven't investigated the problem -- Cheers Jorge.-

2 2