May 2009 - Dillo-dev - lists.mailman3.com

patch: segfault in win_cb in uicmd.cc
by corvid＠lavabit.com 30 May '09

30 May '09

I was closing dillo. So far as I can recall, I just hit ^Q a couple times (my usual method), but I don't think that would explain the win_cb(). (gdb) bt #0 0x08055a00 in UI::tabs (this=0x0) at ui.hh:105 #1 0x080555ef in win_cb (w=0x813fe48, cb_data=0x8190618) at uicmd.cc:351 #2 0x080df426 in fltk::handle () at ../fltk/Widget.h:127 #3 0x080e0995 in do_queued_events () at x11/run.cxx:399 #4 0x080e0c16 in fltk::wait (time_to_wait=1.00000002e+20) at x11/run.cxx:459 #5 0x080e0db0 in fltk::run () at run.cxx:399 #6 0x0804f737 in main (argc=1, argv=0xbffffb34) at dillo.cc:353 (gdb) p num_bws $13 = 2 (gdb) p bws[0] $14 = (BrowserWindow *) 0x81da720 (gdb) p bws[1] $15 = (BrowserWindow *) 0x81e4a10 (gdb) p bws[2] $16 = (BrowserWindow *) 0x81da720 Perhaps I had just closed the old bw[0], with a_List_remove moving the old bw[2] there. Here's a patch, since it's a good idea in any case to check what we've been given in a callback, but there is a bit of symptom-vs-disease in that I'm not positive how I got here in this situation.

1 0

--xid option
by Johannes.Hofmann＠gmx.de 30 May '09

30 May '09

Hi, attached patch tries to implement the missing --xid option that is used to embed dillo into the claws mailer. The right way to do this would probabely be to implement the complete XEMBED protocol which is also mentioned in doc/fltk-problems.doc. However a simple XReparentWindow() seems to work more or less here. Please test. Cheers, Johannes

4 15

repo
by jcid＠dillo.org 29 May '09

29 May '09

Johannes, In patch fd2b0634abe9 there's a long-word splitter, please add a comment on why it's there. IIRC it was discussed in dillo-dev recently but memory is fragile. BTW, there's a warning too: xembed.cc: In member function 'void Xembed::createInternal(uint32_t)': xembed.cc:126: warning: unused variable 'x' TIA. -- Cheers Jorge.-

2 1

x offset > 64k
by corvid＠lavabit.com 28 May '09

28 May '09

I tried looking at a stylesheet, but nothing displayed. It was a one-line document about 7k chars long. It turned out that fltk::getwidth() calls XftTextExtents32() and the width comes back in a short, so it wrapped at 32k. I chopped the line into 1k-long "words", and now I saw text, but once I made a line somewhere over 8k chars long, drawing would wrap and start at the beginning again. Everything looked all right in fltk::drawtext_transformed() as it called XftDrawString32()... I have no idea whether this is something easy to deal with in some way, or a limitation in X...

2 3

patch: a binding for stop
by jcid＠dillo.org 28 May '09

28 May '09

On Wed, May 27, 2009 at 02:22:57PM +0000, corvid wrote: > > Wondering whether we can come to a decision on this one.. > I don't like much Esc for stop, but if that's FFs default, it may be better than another (as the Ctrl-x clash you spot). Afterall this is what configurable keybindings is suppossed to solve so Esc is OK for me as default. > -------------------------------------- > > > Jeremy wrote: > > On Wed, May 06, 2009 at 11:32:31AM -0400, Jorge Arellano Cid wrote: > > > > > > The other one I can think of as mnemonic is <ctrl>x. What do > > > people think? > > > > That clashes with "Cut". Select some text in the URL window and > > <ctrl>+x will delete it. I think it's not a good idea to grab > > something that (a) already has a conventional action, and (b) already > > performs that conventional action in the GUI. > > > > And while we're talking about conventional use: Dillo is highly > > unconventional when it uses <ctrl>+q to close a tab. Everyone else[1] > > uses <ctrl>+w to close a tab (<ctrl>+<shift>+q to close a window) and > > <ctrl>+q to quit. Which can be annoying when switching between the > > two. > > > > Firefox uses Escape to stop, and arora[2] uses <ctrl>+. . > > > > Regards, > > > > Jeremy Henty > > > > [1] ie. Firefox :-) > > [2] http://code.google.com/p/arora/ - WebKit+Qt-based browser. It > > looks very nice and may supplant Firefox as "the browser to fall back > > to when Dillo can't handle the page". > > -- Cheers Jorge.-

1 0

(no subject)
by bogus＠does.not.exist.com 28 May '09

28 May '09

From: Jorge Arellano Cid <jcid(a)dillo.org> To: Dillo mailing list <dillo-dev(a)dillo.org> Cc: Bcc: Subject: Re: [Dillo-dev] patch: a binding for stop Reply-To: In-Reply-To: <20090527142256.GH6001(a)local.gobigwest.com> On Wed, May 27, 2009 at 02:22:57PM +0000, corvid wrote: > > Wondering whether we can come to a decision on this one.. I don't like much Esc for stop, but if that's FFs default, it may be better than another (as the Ctrl-x clash you spot). Afterall this is what configurable keybindings is suppossed to solve so Esc is OK for me as default. > > Jeremy wrote: > > On Wed, May 06, 2009 at 11:32:31AM -0400, Jorge Arellano Cid wrote: > > > > > > The other one I can think of as mnemonic is <ctrl>x. What do > > > people think? > > > > That clashes with "Cut". Select some text in the URL window and > > <ctrl>+x will delete it. I think it's not a good idea to grab > > something that (a) already has a conventional action, and (b) already > > performs that conventional action in the GUI. > > > > And while we're talking about conventional use: Dillo is highly > > unconventional when it uses <ctrl>+q to close a tab. Everyone else[1] > > uses <ctrl>+w to close a tab (<ctrl>+<shift>+q to close a window) and > > <ctrl>+q to quit. Which can be annoying when switching between the > > two. > > > > Firefox uses Escape to stop, and arora[2] uses <ctrl>+. . > > > > Regards, > > > > Jeremy Henty > > > > [1] ie. Firefox :-) > > [2] http://code.google.com/p/arora/ - WebKit+Qt-based browser. It > > looks very nice and may supplant Firefox as "the browser to fall back > > to when Dillo can't handle the page". > > -- Cheers Jorge.-

1 0

include guard naming
by corvid＠lavabit.com 27 May '09

27 May '09

I was just going through and changing the include guards that don't follow the dillo convention, and then I glanced at http://en.wikipedia.org/wiki/Include_guard and it reminds me that the C++ standard prohibits '_'s at the beginning. Does anyone care enough to have an opinion? If we want to rm the leading or surrounding underscores, I might as well do that too before committing. [pop/smtp isn't working at the moment, so I'm sending this through webmail. Let's hope they doesn't mangle line wrapping or anything.]

3 4

[patch]: [doc]: escape some hash in the text
by onepoint＠starurchin.org 27 May '09

27 May '09

When you're sick of bugs, clean up the docs! This escapes some '#' characters so that "#define" and "#include" appear properly in the text. It also silences some Doxygen warnings (it was trying to interpret those words as links). Regards, Jeremy Henty

2 1

Spotted a tiny dillo bug with tabs
by freya128＠yahoo.com 25 May '09

25 May '09

Tiny bug: When dillo changes tabs it doesn't update the main window header thing. Also the same if you close a tab. This can lead to weird effects such as the top header thing having info about a webpage that you don't have open at all. Hope that helps! :) love Freya

2 1

[bug]: uint32_t not declared
by onepoint＠starurchin.org 24 May '09

24 May '09

The latest tip fails to build for me. I don't have uint32_t. Which header should include it? I'm using gcc 4.1.2. Regards, Jeremy Henty

3 5