March 2009 - Dillo-dev - lists.mailman3.com

[patch]: typo fix
by onepoint＠starurchin.org 06 Mar '09

06 Mar '09

Nothing else to say, really. Attached. Regards, Jeremy Henty

2 1

Css_next_token() bug
by Johannes.Hofmann＠gmx.de 06 Mar '09

06 Mar '09

Hi, can someone (corvid?) please have a look at attached patch that fixes a bug in Css_next_token() (at least I think so). Consider: <div style="font-family: '\''; background-color: red;">foo bar</div> In firefox the background is red, in current dillo not, because the string '\'' is not parsed properly. As I'm still uncertain whether to go the re2c way (there the problem does not exist), I'd like to have this fixed in the standard version. However as the code is pretty subtle it would be nice if someone could have a look. Cheers, Johannes

2 2

allow_white_bg and contrast_visited_color
by Johannes.Hofmann＠gmx.de 06 Mar '09

06 Mar '09

On Thu, Mar 05, 2009 at 10:39:23PM +0000, corvid wrote: Committed. Thanks, Johannes

1 0

RFC: Dillo presentation
by onepoint＠starurchin.org 06 Mar '09

06 Mar '09

I have agreed to give presentation on Dillo to my local Linux Users Group this Thursday. Naturally I'm leaving it until the last minute to write anything! :-) I am attaching my crib list of essential points to cover. My aim is to give a very short talk covering * project goals * history (Dillo-1, Dillo-2.0, Dillo-2.1, soon) * development model * supported features * architecture (DPI, Dw) * future I'd very much appreciate any comments people have, particularly if you think there's anything important I have missed out. This is your chance to tell me what to tell them. (Just bear in mind that I aim to be brief, so I can't go into large amounts of detail.) Regards, Jeremy Henty

4 5

allow_white_bg and contrast_visited_color
by Johannes.Hofmann＠gmx.de 05 Mar '09

05 Mar '09

Hi, as we seem to have agreed on using CSS for style customization intead of dillorc settings, I'm trying to get rid of these: link_color: visited_color: text_color: bg_color: force_my_colors: The same thing can more or less be expressed with a custom user stylesheet, so I want to remove them. The problem is non-HTML pages (plain). I would propose to simulate <body><pre> in this case and use the corresponding style. allow_white_bg: This can't be expressed with CSS. We could detect a white background in StyleEngine (like we detect font sizes smaller than font_min_size), but what color should we use instead in this case (note that it must be different enough from the text color)? contrast_visited_color: This one is hard. Consider we want to render a visited link. >From StyleEngine we get a background and a text color, but we don't know what the text color would have been if the link would not be visited. So we can't enforce a color that is different from that. Generally (and even more with CSS), background- and text-colors can change arbitrarily within a page. So there is not a background and a text color per page. standard_widget_colors: Not sure about this one. On the one hand I think that CSS support broke this. On the other hand CSS allows the page author to directly set colors of form widgets. corvid, can you please have a look? Cheers, Johannes

2 2

clipping image inputs
by corvid＠lavabit.com 05 Mar '09

05 Mar '09

With <input type="image" name="name1" src="whatever" WIDTH="80" HEIGHT="14" alt="name1name1name1name1"> <input type="image" name="name2" src="whatever" width="9" height="14" alt="name2name2name2name2"> the long alt text doesn't clip. It looks like the embed knows that it's 80 pixels wide (at least the child widget area stuff in Textblock::drawLine seemed to have the right idea), but the image thinks it's 188 (in my case). PS I have "white-space: nowrap" pretty much working, but I don't know what I'm doing in Textblock very well, so it's definitely not going into this release.

2 5

improving CSS performance
by Johannes.Hofmann＠gmx.de 05 Mar '09

05 Mar '09

Hi, I just commited http://hg.dillo.org/dillo?cs=11c6f887d649 which improves CSS performance by avoiding unnecessary style computations. Please give it a thorough testing. Cheers, Johannes

1 0

Re: css parsing numbers
by Johannes.Hofmann＠gmx.de 03 Mar '09

03 Mar '09

On Fri, Feb 27, 2009 at 03:29:55PM +0000, corvid wrote: > > On Fri, Feb 27, 2009 at 02:26:03PM +0000, corvid wrote: > > > > Committed. I hoped to be able to make that code a bit shorter, but > > > > could not find a reasonable solution... > > > > > > Yeah. In any case, it's just going to get worse/rearranged again > > > for negative numbers... > > > > Exactly. I started my simplification attempts, added negative number > > support - and blew it all up :) > > I'm really considering a flex based scanner now. What do you think? > > I only touched flex very briefly for a class at school long ago, > and I don't remember anything from the experience, but the > idea interests me since it has to be less trouble than trying > to do it by hand... > I think we just need to try it. Attached is a minimal standalone example based on the "Lexical scanner" from the appendix of the CSS 2.1 spec. To compile it use: flex cssscanner.l gcc -o cssscanner lex.yy.c -lfl It reads from stdin. Cheers, Johannes

2 7

minor leak with CustShrinkTabPager
by Johannes.Hofmann＠gmx.de 02 Mar '09

02 Mar '09

Hi, thanks to Jeremy's valgrind log at http://starurchin.org/dillo/valgrind.html I noticed a minor leak with CustShrinkTabPager(). The TabGroup::pager() method internally clones the passed pager, so it must be deleted afterwards, e.g. like this: diff -r 9b0b8ae9b06a src/uicmd.cc --- a/src/uicmd.ccSun Mar 01 12:34:00 2009 +0100 +++ b/src/uicmd.ccMon Mar 02 08:57:02 2009 +0100 @@ -225,7 +225,9 @@ public: CustTabGroup (int x, int y, int ww, int wh, const char *lbl=0) : TabGroup(x,y,ww,wh,lbl) { - this->pager(new CustShrinkTabPager()); + CustShrinkTabPager *cp = new CustShrinkTabPager(); + this->pager(cp); + delete cp; toolTip = new Tooltip; tooltipEnabled = false; buttonPushed = false; Alternatively we could keep one copy around in a static member. Cheers, Johannes

2 1

[bgreer101@earthlink.net: Dillo2 working great with Crux-PPC!]
by jcid＠dillo.org 02 Mar '09

02 Mar '09

-- Cheers Jorge.-

1 0