April 2008 - Dillo-dev - lists.mailman3.com

namespace problem
by Johannes.Hofmann＠gmx.de 24 Apr '08

24 Apr '08

Hi, some time ago I already reported a compilation problem that currently only exists on DragonFlyBSD. The namespace "signal" in the lout library collides with a function declaration in /usr/include/signal.h. For some reason DragonFly happens to include signal.h indirectly. But the same problem will appear on Linux too once we should need signal.h somewhere. Just try to compile the following C++ file (g++ -c <file>): #include <signal.h> namespace signal { } I'd like to resolve this issue before release. I see two options: * rename namespace "signal" to "loutsignal" - which is pretty ugly. The concept of namespaces exists to avoid such stuff... * put all classes in the lout directory into a single namespace "lout". At the moment I prefer the second option, but I don't know Sebastian's reasoning behind this naming. Any opinions? Cheers, Johannes

2 1

dillo-fltk exits on SIGPIPE
by Johannes.Hofmann＠gmx.de 24 Apr '08

24 Apr '08

Hi, do you also see exits on SIGPIPE e.g. on: http://daily.daemonnews.org dillo 1 had signal(SIGPIPE, SIG_IGN); which dillo-fltk is missing. Cheers, Johannes

3 2

Good news from fltk!
by Johannes.Hofmann＠gmx.de 19 Apr '08

19 Apr '08

Hi, I stumbled across this post on fltk.bugs: http://fltk.org/newsgroups.php?s5281+gfltk.bugs+v5290+T0 This is great for us, as it allows us to implement efficient double buffering without X11 specific hacks. Attached is a patch that enables double buffering for partial screen redraws (this is where the flickering is most annoying). You will need at least version r6079 of fltk2 to test. Cheers, Johannes

4 27

Collapsing whitespace
by jcid＠dillo.org 18 Apr '08

18 Apr '08

Hi, Just submitted a patch I wanted to make long ago. It deals with collapsing whitespace. Here's one example: http://www.w3.org/TR/REC-html40/intro/sgmltut.html#h-3.2.1 BTW, I also changed the bool_t to "unsigned char". Please test whether it compiles cleanly. -- Cheers Jorge.-

2 1

Re: patch: BUTTON
by jcid＠dillo.org 15 Apr '08

15 Apr '08

On Tue, Apr 15, 2008 at 04:16:55AM +0000, corvid wrote: > The old code showed uncertainty about whether one can interact with the > stuff inside a button. The spec doesn't say. I suspect you aren't > supposed to be able to. Firefox doesn't let you. If FF doesn't allow interaction it will be hardly found in the WEB, unless IE allows. :-P > When trying to look up info on button nesting, I discovered -- by crashing -- > that I needed to test whether I was in a form. However, I learned that > section 17.2.1 says: > > "The elements used to create controls generally appear inside a FORM element, > but may also appear outside of a FORM element declaration when they are used > to build user interfaces. This is discussed in the section on intrinsic > events. [p.254] Note that controls outside a form cannot be successful > controls [p.245]." > > ..but I'll make a separate patch for controls outside of forms. AFAICS this may be useful with client side scripts, but we're a long way from suporting scripts. -- Cheers Jorge.-

2 1

[patch] fix cookies freezing dillo problem
by akemnade＠tzi.de 15 Apr '08

15 Apr '08

Hi, after some debugging I found out that dillo was frozen because it waits for input on the unix socket from the cookies.dpi. cookies.dpi itself blocks on the read() on the connection socket. If you kill dillo and stop dpid, the next time the cookies.dpi starts, it finds the cookies files locked and terminates immedediately. Then dpid starts the cookies.dpi again and again in an infinite loop. In my theory, the freeze where both processes are hanging in read() is caused when a connection is creating via DEBUG_MSG(5, "Cookies.c: a_Cookies_set \n\t \"%s\" \n",cmd ); a_Capi_dpi_send_cmd(NULL, NULL, cmd, "cookies", 1); but the data is not send yet and /* Get the answer from cookies.dpi */ dpip_tag = a_Dpi_send_blocking_cmd("cookies", cmd); is called. I have attached a patch which uses a_Dpi_send_blocking_cmd(). It seems to fix the problem. dillo has not been frozen again yet. Maybe cookies.dpi should create the SockHandler only when there is data to read (checking for it with select() first). Greetings Andreas Kemnade

2 3

patch: image inputs
by corvid＠lavabit.com 15 Apr '08

15 Apr '08

It works on the sites I tried, and the data sent looks right for other cases, but: - To get click position, I used event_x() and event_y() in fltkui.cc because they happened to have the right values in them and I didn't know the proper place to look for this information. - If the image could not be loaded and you click on the alt text, the click position is sent, even though it's not meaningful. - I don't prevent the image from being loaded even when automatic image loading is disabled (but I'm the only person who would notice anyway). (I would have to be able to get button 3 to bring up the image menu.)

2 5

Re: patch: file input
by jcid＠dillo.org 15 Apr '08

15 Apr '08

Hi, On Thu, Apr 10, 2008 at 04:13:56PM +0000, corvid wrote: > I just stuck it on a label button for now. It looks quite informative. > Already an improvement over Firefox, where I only > find out that I mistyped the filename when the server > doesn't get the file. > > Somewhere that accepts files: http://validator.w3.org > > Edge case that I just noticed: > If I read in a file, delete that file, and try to read it in again > (uses E2EReload), the submit will send the (now empty) file because > a_Capi_get_buf() finds the (now empty) entry in cache. > So I'll have to find out where an a_Cache_entry_remove_by_url() should go. Yes. Please also add a file size threshold, to avoid a dillo exit from an out of memory condition. Committed! -- Cheers Jorge.-

2 10

[patch] fix warning in html.cc
by Johannes.Hofmann＠gmx.de 14 Apr '08

14 Apr '08

Hi, html.cc: In function 'void a_Html_form_event_handler(void*, form::Form*, void*)': html.cc:4331: warning: 'input' may be used uninitialized in this function can be fixed with attached patch. Please review. Cheers, Johannes

3 2

[patch] make ComplexButton work
by Johannes.Hofmann＠gmx.de 14 Apr '08

14 Apr '08

Hi, this patch fixes ComplexButton - at least it works here now :-) The patch includes the ComplexButton destructor proposed by place and enables the ComplexButton code in dw-ui-test. It requires my last FltkViewBase::draw() patch. Cheers, Johannes

3 2