February 2008 - Dillo-dev - lists.mailman3.com

[patch] optimize redraw after resize for textblocks
by Johannes.Hofmann＠gmx.de 22 Feb '08

22 Feb '08

Hello, here comes my attempt to avoid unnecessary redraws caused by images that are not visible. The first patch makes some minor optimizations to the drawing code and disables the use of the asap parameter for better testing. The second patch replaces the general queueDrawTotal() in Layout::resizeIdle () with more specific redraw calls in widgets that can be topLevel. Currently only Textblock is optimized. The idea is that resizing child widgets in a textblock don't affect the layout of the textblock above the resizing widget. So only the area below needs to be redrawn. I think that does not hold for tables, but perhaps other optimizations are possible here? Ideas anyone? The effect is visible e.g. on http://chlamydia.fs.ei.tum.de/pub/DragonFly/packages/stable/DragonFly-1.10.… but not on table based pages. Cheers, Johannes

2 1

[patch] optimize redraw after resize for textblocks
by Johannes.Hofmann＠gmx.de 21 Feb '08

21 Feb '08

Hi, On Thu, Feb 21, 2008 at 04:57:29AM +0000, place wrote: > Hi Johannes, > > I finally got around to applying this today... > Are you seeing any problems with text highlighting? > > If I repeat searches so that the page scrolls some -- but not far enough > for the previous instance to scroll off screen -- the previous instance > stays highlighted and the current instance isn't highlighted. > > It's entirely possible that I screwed something up, but when I > diffed my trees, I didn't notice anything wrong... No, I'm seeing this too now. I will try to fix it. Thanks for testing, Johannes

1 0

Dillo screenshot on my ipaq
by akemnade＠tzi.de 18 Feb '08

18 Feb '08

Hi, I have finally taken the time to make dillo run on my ipaq. Screenshot: http://www.tzi.de/~akemnade/dillo-ipaq.png The big pitfall here is if you don't enable Xft/freetype in your fltk build, you can screw up things. fltk does not get the default fonts from the xserver on the ipaq, so due to missing error checking in fltk, dillo crashes when the first label gets rendered. But I guess, without freetype you won't get nice fonts anyway... dillo/dw does not need to be patched for that. fltk needs a bit of tweaking, I'll look if it is solved in the current version (I'm still using that r5917 snapshot). Greetings Andreas Kemnade

3 3

New table layout rocks!
by onepoint＠starurchin.org 14 Feb '08

14 Feb '08

I've been collecting web pages that Dillo misrendered: truncated images, overlapping text, pages clipped at the right, etc. I'm really pleased to announce that the latest Dillo handles them all. This is a major improvement! I'm assuming this is the new table layout code at work. Regards, Jeremy Henty

5 31

[patch] fix HomeKey/EndKey behaviour
by Johannes.Hofmann＠gmx.de 07 Feb '08

07 Feb '08

Hi the patch below makes HomeKey and EndKey work as it did in dillo1. I think I had introduced the current behaviour that also adjusts the x-position but it is pretty annoying on wide pages. Cheers, Johannes diff -r 1c41f9a73971 dw/fltkviewport.cc --- a/dw/fltkviewport.cc Sun Feb 03 21:13:11 2008 +0100 +++ b/dw/fltkviewport.cc Wed Feb 06 18:16:41 2008 +0100 @@ -292,11 +292,11 @@ int FltkViewport::handle (int event) return 1; case HomeKey: - scrollTo (0, 0); + scrollTo (scrollX, 0); return 1; case EndKey: - scrollTo (canvasWidth, canvasHeight); /* gets adjusted in scroll() */ + scrollTo (scrollX, canvasHeight); /* gets adjusted in scroll() */ return 1; } }

2 1

[PATCH]: Table::apportionRowSpan()
by onepoint＠starurchin.org 05 Feb '08

05 Feb '08

OK, please ignore my previous attempt at reworking Dillo's ROWSPAN handling. I have a simple fix for the bugs I reported at http://starurchin.singularity/dillo/bugs/table_rowspan.html . This patch tweaks dw::Table::apportionRowSpan() to handle the special case where all the rows being spanned have zero height. This fixes the special cases that were breaking without changing the behaviour in any other case. (BTW, I still think there is a case for reworking Dillo's ROWSPAN algorithms along the lines I suggested, but it's nice to fix bugs without such efforts.) Regards, Jeremy Henty

2 4

[patch] fix size of select widgets
by Johannes.Hofmann＠gmx.de 05 Feb '08

05 Feb '08

Here is a small patch to compute the size of select widgets similar to the way it is computed for text input widgets. The width is hardcoded to 10 * size of 'M' in the current font. Regards, Johannes PS: The colored widgets are nice! diff -r 68ee0a55704c dw/fltkui.cc --- a/dw/fltkui.cc Sat Feb 02 18:36:32 2008 +0100 +++ b/dw/fltkui.cc Sat Feb 02 19:20:16 2008 +0100 @@ -1048,10 +1048,21 @@ void FltkOptionMenuResource::widgetCallb void FltkOptionMenuResource::sizeRequest (core::Requisition *requisition) { - /** \bug Random values. */ - requisition->width = 100; - requisition->ascent = 18; - requisition->descent = 5; + if (style) { + FltkFont *font = (FltkFont*)style->font; + ::fltk::setfont(font->font,font->size); + requisition->width = + (int)::fltk::getwidth ("M", 1) * 10 + + 2 * RELIEF_X_THICKNESS; + requisition->ascent = + font->ascent + RELIEF_Y_THICKNESS; + requisition->descent = + font->descent + RELIEF_Y_THICKNESS; + } else { + requisition->width = 1; + requisition->ascent = 1; + requisition->descent = 0; + } }

2 4

an experiment in widget coloring (with code)
by place＠gobigwest.com 05 Feb '08

05 Feb '08

With my color settings, my buttons were light grey with unreadable white labels. Well, that's no good. And standard gui widget colors scream "I'm using a Windows Office Productivity Suite!" to me. So here is something to play with. I currently have the widgets using background color and the labels/text either black or white. fltk_black to make black work right widget_colors.dillo to set backgroundColor in Style. widget_colors.dw where you set the widget colors.

3 16

a_Dialog_text_window() dimensions
by place＠gobigwest.com 03 Feb '08

03 Feb '08

(speaking of my ancient computer... [it keeps not dying, so I keep not buying a new one]) a_Dialog_text_window() dimensions were recently increased to int wh = 600, ww = 650, bh = 30; but my display is small enough that this puts the close button below the bottom of the screen. Perhaps it should be limited by screen dimensions. Or something based on prefs.height and prefs.width...

2 1

a couple of patches: referer and image_off
by jcid＠dillo.org 02 Feb '08

02 Feb '08

On Fri, Feb 01, 2008 at 07:38:45PM +0000, place wrote: > > In brief, using the same URI, the three options offer good > > privacy (because no new information is sent), and if we ever > > enable using the referring page, the old comments apply. > > Whew. > > See, I ran on the equivalent of "host" for > at least a year, and then have been using the > equivalent of "path" for at least a year, so > the idea that I had somehow been doing something > wrong was alarming :) :-) Well, in that case you can provide good advice on which is better as a default. -- Cheers Jorge.-

2 2